Skip to content

Automate browser based workflows with AI

fix(SKY-12158): reserve lightning bolt for cached runs on /runs (#7257)

Aaron Perez36703cb18b24
diff --git a/skyvern-frontend/src/components/TriggerTypeBadge.test.tsx b/skyvern-frontend/src/components/TriggerTypeBadge.test.tsx
new file mode 100644
index 000000000..8c7383f74
--- /dev/null
+++ b/skyvern-frontend/src/components/TriggerTypeBadge.test.tsx
@@ -0,0 +1,44 @@
+// @vitest-environment jsdom
+import { cleanup, render } from "@testing-library/react";
+import { LightningBoltIcon } from "@radix-ui/react-icons";
+import { afterEach, describe, expect, it } from "vitest";
+
+import { TriggerType } from "@/api/types";
+import { TriggerTypeBadge } from "./TriggerTypeBadge";
+
+afterEach(cleanup);
+
+function iconMarkup(root: HTMLElement): string {
+ return root.querySelector("svg")?.innerHTML ?? "";
+}
+
+describe("TriggerTypeBadge", () => {
+ it("does not reuse the cached lightning-bolt glyph for API runs", () => {
+ // The gold lightning bolt is the "ran with code" (cached) indicator on
+ // /runs. The API trigger badge must use a distinct glyph so an API run is
+ // never mistaken for a cached run. (SKY-12158)
+ const { container: apiBadge } = render(
+ <TriggerTypeBadge triggerType={TriggerType.Api} />,
+ );
+ const { container: bolt } = render(<LightningBoltIcon />);
+
+ expect(iconMarkup(apiBadge)).not.toBe("");
+ expect(iconMarkup(apiBadge)).not.toBe(iconMarkup(bolt));
+ });
+
+ it("renders a distinct glyph for each trigger type", () => {
+ const glyphs = [
+ TriggerType.Manual,
+ TriggerType.Mcp,
+ TriggerType.Api,
+ TriggerType.Scheduled,
+ ].map((triggerType) => {
+ const { container } = render(
+ <TriggerTypeBadge triggerType={triggerType} />,
+ );
+ return iconMarkup(container);
+ });
+
+ expect(new Set(glyphs).size).toBe(glyphs.length);
+ });
+});
diff --git a/skyvern-frontend/src/components/TriggerTypeBadge.tsx b/skyvern-frontend/src/components/TriggerTypeBadge.tsx
index 33f7cbfbf..61c71bfc8 100644
--- a/skyvern-frontend/src/components/TriggerTypeBadge.tsx
+++ b/skyvern-frontend/src/components/TriggerTypeBadge.tsx
@@ -1,9 +1,9 @@
import { TriggerType } from "@/api/types";
import {
CalendarIcon,
+ CodeIcon,
CubeIcon,
CursorArrowIcon,
- LightningBoltIcon,
} from "@radix-ui/react-icons";
import { Tip } from "@/components/Tip";
@@ -24,7 +24,7 @@ const triggerConfig: Record<
label: "MCP",
},
[TriggerType.Api]: {
- icon: <LightningBoltIcon className="size-3.5 text-amber-400" />,
+ icon: <CodeIcon className="size-3.5 text-amber-400" />,
label: "API",
},
[TriggerType.Scheduled]: {