Automate browser based workflows with AI
Python aiapiautomationbrowserbrowser-automationcomputergptllmplaywrightpowerautomatepuppeteerpythonrpaseleniumvisionworkflow
fix: pass through script_run / ai_fallback / browser_session_id / max_screenshot_scrolls on /v1/runs/{id} (#5725)
pedrohsdb37527ef568b3
diff --git a/skyvern/services/workflow_service.py b/skyvern/services/workflow_service.pyindex c6a1b46c0..58ca6d0b6 100644--- a/skyvern/services/workflow_service.py+++ b/skyvern/services/workflow_service.py@@ -151,7 +151,11 @@ async def get_workflow_run_response(created_at=workflow_run.created_at,modified_at=workflow_run.modified_at,run_with=workflow_run.run_with,+ ai_fallback=workflow_run.ai_fallback,+ browser_session_id=workflow_run.browser_session_id,browser_profile_id=workflow_run.browser_profile_id,+ max_screenshot_scrolls=workflow_run.max_screenshot_scrolls,+ script_run=workflow_run.script_run,run_request=WorkflowRunRequest(workflow_id=workflow_run.workflow_permanent_id,title=workflow_run_resp.workflow_title,@@ -163,7 +167,7 @@ async def get_workflow_run_response(max_screenshot_scrolls=workflow_run.max_screenshot_scrolls,browser_address=workflow_run.browser_address,browser_profile_id=workflow_run.browser_profile_id,- # TODO: add browser session id+ browser_session_id=workflow_run.browser_session_id,),errors=workflow_run_resp.errors,step_count=workflow_run_resp.total_steps,diff --git a/tests/unit/services/test_get_workflow_run_response_passthrough.py b/tests/unit/services/test_get_workflow_run_response_passthrough.pynew file mode 100644index 000000000..634ef100e--- /dev/null+++ b/tests/unit/services/test_get_workflow_run_response_passthrough.py@@ -0,0 +1,75 @@+"""Regression guard: get_workflow_run_response must pass through all WorkflowRun fields."""++from datetime import datetime, timezone+from unittest.mock import AsyncMock, MagicMock, patch++import pytest++from skyvern.forge.sdk.workflow.models.workflow import WorkflowRun, WorkflowRunStatus+from skyvern.schemas.runs import RunStatus, ScriptRunResponse+from skyvern.services.workflow_service import get_workflow_run_response+++async def test_get_workflow_run_response_passes_through_all_fields() -> None:+ now = datetime.now(timezone.utc)+ script_run = ScriptRunResponse(+ ai_fallback_triggered=False,+ script_id="s_abc",+ script_revision_id="sr_xyz",+ )+ workflow_run = WorkflowRun(+ workflow_run_id="wr_123",+ workflow_id="w_123",+ workflow_permanent_id="wpid_123",+ organization_id="o_123",+ status=WorkflowRunStatus.completed,+ run_with="code",+ ai_fallback=True,+ browser_session_id="pbs_123",+ browser_profile_id="bp_123",+ max_screenshot_scrolls=5,+ script_run=script_run,+ created_at=now,+ modified_at=now,+ queued_at=now,+ started_at=now,+ finished_at=now,+ )++ status_resp = MagicMock(+ outputs={"key": "value"},+ downloaded_files=None,+ recording_url=None,+ screenshot_urls=None,+ failure_reason=None,+ workflow_title="Test",+ parameters={},+ errors=None,+ total_steps=4,+ )++ with (+ patch(+ "skyvern.services.workflow_service.app.DATABASE.workflow_runs.get_workflow_run",+ new_callable=AsyncMock,+ return_value=workflow_run,+ ),+ patch(+ "skyvern.services.workflow_service.app.WORKFLOW_SERVICE.build_workflow_run_status_response_by_workflow_id",+ new_callable=AsyncMock,+ return_value=status_resp,+ ),+ ):+ resp = await get_workflow_run_response("wr_123", organization_id="o_123")++ assert resp is not None+ assert resp.script_run == script_run+ assert resp.ai_fallback is True+ assert resp.browser_session_id == "pbs_123"+ assert resp.max_screenshot_scrolls == 5+ assert resp.run_with == "code"+ assert resp.status == RunStatus.completed+ assert resp.step_count == 4+ assert resp.run_request is not None+ assert resp.run_request.browser_session_id == "pbs_123"