Automate browser based workflows with AI
Python aiapiautomationbrowserbrowser-automationcomputergptllmplaywrightpowerautomatepuppeteerpythonrpaseleniumvisionworkflow
Fix: guard scroll_to_top/scroll_to_next_page against non-numeric JS returns (#5170)
LawyZheng3889c2b848e8
diff --git a/skyvern/webeye/utils/page.py b/skyvern/webeye/utils/page.pyindex 6b0a4b6c6..8a2a5c70a 100644--- a/skyvern/webeye/utils/page.py+++ b/skyvern/webeye/utils/page.py@@ -456,7 +456,13 @@ class SkyvernFrame:timeout_ms=SettingsManager.get_settings().BROWSER_SCRAPING_BUILDING_ELEMENT_TREE_TIMEOUT_MS,arg=[draw_boxes, frame, frame_index],)- return scroll_y_px+ if not isinstance(scroll_y_px, (int, float)):+ LOG.warning(+ "scroll_to_top returned non-numeric value, falling back to 0.0",+ scroll_y_px=scroll_y_px,+ )+ return 0.0+ return float(scroll_y_px)async def scroll_to_next_page(self, draw_boxes: bool, frame: str, frame_index: int, need_overlap: bool = True@@ -474,7 +480,13 @@ class SkyvernFrame:timeout_ms=SettingsManager.get_settings().BROWSER_SCRAPING_BUILDING_ELEMENT_TREE_TIMEOUT_MS,arg=[draw_boxes, frame, frame_index, need_overlap],)- return scroll_y_px+ if not isinstance(scroll_y_px, (int, float)):+ LOG.warning(+ "scroll_to_next_page returned non-numeric value, falling back to 0.0",+ scroll_y_px=scroll_y_px,+ )+ return 0.0+ return float(scroll_y_px)async def remove_bounding_boxes(self) -> None:"""diff --git a/tests/unit/test_scroll_guard.py b/tests/unit/test_scroll_guard.pynew file mode 100644index 000000000..68b807c52--- /dev/null+++ b/tests/unit/test_scroll_guard.py@@ -0,0 +1,72 @@+"""Tests for scroll_to_top and scroll_to_next_page None-guard in SkyvernFrame."""++from __future__ import annotations++from unittest.mock import AsyncMock, patch++import pytest++from skyvern.webeye.utils.page import SkyvernFrame+++def skyvern_frame() -> SkyvernFrame:+ """Create a SkyvernFrame with a mock frame."""+ frame = AsyncMock()+ sf = SkyvernFrame.__new__(SkyvernFrame)+ sf.frame = frame+ return sf+++async def test_scroll_to_top_returns_float(skyvern_frame: SkyvernFrame) -> None:+ with patch.object(SkyvernFrame, "evaluate", new_callable=AsyncMock, return_value=123.45):+ result = await skyvern_frame.scroll_to_top(draw_boxes=False, frame="", frame_index=0)+ assert result == 123.45+ assert isinstance(result, float)+++async def test_scroll_to_top_returns_float_from_int(skyvern_frame: SkyvernFrame) -> None:+ with patch.object(SkyvernFrame, "evaluate", new_callable=AsyncMock, return_value=0):+ result = await skyvern_frame.scroll_to_top(draw_boxes=False, frame="", frame_index=0)+ assert result == 0.0+ assert isinstance(result, float)+++async def test_scroll_to_top_none_returns_zero(skyvern_frame: SkyvernFrame) -> None:+ with patch.object(SkyvernFrame, "evaluate", new_callable=AsyncMock, return_value=None):+ result = await skyvern_frame.scroll_to_top(draw_boxes=False, frame="", frame_index=0)+ assert result == 0.0+ assert isinstance(result, float)+++async def test_scroll_to_top_string_returns_zero(skyvern_frame: SkyvernFrame) -> None:+ with patch.object(SkyvernFrame, "evaluate", new_callable=AsyncMock, return_value="bad"):+ result = await skyvern_frame.scroll_to_top(draw_boxes=False, frame="", frame_index=0)+ assert result == 0.0+++async def test_scroll_to_next_page_returns_float(skyvern_frame: SkyvernFrame) -> None:+ with patch.object(SkyvernFrame, "evaluate", new_callable=AsyncMock, return_value=500.0):+ result = await skyvern_frame.scroll_to_next_page(draw_boxes=False, frame="", frame_index=0)+ assert result == 500.0+ assert isinstance(result, float)+++async def test_scroll_to_next_page_none_returns_zero(skyvern_frame: SkyvernFrame) -> None:+ with patch.object(SkyvernFrame, "evaluate", new_callable=AsyncMock, return_value=None):+ result = await skyvern_frame.scroll_to_next_page(draw_boxes=False, frame="", frame_index=0)+ assert result == 0.0+ assert isinstance(result, float)+++async def test_scroll_to_next_page_string_returns_zero(skyvern_frame: SkyvernFrame) -> None:+ with patch.object(SkyvernFrame, "evaluate", new_callable=AsyncMock, return_value="bad"):+ result = await skyvern_frame.scroll_to_next_page(draw_boxes=False, frame="", frame_index=0)+ assert result == 0.0