Skip to content

Automate browser based workflows with AI

fix: move "Add new credential" to top of credential selector dropdowns (#5206)

Celal Zamanoğlu3a748b3b7439
diff --git a/skyvern-frontend/src/routes/workflows/components/CredentialParameterSourceSelector.tsx b/skyvern-frontend/src/routes/workflows/components/CredentialParameterSourceSelector.tsx
index 2ff564d9c..c8faf451c 100644
--- a/skyvern-frontend/src/routes/workflows/components/CredentialParameterSourceSelector.tsx
+++ b/skyvern-frontend/src/routes/workflows/components/CredentialParameterSourceSelector.tsx
@@ -2,6 +2,7 @@ import {
Select,
SelectContent,
SelectItem,
+ SelectSeparator,
SelectTrigger,
SelectValue,
} from "@/components/ui/select";
@@ -73,17 +74,18 @@ function CredentialParameterSourceSelector({ value, onChange }: Props) {
<SelectValue placeholder="Select a credential" />
</SelectTrigger>
<SelectContent>
- {options.map((option) => (
- <SelectItem key={option.value} value={option.value}>
- {option.label}
- </SelectItem>
- ))}
<SelectItem value="new">
<div className="flex items-center gap-2">
<PlusIcon className="size-4" />
<span>Add new credential</span>
</div>
</SelectItem>
+ {options.length > 0 && <SelectSeparator />}
+ {options.map((option) => (
+ <SelectItem key={option.value} value={option.value}>
+ {option.label}
+ </SelectItem>
+ ))}
</SelectContent>
</Select>
<CredentialsModal
diff --git a/skyvern-frontend/src/routes/workflows/components/CredentialSelector.tsx b/skyvern-frontend/src/routes/workflows/components/CredentialSelector.tsx
index d491c25a0..d6c5e1712 100644
--- a/skyvern-frontend/src/routes/workflows/components/CredentialSelector.tsx
+++ b/skyvern-frontend/src/routes/workflows/components/CredentialSelector.tsx
@@ -4,6 +4,7 @@ import {
SelectContent,
SelectItem,
SelectItemText,
+ SelectSeparator,
SelectTrigger,
SelectValue,
} from "@/components/ui/select";
@@ -54,6 +55,13 @@ function CredentialSelector({ value, onChange, placeholder }: Props) {
<SelectValue placeholder={placeholder ?? "Select a credential"} />
</SelectTrigger>
<SelectContent>
+ <SelectItem value="new">
+ <div className="flex items-center gap-2">
+ <PlusIcon className="size-4" />
+ <span>Add new credential</span>
+ </div>
+ </SelectItem>
+ {credentials.length > 0 && <SelectSeparator />}
{credentials.map((credential) => (
<CustomSelectItem
key={credential.credential_id}
@@ -87,12 +95,6 @@ function CredentialSelector({ value, onChange, placeholder }: Props) {
</div>
</CustomSelectItem>
))}
- <SelectItem value="new">
- <div className="flex items-center gap-2">
- <PlusIcon className="size-4" />
- <span>Add new credential</span>
- </div>
- </SelectItem>
</SelectContent>
</Select>
<CredentialsModal
diff --git a/skyvern-frontend/src/routes/workflows/editor/nodes/LoginNode/LoginBlockCredentialSelector.tsx b/skyvern-frontend/src/routes/workflows/editor/nodes/LoginNode/LoginBlockCredentialSelector.tsx
index 0be82e905..f54747589 100644
--- a/skyvern-frontend/src/routes/workflows/editor/nodes/LoginNode/LoginBlockCredentialSelector.tsx
+++ b/skyvern-frontend/src/routes/workflows/editor/nodes/LoginNode/LoginBlockCredentialSelector.tsx
@@ -2,6 +2,7 @@ import {
Select,
SelectContent,
SelectItem,
+ SelectSeparator,
SelectTrigger,
SelectValue,
} from "@/components/ui/select";
@@ -268,6 +269,13 @@ function LoginBlockCredentialSelector({
)}
</SelectTrigger>
<SelectContent>
+ <SelectItem value="new">
+ <div className="flex items-center gap-2">
+ <PlusIcon className="size-4" />
+ <span>Add new credential</span>
+ </div>
+ </SelectItem>
+ {options.length > 0 && <SelectSeparator />}
{options.map((option) => (
<SelectItem key={option.value} value={option.value}>
<div className="flex items-center gap-2">
@@ -287,12 +295,6 @@ function LoginBlockCredentialSelector({
</div>
</SelectItem>
))}
- <SelectItem value="new">
- <div className="flex items-center gap-2">
- <PlusIcon className="size-4" />
- <span>Add new credential</span>
- </div>
- </SelectItem>
</SelectContent>
</Select>
<CredentialsModal