Automate browser based workflows with AI
Python aiapiautomationbrowserbrowser-automationcomputergptllmplaywrightpowerautomatepuppeteerpythonrpaseleniumvisionworkflow
fix: add settle delay before page.complete() verification + action timestamps (#5400)
pedrohsdb42c7348ef9ae
diff --git a/skyvern/core/script_generations/script_skyvern_page.py b/skyvern/core/script_generations/script_skyvern_page.pyindex 12b1f839f..fdf0c1aa5 100644--- a/skyvern/core/script_generations/script_skyvern_page.py+++ b/skyvern/core/script_generations/script_skyvern_page.py@@ -1014,6 +1014,16 @@ class ScriptSkyvernPage(SkyvernPage):if context.script_mode:print(" ⏭ Skipping complete() verification (--no-verify)")return++ # In script mode, add a settle delay before verification. Scripts execute+ # actions sequentially with no pause — page.complete() fires immediately+ # after the last click/fill. The page may still be mid-redirect or+ # rendering the post-action state. In agent mode, the step loop naturally+ # introduces 5-15 seconds of latency (re-scrape + LLM processing) which+ # gives the page time to settle. This delay bridges that gap.+ if (context.code_version or 0) >= 2:+ await asyncio.sleep(3)+task = await app.DATABASE.tasks.get_task(context.task_id, context.organization_id)step = await app.DATABASE.tasks.get_step(context.step_id, context.organization_id)if task and step:diff --git a/skyvern/forge/prompts/skyvern/script-reviewer.j2 b/skyvern/forge/prompts/skyvern/script-reviewer.j2index e710aa14a..03f9913a0 100644--- a/skyvern/forge/prompts/skyvern/script-reviewer.j2+++ b/skyvern/forge/prompts/skyvern/script-reviewer.j2@@ -110,7 +110,9 @@ The cached code failed and the AI agent took over. Here is what happened:{% for a in episode.agent_actions.actions %}{{ loop.index }}. {{ a.action_type }}: {{ a.intention or a.reasoning or "N/A" }} ({{ a.status }}){%- if a.page_url and loop.first %} [url: {{ a.page_url }}]{% endif %}-{%- if a.page_url and not loop.first and a.page_url != ns.prev_url %} [url changed: {{ a.page_url }}]{% endif %}+{%- if a.page_url and not loop.first and a.page_url != ns.prev_url and a.seconds_since_previous and a.seconds_since_previous > 3 %} [after step {{ loop.index - 1 }}, page navigated to {{ a.page_url }} — {{ a.seconds_since_previous }}s since last action]+{%- elif a.page_url and not loop.first and a.page_url != ns.prev_url %} [after step {{ loop.index - 1 }}, page navigated to {{ a.page_url }}]+{%- elif a.seconds_since_previous and a.seconds_since_previous > 3 %} [{{ a.seconds_since_previous }}s since last action]{% endif %}{%- if a.field %} [field: {{ a.field }}]{% endif %}{%- if a.element_tag %} [tag: {{ a.element_tag }}]{% endif %}{%- if a.element_text %} [text: "{{ a.element_text }}"]{% endif %}diff --git a/skyvern/forge/sdk/workflow/service.py b/skyvern/forge/sdk/workflow/service.pyindex bc7c83436..ef319100d 100644--- a/skyvern/forge/sdk/workflow/service.py+++ b/skyvern/forge/sdk/workflow/service.py@@ -123,7 +123,7 @@ from skyvern.schemas.workflows import (WorkflowStatus,)from skyvern.services import script_service, workflow_script_service-from skyvern.utils.css_selector import build_action_summary # shared with script_service+from skyvern.utils.css_selector import build_action_summaries_with_timing # shared with script_servicefrom skyvern.utils.url_validators import validate_url as validate_url_with_blocked_host_checkfrom skyvern.webeye.browser_state import BrowserState@@ -2282,7 +2282,7 @@ class WorkflowService:task_id=wrb.task_id,organization_id=organization_id,)- agent_actions_summary["actions"] = [build_action_summary(a) for a in actions[:20]]+ agent_actions_summary["actions"] = build_action_summaries_with_timing(actions)except Exception:LOG.debug("Could not fetch rich actions for fallback episode",diff --git a/skyvern/services/script_service.py b/skyvern/services/script_service.pyindex 51b05d96d..3ece8e22d 100644--- a/skyvern/services/script_service.py+++ b/skyvern/services/script_service.py@@ -84,7 +84,7 @@ from skyvern.schemas.scripts import ()from skyvern.schemas.steps import AgentStepOutputfrom skyvern.schemas.workflows import BlockResult, BlockStatus, BlockType, FileStorageType, FileType-from skyvern.utils.css_selector import build_action_summary+from skyvern.utils.css_selector import build_action_summaries_with_timingfrom skyvern.webeye.actions.action_types import ActionTypefrom skyvern.webeye.actions.actions import Action, DecisiveActionfrom skyvern.webeye.scraper.scraped_page import ElementTreeFormat@@ -1395,7 +1395,7 @@ async def _fallback_to_ai_run(task_id=task_id,organization_id=organization_id,)- agent_actions_summary["actions"] = [build_action_summary(a) for a in actions[:20]]+ agent_actions_summary["actions"] = build_action_summaries_with_timing(actions)except Exception:LOG.debug("Could not fetch actions for fallback episode", exc_info=True)diff --git a/skyvern/utils/css_selector.py b/skyvern/utils/css_selector.pyindex b6256c415..feaf7124d 100644--- a/skyvern/utils/css_selector.py+++ b/skyvern/utils/css_selector.py@@ -177,3 +177,23 @@ def build_action_summary(action: Action) -> dict:"all_attributes": useful_attrs or None,"css_suggestion": compute_stable_selector(elem),}+++def build_action_summaries_with_timing(actions: list[Action]) -> list[dict]:+ """Build action summaries with time deltas between consecutive actions.++ Wraps build_action_summary and adds seconds_since_previous (the delta+ in seconds from the previous action) for all actions with timestamps.+ The Jinja template filters to only render deltas > 3 seconds.+ """+ summaries = []+ prev_ts = None+ for a in actions[:20]:+ summary = build_action_summary(a)+ if a.created_at and prev_ts:+ delta = (a.created_at - prev_ts).total_seconds()+ summary["seconds_since_previous"] = round(max(delta, 0), 1)+ if a.created_at:+ prev_ts = a.created_at+ summaries.append(summary)+ return summariesdiff --git a/skyvern/webeye/browser_factory.py b/skyvern/webeye/browser_factory.pyindex db554e3aa..bac7a5521 100644--- a/skyvern/webeye/browser_factory.py+++ b/skyvern/webeye/browser_factory.py@@ -426,6 +426,24 @@ def _get_proxy_server_creds(proxy: str) -> dict:return {}+def _is_browser_profile_corruption_error(error: Exception) -> bool:+ """Return True if the error is consistent with a corrupted or bloated browser profile.++ These errors appear when launch_persistent_context fails to start Chrome because+ the user_data_dir is in a bad state (corrupted files, oversized cache, lock files+ from a prior crash, etc.). The error text comes from Playwright's CDP driver.+ """+ error_str = str(error).lower()+ corruption_indicators = [+ "connection closed while reading from the driver",+ "target closed",+ "browser has been closed",+ "failed to launch",+ "unable to open database",+ ]+ return any(indicator in error_str for indicator in corruption_indicators)++def _get_cdp_port(kwargs: dict) -> int | None:raw_cdp_port = kwargs.get("cdp_port")if isinstance(raw_cdp_port, (int, str)):@@ -479,6 +497,7 @@ async def _create_headless_chromium(browser_profile_id = cast(str | None, kwargs.get("browser_profile_id"))organization_id_for_profile = cast(str | None, kwargs.get("organization_id"))user_data_dir: str | None = None+ loaded_from_saved_profile = Falseif browser_profile_id and organization_id_for_profile:profile_dir = await app.STORAGE.retrieve_browser_profile(@@ -487,6 +506,7 @@ async def _create_headless_chromium()if profile_dir:user_data_dir = profile_dir+ loaded_from_saved_profile = TrueLOG.info("Using browser profile",browser_profile_id=browser_profile_id,@@ -522,7 +542,29 @@ async def _create_headless_chromium(har_path=browser_args["record_har_path"],browser_session_dir=user_data_dir,)- browser_context = await playwright.chromium.launch_persistent_context(**browser_args)+ try:+ browser_context = await playwright.chromium.launch_persistent_context(**browser_args)+ except Exception as launch_error:+ if loaded_from_saved_profile and _is_browser_profile_corruption_error(launch_error):+ LOG.warning(+ "Browser launch failed with saved profile — profile may be corrupted, falling back to fresh profile",+ browser_profile_id=browser_profile_id,+ organization_id=organization_id_for_profile,+ error=str(launch_error),+ )+ fallback_dir = make_temp_directory(prefix="skyvern_browser_")+ BrowserContextFactory.update_chromium_browser_preferences(+ user_data_dir=fallback_dir,+ download_dir=download_dir,+ )+ browser_args["user_data_dir"] = fallback_dir+ browser_artifacts = BrowserContextFactory.build_browser_artifacts(+ har_path=browser_args["record_har_path"],+ browser_session_dir=fallback_dir,+ )+ browser_context = await playwright.chromium.launch_persistent_context(**browser_args)+ else:+ raisereturn browser_context, browser_artifacts, None@@ -544,6 +586,7 @@ async def _create_headful_chromium(browser_profile_id = cast(str | None, kwargs.get("browser_profile_id"))organization_id_for_profile = cast(str | None, kwargs.get("organization_id"))user_data_dir: str | None = None+ loaded_from_saved_profile = Falseif browser_profile_id and organization_id_for_profile:profile_dir = await app.STORAGE.retrieve_browser_profile(@@ -552,6 +595,7 @@ async def _create_headful_chromium()if profile_dir:user_data_dir = profile_dir+ loaded_from_saved_profile = TrueLOG.info("Using browser profile",browser_profile_id=browser_profile_id,@@ -587,7 +631,29 @@ async def _create_headful_chromium(har_path=browser_args["record_har_path"],browser_session_dir=user_data_dir,)- browser_context = await playwright.chromium.launch_persistent_context(**browser_args)+ try:+ browser_context = await playwright.chromium.launch_persistent_context(**browser_args)+ except Exception as launch_error:+ if loaded_from_saved_profile and _is_browser_profile_corruption_error(launch_error):+ LOG.warning(+ "Browser launch failed with saved profile — profile may be corrupted, falling back to fresh profile",+ browser_profile_id=browser_profile_id,+ organization_id=organization_id_for_profile,+ error=str(launch_error),+ )+ fallback_dir = make_temp_directory(prefix="skyvern_browser_")+ BrowserContextFactory.update_chromium_browser_preferences(+ user_data_dir=fallback_dir,+ download_dir=download_dir,+ )+ browser_args["user_data_dir"] = fallback_dir+ browser_artifacts = BrowserContextFactory.build_browser_artifacts(+ har_path=browser_args["record_har_path"],+ browser_session_dir=fallback_dir,+ )+ browser_context = await playwright.chromium.launch_persistent_context(**browser_args)+ else:+ raisereturn browser_context, browser_artifacts, Nonediff --git a/tests/unit/test_action_url.py b/tests/unit/test_action_url.pyindex 179919562..b3f8271d2 100644--- a/tests/unit/test_action_url.py+++ b/tests/unit/test_action_url.py@@ -116,11 +116,76 @@ def test_template_url_rendering():# First action should show [url: portal.example.com/login]assert "[url: https://portal.example.com/login]" in prompt- # Third action should show [url changed: sso.example.com/auth]- assert "[url changed: https://sso.example.com/auth]" in prompt+ # Third action should show page navigation to sso.example.com/auth+ assert "page navigated to https://sso.example.com/auth" in prompt# Second action (same URL as first) should NOT show urllines = prompt.split("\n")action_2_lines = [line for line in lines if "2. input_text:" in line]assert action_2_lines, "Action 2 should exist"assert "[url:" not in action_2_lines[0]- assert "[url changed:" not in action_2_lines[0]+ assert "page navigated" not in action_2_lines[0]+++class TestBuildActionSummariesWithTiming:+ """Tests for build_action_summaries_with_timing shared helper."""++ def _make_action_with_timestamp(self, ts, **kwargs):+ from skyvern.webeye.actions.actions import Action, ActionType++ defaults = {+ "action_type": ActionType.CLICK,+ "status": "completed",+ "intention": "Click button",+ "created_at": ts,+ "skyvern_element_data": None,+ }+ defaults.update(kwargs)+ return Action(**defaults)++ def test_computes_deltas_between_actions(self):+ from datetime import datetime, timezone++ from skyvern.utils.css_selector import build_action_summaries_with_timing++ t0 = datetime(2026, 4, 6, 12, 0, 0, tzinfo=timezone.utc)+ t1 = datetime(2026, 4, 6, 12, 0, 2, tzinfo=timezone.utc) # +2s+ t2 = datetime(2026, 4, 6, 12, 0, 9, tzinfo=timezone.utc) # +7s++ actions = [+ self._make_action_with_timestamp(t0),+ self._make_action_with_timestamp(t1),+ self._make_action_with_timestamp(t2),+ ]+ summaries = build_action_summaries_with_timing(actions)+ assert len(summaries) == 3+ assert "seconds_since_previous" not in summaries[0] # first action, no previous+ assert summaries[1]["seconds_since_previous"] == 2.0+ assert summaries[2]["seconds_since_previous"] == 7.0++ def test_handles_none_timestamps(self):+ from skyvern.utils.css_selector import build_action_summaries_with_timing++ actions = [+ self._make_action_with_timestamp(None),+ self._make_action_with_timestamp(None),+ ]+ summaries = build_action_summaries_with_timing(actions)+ assert len(summaries) == 2+ assert "seconds_since_previous" not in summaries[0]+ assert "seconds_since_previous" not in summaries[1]++ def test_negative_delta_clamped_to_zero(self):+ from datetime import datetime, timezone++ from skyvern.utils.css_selector import build_action_summaries_with_timing++ t0 = datetime(2026, 4, 6, 12, 0, 10, tzinfo=timezone.utc)+ t1 = datetime(2026, 4, 6, 12, 0, 5, tzinfo=timezone.utc) # earlier (clock skew)++ actions = [+ self._make_action_with_timestamp(t0),+ self._make_action_with_timestamp(t1),+ ]+ summaries = build_action_summaries_with_timing(actions)+ # Negative delta clamped to 0+ assert summaries[1]["seconds_since_previous"] == 0.0