Skip to content

Automate browser based workflows with AI

fix: only show delete confirmation dialog when output is referenced (SKY-8326) (#5095)

Celal Zamanoğlu477cd700bb70
diff --git a/skyvern-frontend/src/routes/workflows/editor/Workspace.tsx b/skyvern-frontend/src/routes/workflows/editor/Workspace.tsx
index b899af1da..c8614bd53 100644
--- a/skyvern-frontend/src/routes/workflows/editor/Workspace.tsx
+++ b/skyvern-frontend/src/routes/workflows/editor/Workspace.tsx
@@ -287,6 +287,12 @@ function Workspace({
const handleRequestDeleteNode = useCallback(
(nodeId: string, nodeLabel: string, confirmCallback: () => void) => {
+ const outputKey = getOutputParameterKey(nodeLabel);
+ const affected = getAffectedBlocks(nodes, outputKey);
+ if (affected.length === 0) {
+ confirmCallback();
+ return;
+ }
deleteConfirmCallbackRef.current = confirmCallback;
setDeleteBlockDialogState({
open: true,
@@ -294,7 +300,7 @@ function Workspace({
nodeLabel,
});
},
- [],
+ [nodes],
);
const [cacheKeyValue, setCacheKeyValue] = useState(
diff --git a/skyvern-frontend/src/routes/workflows/editor/panels/WorkflowParametersPanel.tsx b/skyvern-frontend/src/routes/workflows/editor/panels/WorkflowParametersPanel.tsx
index e8c270f9a..e1d9c49b6 100644
--- a/skyvern-frontend/src/routes/workflows/editor/panels/WorkflowParametersPanel.tsx
+++ b/skyvern-frontend/src/routes/workflows/editor/panels/WorkflowParametersPanel.tsx
@@ -159,6 +159,14 @@ function WorkflowParametersPanel({ onMouseDownCapture }: Props) {
<button
type="button"
onClick={() => {
+ const affected = getAffectedBlocks(
+ nodes,
+ parameter.key,
+ );
+ if (affected.length === 0) {
+ handleDeleteParameter(parameter.key);
+ return;
+ }
setDeleteDialogState({
open: true,
parameterKey: parameter.key,