Automate browser based workflows with AI
Python aiapiautomationbrowserbrowser-automationcomputergptllmplaywrightpowerautomatepuppeteerpythonrpaseleniumvisionworkflow
Materialize the updated row before commit so artifact URI writes stop raising MissingGreenlet (SKY-13354) (#7951)
Shuchang Zheng49b3d8d72c24
diff --git a/skyvern/forge/sdk/db/repositories/artifacts.py b/skyvern/forge/sdk/db/repositories/artifacts.pyindex a680f90ee..82e81da35 100644--- a/skyvern/forge/sdk/db/repositories/artifacts.py+++ b/skyvern/forge/sdk/db/repositories/artifacts.py@@ -100,8 +100,13 @@ class ArtifactsRepository(BaseRepository):.returning(ArtifactModel))artifact = await session.scalar(query)+ if artifact is None:+ return None+ # Read the row before committing: commit expires the instance, and the+ # refetch it would trigger runs outside the async greenlet context.+ converted = convert_to_artifact(artifact, self.debug_enabled)await session.commit()- return convert_to_artifact(artifact, self.debug_enabled) if artifact else None+ return converted@traced(name="skyvern.db.bulk_create_artifacts")@db_operation("bulk_create_artifacts")diff --git a/skyvern/forge/sdk/db/repositories/otp.py b/skyvern/forge/sdk/db/repositories/otp.pyindex 5df52b0a1..5629d2f7d 100644--- a/skyvern/forge/sdk/db/repositories/otp.py+++ b/skyvern/forge/sdk/db/repositories/otp.py@@ -266,5 +266,10 @@ class OTPRepository(BaseRepository):.returning(TOTPCodeModel))row = (await session.scalars(query)).one_or_none()+ if row is None:+ return None+ # Read the row before committing: commit expires the instance, and the+ # refetch it would trigger runs outside the async greenlet context.+ promoted = TOTPCode.model_validate(row)await session.commit()- return TOTPCode.model_validate(row) if row else None+ return promoteddiff --git a/tests/unit/forge/sdk/db/test_artifacts_repository.py b/tests/unit/forge/sdk/db/test_artifacts_repository.pynew file mode 100644index 000000000..940245911--- /dev/null+++ b/tests/unit/forge/sdk/db/test_artifacts_repository.py@@ -0,0 +1,67 @@+import datetime++import pytest+import pytest_asyncio+from sqlalchemy.ext.asyncio import AsyncEngine++from skyvern.forge.sdk.db.base_alchemy_db import BaseAlchemyDB+from skyvern.forge.sdk.db.models import ArtifactModel+from skyvern.forge.sdk.db.repositories.artifacts import ArtifactsRepository+++@pytest_asyncio.fixture+async def repo(sqlite_engine: AsyncEngine) -> ArtifactsRepository:+ db = BaseAlchemyDB(sqlite_engine)+ return ArtifactsRepository(db.Session, debug_enabled=False)+++@pytest_asyncio.fixture+async def recording_artifact(sqlite_engine: AsyncEngine) -> str:+ created_at = datetime.datetime(2026, 8, 1, 12, 0, 0)+ async with sqlite_engine.begin() as conn:+ await conn.execute(+ ArtifactModel.__table__.insert().values(+ artifact_id="a_recording",+ organization_id="o_test",+ workflow_run_id="wr_test",+ artifact_type="recording",+ uri="s3://bucket/recording.webm",+ file_size=100,+ created_at=created_at,+ modified_at=created_at,+ )+ )+ return "a_recording"+++async def test_update_artifact_uri_returns_updated_values(+ repo: ArtifactsRepository,+ recording_artifact: str,+) -> None:+ updated = await repo.update_artifact_uri(+ artifact_id=recording_artifact,+ organization_id="o_test",+ uri="s3://bucket/recording.mp4",+ file_size=42,+ )++ assert updated is not None+ assert updated.artifact_id == recording_artifact+ assert updated.uri == "s3://bucket/recording.mp4"+ assert updated.file_size == 42+++async def test_update_artifact_uri_returns_none_for_other_organization(+ repo: ArtifactsRepository,+ recording_artifact: str,+) -> None:+ assert (+ await repo.update_artifact_uri(+ artifact_id=recording_artifact,+ organization_id="o_other",+ uri="s3://bucket/recording.mp4",+ )+ is None+ )diff --git a/tests/unit/forge/sdk/db/test_otp_repository.py b/tests/unit/forge/sdk/db/test_otp_repository.pyindex 2c120768c..ede1770dd 100644--- a/tests/unit/forge/sdk/db/test_otp_repository.py+++ b/tests/unit/forge/sdk/db/test_otp_repository.py@@ -174,3 +174,31 @@ async def test_otp_repository_readers_match_non_email_identifiers_exactly(assert [result.totp_code_id for result in upper_results] == ["otp_username_upper"]assert [result.totp_code_id for result in lower_results] == ["otp_username_lower"]+++async def test_promote_raw_otp_code_returns_promoted_row(agent_db: AgentDB) -> None:+ async with agent_db.Session() as session:+ session.add(+ TOTPCodeModel(+ totp_code_id="otp_promote",+ organization_id="o_test",+ totp_identifier="[email protected]",+ content="your code is 123456",+ code=None,+ otp_type=None,+ parse_status="raw",+ )+ )+ await session.commit()++ promoted = await agent_db.otp.promote_raw_otp_code(+ totp_code_id="otp_promote",+ organization_id="o_test",+ code="123456",+ otp_type=OTPType.TOTP,+ )++ assert promoted is not None+ assert promoted.totp_code_id == "otp_promote"+ assert promoted.code == "123456"