Skip to content

Automate browser based workflows with AI

fix(record): stop NaN coordinates from killing the live-draft channel (#6999)

Cindy Li4e40b037cdbc
diff --git a/skyvern/forge/sdk/routes/streaming/channels/js/exfiltrate.js b/skyvern/forge/sdk/routes/streaming/channels/js/exfiltrate.js
index 747acfb91..5e5fe5496 100644
--- a/skyvern/forge/sdk/routes/streaming/channels/js/exfiltrate.js
+++ b/skyvern/forge/sdk/routes/streaming/channels/js/exfiltrate.js
@@ -167,10 +167,16 @@
? e.target?.value
: undefined,
mousePosition: {
- xa: e.clientX,
- ya: e.clientY,
- xp: e.clientX / window.innerWidth,
- yp: e.clientY / window.innerHeight,
+ xa: Number.isFinite(e.clientX) ? e.clientX : null,
+ ya: Number.isFinite(e.clientY) ? e.clientY : null,
+ xp:
+ Number.isFinite(e.clientX) && window.innerWidth
+ ? e.clientX / window.innerWidth
+ : null,
+ yp:
+ Number.isFinite(e.clientY) && window.innerHeight
+ ? e.clientY / window.innerHeight
+ : null,
},
key: e.key,
code: e.code,
diff --git a/skyvern/forge/sdk/routes/streaming/channels/message.py b/skyvern/forge/sdk/routes/streaming/channels/message.py
index 5c146e949..971bab269 100644
--- a/skyvern/forge/sdk/routes/streaming/channels/message.py
+++ b/skyvern/forge/sdk/routes/streaming/channels/message.py
@@ -15,6 +15,7 @@ Channel data:
import asyncio
import dataclasses
import enum
+import math
import typing as t
import structlog
@@ -383,16 +384,29 @@ def message_to_dict(message: MessageOut) -> dict:
if isinstance(obj, enum.Enum):
return obj.value
if isinstance(obj, BaseModel):
- return obj.model_dump(mode="json")
+ return _replace_non_finite(obj.model_dump(mode="json"))
if isinstance(obj, list):
return [convert_value(item) for item in obj]
if isinstance(obj, dict):
return {key: convert_value(value) for key, value in obj.items()}
+ if isinstance(obj, float) and not math.isfinite(obj):
+ return None
return obj
return {key: convert_value(value) for key, value in dataclasses.asdict(message).items()}
+def _replace_non_finite(obj: t.Any) -> t.Any:
+ """NaN/Infinity are not valid JSON; JSON.parse rejects them and drops the whole frame."""
+ if isinstance(obj, float):
+ return obj if math.isfinite(obj) else None
+ if isinstance(obj, list):
+ return [_replace_non_finite(item) for item in obj]
+ if isinstance(obj, dict):
+ return {key: _replace_non_finite(value) for key, value in obj.items()}
+ return obj
+
+
@dataclasses.dataclass
class MessageChannel:
"""
diff --git a/tests/unit/forge/sdk/routes/streaming/test_message_reify.py b/tests/unit/forge/sdk/routes/streaming/test_message_reify.py
index 51a38b520..7df08bb7c 100644
--- a/tests/unit/forge/sdk/routes/streaming/test_message_reify.py
+++ b/tests/unit/forge/sdk/routes/streaming/test_message_reify.py
@@ -2,6 +2,7 @@
from __future__ import annotations
+import json
import typing as t
from contextlib import asynccontextmanager
from unittest.mock import AsyncMock, MagicMock
@@ -26,6 +27,7 @@ from skyvern.forge.sdk.routes.streaming.channels.message import (
MessageInReload,
MessageInTakeScreenshot,
MessageKind,
+ MessageOutExfiltratedEvent,
MessageOutRecordingInterpretationUpdate,
loop_stream_messages,
message_to_dict,
@@ -355,3 +357,34 @@ class TestMessageLoopUrlUpdates:
method.assert_awaited_once_with(**expected_kwargs)
execute.get_current_url.assert_awaited_once_with()
websocket.send_json.assert_any_await({"kind": "browser-url", "url": current_url})
+
+
+class TestMessageToDictJsonSafety:
+ def test_non_finite_floats_become_null(self) -> None:
+ msg = MessageOutExfiltratedEvent(
+ event_name="click",
+ params={"mousePosition": {"xa": 42.0, "xp": float("nan"), "yp": float("inf")}},
+ )
+
+ data = message_to_dict(msg)
+
+ mouse = data["params"]["mousePosition"]
+ assert mouse["xa"] == 42.0
+ assert mouse["xp"] is None
+ assert mouse["yp"] is None
+ json.dumps(data, allow_nan=False)
+
+ def test_non_finite_floats_in_nested_model_become_null(self) -> None:
+ step = RecordingDraftStep(
+ step_id="s1",
+ action_kind=ActionKind.CLICK,
+ block_type="action",
+ label="click",
+ timestamp_start=float("nan"),
+ )
+ msg = MessageOutRecordingInterpretationUpdate(steps=[step])
+
+ data = message_to_dict(msg)
+
+ assert data["steps"][0]["timestamp_start"] is None
+ json.dumps(data, allow_nan=False)