Automate browser based workflows with AI
Python aiapiautomationbrowserbrowser-automationcomputergptllmplaywrightpowerautomatepuppeteerpythonrpaseleniumvisionworkflow
fix(SKY-12372): make round robin selectable on the run credential rotation page (#7363)
Suchintan4ef3f1ea76a2
diff --git a/docs/pr-screenshots/sky12372-after-1-force-seeded.png b/docs/pr-screenshots/sky12372-after-1-force-seeded.pngnew file mode 100644index 000000000..5aaf429d9Binary files /dev/null and b/docs/pr-screenshots/sky12372-after-1-force-seeded.png differdiff --git a/docs/pr-screenshots/sky12372-after-2-rotation-selected.png b/docs/pr-screenshots/sky12372-after-2-rotation-selected.pngnew file mode 100644index 000000000..fa61a0af5Binary files /dev/null and b/docs/pr-screenshots/sky12372-after-2-rotation-selected.png differdiff --git a/skyvern-frontend/src/routes/workflows/RunWorkflowForm.tsx b/skyvern-frontend/src/routes/workflows/RunWorkflowForm.tsxindex fd6747c21..eef3c062d 100644--- a/skyvern-frontend/src/routes/workflows/RunWorkflowForm.tsx+++ b/skyvern-frontend/src/routes/workflows/RunWorkflowForm.tsx@@ -21,7 +21,6 @@ import {AccordionItem,AccordionTrigger,} from "@/components/ui/accordion";-import { Badge } from "@/components/ui/badge";import {Form,FormControl,@@ -37,7 +36,6 @@ import {SelectTrigger,SelectValue,} from "@/components/ui/select";-import { RadioGroup, RadioGroupItem } from "@/components/ui/radio-group";import { Switch } from "@/components/ui/switch";import { CopyApiCommandDropdown } from "@/components/CopyApiCommandDropdown";import { Input } from "@/components/ui/input";@@ -69,16 +67,14 @@ import {} from "./types/workflowTypes";import { WorkflowParameterInput } from "./WorkflowParameterInput";import { BrowserProfileSelector } from "./components/BrowserProfileSelector";+import { RotatingCredentialField } from "./components/RotatingCredentialField";import { TestWebhookDialog } from "@/components/TestWebhookDialog";import * as env from "@/util/env";import {parseJsonWorkflowParameterValue,validateJsonWorkflowParameterValue,} from "./utils";-import {- getLoginCredentialInputs,- getRotatingCredentialIds,-} from "./runWorkflowCredentials";+import { getLoginCredentialInputs } from "./runWorkflowCredentials";import { useCredentialsQuery } from "./hooks/useCredentialsQuery";import { visitWorkflowBlocks } from "./workflowBlockUtils";@@ -317,16 +313,6 @@ function deriveRunWith(return "agent";}-function formatCredentialSelectionStrategy(- selectionStrategy: CredentialParameter["selection_strategy"],-) {- if (selectionStrategy === "random") {- return "Random";- }-- return "Round robin";-}-function formatLoginBlockList(labels: Array<string>) {if (labels.length <= 1) {return labels[0] ?? "";@@ -843,145 +829,24 @@ function RunWorkflowForm({);}- const credentialIds = getRotatingCredentialIds(parameter);return (<FormFieldkey={parameter.key}control={form.control}name={parameter.key}- render={({ field }) => {- const forcedCredentialId =- typeof field.value === "string" ? field.value : "";- const mode = forcedCredentialId ? "force" : "rotation";- const forceSelectValue =- forcedCredentialId || credentialIds[0] || "";-- return (- <FormItem>- <div className="flex gap-16">- <FormLabel className="!text-slate-50">- <div className="w-72">- <div className="flex items-center gap-2 text-lg">- {title}- <span className="text-sm text-slate-400">- credential rotation- </span>- </div>- <h2 className="text-sm text-slate-400">- {description}- </h2>- </div>- </FormLabel>- <div className="w-full space-y-3">- <FormControl>- <RadioGroup- value={mode}- onValueChange={(value) => {- if (value === "force") {- field.onChange(forceSelectValue);- } else {- field.onChange(undefined);- }- form.trigger(parameter.key);- }}- className="gap-3"- >- <label- className="flex cursor-pointer items-start gap-3 rounded-md border border-slate-700 bg-slate-900/40 p-3"- htmlFor={`${parameter.key}-rotation`}- >- <RadioGroupItem- id={`${parameter.key}-rotation`}- value="rotation"- className="mt-1"- />- <div className="min-w-0 flex-1 space-y-2">- <div className="flex flex-wrap items-center gap-2">- <span className="text-sm font-medium text-slate-100">- Use configured rotation- </span>- <Badge- variant="outline"- className="text-xs font-normal"- >- {formatCredentialSelectionStrategy(- parameter.selection_strategy,- )}- </Badge>- </div>- <div className="grid gap-2 md:grid-cols-2">- {credentialIds.map((credentialId) => (- <div- key={credentialId}- className="min-w-0 rounded border border-slate-700/60 bg-slate-950/40 px-2 py-1.5 text-xs text-slate-200"- >- <span className="block truncate">- {credentialNamesById.get(- credentialId,- ) ?? credentialId}- </span>- </div>- ))}- </div>- </div>- </label>-- <label- className="flex cursor-pointer items-start gap-3 rounded-md border border-slate-700 bg-slate-900/40 p-3"- htmlFor={`${parameter.key}-force`}- >- <RadioGroupItem- id={`${parameter.key}-force`}- value="force"- className="mt-1"- />- <div className="min-w-0 flex-1 space-y-2">- <div className="flex flex-wrap items-center gap-2">- <span className="text-sm font-medium text-slate-100">- Force one credential for this run- </span>- {mode === "force" && (- <Badge- variant="outline"- className="text-xs font-normal"- >- Run only- </Badge>- )}- </div>- <Select- disabled={mode !== "force"}- value={forceSelectValue}- onValueChange={(value) => {- field.onChange(value);- form.trigger(parameter.key);- }}- >- <SelectTrigger className="w-full">- <SelectValue placeholder="Select a credential" />- </SelectTrigger>- <SelectContent>- {credentialIds.map((credentialId) => (- <SelectItem- key={credentialId}- value={credentialId}- >- {credentialNamesById.get(- credentialId,- ) ?? credentialId}- </SelectItem>- ))}- </SelectContent>- </Select>- </div>- </label>- </RadioGroup>- </FormControl>- </div>- </div>- </FormItem>- );- }}+ render={({ field }) => (+ <RotatingCredentialField+ parameter={parameter as CredentialParameter}+ value={field.value}+ onChange={(value) => {+ field.onChange(value);+ form.trigger(parameter.key);+ }}+ credentialNamesById={credentialNamesById}+ title={title}+ description={description}+ />+ )}/>);})}diff --git a/skyvern-frontend/src/routes/workflows/components/RotatingCredentialField.test.tsx b/skyvern-frontend/src/routes/workflows/components/RotatingCredentialField.test.tsxnew file mode 100644index 000000000..f9a855d9d--- /dev/null+++ b/skyvern-frontend/src/routes/workflows/components/RotatingCredentialField.test.tsx@@ -0,0 +1,127 @@+// @vitest-environment jsdom++import { fireEvent, render, screen } from "@testing-library/react";+import { useForm } from "react-hook-form";+import { describe, expect, test, vi } from "vitest";++import { Form, FormField } from "@/components/ui/form";++import { CredentialParameter } from "../types/workflowTypes";+import { RotatingCredentialField } from "./RotatingCredentialField";++const credentialNamesById = new Map([+ ["cred_1", "Cred One"],+ ["cred_2", "Cred Two"],+]);++function buildCredentialParameter(): CredentialParameter {+ return {+ credential_ids: ["cred_1", "cred_2"],+ selection_strategy: "round_robin",+ credential_id: "cred_1",+ key: "Portal_Login",+ parameter_type: "credential",+ workflow_id: "workflow_1",+ credential_parameter_id: "credential_parameter_1",+ description: null,+ created_at: "2026-07-13T00:00:00Z",+ modified_at: "2026-07-13T00:00:00Z",+ deleted_at: null,+ };+}++// field.onChange(undefined) is a no-op in react-hook-form, so drive value+// through the real RHF field (not useState) to exercise the actual clear path.+function ControlledRotatingCredentialField({+ initialValue,+ onChange,+}: {+ initialValue: string | null;+ onChange: (value: string | null) => void;+}) {+ const parameter = buildCredentialParameter();+ const form = useForm<Record<string, unknown>>({+ defaultValues: { [parameter.key]: initialValue },+ });++ return (+ <Form {...form}>+ <FormField+ control={form.control}+ name={parameter.key}+ render={({ field }) => (+ <RotatingCredentialField+ parameter={parameter}+ value={field.value}+ onChange={(nextValue) => {+ onChange(nextValue);+ field.onChange(nextValue);+ }}+ credentialNamesById={credentialNamesById}+ title="Portal Login"+ description="Rotating login credentials"+ />+ )}+ />+ </Form>+ );+}++describe("RotatingCredentialField", () => {+ test("can switch from a seeded force selection to configured rotation", () => {+ const onChange = vi.fn();++ render(+ <ControlledRotatingCredentialField+ initialValue="cred_1"+ onChange={onChange}+ />,+ );++ let radios = screen.getAllByRole("radio");+ expect(radios[0]?.getAttribute("aria-checked")).toBe("false");+ expect(radios[1]?.getAttribute("aria-checked")).toBe("true");++ fireEvent.click(screen.getByText("Use configured rotation"));++ expect(onChange).toHaveBeenCalledWith(null);+ radios = screen.getAllByRole("radio");+ expect(radios[0]?.getAttribute("aria-checked")).toBe("true");+ expect(radios[1]?.getAttribute("aria-checked")).toBe("false");+ });++ test("can force a single credential from rotation", () => {+ const onChange = vi.fn();++ render(+ <ControlledRotatingCredentialField+ initialValue={null}+ onChange={onChange}+ />,+ );++ let radios = screen.getAllByRole("radio");+ expect(radios[0]?.getAttribute("aria-checked")).toBe("true");+ expect(radios[1]?.getAttribute("aria-checked")).toBe("false");++ fireEvent.click(screen.getByText("Force one credential for this run"));++ expect(onChange).toHaveBeenCalledWith("cred_1");+ radios = screen.getAllByRole("radio");+ expect(radios[0]?.getAttribute("aria-checked")).toBe("false");+ expect(radios[1]?.getAttribute("aria-checked")).toBe("true");+ });++ test("defaults to rotation when value is empty", () => {+ render(+ <ControlledRotatingCredentialField+ initialValue={null}+ onChange={vi.fn()}+ />,+ );++ const radios = screen.getAllByRole("radio");+ expect(radios[0]?.getAttribute("aria-checked")).toBe("true");+ expect(radios[1]?.getAttribute("aria-checked")).toBe("false");+ });+});diff --git a/skyvern-frontend/src/routes/workflows/components/RotatingCredentialField.tsx b/skyvern-frontend/src/routes/workflows/components/RotatingCredentialField.tsxnew file mode 100644index 000000000..ac0ab182b--- /dev/null+++ b/skyvern-frontend/src/routes/workflows/components/RotatingCredentialField.tsx@@ -0,0 +1,157 @@+import { Badge } from "@/components/ui/badge";+import { FormControl, FormItem, FormLabel } from "@/components/ui/form";+import { RadioGroup, RadioGroupItem } from "@/components/ui/radio-group";+import {+ Select,+ SelectContent,+ SelectItem,+ SelectTrigger,+ SelectValue,+} from "@/components/ui/select";++import { getRotatingCredentialIds } from "../runWorkflowCredentials";+import { CredentialParameter } from "../types/workflowTypes";++type RotatingCredentialFieldProps = {+ parameter: CredentialParameter;+ value: unknown;+ onChange: (value: string | null) => void;+ credentialNamesById: Map<string, string>;+ title: string;+ description: string;+};++function formatCredentialSelectionStrategy(+ selectionStrategy: CredentialParameter["selection_strategy"],+) {+ if (selectionStrategy === "random") {+ return "Random";+ }++ return "Round robin";+}++function RotatingCredentialField({+ parameter,+ value,+ onChange,+ credentialNamesById,+ title,+ description,+}: RotatingCredentialFieldProps) {+ const credentialIds = getRotatingCredentialIds(parameter);+ const forcedCredentialId = typeof value === "string" ? value : "";+ const mode = forcedCredentialId ? "force" : "rotation";+ const forceSelectValue = forcedCredentialId || credentialIds[0] || "";++ return (+ <FormItem>+ <div className="flex gap-16">+ <FormLabel className="!text-slate-50">+ <div className="w-72">+ <div className="flex items-center gap-2 text-lg">+ {title}+ <span className="text-sm text-slate-400">+ credential rotation+ </span>+ </div>+ <h2 className="text-sm text-slate-400">{description}</h2>+ </div>+ </FormLabel>+ <div className="w-full space-y-3">+ <FormControl>+ <RadioGroup+ value={mode}+ onValueChange={(nextMode) => {+ if (nextMode === "force") {+ onChange(forceSelectValue);+ } else {+ onChange(null);+ }+ }}+ className="gap-3"+ >+ <label+ className="flex cursor-pointer items-start gap-3 rounded-md border border-slate-700 bg-slate-900/40 p-3"+ htmlFor={`${parameter.key}-rotation`}+ >+ <RadioGroupItem+ id={`${parameter.key}-rotation`}+ value="rotation"+ className="mt-1"+ />+ <div className="min-w-0 flex-1 space-y-2">+ <div className="flex flex-wrap items-center gap-2">+ <span className="text-sm font-medium text-slate-100">+ Use configured rotation+ </span>+ <Badge variant="outline" className="text-xs font-normal">+ {formatCredentialSelectionStrategy(+ parameter.selection_strategy,+ )}+ </Badge>+ </div>+ <div className="grid gap-2 md:grid-cols-2">+ {credentialIds.map((credentialId) => (+ <div+ key={credentialId}+ className="min-w-0 rounded border border-slate-700/60 bg-slate-950/40 px-2 py-1.5 text-xs text-slate-200"+ >+ <span className="block truncate">+ {credentialNamesById.get(credentialId) ??+ credentialId}+ </span>+ </div>+ ))}+ </div>+ </div>+ </label>++ <label+ className="flex cursor-pointer items-start gap-3 rounded-md border border-slate-700 bg-slate-900/40 p-3"+ htmlFor={`${parameter.key}-force`}+ >+ <RadioGroupItem+ id={`${parameter.key}-force`}+ value="force"+ className="mt-1"+ />+ <div className="min-w-0 flex-1 space-y-2">+ <div className="flex flex-wrap items-center gap-2">+ <span className="text-sm font-medium text-slate-100">+ Force one credential for this run+ </span>+ {mode === "force" && (+ <Badge variant="outline" className="text-xs font-normal">+ Run only+ </Badge>+ )}+ </div>+ <Select+ disabled={mode !== "force"}+ value={forceSelectValue}+ onValueChange={(value) => onChange(value)}+ >+ <SelectTrigger className="w-full">+ <SelectValue placeholder="Select a credential" />+ </SelectTrigger>+ <SelectContent>+ {credentialIds.map((credentialId) => (+ <SelectItem key={credentialId} value={credentialId}>+ {credentialNamesById.get(credentialId) ??+ credentialId}+ </SelectItem>+ ))}+ </SelectContent>+ </Select>+ </div>+ </label>+ </RadioGroup>+ </FormControl>+ </div>+ </div>+ </FormItem>+ );+}++export { RotatingCredentialField };