Skip to content

Automate browser based workflows with AI

Fix SKY-9838 download retry loop without empty artifacts (#6009)

Andrew Neilson516ec34da18a
diff --git a/skyvern/forge/sdk/copilot/context.py b/skyvern/forge/sdk/copilot/context.py
index 5c3fb1be0..9a4324e6b 100644
--- a/skyvern/forge/sdk/copilot/context.py
+++ b/skyvern/forge/sdk/copilot/context.py
@@ -197,6 +197,7 @@ class CopilotContext(AgentContext):
# this guards auto-retry WITHIN a turn but not cross-turn "user says
# retry" requests.
pending_reconciliation_run_id: str | None = None
+ pending_reconciliation_requires_user_input: bool = False
# Consecutive test runs whose data-producing blocks completed with no
# meaningful output (missing, empty, or all-null fields). Resets when a
# run produces real data. Used to escalate when the agent is stuck
diff --git a/skyvern/forge/sdk/copilot/enforcement.py b/skyvern/forge/sdk/copilot/enforcement.py
index aa6f70faa..fbee0e8a8 100644
--- a/skyvern/forge/sdk/copilot/enforcement.py
+++ b/skyvern/forge/sdk/copilot/enforcement.py
@@ -393,6 +393,8 @@ def _needs_failed_test_nudge(ctx: Any) -> bool:
# the dedicated non-retriable branch in _check_enforcement owns this case.
if getattr(ctx, "last_test_non_retriable_nav_error", None):
return False
+ if getattr(ctx, "pending_reconciliation_requires_user_input", False) is True:
+ return False
if getattr(ctx, "last_test_ok", None) is not False:
return False
if not getattr(ctx, "test_after_update_done", False):
diff --git a/skyvern/forge/sdk/copilot/tools.py b/skyvern/forge/sdk/copilot/tools.py
index 2aa1f0785..a7ca7389f 100644
--- a/skyvern/forge/sdk/copilot/tools.py
+++ b/skyvern/forge/sdk/copilot/tools.py
@@ -428,6 +428,15 @@ def _maybe_clear_reconciliation_flag(copilot_ctx: Any, result: Any) -> None:
was_per_tool_budget = getattr(copilot_ctx, "last_failure_category_top", None) == PER_TOOL_BUDGET_FAILURE_CATEGORY
if is_trusted_final or was_per_tool_budget:
copilot_ctx.pending_reconciliation_run_id = None
+ copilot_ctx.pending_reconciliation_requires_user_input = False
+ return
+ if resolved_status == WorkflowRunStatus.canceled.value:
+ copilot_ctx.pending_reconciliation_requires_user_input = True
+
+
+def _mark_pending_reconciliation_run(copilot_ctx: Any, workflow_run_id: str) -> None:
+ copilot_ctx.pending_reconciliation_run_id = workflow_run_id
+ copilot_ctx.pending_reconciliation_requires_user_input = False
def _enum_or_string_name(value: Any) -> str:
@@ -746,6 +755,13 @@ def _tool_loop_error(ctx: AgentContext, tool_name: str, arguments: dict[str, Any
# have landed.
pending_run_id = getattr(ctx, "pending_reconciliation_run_id", None)
if isinstance(pending_run_id, str) and pending_run_id:
+ if getattr(ctx, "pending_reconciliation_requires_user_input", False) is True:
+ return (
+ f"The canceled run {pending_run_id} has already been inspected. "
+ f"Do NOT run more blocks in this turn; ask the user whether to retry, "
+ f"accept the unverified draft, or adjust the workflow first. This guard "
+ f"prevents duplicate side effects on live sites."
+ )
return (
f"The previous block-running tool call for run {pending_run_id} "
f"ended without a trustworthy terminal status. "
@@ -1641,11 +1657,16 @@ WatchdogExitReason = Literal["success", "stagnation", "ceiling", "per_tool_budge
# Block types that legitimately execute long silent periods: one DB write on
# entry, work done without intermediate writes (sleep / LLM call / await human
-# input), one write on finish. The watchdog can't distinguish these from
-# "stuck", so any invocation that includes one disables stagnation for the
-# whole run and relies on the safety ceiling alone.
+# input / browser download wait), one write on finish. The watchdog can't
+# distinguish these from "stuck", so any invocation that includes one disables
+# stagnation for the whole run and relies on the safety ceiling alone.
_QUIET_BLOCK_TYPES: frozenset[str] = frozenset(
- {BlockType.WAIT.value, BlockType.TEXT_PROMPT.value, BlockType.HUMAN_INTERACTION.value}
+ {
+ BlockType.WAIT.value,
+ BlockType.TEXT_PROMPT.value,
+ BlockType.HUMAN_INTERACTION.value,
+ BlockType.FILE_DOWNLOAD.value,
+ }
)
@@ -2067,7 +2088,7 @@ async def _run_blocks_and_collect_debug(
if exit_reason != "success":
assert exit_reason is not None # narrows for mypy; outer check excludes "success" but not None
- ctx.pending_reconciliation_run_id = workflow_run.workflow_run_id
+ _mark_pending_reconciliation_run(ctx, workflow_run.workflow_run_id)
error_msg = await _watchdog_error_message(
exit_reason, ctx, workflow_run.workflow_run_id, run, budget_seconds
)
diff --git a/skyvern/webeye/actions/handler.py b/skyvern/webeye/actions/handler.py
index a1fbff68e..0e0a338a0 100644
--- a/skyvern/webeye/actions/handler.py
+++ b/skyvern/webeye/actions/handler.py
@@ -15,7 +15,7 @@ import structlog
from fuzzysearch import find_near_matches
from opentelemetry import trace as otel_trace
from playwright._impl._errors import Error as PlaywrightError
-from playwright.async_api import FileChooser, Frame, Locator, Page, TimeoutError
+from playwright.async_api import Download, FileChooser, Frame, Locator, Page, TimeoutError
from pydantic import BaseModel
from skyvern.config import settings
@@ -123,6 +123,14 @@ from skyvern.webeye.utils.page import SkyvernFrame
LOG = structlog.get_logger()
+DOWNLOAD_EVENT_ACTIVE_DIR_GRACE_SECONDS = 60
+
+
+def _download_target_path(download_dir: Path, suggested_filename: str | None) -> Path:
+ filename = Path(suggested_filename or "download").name
+ stem, suffix = os.path.splitext(filename)
+ return download_dir / f"{uuid.uuid4()}-{stem or 'download'}{suffix}"
+
async def _screenshot_without_cursor(page: Page, **kwargs: Any) -> bytes:
"""Take a screenshot with cursor overlay hidden so it doesn't interfere with LLM analysis."""
@@ -456,18 +464,28 @@ class ActionHandler:
run_id=context.run_id if context and context.run_id else task.workflow_run_id or task.task_id
)
)
+ download_event: asyncio.Future[Download] = asyncio.get_running_loop().create_future()
+
+ def _capture_download_event(download: Download) -> None:
+ if not download_event.done():
+ download_event.set_result(download)
+
+ async def _list_observed_download_files() -> list[str]:
+ files = list_files_in_directory(download_dir)
+ if task.browser_session_id:
+ files_in_browser_session = await app.STORAGE.list_downloaded_files_in_browser_session(
+ organization_id=task.organization_id, browser_session_id=task.browser_session_id
+ )
+ files = files + files_in_browser_session
+ return files
+
initial_page_count = 0
page_url_before_download = page.url
# get the initial page count
if browser_state:
initial_page_count = len(await browser_state.list_valid_pages())
- list_files_before = list_files_in_directory(download_dir)
- if task.browser_session_id:
- files_in_browser_session = await app.STORAGE.list_downloaded_files_in_browser_session(
- organization_id=task.organization_id, browser_session_id=task.browser_session_id
- )
- list_files_before = list_files_before + files_in_browser_session
+ list_files_before = await _list_observed_download_files()
LOG.info(
"Number of files in download directory before action",
num_downloaded_files_before=len(list_files_before),
@@ -475,6 +493,7 @@ class ActionHandler:
)
download_triggered = False
+ page.on("download", _capture_download_event)
try:
with _tracer.start_as_current_span("skyvern.agent.action.handle_inner") as _hi_span:
apply_context_attrs(_hi_span)
@@ -488,10 +507,17 @@ class ActionHandler:
if not results:
return results
_download_timeout = task.download_timeout or BROWSER_DOWNLOAD_MAX_WAIT_TIME
+ _download_event_grace_seconds = min(DOWNLOAD_EVENT_ACTIVE_DIR_GRACE_SECONDS, _download_timeout)
with _tracer.start_as_current_span("skyvern.agent.action.download_wait") as _dl_wait_span:
apply_context_attrs(_dl_wait_span)
_dl_wait_span.set_attribute("timeout_seconds", _download_timeout)
+ _dl_wait_span.set_attribute("download_event_grace_seconds", _download_event_grace_seconds)
_poll_iterations = 0
+ captured_download: Download | None = None
+ download_event_captured = False
+ download_event_captured_at: float | None = None
+ download_event_fallback_attempted = False
+ download_event_fallback_used = False
try:
LOG.info(
"Checking if there is any new files after click",
@@ -500,13 +526,17 @@ class ActionHandler:
async with asyncio.timeout(_download_timeout):
while True:
_poll_iterations += 1
- list_files_after = list_files_in_directory(download_dir)
- if task.browser_session_id:
- files_in_browser_session = await app.STORAGE.list_downloaded_files_in_browser_session(
- organization_id=task.organization_id,
- browser_session_id=task.browser_session_id,
+ if download_event.done() and captured_download is None:
+ captured_download = download_event.result()
+ download_event_captured = True
+ download_event_captured_at = time.monotonic()
+ LOG.info(
+ "Captured download event; waiting for active run directory file",
+ download_dir=download_dir,
+ workflow_run_id=task.workflow_run_id,
)
- list_files_after = list_files_after + files_in_browser_session
+
+ list_files_after = await _list_observed_download_files()
if len(list_files_after) > len(list_files_before):
LOG.info(
@@ -517,6 +547,48 @@ class ActionHandler:
)
download_triggered = True
break
+
+ if (
+ captured_download is not None
+ and download_event_captured_at is not None
+ and not download_event_fallback_attempted
+ and time.monotonic() - download_event_captured_at >= _download_event_grace_seconds
+ ):
+ download_event_fallback_attempted = True
+ download_target = _download_target_path(
+ download_dir, captured_download.suggested_filename
+ )
+ try:
+ await captured_download.save_as(download_target)
+ if download_target.exists() and download_target.stat().st_size == 0:
+ download_target.unlink(missing_ok=True)
+ LOG.warning(
+ "Captured download event fallback produced an empty file; marking download triggered without artifact",
+ download_dir=download_dir,
+ download_target=str(download_target),
+ workflow_run_id=task.workflow_run_id,
+ )
+ list_files_after = await _list_observed_download_files()
+ download_triggered = True
+ break
+
+ list_files_after = await _list_observed_download_files()
+ LOG.info(
+ "Copied captured download event to active run directory",
+ download_dir=download_dir,
+ download_target=str(download_target),
+ workflow_run_id=task.workflow_run_id,
+ )
+ download_triggered = True
+ download_event_fallback_used = True
+ break
+ except Exception:
+ LOG.warning(
+ "Failed to copy captured download event to active run directory",
+ download_dir=download_dir,
+ workflow_run_id=task.workflow_run_id,
+ exc_info=True,
+ )
await asyncio.sleep(1)
except asyncio.TimeoutError:
@@ -527,6 +599,9 @@ class ActionHandler:
finally:
_dl_wait_span.set_attribute("download_triggered", download_triggered)
_dl_wait_span.set_attribute("poll_iterations", _poll_iterations)
+ _dl_wait_span.set_attribute("download_event_captured", download_event_captured)
+ _dl_wait_span.set_attribute("download_event_fallback_attempted", download_event_fallback_attempted)
+ _dl_wait_span.set_attribute("download_event_fallback_used", download_event_fallback_used)
if not download_triggered:
results[-1].download_triggered = False
@@ -616,6 +691,11 @@ class ActionHandler:
exc_info=True,
)
+ try:
+ page.remove_listener("download", _capture_download_event)
+ except Exception:
+ LOG.warning("Failed to remove one-shot download event listener", exc_info=True)
+
persisted_action = await app.DATABASE.workflow_params.create_action(action=action)
action.action_id = persisted_action.action_id
diff --git a/tests/unit/test_copilot_per_tool_budget.py b/tests/unit/test_copilot_per_tool_budget.py
index 16fcafa9f..c1ea40859 100644
--- a/tests/unit/test_copilot_per_tool_budget.py
+++ b/tests/unit/test_copilot_per_tool_budget.py
@@ -34,6 +34,7 @@ from skyvern.forge.sdk.copilot.failure_tracking import (
compute_failure_signature,
)
from skyvern.forge.sdk.copilot.tools import (
+ _mark_pending_reconciliation_run,
_maybe_clear_reconciliation_flag,
_record_per_tool_budget_problem_blocks_from_results,
_record_run_blocks_result,
@@ -265,6 +266,57 @@ def test_reconciliation_does_not_clear_for_non_budget_canceled() -> None:
assert ctx.pending_reconciliation_run_id == "wr_1"
+def test_reconciliation_does_not_mark_user_input_for_non_final_poll() -> None:
+ ctx = _fresh_context()
+ ctx.pending_reconciliation_run_id = "wr_1"
+ ctx.last_failure_category_top = None
+
+ _maybe_clear_reconciliation_flag(ctx, _get_run_results_response("wr_1", "running"))
+
+ assert ctx.pending_reconciliation_run_id == "wr_1"
+ assert ctx.pending_reconciliation_requires_user_input is False
+
+
+def test_new_pending_reconciliation_resets_inspected_canceled_flag() -> None:
+ ctx = _fresh_context()
+ ctx.pending_reconciliation_run_id = "wr_old"
+ ctx.pending_reconciliation_requires_user_input = True
+
+ _mark_pending_reconciliation_run(ctx, "wr_new")
+
+ assert ctx.pending_reconciliation_run_id == "wr_new"
+ assert ctx.pending_reconciliation_requires_user_input is False
+
+
+def test_non_budget_canceled_reconciliation_suppresses_failed_test_nudge() -> None:
+ ctx = _fresh_context()
+ ctx.update_workflow_called = True
+ ctx.test_after_update_done = True
+ ctx.last_test_ok = False
+ ctx.pending_reconciliation_run_id = "wr_1"
+ ctx.last_failure_category_top = None
+
+ _maybe_clear_reconciliation_flag(ctx, _get_run_results_response("wr_1", "canceled"))
+
+ assert ctx.pending_reconciliation_run_id == "wr_1"
+ assert ctx.pending_reconciliation_requires_user_input is True
+ assert _check_enforcement(ctx) is None
+
+
+def test_block_running_after_non_budget_canceled_inspection_does_not_request_get_results_again() -> None:
+ ctx = _fresh_context()
+ ctx.pending_reconciliation_run_id = "wr_1"
+ ctx.last_failure_category_top = None
+
+ _maybe_clear_reconciliation_flag(ctx, _get_run_results_response("wr_1", "canceled"))
+
+ msg = _tool_loop_error(ctx, "update_and_run_blocks")
+
+ assert msg is not None
+ assert "get_run_results" not in msg
+ assert "ask" in msg.lower() or "user" in msg.lower()
+
+
def test_reconciliation_clears_for_per_tool_budget_failed_status_too() -> None:
"""``failed`` would clear the guard regardless, but check the budget path
doesn't accidentally regress that case."""
diff --git a/tests/unit/test_copilot_watchdog.py b/tests/unit/test_copilot_watchdog.py
index 56cad8f95..af5217b4f 100644
--- a/tests/unit/test_copilot_watchdog.py
+++ b/tests/unit/test_copilot_watchdog.py
@@ -363,6 +363,13 @@ def test_any_quiet_block_requested_human_interaction() -> None:
assert _any_quiet_block_requested(ctx, ["wait_for_user"]) is True
+def test_any_quiet_block_requested_file_download() -> None:
+ """File-download blocks can legitimately wait longer than the stagnation
+ window while the browser is waiting for the download to finish."""
+ ctx = SimpleNamespace(last_workflow=_workflow_with_block_types(("file_download", "download_file")))
+ assert _any_quiet_block_requested(ctx, ["download_file"]) is True
+
+
def test_any_quiet_block_requested_mixed_requested_labels_match_quiet_one() -> None:
"""When multiple blocks are requested, having any one quiet type is
enough to disable stagnation for the whole invocation."""
diff --git a/tests/unit/test_download_file_action_handler.py b/tests/unit/test_download_file_action_handler.py
index dfc4a6935..99737d18e 100644
--- a/tests/unit/test_download_file_action_handler.py
+++ b/tests/unit/test_download_file_action_handler.py
@@ -541,3 +541,353 @@ async def test_handle_action_does_not_navigate_back_when_page_url_unchanged() ->
# Page URL is unchanged; no navigation back should occur
browser_state.navigate_to_url.assert_not_called()
+
+
+async def test_handle_action_prefers_observed_file_over_download_event_copy() -> None:
+ """When the active run directory receives the file normally, the Playwright
+ download event should only act as a signal and should not create a duplicate."""
+ now = datetime.now(UTC)
+ organization = make_organization(now)
+ task = make_task(
+ now,
+ organization,
+ workflow_run_id="wr-1",
+ browser_session_id=None,
+ )
+ step = make_step(now, task, step_id="step-1", status=StepStatus.created, order=0, output=None)
+
+ page = MagicMock()
+ page.url = "https://example.com/download"
+ page.context.browser = None
+ download_callbacks: dict[str, object] = {}
+ page.on.side_effect = lambda event, callback: download_callbacks.__setitem__(event, callback)
+
+ browser_state = MagicMock()
+ browser_state.list_valid_pages = AsyncMock(return_value=[page])
+
+ scraped_page = ScrapedPage(
+ elements=[],
+ element_tree=[],
+ element_tree_trimmed=[],
+ _browser_state=browser_state,
+ _clean_up_func=AsyncMock(return_value=[]),
+ _scrape_exclude=None,
+ )
+
+ action = ClickAction(
+ element_id="download-link",
+ download=True,
+ organization_id=task.organization_id,
+ task_id=task.task_id,
+ step_id=step.step_id,
+ )
+
+ download = MagicMock()
+ download.suggested_filename = "report.pdf"
+ download.save_as = AsyncMock()
+
+ with tempfile.TemporaryDirectory() as temp_root:
+ primary_dir = os.path.join(temp_root, "pbs-1")
+ os.makedirs(primary_dir)
+
+ async def mock_inner_handle_action(*args, **kwargs) -> list[ActionSuccess]:
+ download_callbacks["download"](download)
+ with open(os.path.join(primary_dir, "report.pdf"), "w") as f:
+ f.write("dummy")
+ return [ActionSuccess()]
+
+ mock_app = MagicMock()
+ mock_app.BROWSER_MANAGER.get_for_task.return_value = browser_state
+ mock_app.DATABASE.workflow_params.create_action = AsyncMock(return_value=action)
+ mock_app.STORAGE = MagicMock()
+ wait_for_downloads = AsyncMock()
+
+ with (
+ patch.object(ActionHandler, "_handle_action", side_effect=mock_inner_handle_action),
+ patch("skyvern.webeye.actions.handler.get_download_dir", return_value=primary_dir),
+ patch(
+ "skyvern.webeye.actions.handler.skyvern_context.current",
+ return_value=MagicMock(run_id="pbs-1"),
+ ),
+ patch(
+ "skyvern.webeye.actions.handler.check_downloading_files_and_wait_for_download_to_complete",
+ new=wait_for_downloads,
+ ),
+ patch("skyvern.webeye.actions.handler.app", mock_app),
+ ):
+ results = await ActionHandler.handle_action(
+ scraped_page=scraped_page,
+ task=task,
+ step=step,
+ page=page,
+ action=action,
+ )
+
+ assert results[-1].download_triggered is True
+ assert results[-1].downloaded_files == ["report.pdf"]
+ assert action.download_triggered is True
+ assert action.downloaded_files == results[-1].downloaded_files
+ assert wait_for_downloads.await_count == 1
+ download.save_as.assert_not_awaited()
+ page.remove_listener.assert_called_once_with("download", download_callbacks["download"])
+
+
+async def test_handle_action_copies_download_event_when_no_observed_file_appears() -> None:
+ """A browser launched before a task/run id may still emit downloads in its
+ original directory; after a grace period, copy the event into the active run directory."""
+ now = datetime.now(UTC)
+ organization = make_organization(now)
+ task = make_task(
+ now,
+ organization,
+ workflow_run_id="wr-1",
+ browser_session_id=None,
+ )
+ step = make_step(now, task, step_id="step-1", status=StepStatus.created, order=0, output=None)
+
+ page = MagicMock()
+ page.url = "https://example.com/download"
+ page.context.browser = None
+ download_callbacks: dict[str, object] = {}
+ page.on.side_effect = lambda event, callback: download_callbacks.__setitem__(event, callback)
+
+ browser_state = MagicMock()
+ browser_state.list_valid_pages = AsyncMock(return_value=[page])
+
+ scraped_page = ScrapedPage(
+ elements=[],
+ element_tree=[],
+ element_tree_trimmed=[],
+ _browser_state=browser_state,
+ _clean_up_func=AsyncMock(return_value=[]),
+ _scrape_exclude=None,
+ )
+
+ action = ClickAction(
+ element_id="download-link",
+ download=True,
+ organization_id=task.organization_id,
+ task_id=task.task_id,
+ step_id=step.step_id,
+ )
+
+ download = MagicMock()
+ download.suggested_filename = "report.pdf"
+
+ async def save_download(target_path: str | os.PathLike[str]) -> None:
+ with open(target_path, "w") as f:
+ f.write("dummy")
+
+ download.save_as = AsyncMock(side_effect=save_download)
+
+ async def mock_inner_handle_action(*args, **kwargs) -> list[ActionSuccess]:
+ download_callbacks["download"](download)
+ return [ActionSuccess()]
+
+ with tempfile.TemporaryDirectory() as temp_root:
+ primary_dir = os.path.join(temp_root, "pbs-1")
+ os.makedirs(primary_dir)
+
+ mock_app = MagicMock()
+ mock_app.BROWSER_MANAGER.get_for_task.return_value = browser_state
+ mock_app.DATABASE.workflow_params.create_action = AsyncMock(return_value=action)
+ mock_app.STORAGE = MagicMock()
+ wait_for_downloads = AsyncMock()
+
+ with (
+ patch.object(ActionHandler, "_handle_action", side_effect=mock_inner_handle_action),
+ patch("skyvern.webeye.actions.handler.get_download_dir", return_value=primary_dir),
+ patch(
+ "skyvern.webeye.actions.handler.skyvern_context.current",
+ return_value=MagicMock(run_id="pbs-1"),
+ ),
+ patch(
+ "skyvern.webeye.actions.handler.check_downloading_files_and_wait_for_download_to_complete",
+ new=wait_for_downloads,
+ ),
+ patch("skyvern.webeye.actions.handler.app", mock_app),
+ patch("skyvern.webeye.actions.handler.DOWNLOAD_EVENT_ACTIVE_DIR_GRACE_SECONDS", 0),
+ ):
+ results = await ActionHandler.handle_action(
+ scraped_page=scraped_page,
+ task=task,
+ step=step,
+ page=page,
+ action=action,
+ )
+
+ assert results[-1].download_triggered is True
+ assert len(results[-1].downloaded_files) == 1
+ assert results[-1].downloaded_files[0].endswith("-report.pdf")
+ assert action.download_triggered is True
+ assert action.downloaded_files == results[-1].downloaded_files
+ assert wait_for_downloads.await_count == 1
+ download.save_as.assert_awaited_once()
+ saved_path = download.save_as.await_args.args[0]
+ assert os.path.dirname(saved_path) == primary_dir
+ page.remove_listener.assert_called_once_with("download", download_callbacks["download"])
+
+
+async def test_handle_action_ignores_empty_download_event_fallback_file() -> None:
+ """An empty event fallback artifact should not be reported as a downloaded file."""
+ now = datetime.now(UTC)
+ organization = make_organization(now)
+ task = make_task(
+ now,
+ organization,
+ workflow_run_id="wr-1",
+ browser_session_id=None,
+ download_timeout=0.01,
+ )
+ step = make_step(now, task, step_id="step-1", status=StepStatus.created, order=0, output=None)
+
+ page = MagicMock()
+ page.url = "https://example.com/download"
+ page.context.browser = None
+ download_callbacks: dict[str, object] = {}
+ page.on.side_effect = lambda event, callback: download_callbacks.__setitem__(event, callback)
+
+ browser_state = MagicMock()
+ browser_state.list_valid_pages = AsyncMock(return_value=[page])
+
+ scraped_page = ScrapedPage(
+ elements=[],
+ element_tree=[],
+ element_tree_trimmed=[],
+ _browser_state=browser_state,
+ _clean_up_func=AsyncMock(return_value=[]),
+ _scrape_exclude=None,
+ )
+
+ action = ClickAction(
+ element_id="download-link",
+ download=True,
+ organization_id=task.organization_id,
+ task_id=task.task_id,
+ step_id=step.step_id,
+ )
+
+ download = MagicMock()
+ download.suggested_filename = "report.pdf"
+
+ async def save_empty_download(target_path: str | os.PathLike[str]) -> None:
+ open(target_path, "w").close()
+
+ download.save_as = AsyncMock(side_effect=save_empty_download)
+
+ async def mock_inner_handle_action(*args, **kwargs) -> list[ActionSuccess]:
+ download_callbacks["download"](download)
+ return [ActionSuccess()]
+
+ with tempfile.TemporaryDirectory() as temp_root:
+ primary_dir = os.path.join(temp_root, "pbs-1")
+ os.makedirs(primary_dir)
+
+ mock_app = MagicMock()
+ mock_app.BROWSER_MANAGER.get_for_task.return_value = browser_state
+ mock_app.DATABASE.workflow_params.create_action = AsyncMock(return_value=action)
+ mock_app.STORAGE = MagicMock()
+ wait_for_downloads = AsyncMock()
+
+ with (
+ patch.object(ActionHandler, "_handle_action", side_effect=mock_inner_handle_action),
+ patch("skyvern.webeye.actions.handler.get_download_dir", return_value=primary_dir),
+ patch(
+ "skyvern.webeye.actions.handler.skyvern_context.current",
+ return_value=MagicMock(run_id="pbs-1"),
+ ),
+ patch(
+ "skyvern.webeye.actions.handler.check_downloading_files_and_wait_for_download_to_complete",
+ new=wait_for_downloads,
+ ),
+ patch("skyvern.webeye.actions.handler.app", mock_app),
+ patch("skyvern.webeye.actions.handler.DOWNLOAD_EVENT_ACTIVE_DIR_GRACE_SECONDS", 0),
+ ):
+ results = await ActionHandler.handle_action(
+ scraped_page=scraped_page,
+ task=task,
+ step=step,
+ page=page,
+ action=action,
+ )
+
+ remaining_files = os.listdir(primary_dir)
+
+ assert results[-1].download_triggered is True
+ assert results[-1].downloaded_files is None
+ assert action.download_triggered is True
+ assert action.downloaded_files is None
+ assert remaining_files == []
+ assert wait_for_downloads.await_count == 1
+ download.save_as.assert_awaited_once()
+ page.remove_listener.assert_called_once_with("download", download_callbacks["download"])
+
+
+async def test_handle_action_removes_download_listener_when_inner_action_raises() -> None:
+ now = datetime.now(UTC)
+ organization = make_organization(now)
+ task = make_task(
+ now,
+ organization,
+ workflow_run_id="wr-1",
+ browser_session_id=None,
+ )
+ step = make_step(now, task, step_id="step-1", status=StepStatus.created, order=0, output=None)
+
+ page = MagicMock()
+ page.url = "https://example.com/download"
+ download_callbacks: dict[str, object] = {}
+ page.on.side_effect = lambda event, callback: download_callbacks.__setitem__(event, callback)
+
+ browser_state = MagicMock()
+ browser_state.list_valid_pages = AsyncMock(return_value=[page])
+
+ scraped_page = ScrapedPage(
+ elements=[],
+ element_tree=[],
+ element_tree_trimmed=[],
+ _browser_state=browser_state,
+ _clean_up_func=AsyncMock(return_value=[]),
+ _scrape_exclude=None,
+ )
+
+ action = ClickAction(
+ element_id="download-link",
+ download=True,
+ organization_id=task.organization_id,
+ task_id=task.task_id,
+ step_id=step.step_id,
+ )
+
+ with tempfile.TemporaryDirectory() as temp_root:
+ primary_dir = os.path.join(temp_root, "pbs-1")
+ os.makedirs(primary_dir)
+
+ mock_app = MagicMock()
+ mock_app.BROWSER_MANAGER.get_for_task.return_value = browser_state
+ mock_app.DATABASE.workflow_params.create_action = AsyncMock(return_value=action)
+ mock_app.STORAGE = MagicMock()
+
+ with (
+ patch.object(ActionHandler, "_handle_action", side_effect=RuntimeError("boom")),
+ patch("skyvern.webeye.actions.handler.get_download_dir", return_value=primary_dir),
+ patch(
+ "skyvern.webeye.actions.handler.skyvern_context.current",
+ return_value=MagicMock(run_id="pbs-1"),
+ ),
+ patch("skyvern.webeye.actions.handler.app", mock_app),
+ ):
+ with pytest.raises(RuntimeError, match="boom"):
+ await ActionHandler.handle_action(
+ scraped_page=scraped_page,
+ task=task,
+ step=step,
+ page=page,
+ action=action,
+ )
+
+ page.remove_listener.assert_called_once_with("download", download_callbacks["download"])