Automate browser based workflows with AI
Python aiapiautomationbrowserbrowser-automationcomputergptllmplaywrightpowerautomatepuppeteerpythonrpaseleniumvisionworkflow
chore: enable ruff B009/B010 and add Any typing guideline (#6253)
Andrew Neilson5217498b5607
diff --git a/pyproject.toml b/pyproject.tomlindex f9d01a90e..08bd9230f 100644--- a/pyproject.toml+++ b/pyproject.toml@@ -313,6 +313,7 @@ line-length = 120target-version = "py311"[tool.ruff.lint]+extend-select = ["B009", "B010"] # flake8-bugbear: no getattr/setattr with a constant attribute name[tool.isort]profile = "black"diff --git a/skyvern/cli/masked_prompt.py b/skyvern/cli/masked_prompt.pyindex b25dddca2..a6fdcc0ea 100644--- a/skyvern/cli/masked_prompt.py+++ b/skyvern/cli/masked_prompt.py@@ -136,7 +136,7 @@ def _read_masked_tty_unix(output: TextIO, *, mask: str) -> str:def _read_masked_tty_windows(output: TextIO, *, mask: str) -> str:import msvcrt- get_wide_char: Callable[[], str] = getattr(msvcrt, "getwch")+ get_wide_char: Callable[[], str] = msvcrt.getwch # type: ignore[attr-defined]def read_char() -> str:char = get_wide_char()diff --git a/skyvern/forge/sdk/copilot/tools.py b/skyvern/forge/sdk/copilot/tools.pyindex c6a84e4d8..e4e725ce6 100644--- a/skyvern/forge/sdk/copilot/tools.py+++ b/skyvern/forge/sdk/copilot/tools.py@@ -645,7 +645,7 @@ def _record_per_tool_budget_problem_blocks_from_results(copilot_ctx: Any, resultlabel = block.get("label")if isinstance(label, str) and label:labels.add(label)- setattr(copilot_ctx, "per_tool_budget_problem_block_labels", sorted(labels))+ copilot_ctx.per_tool_budget_problem_block_labels = sorted(labels)def _navigation_labels_in_workflow(workflow: Any) -> set[str]:@@ -669,7 +669,7 @@ def _clear_resolved_per_tool_budget_problem_labels(copilot_ctx: Any, workflow: Aif not problem_labels:returnremaining = sorted(problem_labels & _navigation_labels_in_workflow(workflow))- setattr(copilot_ctx, "per_tool_budget_problem_block_labels", remaining)+ copilot_ctx.per_tool_budget_problem_block_labels = remainingdef _requested_block_label_set(arguments: dict[str, Any] | None) -> set[str] | None:diff --git a/skyvern/schemas/llm.py b/skyvern/schemas/llm.pyindex e3a01cd24..73a3732da 100644--- a/skyvern/schemas/llm.py+++ b/skyvern/schemas/llm.py@@ -32,8 +32,8 @@ def _resolve_generation_defaults(config: object, max_tokens: object, temperatureobject.__setattr__(config, "temperature", settings.LLM_CONFIG_TEMPERATURE)_assert_settings_defaults_resolved(- getattr(config, "max_tokens"),- getattr(config, "temperature"),+ config.max_tokens, # type: ignore[attr-defined]+ config.temperature, # type: ignore[attr-defined])diff --git a/skyvern/services/script_reviewer_v3/skills/validate.py b/skyvern/services/script_reviewer_v3/skills/validate.pyindex 8e1164b12..f76f20f6f 100644--- a/skyvern/services/script_reviewer_v3/skills/validate.py+++ b/skyvern/services/script_reviewer_v3/skills/validate.py@@ -157,7 +157,7 @@ async def _resolve_run_parameter_values(context: Any) -> dict[str, str]:"""workflow_run_id = Noneif hasattr(context, "workflow_run_id"):- workflow_run_id = getattr(context, "workflow_run_id")+ workflow_run_id = context.workflow_run_idelif hasattr(context, "context") and hasattr(context.context, "workflow_run_id"):workflow_run_id = context.context.workflow_run_idif not workflow_run_id:@@ -185,9 +185,9 @@ async def _resolve_parameter_keys(context: Any) -> list[str]:if obj is None:continueif not org_id and hasattr(obj, "organization_id"):- org_id = getattr(obj, "organization_id")+ org_id = obj.organization_idif not wpid and hasattr(obj, "workflow_permanent_id"):- wpid = getattr(obj, "workflow_permanent_id")+ wpid = obj.workflow_permanent_idif org_id and wpid:breakif not (org_id and wpid):diff --git a/tests/unit/embedded/test_sqlite_server_mode.py b/tests/unit/embedded/test_sqlite_server_mode.pyindex 09a602c41..0d11b23d3 100644--- a/tests/unit/embedded/test_sqlite_server_mode.py+++ b/tests/unit/embedded/test_sqlite_server_mode.py@@ -296,7 +296,7 @@ async def test_local_allows_env_only_persistent_mode(monkeypatch: pytest.MonkeyPtry:assert factory.call_args.kwargs["use_in_memory_db"] is False- assert getattr(skyvern, "_embedded_client") is embedded_client+ assert skyvern._embedded_client is embedded_clientfinally:await skyvern.aclose()@@ -323,7 +323,7 @@ async def test_local_persistent_mode_accepts_settings_without_dotenv(try:assert factory.call_args.kwargs["use_in_memory_db"] is Falseassert factory.call_args.kwargs["settings_overrides"] == overrides- assert getattr(skyvern, "_embedded_client") is embedded_client+ assert skyvern._embedded_client is embedded_clientfinally:await skyvern.aclose()