Automate browser based workflows with AI
Python aiapiautomationbrowserbrowser-automationcomputergptllmplaywrightpowerautomatepuppeteerpythonrpaseleniumvisionworkflow
fix: Use SettingsManager for model-to-LLM-key mapping so cloud fallback overrides apply (#4839)
pedrohsdb526f11dd5529
diff --git a/skyvern/forge/sdk/routes/agent_protocol.py b/skyvern/forge/sdk/routes/agent_protocol.pyindex cdb1f6ff3..6c10d7876 100644--- a/skyvern/forge/sdk/routes/agent_protocol.py+++ b/skyvern/forge/sdk/routes/agent_protocol.py@@ -87,6 +87,7 @@ from skyvern.forge.sdk.schemas.tasks import ()from skyvern.forge.sdk.schemas.workflow_runs import WorkflowRunTimelinefrom skyvern.forge.sdk.services import org_auth_service+from skyvern.forge.sdk.settings_manager import SettingsManagerfrom skyvern.forge.sdk.workflow.exceptions import (FailedToCreateWorkflow,FailedToUpdateWorkflow,@@ -1699,7 +1700,7 @@ async def models() -> ModelsResponse:"""Get a list of available models."""- mapping = settings.get_model_name_to_llm_key()+ mapping = SettingsManager.get_settings().get_model_name_to_llm_key()just_labels = {k: v["label"] for k, v in mapping.items() if "anthropic" not in k.lower()}return ModelsResponse(models=just_labels)diff --git a/skyvern/forge/sdk/schemas/task_v2.py b/skyvern/forge/sdk/schemas/task_v2.pyindex 64f642f9b..4c35166fe 100644--- a/skyvern/forge/sdk/schemas/task_v2.py+++ b/skyvern/forge/sdk/schemas/task_v2.py@@ -5,7 +5,7 @@ from typing import Anyfrom pydantic import BaseModel, ConfigDict, Field, field_validator-from skyvern.config import settings+from skyvern.forge.sdk.settings_manager import SettingsManagerfrom skyvern.schemas.runs import GeoTarget, ProxyLocation, ProxyLocationInputfrom skyvern.utils.url_validators import validate_url@@ -95,7 +95,7 @@ class TaskV2(BaseModel):if self.model:model_name = self.model.get("model_name")if model_name:- mapping = settings.get_model_name_to_llm_key()+ mapping = SettingsManager.get_settings().get_model_name_to_llm_key()llm_key = mapping.get(model_name, {}).get("llm_key")if llm_key:return llm_keydiff --git a/skyvern/forge/sdk/schemas/tasks.py b/skyvern/forge/sdk/schemas/tasks.pyindex 42ec74e12..139891a49 100644--- a/skyvern/forge/sdk/schemas/tasks.py+++ b/skyvern/forge/sdk/schemas/tasks.py@@ -8,7 +8,6 @@ from fastapi import statusfrom pydantic import BaseModel, Field, field_validator, model_validatorfrom typing_extensions import Self-from skyvern.config import settingsfrom skyvern.exceptions import (InvalidTaskStatusTransition,SkyvernHTTPException,@@ -17,6 +16,7 @@ from skyvern.exceptions import ()from skyvern.forge.sdk.db.enums import TaskTypefrom skyvern.forge.sdk.schemas.files import FileInfo+from skyvern.forge.sdk.settings_manager import SettingsManagerfrom skyvern.schemas.docs.doc_strings import PROXY_LOCATION_DOC_STRINGfrom skyvern.schemas.runs import ProxyLocationInputfrom skyvern.utils.url_validators import validate_url@@ -303,7 +303,7 @@ class Task(TaskBase):if self.model:model_name = self.model.get("model_name")if model_name:- mapping = settings.get_model_name_to_llm_key()+ mapping = SettingsManager.get_settings().get_model_name_to_llm_key()return mapping.get(model_name, {}).get("llm_key")return Nonediff --git a/skyvern/forge/sdk/workflow/models/block.py b/skyvern/forge/sdk/workflow/models/block.pyindex 881b4fd18..87f5df707 100644--- a/skyvern/forge/sdk/workflow/models/block.py+++ b/skyvern/forge/sdk/workflow/models/block.py@@ -76,6 +76,7 @@ from skyvern.forge.sdk.schemas.task_v2 import TaskV2Statusfrom skyvern.forge.sdk.schemas.tasks import Task, TaskOutput, TaskStatusfrom skyvern.forge.sdk.services.bitwarden import BitwardenConstantsfrom skyvern.forge.sdk.services.credentials import AzureVaultConstants, OnePasswordConstants+from skyvern.forge.sdk.settings_manager import SettingsManagerfrom skyvern.forge.sdk.trace import tracedfrom skyvern.forge.sdk.utils.pdf_parser import extract_pdf_file, validate_pdf_filefrom skyvern.forge.sdk.utils.sanitization import sanitize_postgres_text@@ -182,7 +183,7 @@ class Block(BaseModel, abc.ABC):if self.model:model_name = self.model.get("model_name")if model_name:- mapping = settings.get_model_name_to_llm_key()+ mapping = SettingsManager.get_settings().get_model_name_to_llm_key()return mapping.get(model_name, {}).get("llm_key")return Nonediff --git a/tests/unit/test_text_prompt_block.py b/tests/unit/test_text_prompt_block.pyindex 6e83afa78..2f8026951 100644--- a/tests/unit/test_text_prompt_block.py+++ b/tests/unit/test_text_prompt_block.py@@ -4,7 +4,9 @@ from unittest.mock import AsyncMockimport pytest+from skyvern.config import settings as base_settingsfrom skyvern.forge.prompts import prompt_engine+from skyvern.forge.sdk.settings_manager import SettingsManagerfrom skyvern.forge.sdk.workflow.models.block import TextPromptBlockfrom skyvern.forge.sdk.workflow.models.parameter import OutputParameter, ParameterType@@ -20,6 +22,8 @@ block_module = sys.modules["skyvern.forge.sdk.workflow.models.block"]],)async def test_text_prompt_block_uses_selected_model(monkeypatch, model_name, expected_llm_key):+ # Reset SettingsManager to base settings so cloud overrides from earlier tests don't leak+ monkeypatch.setattr(SettingsManager, "_SettingsManager__instance", base_settings)now = datetime.now(timezone.utc)output_parameter = OutputParameter(parameter_type=ParameterType.OUTPUT,