Skip to content

Automate browser based workflows with AI

feat(SKY-12251): expand skyvern.platform tagging via cloud-only detector (cache key unchanged) (#7296)

Aaron Perez52fc6f969afd
diff --git a/skyvern/forge/agent_functions.py b/skyvern/forge/agent_functions.py
index 655eef175..094a8c023 100644
--- a/skyvern/forge/agent_functions.py
+++ b/skyvern/forge/agent_functions.py
@@ -1755,6 +1755,10 @@ class AgentFunction:
"""
return None
+ def detect_platform_for_tagging(self, url_or_domain: str | None) -> str | None:
+ """Detect a cloud platform for run tagging. OSS intentionally does not tag."""
+ return None
+
def match_field_to_canonical_category(self, field_label: str) -> Any:
"""Match a form field label to a canonical category for zero-LLM matching.
diff --git a/skyvern/forge/sdk/workflow/service.py b/skyvern/forge/sdk/workflow/service.py
index 9adaf141c..81dfdec47 100644
--- a/skyvern/forge/sdk/workflow/service.py
+++ b/skyvern/forge/sdk/workflow/service.py
@@ -660,7 +660,7 @@ class WorkflowService:
parameters: dict[str, Any],
) -> None:
try:
- platform = workflow_script_service.detect_workflow_platform(workflow, parameters)
+ platform = workflow_script_service.detect_workflow_platform_for_tagging(workflow, parameters)
if not platform:
return
await app.DATABASE.tags.apply_system_run_tag_changes(
diff --git a/skyvern/services/workflow_script_service.py b/skyvern/services/workflow_script_service.py
index 19f4ad217..1c93eab12 100644
--- a/skyvern/services/workflow_script_service.py
+++ b/skyvern/services/workflow_script_service.py
@@ -298,6 +298,17 @@ def detect_workflow_platform(
return app.AGENT_FUNCTION.detect_ats_platform(domain)
+def detect_workflow_platform_for_tagging(
+ workflow: Workflow,
+ parameters: dict[str, Any],
+) -> str | None:
+ """Detect a cloud platform for run tagging without changing cache-key behavior."""
+ domain = _extract_first_block_domain(workflow, parameters)
+ if not domain:
+ return None
+ return app.AGENT_FUNCTION.detect_platform_for_tagging(domain)
+
+
def resolve_cache_key_value(
workflow: Workflow,
parameters: dict[str, Any],
diff --git a/tests/unit/test_workflow_run_parameter_batching.py b/tests/unit/test_workflow_run_parameter_batching.py
index db877c6f2..35576e856 100644
--- a/tests/unit/test_workflow_run_parameter_batching.py
+++ b/tests/unit/test_workflow_run_parameter_batching.py
@@ -182,7 +182,7 @@ async def test_setup_workflow_run_writes_detected_platform_as_system_run_tag() -
with (
patch("skyvern.forge.sdk.workflow.service.app") as mock_app,
patch(
- "skyvern.forge.sdk.workflow.service.workflow_script_service.detect_workflow_platform",
+ "skyvern.forge.sdk.workflow.service.workflow_script_service.detect_workflow_platform_for_tagging",
return_value="known_platform",
) as detect_platform,
):
@@ -214,7 +214,7 @@ async def test_setup_workflow_run_skips_platform_tag_when_detection_has_no_verdi
with (
patch("skyvern.forge.sdk.workflow.service.app") as mock_app,
patch(
- "skyvern.forge.sdk.workflow.service.workflow_script_service.detect_workflow_platform",
+ "skyvern.forge.sdk.workflow.service.workflow_script_service.detect_workflow_platform_for_tagging",
return_value=None,
),
):
@@ -239,7 +239,7 @@ async def test_setup_workflow_run_continues_when_platform_tag_write_fails() -> N
with (
patch("skyvern.forge.sdk.workflow.service.app") as mock_app,
patch(
- "skyvern.forge.sdk.workflow.service.workflow_script_service.detect_workflow_platform",
+ "skyvern.forge.sdk.workflow.service.workflow_script_service.detect_workflow_platform_for_tagging",
return_value="known_platform",
),
):
diff --git a/tests/unit/test_workflow_script_cache_key_resolution.py b/tests/unit/test_workflow_script_cache_key_resolution.py
index c3583d0fe..70391c7dc 100644
--- a/tests/unit/test_workflow_script_cache_key_resolution.py
+++ b/tests/unit/test_workflow_script_cache_key_resolution.py
@@ -4,11 +4,13 @@ from types import SimpleNamespace
import pytest
from jinja2 import UndefinedError
+from skyvern.forge.agent_functions import AgentFunction
from skyvern.forge.sdk.workflow.models.workflow import Workflow, is_adaptive_caching_from_effective_state
from skyvern.services import workflow_script_service
from skyvern.services.workflow_script_service import (
CacheKeyResolutionError,
detect_workflow_platform,
+ detect_workflow_platform_for_tagging,
resolve_cache_key_value,
)
@@ -54,7 +56,10 @@ def _stub_platform_detection(monkeypatch: pytest.MonkeyPatch) -> None:
monkeypatch.setattr(
workflow_script_service.app,
"AGENT_FUNCTION",
- SimpleNamespace(detect_ats_platform=lambda domain: "known_platform" if domain == "ats.example.com" else None),
+ SimpleNamespace(
+ detect_ats_platform=lambda domain: "known_platform" if domain == "ats.example.com" else None,
+ detect_platform_for_tagging=lambda domain: "tagging_platform" if domain == "tagging.example.com" else None,
+ ),
)
@@ -82,6 +87,22 @@ def test_detect_workflow_platform_returns_none_when_detector_has_no_verdict() ->
assert detect_workflow_platform(workflow, {}) is None
+def test_cache_key_ignores_tagging_only_platforms() -> None:
+ workflow = _workflow(cache_key="default", url="https://tagging.example.com/jobs/1")
+
+ assert resolve_cache_key_value(workflow, {}, adaptive_caching=False) == "default:tagging.example.com"
+
+
+def test_tagging_detector_uses_tagging_only_platforms() -> None:
+ workflow = _workflow(cache_key="default", url="https://tagging.example.com/jobs/1")
+
+ assert detect_workflow_platform_for_tagging(workflow, {}) == "tagging_platform"
+
+
+def test_oss_platform_tagging_is_noop() -> None:
+ assert AgentFunction().detect_platform_for_tagging("https://tagging.example.com/jobs/1") is None
+
+
def test_resolve_appends_v2_when_adaptive_caching_enabled() -> None:
workflow = _workflow(cache_key="custom", url=None)