Automate browser based workflows with AI
Python aiapiautomationbrowserbrowser-automationcomputergptllmplaywrightpowerautomatepuppeteerpythonrpaseleniumvisionworkflow
feat(SKY-11553): allow-by-default Playwright facade for secure CodeBlock runner (#7302)
Shuchang Zheng61d0bb15b523
diff --git a/skyvern/forge/sdk/workflow/code_block_safety.py b/skyvern/forge/sdk/workflow/code_block_safety.pyindex 975671afb..5209dc8f4 100644--- a/skyvern/forge/sdk/workflow/code_block_safety.py+++ b/skyvern/forge/sdk/workflow/code_block_safety.py@@ -80,7 +80,7 @@ def is_safe_code("""Reject imports, private members, and known escape hatches."""tree = ast.parse(textwrap.dedent(code))for node in ast.walk(tree):- if hasattr(node, "attr") and str(node.attr).startswith("__"):+ if hasattr(node, "attr") and str(node.attr).startswith("_"):raise error_factory("Not allowed to access private methods or attributes")if isinstance(node, ast.Name) and node.id.startswith("__"):raise error_factory("Not allowed to access private methods or attributes")diff --git a/skyvern/forge/sdk/workflow/models/code_block_recorder.py b/skyvern/forge/sdk/workflow/models/code_block_recorder.pyindex ae5509e01..1330b871d 100644--- a/skyvern/forge/sdk/workflow/models/code_block_recorder.py+++ b/skyvern/forge/sdk/workflow/models/code_block_recorder.py@@ -1,5 +1,6 @@from __future__ import annotations+import inspectimport sysimport timefrom os import PathLike, fspath@@ -50,6 +51,7 @@ _LOCATOR_FACTORY_METHODS = frozenset("filter",})+_RECORDABLE_HANDLE_TYPE_NAMES = frozenset({"ElementHandle", "FrameLocator", "Locator"})# SkyvernPage high-level API (page.extract / page.complete / ...). These are not raw# Playwright calls, so they fall through the maps above and used to execute unrecorded —# a navigate+extract block then rendered as only repeated "Goto URL" on the timeline.@@ -308,12 +310,37 @@ class _Recorder:return result+def _wrap_recording_result(value: Any, recorder: _Recorder, selector: str | None) -> Any:+ if isinstance(value, list):+ return [_wrap_recording_result(item, recorder, selector) for item in value]+ if type(value).__module__.startswith("playwright.") and type(value).__name__ in _RECORDABLE_HANDLE_TYPE_NAMES:+ return RecordingLocator(value, recorder, selector)+ return value+++def _wrap_call_result(value: Any, recorder: _Recorder, selector: str | None) -> Any:+ if inspect.isawaitable(value):++ async def resolve() -> Any:+ return _wrap_recording_result(await value, recorder, selector)++ return resolve()+ return _wrap_recording_result(value, recorder, selector)++class RecordingLocator:+ # Private worker-side hooks consumed by PlaywrightPageOperationBroker. The sandbox only+ # receives opaque markers, never this proxy instance.+ _skyvern_brokerable_handle = True+def __init__(self, locator: Any, recorder: _Recorder, selector: str | None) -> None:self.__locator = locatorself.__recorder = recorderself.__selector = selector+ def _skyvern_page_operation_argument(self) -> Any:+ return self.__locator+def locator(self, selector: str, **kwargs: Any) -> RecordingLocator:return RecordingLocator(self.__locator.locator(selector, **kwargs), self.__recorder, selector)@@ -333,8 +360,14 @@ class RecordingLocator:return factoryaction_type = _LOCATOR_ACTION_MAP.get(name)- if action_type is None or not callable(attr):+ if not callable(attr):return attr+ if action_type is None:++ def forwarded(*args: Any, **kwargs: Any) -> Any:+ return _wrap_call_result(attr(*args, **kwargs), self.__recorder, self.__selector)++ return forwardedasync def recorded(*args: Any, **kwargs: Any) -> Any:return await self.__recorder.record(@@ -398,8 +431,14 @@ class RecordingPage:# Record direct page-level interactions (page.click/fill/press/...) and the high-level# SkyvernPage API (page.extract/complete/...) with the same redaction as the locator path.action_type = _LOCATOR_ACTION_MAP.get(name) or _PAGE_ACTION_MAP.get(name) or _HIGH_LEVEL_ACTION_MAP.get(name)- if action_type is None or not callable(attr):+ if not callable(attr):return attr+ if action_type is None:++ def forwarded(*args: Any, **kwargs: Any) -> Any:+ return _wrap_call_result(attr(*args, **kwargs), self.__recorder, _factory_selector(name, args))++ return forwardedrecord_prompt = name in _PROMPT_METHODSasync def recorded(*args: Any, **kwargs: Any) -> Any:diff --git a/tests/unit/test_code_block_sandbox.py b/tests/unit/test_code_block_sandbox.pyindex 1bc2a4fea..6d0d082fc 100644--- a/tests/unit/test_code_block_sandbox.py+++ b/tests/unit/test_code_block_sandbox.py@@ -44,6 +44,10 @@ class TestIsSafeCodeRejectsImports:class TestIsSafeCodeRejectsDunderAccess:+ def test_single_underscore_attribute(self) -> None:+ with pytest.raises(InsecureCodeDetected, match="private"):+ CodeBlock.is_safe_code("page._session._nonce")+def test_dunder_class(self) -> None:with pytest.raises(InsecureCodeDetected, match="private"):CodeBlock.is_safe_code("x.__class__")