Automate browser based workflows with AI
Python aiapiautomationbrowserbrowser-automationcomputergptllmplaywrightpowerautomatepuppeteerpythonrpaseleniumvisionworkflow
fix(frontend): restore GitHub star count in header (SKY-9868) (#6042)
Celal Zamanoğlu64b7aad8d47a
diff --git a/skyvern-frontend/src/hooks/useGithubStarCount.ts b/skyvern-frontend/src/hooks/useGithubStarCount.tsnew file mode 100644index 000000000..c294da43b--- /dev/null+++ b/skyvern-frontend/src/hooks/useGithubStarCount.ts@@ -0,0 +1,39 @@+import { useQuery } from "@tanstack/react-query";++const GITHUB_REPO_API_URL = "https://api.github.com/repos/skyvern-ai/skyvern";++type GithubRepoResponse = {+ stargazers_count: number;+};++type Options = {+ enabled?: boolean;+};++const starCountFormatter = new Intl.NumberFormat("en-US", {+ notation: "compact",+ maximumFractionDigits: 1,+});++function useGithubStarCount({ enabled = true }: Options = {}) {+ return useQuery<number>({+ queryKey: ["githubStarCount", "skyvern-ai/skyvern"],+ queryFn: async () => {+ const response = await fetch(GITHUB_REPO_API_URL, {+ headers: { Accept: "application/vnd.github+json" },+ });+ if (!response.ok) {+ throw new Error(`GitHub API ${response.status}`);+ }+ const data: GithubRepoResponse = await response.json();+ return data.stargazers_count;+ },+ enabled,+ staleTime: 60 * 60 * 1000,+ gcTime: 24 * 60 * 60 * 1000,+ retry: false,+ refetchOnWindowFocus: false,+ });+}++export { starCountFormatter, useGithubStarCount };diff --git a/skyvern-frontend/src/routes/root/Header.tsx b/skyvern-frontend/src/routes/root/Header.tsxindex 0d1b71b73..157719e50 100644--- a/skyvern-frontend/src/routes/root/Header.tsx+++ b/skyvern-frontend/src/routes/root/Header.tsx@@ -5,6 +5,10 @@ import {} from "@radix-ui/react-icons";import { Link, useMatch, useSearchParams } from "react-router-dom";import { NavigationHamburgerMenu } from "./NavigationHamburgerMenu";+import {+ starCountFormatter,+ useGithubStarCount,+} from "@/hooks/useGithubStarCount";function Header() {const [searchParams] = useSearchParams();@@ -15,6 +19,8 @@ function Header() {location.pathname.includes("debug") ||embed === "true";+ const { data: starCount } = useGithubStarCount({ enabled: !match });+if (match) {return null;}@@ -40,6 +46,11 @@ function Header() {><GitHubLogoIcon className="h-7 w-7" /><StarIcon className="h-5 w-5" />+ {typeof starCount === "number" ? (+ <span className="text-sm tabular-nums">+ {starCountFormatter.format(starCount)}+ </span>+ ) : null}</Link></div></div>diff --git a/skyvern/webeye/real_browser_manager.py b/skyvern/webeye/real_browser_manager.pyindex eae11412b..87e77fdd0 100644--- a/skyvern/webeye/real_browser_manager.py+++ b/skyvern/webeye/real_browser_manager.py@@ -116,8 +116,13 @@ class RealBrowserManager(BrowserManager):if browser_state is None:LOG.info("Creating browser state for task", task_id=task.task_id)+ proxy_location = task.proxy_location+ if browser_session_id and task.organization_id:+ session = await app.PERSISTENT_SESSIONS_MANAGER.get_session(browser_session_id, task.organization_id)+ if session and session.proxy_location is not None:+ proxy_location = session.proxy_locationbrowser_state = await self._create_browser_state(- proxy_location=task.proxy_location,+ proxy_location=proxy_location,url=task.url,task_id=task.task_id,workflow_permanent_id=task.workflow_permanent_id,@@ -211,8 +216,15 @@ class RealBrowserManager(BrowserManager):"Creating browser state for workflow run",workflow_run_id=workflow_run.workflow_run_id,)+ proxy_location = workflow_run.proxy_location+ if browser_session_id and workflow_run.organization_id:+ session = await app.PERSISTENT_SESSIONS_MANAGER.get_session(+ browser_session_id, workflow_run.organization_id+ )+ if session and session.proxy_location is not None:+ proxy_location = session.proxy_locationbrowser_state = await self._create_browser_state(- proxy_location=workflow_run.proxy_location,+ proxy_location=proxy_location,url=url,workflow_run_id=workflow_run.workflow_run_id,workflow_permanent_id=workflow_run.workflow_permanent_id,diff --git a/tests/unit/test_real_browser_manager.py b/tests/unit/test_real_browser_manager.pyindex 00c091294..41895b04c 100644--- a/tests/unit/test_real_browser_manager.py+++ b/tests/unit/test_real_browser_manager.py@@ -133,6 +133,146 @@ async def test_non_pbs_workflow_run_inherits_parent_browser() -> None:assert manager.pages["wfr_parent"] is parent_state+def make_task(+ task_id: str,+ organization_id: str = "org_test",+ proxy_location: object = None,+ workflow_run_id: str | None = None,+) -> MagicMock:+ task = MagicMock()+ task.task_id = task_id+ task.organization_id = organization_id+ task.proxy_location = proxy_location+ task.workflow_run_id = workflow_run_id+ task.url = "https://example.com"+ task.workflow_permanent_id = None+ task.extra_http_headers = None+ task.browser_address = None+ return task+++def make_session(proxy_location: object = None) -> MagicMock:+ session = MagicMock()+ session.proxy_location = proxy_location+ return session+++async def test_task_browser_inherits_session_proxy_when_no_browser_state() -> None:+ """When a task has a browser_session_id and no in-memory browser state, the session's proxy_location is used."""+ manager = RealBrowserManager()+ task = make_task("tsk_1", proxy_location="RESIDENTIAL")+ new_browser_state = MagicMock()+ new_browser_state.get_or_create_page = AsyncMock()++ session_proxy = "RESIDENTIAL_DE"+ session = make_session(proxy_location=session_proxy)++ with patch("skyvern.webeye.real_browser_manager.app") as mock_app:+ mock_app.PERSISTENT_SESSIONS_MANAGER.get_browser_state = AsyncMock(return_value=None)+ mock_app.PERSISTENT_SESSIONS_MANAGER.get_session = AsyncMock(return_value=session)+ mock_app.PERSISTENT_SESSIONS_MANAGER.set_browser_state = AsyncMock()++ with patch.object(+ manager, "_create_browser_state", new=AsyncMock(return_value=new_browser_state)+ ) as mock_create:+ await manager.get_or_create_for_task(task=task, browser_session_id="pbs_123")++ mock_create.assert_awaited_once()+ _, kwargs = mock_create.call_args+ assert kwargs["proxy_location"] == session_proxy+++async def test_task_browser_uses_task_proxy_when_session_has_no_proxy() -> None:+ """When the session has no proxy_location, the task's proxy_location is used."""+ manager = RealBrowserManager()+ task_proxy = "RESIDENTIAL_US"+ task = make_task("tsk_2", proxy_location=task_proxy)+ new_browser_state = MagicMock()+ new_browser_state.get_or_create_page = AsyncMock()++ session = make_session(proxy_location=None)++ with patch("skyvern.webeye.real_browser_manager.app") as mock_app:+ mock_app.PERSISTENT_SESSIONS_MANAGER.get_browser_state = AsyncMock(return_value=None)+ mock_app.PERSISTENT_SESSIONS_MANAGER.get_session = AsyncMock(return_value=session)+ mock_app.PERSISTENT_SESSIONS_MANAGER.set_browser_state = AsyncMock()++ with patch.object(+ manager, "_create_browser_state", new=AsyncMock(return_value=new_browser_state)+ ) as mock_create:+ await manager.get_or_create_for_task(task=task, browser_session_id="pbs_123")++ mock_create.assert_awaited_once()+ _, kwargs = mock_create.call_args+ assert kwargs["proxy_location"] == task_proxy+++async def test_workflow_run_browser_inherits_session_proxy_when_no_browser_state() -> None:+ """When a workflow run has a browser_session_id and no in-memory state, the session's proxy is used."""+ manager = RealBrowserManager()+ workflow_run = make_workflow_run("wfr_1")+ workflow_run.proxy_location = "RESIDENTIAL"++ new_browser_state = MagicMock()+ new_browser_state.get_or_create_page = AsyncMock()++ session_proxy = "RESIDENTIAL_FR"+ session = make_session(proxy_location=session_proxy)++ with patch("skyvern.webeye.real_browser_manager.app") as mock_app:+ mock_app.PERSISTENT_SESSIONS_MANAGER.get_browser_state = AsyncMock(return_value=None)+ mock_app.PERSISTENT_SESSIONS_MANAGER.get_session = AsyncMock(return_value=session)+ mock_app.PERSISTENT_SESSIONS_MANAGER.set_browser_state = AsyncMock()++ with patch.object(+ manager, "_create_browser_state", new=AsyncMock(return_value=new_browser_state)+ ) as mock_create:+ await manager.get_or_create_for_workflow_run(+ workflow_run=workflow_run,+ url="https://example.com",+ browser_session_id="pbs_456",+ )++ mock_create.assert_awaited_once()+ _, kwargs = mock_create.call_args+ assert kwargs["proxy_location"] == session_proxy+++async def test_workflow_run_browser_uses_workflow_proxy_when_session_has_no_proxy() -> None:+ """When the session has no proxy_location, the workflow run's proxy_location is used."""+ manager = RealBrowserManager()+ workflow_run = make_workflow_run("wfr_2")+ wf_proxy = "RESIDENTIAL_IE"+ workflow_run.proxy_location = wf_proxy++ new_browser_state = MagicMock()+ new_browser_state.get_or_create_page = AsyncMock()++ session = make_session(proxy_location=None)++ with patch("skyvern.webeye.real_browser_manager.app") as mock_app:+ mock_app.PERSISTENT_SESSIONS_MANAGER.get_browser_state = AsyncMock(return_value=None)+ mock_app.PERSISTENT_SESSIONS_MANAGER.get_session = AsyncMock(return_value=session)+ mock_app.PERSISTENT_SESSIONS_MANAGER.set_browser_state = AsyncMock()++ with patch.object(+ manager, "_create_browser_state", new=AsyncMock(return_value=new_browser_state)+ ) as mock_create:+ await manager.get_or_create_for_workflow_run(+ workflow_run=workflow_run,+ url="https://example.com",+ browser_session_id="pbs_456",+ )++ mock_create.assert_awaited_once()+ _, kwargs = mock_create.call_args+ assert kwargs["proxy_location"] == wf_proxy++def _make_browser_state_with_video(video_path: str) -> MagicMock:video_artifact = MagicMock()video_artifact.video_path = video_path