Skip to content

Automate browser based workflows with AI

fix(SKY-10452): pre-create browser with block URL in script mode for proxy selection (#6228)

LawyZheng66800397d8fc
diff --git a/skyvern/forge/sdk/workflow/service.py b/skyvern/forge/sdk/workflow/service.py
index ff475b20c..8511a12c4 100644
--- a/skyvern/forge/sdk/workflow/service.py
+++ b/skyvern/forge/sdk/workflow/service.py
@@ -378,6 +378,30 @@ def _get_workflow_definition_core_data(workflow_definition: WorkflowDefinition)
return workflow_dict
+async def _precreate_script_browser(
+ block: BlockTypeVar,
+ workflow_run: "WorkflowRun",
+ browser_session_id: str | None,
+) -> None:
+ url = getattr(block, "url", None)
+ if not url:
+ return
+ try:
+ wrc = app.WORKFLOW_CONTEXT_MANAGER.get_workflow_run_context(workflow_run.workflow_run_id)
+ except Exception:
+ LOG.warning("Workflow run context unavailable for browser pre-creation", exc_info=True)
+ return
+ resolved_url = block.format_block_parameter_template_from_workflow_run_context(url, wrc)
+ if not resolved_url or not isinstance(resolved_url, str):
+ return
+ await app.BROWSER_MANAGER.get_or_create_for_workflow_run(
+ workflow_run=workflow_run,
+ url=resolved_url,
+ browser_session_id=browser_session_id,
+ browser_profile_id=workflow_run.browser_profile_id,
+ )
+
+
class WorkflowService:
# Prevent GC of fire-and-forget asyncio tasks (e.g. task_run sync).
_background_tasks: set[asyncio.Task] = set() # noqa: RUF012
@@ -2700,6 +2724,19 @@ class WorkflowService:
block_label=block.label,
exc_info=True,
)
+ try:
+ await _precreate_script_browser(
+ block=block,
+ workflow_run=workflow_run,
+ browser_session_id=browser_session_id,
+ )
+ except Exception:
+ LOG.warning(
+ "Failed to pre-create browser with block URL; script will create lazily",
+ block_label=block.label,
+ exc_info=True,
+ )
+
block_exec_start = time.monotonic()
try:
vars_dict = vars(loaded_script_module) if loaded_script_module else {}
diff --git a/tests/unit/test_script_mode_browser_url.py b/tests/unit/test_script_mode_browser_url.py
new file mode 100644
index 000000000..d8b6f6e28
--- /dev/null
+++ b/tests/unit/test_script_mode_browser_url.py
@@ -0,0 +1,145 @@
+from unittest.mock import AsyncMock, MagicMock, patch
+
+import pytest
+
+from skyvern.forge.sdk.workflow.service import _precreate_script_browser
+
+
+def _make_block(url: str | None = None) -> MagicMock:
+ block = MagicMock()
+ block.url = url
+ block.label = "TestBlock"
+ block.format_block_parameter_template_from_workflow_run_context = MagicMock(
+ side_effect=lambda val, ctx: val # identity by default
+ )
+ return block
+
+
+def _make_workflow_run(
+ workflow_run_id: str = "wfr_test",
+ browser_profile_id: str | None = None,
+) -> MagicMock:
+ wfr = MagicMock()
+ wfr.workflow_run_id = workflow_run_id
+ wfr.browser_profile_id = browser_profile_id
+ return wfr
+
+
+async def test_precreate_with_static_url() -> None:
+ """Block with a static URL: browser pre-created with that URL."""
+ block = _make_block(url="https://www.example.com/target")
+ wfr = _make_workflow_run()
+ mock_wrc = MagicMock()
+
+ with patch("skyvern.forge.sdk.workflow.service.app") as mock_app:
+ mock_app.WORKFLOW_CONTEXT_MANAGER.get_workflow_run_context.return_value = mock_wrc
+ mock_app.BROWSER_MANAGER.get_or_create_for_workflow_run = AsyncMock()
+
+ await _precreate_script_browser(
+ block=block,
+ workflow_run=wfr,
+ browser_session_id="bs_123",
+ )
+
+ mock_app.BROWSER_MANAGER.get_or_create_for_workflow_run.assert_called_once_with(
+ workflow_run=wfr,
+ url="https://www.example.com/target",
+ browser_session_id="bs_123",
+ browser_profile_id=wfr.browser_profile_id,
+ )
+ block.format_block_parameter_template_from_workflow_run_context.assert_called_once_with(
+ "https://www.example.com/target", mock_wrc
+ )
+
+
+async def test_precreate_with_templated_url() -> None:
+ """Block with a templated URL: resolved URL is passed to browser creation."""
+ block = _make_block(url="{{ parameters.target_url }}")
+ block.format_block_parameter_template_from_workflow_run_context = MagicMock(
+ return_value="https://www.resolved-site.com/page"
+ )
+ wfr = _make_workflow_run()
+
+ with patch("skyvern.forge.sdk.workflow.service.app") as mock_app:
+ mock_app.WORKFLOW_CONTEXT_MANAGER.get_workflow_run_context.return_value = MagicMock()
+ mock_app.BROWSER_MANAGER.get_or_create_for_workflow_run = AsyncMock()
+
+ await _precreate_script_browser(
+ block=block,
+ workflow_run=wfr,
+ browser_session_id=None,
+ )
+
+ call_kwargs = mock_app.BROWSER_MANAGER.get_or_create_for_workflow_run.call_args
+ assert call_kwargs.kwargs["url"] == "https://www.resolved-site.com/page"
+
+
+async def test_no_precreation_when_url_missing() -> None:
+ """Block without URL: no browser pre-creation, no app calls."""
+ block = _make_block(url=None)
+ wfr = _make_workflow_run()
+
+ with patch("skyvern.forge.sdk.workflow.service.app") as mock_app:
+ await _precreate_script_browser(
+ block=block,
+ workflow_run=wfr,
+ browser_session_id=None,
+ )
+
+ mock_app.WORKFLOW_CONTEXT_MANAGER.get_workflow_run_context.assert_not_called()
+ mock_app.BROWSER_MANAGER.get_or_create_for_workflow_run.assert_not_called()
+
+
+async def test_no_precreation_when_url_empty_string() -> None:
+ """Block with empty-string URL: treated as falsy, no pre-creation."""
+ block = _make_block(url="")
+ wfr = _make_workflow_run()
+
+ with patch("skyvern.forge.sdk.workflow.service.app") as mock_app:
+ await _precreate_script_browser(
+ block=block,
+ workflow_run=wfr,
+ browser_session_id=None,
+ )
+
+ mock_app.BROWSER_MANAGER.get_or_create_for_workflow_run.assert_not_called()
+
+
+async def test_no_precreation_when_block_lacks_url_attr() -> None:
+ """Block type without a url attribute: skipped via getattr guard."""
+ block = MagicMock(spec=[]) # empty spec = no attributes
+ wfr = _make_workflow_run()
+
+ with patch("skyvern.forge.sdk.workflow.service.app") as mock_app:
+ await _precreate_script_browser(
+ block=block,
+ workflow_run=wfr,
+ browser_session_id=None,
+ )
+
+ mock_app.BROWSER_MANAGER.get_or_create_for_workflow_run.assert_not_called()
+
+
+async def test_browser_creation_failure_propagates() -> None:
+ """When browser creation raises, the exception propagates to the caller."""
+ block = _make_block(url="https://www.example.com")
+ wfr = _make_workflow_run()
+
+ with patch("skyvern.forge.sdk.workflow.service.app") as mock_app:
+ mock_app.WORKFLOW_CONTEXT_MANAGER.get_workflow_run_context.return_value = MagicMock()
+ mock_app.BROWSER_MANAGER.get_or_create_for_workflow_run = AsyncMock(
+ side_effect=RuntimeError("browser creation failed")
+ )
+
+ with pytest.raises(RuntimeError, match="browser creation failed"):
+ await _precreate_script_browser(
+ block=block,
+ workflow_run=wfr,
+ browser_session_id=None,
+ )