Automate browser based workflows with AI
Python aiapiautomationbrowserbrowser-automationcomputergptllmplaywrightpowerautomatepuppeteerpythonrpaseleniumvisionworkflow
Add per-workflow Mask Secrets advanced setting (SKY-11822) (#7955)
Suchintan68f97646270f
diff --git a/alembic/versions/2026_08_01_2301-70e4ff9019f1_.py b/alembic/versions/2026_08_01_2301-70e4ff9019f1_.pynew file mode 100644index 000000000..c58e19d09--- /dev/null+++ b/alembic/versions/2026_08_01_2301-70e4ff9019f1_.py@@ -0,0 +1,30 @@+"""++Revision ID: 70e4ff9019f1+Revises: 04647fa4df41+Create Date: 2026-08-01T23:01:51.557562+00:00++"""++from typing import Sequence, Union++import sqlalchemy as sa++from alembic import op++# revision identifiers, used by Alembic.+revision: str = "70e4ff9019f1"+down_revision: Union[str, None] = "04647fa4df41"+branch_labels: Union[str, Sequence[str], None] = None+depends_on: Union[str, Sequence[str], None] = None+++def upgrade() -> None:+ op.add_column(+ "workflows",+ sa.Column("mask_secrets", sa.Boolean(), nullable=False, server_default=sa.false()),+ )+++def downgrade() -> None:+ op.drop_column("workflows", "mask_secrets")diff --git a/docs/api-reference/openapi.json b/docs/api-reference/openapi.jsonindex 992f17785..52d01760f 100644--- a/docs/api-reference/openapi.json+++ b/docs/api-reference/openapi.json@@ -26757,6 +26757,11 @@"title": "Persist Browser Session","default": false},+ "mask_secrets": {+ "type": "boolean",+ "title": "Mask Secrets",+ "default": false+ },"pin_saved_session_ip": {"type": "boolean","title": "Pin Saved Session Ip",@@ -27085,6 +27090,18 @@"title": "Persist Browser Session","default": false},+ "mask_secrets": {+ "anyOf": [+ {+ "type": "boolean"+ },+ {+ "type": "null"+ }+ ],+ "title": "Mask Secrets",+ "description": "Visually mask secrets as they are typed in the browser, hiding them from screenshots, recordings, and the live view."+ },"pin_saved_session_ip": {"type": "boolean","title": "Pin Saved Session Ip",diff --git a/skyvern-frontend/src/routes/workflows/components/WorkflowVisualComparisonDrawer.tsx b/skyvern-frontend/src/routes/workflows/components/WorkflowVisualComparisonDrawer.tsxindex 4287c51d6..a189f1871 100644--- a/skyvern-frontend/src/routes/workflows/components/WorkflowVisualComparisonDrawer.tsx+++ b/skyvern-frontend/src/routes/workflows/components/WorkflowVisualComparisonDrawer.tsx@@ -120,6 +120,7 @@ function getWorkflowElements(version: WorkflowVersion) {scriptCacheKey: version.cache_key,aiFallback: version.ai_fallback ?? true,enableSelfHealing: version.enable_self_healing ?? false,+ maskSecrets: version.mask_secrets ?? false,runSequentially: version.run_sequentially ?? false,sequentialKey: version.sequential_key ?? null,finallyBlockLabel: version.workflow_definition?.finally_block_label ?? null,diff --git a/skyvern-frontend/src/routes/workflows/copilot/WorkflowCopilotChat.tsx b/skyvern-frontend/src/routes/workflows/copilot/WorkflowCopilotChat.tsxindex 1a38319a8..4e3c86b0f 100644--- a/skyvern-frontend/src/routes/workflows/copilot/WorkflowCopilotChat.tsx+++ b/skyvern-frontend/src/routes/workflows/copilot/WorkflowCopilotChat.tsx@@ -2084,6 +2084,7 @@ export function WorkflowCopilotChat({cache_key: normalizedKey,ai_fallback: saveData.settings.aiFallback ?? true,enable_self_healing: saveData.settings.enableSelfHealing ?? false,+ mask_secrets: saveData.settings.maskSecrets,code_version:saveData.settings.runWith === "code"? (saveData.settings.codeVersion ?? 2)@@ -2112,6 +2113,7 @@ export function WorkflowCopilotChat({webhook_callback_url: saveData.settings.webhookCallbackUrl,persist_browser_session: saveData.settings.persistBrowserSession,pin_saved_session_ip: saveData.settings.pinSavedSessionIp,+ mask_secrets: saveData.settings.maskSecrets,browser_profile_id: saveData.settings.browserProfileId,browser_profile_key: saveData.settings.browserProfileKey,model: saveData.settings.model,diff --git a/skyvern-frontend/src/routes/workflows/debugger/Debugger.tsx b/skyvern-frontend/src/routes/workflows/debugger/Debugger.tsxindex b61b902bb..dad584559 100644--- a/skyvern-frontend/src/routes/workflows/debugger/Debugger.tsx+++ b/skyvern-frontend/src/routes/workflows/debugger/Debugger.tsx@@ -89,6 +89,7 @@ function Debugger() {scriptCacheKey: workflow.cache_key,aiFallback: workflow.ai_fallback ?? true,enableSelfHealing: workflow.enable_self_healing ?? false,+ maskSecrets: workflow.mask_secrets ?? false,runSequentially: workflow.run_sequentially ?? false,sequentialKey: workflow.sequential_key ?? null,finallyBlockLabel:diff --git a/skyvern-frontend/src/routes/workflows/defaultWorkflowRequest.ts b/skyvern-frontend/src/routes/workflows/defaultWorkflowRequest.tsindex 908646aa6..35d50e89e 100644--- a/skyvern-frontend/src/routes/workflows/defaultWorkflowRequest.ts+++ b/skyvern-frontend/src/routes/workflows/defaultWorkflowRequest.ts@@ -6,6 +6,7 @@ const defaultWorkflowRequest: WorkflowCreateYAMLRequest = {ai_fallback: true,enable_self_healing: false,code_version: 2,+ mask_secrets: false,run_with: "agent",workflow_definition: {version: 2,diff --git a/skyvern-frontend/src/routes/workflows/editor/WorkflowEditor.tsx b/skyvern-frontend/src/routes/workflows/editor/WorkflowEditor.tsxindex 830de7906..881d3e7dc 100644--- a/skyvern-frontend/src/routes/workflows/editor/WorkflowEditor.tsx+++ b/skyvern-frontend/src/routes/workflows/editor/WorkflowEditor.tsx@@ -119,6 +119,7 @@ function WorkflowEditor() {scriptCacheKey: workflow.cache_key,aiFallback: workflow.ai_fallback ?? true,enableSelfHealing: workflow.enable_self_healing ?? false,+ maskSecrets: workflow.mask_secrets ?? false,runSequentially: workflow.run_sequentially ?? false,sequentialKey: workflow.sequential_key ?? null,finallyBlockLabel:diff --git a/skyvern-frontend/src/routes/workflows/editor/Workspace.tsx b/skyvern-frontend/src/routes/workflows/editor/Workspace.tsxindex 23c8ecc12..562ab494d 100644--- a/skyvern-frontend/src/routes/workflows/editor/Workspace.tsx+++ b/skyvern-frontend/src/routes/workflows/editor/Workspace.tsx@@ -1603,6 +1603,7 @@ function Workspace({scriptCacheKey: workflowData.cache_key ?? null,aiFallback: workflowData.ai_fallback ?? true,enableSelfHealing: workflowData.enable_self_healing ?? false,+ maskSecrets: workflowData.mask_secrets ?? false,runSequentially: workflowData.run_sequentially ?? false,sequentialKey: workflowData.sequential_key ?? null,finallyBlockLabel:@@ -1915,6 +1916,7 @@ function Workspace({scriptCacheKey: selectedVersion.cache_key,aiFallback: selectedVersion.ai_fallback ?? true,enableSelfHealing: selectedVersion.enable_self_healing ?? false,+ maskSecrets: selectedVersion.mask_secrets ?? false,runSequentially: selectedVersion.run_sequentially ?? false,sequentialKey: selectedVersion.sequential_key ?? null,finallyBlockLabel:@@ -2941,6 +2943,7 @@ function Workspace({ai_fallback: saveData.settings.aiFallback,enable_self_healing: saveData.settings.enableSelfHealing ?? false,adaptive_caching: false,+ mask_secrets: saveData.settings.maskSecrets,code_version:saveData.settings.runWith === "code"? (saveData.settings.codeVersion ?? 2)diff --git a/skyvern-frontend/src/routes/workflows/editor/nestedConditionalSave.test.ts b/skyvern-frontend/src/routes/workflows/editor/nestedConditionalSave.test.tsindex 5021d845f..163db7e07 100644--- a/skyvern-frontend/src/routes/workflows/editor/nestedConditionalSave.test.ts+++ b/skyvern-frontend/src/routes/workflows/editor/nestedConditionalSave.test.ts@@ -33,6 +33,7 @@ const DEFAULT_SETTINGS: WorkflowSettings = {scriptCacheKey: null,aiFallback: true,enableSelfHealing: false,+ maskSecrets: false,runSequentially: false,sequentialKey: null,finallyBlockLabel: null,diff --git a/skyvern-frontend/src/routes/workflows/editor/nodes/StartNode/StartNode.test.tsx b/skyvern-frontend/src/routes/workflows/editor/nodes/StartNode/StartNode.test.tsxindex eb190b10e..9ed75c977 100644--- a/skyvern-frontend/src/routes/workflows/editor/nodes/StartNode/StartNode.test.tsx+++ b/skyvern-frontend/src/routes/workflows/editor/nodes/StartNode/StartNode.test.tsx@@ -60,6 +60,7 @@ const startNodeData: WorkflowStartNodeData = {scriptCacheKey: null,aiFallback: true,enableSelfHealing: false,+ maskSecrets: false,runSequentially: false,sequentialKey: null,finallyBlockLabel: null,diff --git a/skyvern-frontend/src/routes/workflows/editor/nodes/StartNode/WorkflowSettingsEditor.test.tsx b/skyvern-frontend/src/routes/workflows/editor/nodes/StartNode/WorkflowSettingsEditor.test.tsxindex 96bc2e2a3..39be4a66a 100644--- a/skyvern-frontend/src/routes/workflows/editor/nodes/StartNode/WorkflowSettingsEditor.test.tsx+++ b/skyvern-frontend/src/routes/workflows/editor/nodes/StartNode/WorkflowSettingsEditor.test.tsx@@ -27,6 +27,7 @@ const startNodeData: WorkflowStartNodeData = {scriptCacheKey: null,aiFallback: true,enableSelfHealing: false,+ maskSecrets: false,runSequentially: false,sequentialKey: null,finallyBlockLabel: null,@@ -100,6 +101,10 @@ vi.mock("@/components/TestWebhookDialog", () => ({TestWebhookDialog: () => <div data-testid="test-webhook-dialog" />,}));+vi.mock("@/components/HelpTooltip", () => ({+ HelpTooltip: ({ content }: { content: string }) => <span>{content}</span>,+}));+vi.mock("@/routes/workflows/hooks/useResetProfileMutation", () => ({useResetProfileMutation: () => ({mutate: vi.fn(),@@ -232,3 +237,24 @@ describe("WorkflowSettingsEditor browser profile key field", () => {).toBe("{{ credential_id }}");});});++describe("WorkflowSettingsEditor mask secrets setting", () => {+ test("renders the pinned tooltip and updates maskSecrets", () => {+ renderSettings();++ const label = screen.getByText("Mask Secrets");+ expect(+ screen.getByText(+ "Visually mask secrets while they are typed, so they do not appear in screenshots, recordings, or the live browser view. Turning this on can make login debugging harder because typed values are hidden.",+ ),+ ).toBeDefined();++ const toggle = label.parentElement?.querySelector('button[role="switch"]');+ expect(toggle).not.toBeNull();+ fireEvent.click(toggle!);++ expect(mockUpdateNodeData).toHaveBeenCalledWith("start", {+ maskSecrets: true,+ });+ });+});diff --git a/skyvern-frontend/src/routes/workflows/editor/nodes/StartNode/WorkflowSettingsEditor.tsx b/skyvern-frontend/src/routes/workflows/editor/nodes/StartNode/WorkflowSettingsEditor.tsxindex 5b14f1868..bfe247a14 100644--- a/skyvern-frontend/src/routes/workflows/editor/nodes/StartNode/WorkflowSettingsEditor.tsx+++ b/skyvern-frontend/src/routes/workflows/editor/nodes/StartNode/WorkflowSettingsEditor.tsx@@ -54,6 +54,9 @@ import {const PREVENT_OVERLAPPING_RUNS_TOOLTIP ="Queues new runs of this agent until any in-progress run finishes. Does not affect block ordering inside a single run; blocks always execute in declared order. Use this when concurrent runs would collide on shared state, such as the same credentials, browser session, or downstream account.";+const MASK_SECRETS_TOOLTIP =+ "Visually mask secrets while they are typed, so they do not appear in screenshots, recordings, or the live browser view. Turning this on can make login debugging harder because typed values are hidden.";+const SEQUENTIAL_KEY_TOOLTIP ="Scope the run queue. Runs with the same key are queued together; runs with different keys can still execute in parallel. Templated against agent inputs, for example {{ account_id }} to serialize per account.";@@ -284,6 +287,17 @@ function WorkflowSettingsEditorBody({</div></div><div className="flex flex-col gap-4">+ <div className="space-y-2">+ <div className="flex items-center gap-2">+ <Label>Mask Secrets</Label>+ <HelpTooltip content={MASK_SECRETS_TOOLTIP} />+ <Switch+ className="ml-auto"+ checked={data.maskSecrets}+ onCheckedChange={(value) => update({ maskSecrets: value })}+ />+ </div>+ </div><div className="space-y-2"><div className="flex items-center gap-2"><Label>Prevent Overlapping Runs</Label>diff --git a/skyvern-frontend/src/routes/workflows/editor/nodes/StartNode/types.ts b/skyvern-frontend/src/routes/workflows/editor/nodes/StartNode/types.tsindex e8e6e4208..f61d0850c 100644--- a/skyvern-frontend/src/routes/workflows/editor/nodes/StartNode/types.ts+++ b/skyvern-frontend/src/routes/workflows/editor/nodes/StartNode/types.ts@@ -22,6 +22,7 @@ export type WorkflowStartNodeData = {scriptCacheKey: string | null;aiFallback: boolean;enableSelfHealing: boolean;+ maskSecrets: boolean;runSequentially: boolean;sequentialKey: string | null;finallyBlockLabel: string | null;diff --git a/skyvern-frontend/src/routes/workflows/editor/panels/BlockConfigForm/WorkflowSettingsBlockForm.tsx b/skyvern-frontend/src/routes/workflows/editor/panels/BlockConfigForm/WorkflowSettingsBlockForm.tsxindex 4bd58b07f..fb56bcb68 100644--- a/skyvern-frontend/src/routes/workflows/editor/panels/BlockConfigForm/WorkflowSettingsBlockForm.tsx+++ b/skyvern-frontend/src/routes/workflows/editor/panels/BlockConfigForm/WorkflowSettingsBlockForm.tsx@@ -36,6 +36,7 @@ function WorkflowSettingsBlockFormBody({aiFallback: data.aiFallback,enableSelfHealing: data.enableSelfHealing,scriptCacheKey: data.scriptCacheKey,+ maskSecrets: data.maskSecrets,runSequentially: data.runSequentially,sequentialKey: data.sequentialKey,persistBrowserSession: data.persistBrowserSession,diff --git a/skyvern-frontend/src/routes/workflows/editor/panels/WorkflowComparisonPanel.tsx b/skyvern-frontend/src/routes/workflows/editor/panels/WorkflowComparisonPanel.tsxindex 8ff19cd61..78dac8571 100644--- a/skyvern-frontend/src/routes/workflows/editor/panels/WorkflowComparisonPanel.tsx+++ b/skyvern-frontend/src/routes/workflows/editor/panels/WorkflowComparisonPanel.tsx@@ -161,6 +161,7 @@ function getWorkflowElements(version: WorkflowVersion) {scriptCacheKey: version.cache_key,aiFallback: version.ai_fallback ?? true,enableSelfHealing: version.enable_self_healing ?? false,+ maskSecrets: version.mask_secrets ?? false,runSequentially: version.run_sequentially ?? false,sequentialKey: version.sequential_key ?? null,finallyBlockLabel: version.workflow_definition?.finally_block_label ?? null,diff --git a/skyvern-frontend/src/routes/workflows/editor/sortable/perf.test.ts b/skyvern-frontend/src/routes/workflows/editor/sortable/perf.test.tsindex 8d1373b56..7676a2335 100644--- a/skyvern-frontend/src/routes/workflows/editor/sortable/perf.test.ts+++ b/skyvern-frontend/src/routes/workflows/editor/sortable/perf.test.ts@@ -62,6 +62,7 @@ const DEFAULT_SETTINGS: WorkflowSettings = {scriptCacheKey: null,aiFallback: true,enableSelfHealing: false,+ maskSecrets: false,runSequentially: false,sequentialKey: null,finallyBlockLabel: null,diff --git a/skyvern-frontend/src/routes/workflows/editor/sortable/roundTrip.test.ts b/skyvern-frontend/src/routes/workflows/editor/sortable/roundTrip.test.tsindex 2c674e93c..2c3ba6910 100644--- a/skyvern-frontend/src/routes/workflows/editor/sortable/roundTrip.test.ts+++ b/skyvern-frontend/src/routes/workflows/editor/sortable/roundTrip.test.ts@@ -58,6 +58,7 @@ const DEFAULT_SETTINGS: WorkflowSettings = {scriptCacheKey: null,aiFallback: true,enableSelfHealing: false,+ maskSecrets: false,runSequentially: false,sequentialKey: null,finallyBlockLabel: null,@@ -543,6 +544,7 @@ describe("round-trip reorder → save → reload (M1 top-level)", () => {...DEFAULT_SETTINGS,errorCodeMapping: { OUT_OF_STOCK: "item unavailable" },finallyBlockLabel: "B5",+ maskSecrets: true,workflowSystemPrompt: "always double-check totals",};const { nodes } = getElements(buildFiveBlockFixture(), settings, true);@@ -551,6 +553,7 @@ describe("round-trip reorder → save → reload (M1 top-level)", () => {OUT_OF_STOCK: "item unavailable",});expect(recovered.finallyBlockLabel).toBe("B5");+ expect(recovered.maskSecrets).toBe(true);expect(recovered.workflowSystemPrompt).toBe("always double-check totals");});});diff --git a/skyvern-frontend/src/routes/workflows/editor/undefinedParametersGuard.test.ts b/skyvern-frontend/src/routes/workflows/editor/undefinedParametersGuard.test.tsindex eb4279cf2..e4a7c3fe2 100644--- a/skyvern-frontend/src/routes/workflows/editor/undefinedParametersGuard.test.ts+++ b/skyvern-frontend/src/routes/workflows/editor/undefinedParametersGuard.test.ts@@ -23,6 +23,7 @@ const DEFAULT_SETTINGS: WorkflowSettings = {scriptCacheKey: null,aiFallback: true,enableSelfHealing: false,+ maskSecrets: false,runSequentially: false,sequentialKey: null,finallyBlockLabel: null,diff --git a/skyvern-frontend/src/routes/workflows/editor/utils.test.ts b/skyvern-frontend/src/routes/workflows/editor/utils.test.tsindex 648b3da70..cf427dc02 100644--- a/skyvern-frontend/src/routes/workflows/editor/utils.test.ts+++ b/skyvern-frontend/src/routes/workflows/editor/utils.test.ts@@ -50,6 +50,7 @@ const baseWorkflow = {enable_self_healing: false,adaptive_caching: null,code_version: null,+ mask_secrets: false,run_sequentially: false,sequential_key: null,folder_id: null,diff --git a/skyvern-frontend/src/routes/workflows/editor/workflowChangesSummary.test.ts b/skyvern-frontend/src/routes/workflows/editor/workflowChangesSummary.test.tsindex 82e47e4cb..05d889056 100644--- a/skyvern-frontend/src/routes/workflows/editor/workflowChangesSummary.test.ts+++ b/skyvern-frontend/src/routes/workflows/editor/workflowChangesSummary.test.ts@@ -299,6 +299,16 @@ describe("summarizeWorkflowChanges (snapshot baseline)", () => {).toEqual(["Toggled persist browser session"]);});+ it("names a secret masking toggle", () => {+ const base = snapshotOf(saveData({ settings: { maskSecrets: false } }));+ expect(+ summarizeWorkflowChanges(+ saveData({ settings: { maskSecrets: true } }),+ base,+ ),+ ).toEqual(["Toggled secret masking"]);+ });+it("groups a browser-profile change into one line", () => {const base = snapshotOf(saveData({@@ -345,6 +355,7 @@ describe("summarizeWorkflowChanges (snapshot baseline)", () => {scriptCacheKey: "c",aiFallback: true,enableSelfHealing: false,+ maskSecrets: false,runSequentially: true,sequentialKey: "s",finallyBlockLabel: "f",diff --git a/skyvern-frontend/src/routes/workflows/editor/workflowChangesSummary.ts b/skyvern-frontend/src/routes/workflows/editor/workflowChangesSummary.tsindex ea1cd6d63..3fa17ad06 100644--- a/skyvern-frontend/src/routes/workflows/editor/workflowChangesSummary.ts+++ b/skyvern-frontend/src/routes/workflows/editor/workflowChangesSummary.ts@@ -218,6 +218,7 @@ const SETTINGS_LABELS: Array<{{ fields: ["scriptCacheKey"], label: "Changed script cache key" },{ fields: ["aiFallback"], label: "Toggled AI fallback" },{ fields: ["enableSelfHealing"], label: "Toggled self-healing" },+ { fields: ["maskSecrets"], label: "Toggled secret masking" },{fields: ["runSequentially", "sequentialKey"],label: "Changed sequential run settings",diff --git a/skyvern-frontend/src/routes/workflows/editor/workflowEditorUtils.ts b/skyvern-frontend/src/routes/workflows/editor/workflowEditorUtils.tsindex ab21cd33e..50dc2b868 100644--- a/skyvern-frontend/src/routes/workflows/editor/workflowEditorUtils.ts+++ b/skyvern-frontend/src/routes/workflows/editor/workflowEditorUtils.ts@@ -2090,6 +2090,7 @@ function getElements(scriptCacheKey: settings.scriptCacheKey,aiFallback: settings.aiFallback ?? true,enableSelfHealing: settings.enableSelfHealing ?? false,+ maskSecrets: settings.maskSecrets,label: "__start_block__",showCode: false,runSequentially: settings.runSequentially,@@ -3612,6 +3613,7 @@ function getWorkflowSettings(nodes: Array<AppNode>): WorkflowSettings {scriptCacheKey: null,aiFallback: true,enableSelfHealing: false,+ maskSecrets: false,runSequentially: false,sequentialKey: null,finallyBlockLabel: null,@@ -3650,6 +3652,7 @@ function getWorkflowSettings(nodes: Array<AppNode>): WorkflowSettings {scriptCacheKey: data.scriptCacheKey,aiFallback: data.aiFallback,enableSelfHealing: data.enableSelfHealing,+ maskSecrets: data.maskSecrets,runSequentially: data.runSequentially,sequentialKey: data.sequentialKey,finallyBlockLabel: data.finallyBlockLabel ?? null,@@ -4826,6 +4829,7 @@ function convert(workflow: WorkflowApiResponse): WorkflowCreateYAMLRequest {cache_key: workflow.cache_key,ai_fallback: workflow.ai_fallback ?? undefined,enable_self_healing: workflow.enable_self_healing ?? undefined,+ mask_secrets: workflow.mask_secrets ?? false,run_sequentially: workflow.run_sequentially ?? undefined,sequential_key: workflow.sequential_key ?? undefined,};diff --git a/skyvern-frontend/src/routes/workflows/editor/workflowVersionFromSaveData.test.ts b/skyvern-frontend/src/routes/workflows/editor/workflowVersionFromSaveData.test.tsindex 2bd037b20..db0cca628 100644--- a/skyvern-frontend/src/routes/workflows/editor/workflowVersionFromSaveData.test.ts+++ b/skyvern-frontend/src/routes/workflows/editor/workflowVersionFromSaveData.test.ts@@ -35,6 +35,7 @@ function makeSaveData(codeVersion: null,scriptCacheKey: "cache_1",aiFallback: true,+ maskSecrets: true,runSequentially: false,sequentialKey: null,finallyBlockLabel: null,@@ -94,6 +95,7 @@ describe("workflowVersionFromSaveData", () => {expect(version.persist_browser_session).toBe(true);expect(version.browser_profile_id).toBe("bp_1");expect(version.cache_key).toBe("cache_1");+ expect(version.mask_secrets).toBe(true);expect(version.extra_http_headers).toEqual({ a: "b" });expect(version.adaptive_caching).toBe(true);});diff --git a/skyvern-frontend/src/routes/workflows/editor/workflowVersionFromSaveData.ts b/skyvern-frontend/src/routes/workflows/editor/workflowVersionFromSaveData.tsindex fd03be692..6597a537c 100644--- a/skyvern-frontend/src/routes/workflows/editor/workflowVersionFromSaveData.ts+++ b/skyvern-frontend/src/routes/workflows/editor/workflowVersionFromSaveData.ts@@ -65,6 +65,7 @@ export function workflowVersionFromSaveData(ai_fallback: settings.aiFallback,enable_self_healing: settings.enableSelfHealing ?? false,adaptive_caching: workflow.adaptive_caching ?? false,+ mask_secrets: settings.maskSecrets,code_version:settings.runWith === "code" ? (settings.codeVersion ?? 2) : null,run_sequentially: settings.runSequentially,diff --git a/skyvern-frontend/src/routes/workflows/types/workflowTypes.ts b/skyvern-frontend/src/routes/workflows/types/workflowTypes.tsindex b8cfbcb54..4029b5cc9 100644--- a/skyvern-frontend/src/routes/workflows/types/workflowTypes.ts+++ b/skyvern-frontend/src/routes/workflows/types/workflowTypes.ts@@ -744,6 +744,7 @@ export type WorkflowApiResponse = {enable_self_healing: boolean | null;adaptive_caching: boolean | null;code_version: number | null;+ mask_secrets: boolean;run_sequentially: boolean | null;sequential_key: string | null;folder_id: string | null;@@ -770,6 +771,7 @@ export type WorkflowSettings = {scriptCacheKey: string | null;aiFallback: boolean | null;enableSelfHealing: boolean | null;+ maskSecrets: boolean;runSequentially: boolean;sequentialKey: string | null;finallyBlockLabel: string | null;diff --git a/skyvern-frontend/src/routes/workflows/types/workflowYamlTypes.ts b/skyvern-frontend/src/routes/workflows/types/workflowYamlTypes.tsindex e9498c8eb..3a826524b 100644--- a/skyvern-frontend/src/routes/workflows/types/workflowYamlTypes.ts+++ b/skyvern-frontend/src/routes/workflows/types/workflowYamlTypes.ts@@ -31,6 +31,7 @@ export type WorkflowCreateYAMLRequest = {enable_self_healing?: boolean;adaptive_caching?: boolean;code_version?: number | null;+ mask_secrets?: boolean | null;run_sequentially?: boolean;sequential_key?: string | null;folder_id?: string | null;diff --git a/skyvern-frontend/src/store/WorkflowHasChangesStore.ts b/skyvern-frontend/src/store/WorkflowHasChangesStore.tsindex cfff39b54..9937f166a 100644--- a/skyvern-frontend/src/store/WorkflowHasChangesStore.ts+++ b/skyvern-frontend/src/store/WorkflowHasChangesStore.ts@@ -206,6 +206,7 @@ const useWorkflowSave = (opts?: WorkflowSaveOpts) => {cache_key: normalizedKey,ai_fallback: saveData.settings.aiFallback ?? true,enable_self_healing: saveData.settings.enableSelfHealing ?? false,+ mask_secrets: saveData.settings.maskSecrets,code_version:saveData.settings.runWith === "code"? (saveData.settings.codeVersion ?? 2)diff --git a/skyvern/cli/mcp_tools/workflow.py b/skyvern/cli/mcp_tools/workflow.pyindex a3e3413bc..bbb25c557 100644--- a/skyvern/cli/mcp_tools/workflow.py+++ b/skyvern/cli/mcp_tools/workflow.py@@ -508,6 +508,7 @@ _WORKFLOW_UPDATE_PRESERVED_TOP_LEVEL_FIELDS = ("totp_verification_url","totp_identifier","persist_browser_session",+ "mask_secrets","pin_saved_session_ip","browser_profile_id","browser_profile_key",diff --git a/skyvern/forge/agent.py b/skyvern/forge/agent.pyindex 77bfb73dc..f78d74eed 100644--- a/skyvern/forge/agent.py+++ b/skyvern/forge/agent.py@@ -5391,10 +5391,15 @@ class ForgeAgent:_ctx = skyvern_context.current()_use_bundling = _ctx.use_artifact_bundling if _ctx else False- secret_values = app.WORKFLOW_CONTEXT_MANAGER.get_secret_values_for_run(task.workflow_run_id)+ redaction_enabled = settings.ENABLE_SECRET_ARTIFACT_REDACTION+ secret_values = (+ app.WORKFLOW_CONTEXT_MANAGER.get_secret_values_for_run(task.workflow_run_id)+ if redaction_enabled+ else set()+ )har_data = await app.BROWSER_MANAGER.get_har_data(task_id=task.task_id, browser_state=browser_state)- if settings.ENABLE_SECRET_ARTIFACT_REDACTION:+ if redaction_enabled:har_data = await asyncio.to_thread(redact_har_bytes, har_data, secret_values)if settings.SKYVERN_SUBMISSION_SIGNAL_SHADOW:submission_shadow.schedule_submission_signal_shadow(@@ -5409,7 +5414,7 @@ class ForgeAgent:browser_log = await app.BROWSER_MANAGER.get_browser_console_log(task_id=task.task_id, browser_state=browser_state)- if settings.ENABLE_SECRET_ARTIFACT_REDACTION:+ if redaction_enabled:browser_log = await asyncio.to_thread(redact_console_log_bytes, browser_log, secret_values)LOG.debug("Uploading browser log", browser_log_size=len(browser_log))diff --git a/skyvern/forge/sdk/api/llm/api_handler_factory.py b/skyvern/forge/sdk/api/llm/api_handler_factory.pyindex 1eb90f0ac..91b710758 100644--- a/skyvern/forge/sdk/api/llm/api_handler_factory.py+++ b/skyvern/forge/sdk/api/llm/api_handler_factory.py@@ -1,7 +1,6 @@import asyncioimport copyimport dataclasses-import inspectimport jsonimport reimport time@@ -275,13 +274,6 @@ def _current_secret_values_for_redaction() -> set[str]:)except Exception:return set()- if inspect.isawaitable(secret_values):- close = getattr(secret_values, "close", None)- if callable(close):- close()- return set()- if not isinstance(secret_values, set):- return set()return secret_valuesdiff --git a/skyvern/forge/sdk/artifact/manager.py b/skyvern/forge/sdk/artifact/manager.pyindex dab4a74e3..8e669a867 100644--- a/skyvern/forge/sdk/artifact/manager.py+++ b/skyvern/forge/sdk/artifact/manager.py@@ -1,5 +1,4 @@import asyncio-import inspectimport ioimport osimport time@@ -90,6 +89,7 @@ _REDACTABLE_TEXT_ARTIFACT_TYPES: frozenset[ArtifactType] = frozenset(ArtifactType.BROWSER_CONSOLE_LOG,ArtifactType.SKYVERN_LOG,ArtifactType.SKYVERN_LOG_RAW,+ ArtifactType.HASHED_HREF_MAP,})@@ -106,14 +106,6 @@ def _maybe_redact_artifact_data(artifact_type: ArtifactType, data: bytes, workflsecret_values = app.WORKFLOW_CONTEXT_MANAGER.get_secret_values_for_run(resolved_workflow_run_id)except Exception:return data- if inspect.isawaitable(secret_values):- close = getattr(secret_values, "close", None)- if callable(close):- close()- return data- if not isinstance(secret_values, set):- return data-if artifact_type == ArtifactType.HAR:return redact_har_bytes(data, secret_values)if not secret_values:diff --git a/skyvern/forge/sdk/copilot/tools/frontier.py b/skyvern/forge/sdk/copilot/tools/frontier.pyindex 5d9b2d449..cb8d5daa9 100644--- a/skyvern/forge/sdk/copilot/tools/frontier.py+++ b/skyvern/forge/sdk/copilot/tools/frontier.py@@ -618,6 +618,7 @@ _CANONICAL_WORKFLOW_SETTING_FIELDS: tuple[str, ...] = ("totp_verification_url","totp_identifier","persist_browser_session",+ "mask_secrets","pin_saved_session_ip","browser_profile_id","browser_profile_key",diff --git a/skyvern/forge/sdk/copilot/tools/workflow_update.py b/skyvern/forge/sdk/copilot/tools/workflow_update.pyindex d910216d9..12bb6f2e9 100644--- a/skyvern/forge/sdk/copilot/tools/workflow_update.py+++ b/skyvern/forge/sdk/copilot/tools/workflow_update.py@@ -10625,12 +10625,14 @@ async def _update_workflow(# Derive plain-language steps from each code block's code so the editor timeline# mirrors the actual code (deterministic action_type + line ranges).workflow_yaml_with_steps = await apply_derived_code_block_steps(workflow_yaml)+ prior_workflow = await _get_prior_workflow(ctx)workflow = await _process_workflow_yaml(workflow_id=ctx.workflow_id,workflow_permanent_id=ctx.workflow_permanent_id,organization_id=ctx.organization_id,workflow_yaml=workflow_yaml_with_steps,settings_fallback_yaml=prior_yaml,+ settings_fallback_workflow=prior_workflow,credential_scrub_values=registered_scrub_values(ctx),)_record_workflow_proxy_location_span(workflow_yaml, workflow)@@ -10638,7 +10640,6 @@ async def _update_workflow(# Param / top-level setting changes go through canonical because# prepare_workflow and the runtime parameter-row read consume canonical# values; terminal handlers roll back on non-auto-accept.- prior_workflow = await _get_prior_workflow(ctx)requires_canonical_persist = _workflow_requires_canonical_persist(prior_workflow, workflow) or _workflow_needs_contract_readback_persist(@@ -10660,6 +10661,7 @@ async def _update_workflow(totp_verification_url=workflow.totp_verification_url,totp_identifier=workflow.totp_identifier,persist_browser_session=workflow.persist_browser_session,+ mask_secrets=getattr(workflow, "mask_secrets", False),pin_saved_session_ip=workflow.pin_saved_session_ip,browser_profile_id=workflow.browser_profile_id,browser_profile_key=workflow.browser_profile_key,diff --git a/skyvern/forge/sdk/copilot/workflow_yaml.py b/skyvern/forge/sdk/copilot/workflow_yaml.pyindex f2121aa0a..f066b5342 100644--- a/skyvern/forge/sdk/copilot/workflow_yaml.py+++ b/skyvern/forge/sdk/copilot/workflow_yaml.py@@ -405,6 +405,7 @@ async def _process_workflow_yaml(organization_id: str,workflow_yaml: str,settings_fallback_yaml: str | None = None,+ settings_fallback_workflow: Workflow | None = None,credential_scrub_values: Collection[str] = (),) -> Workflow:# Single seam every copilot YAML->Workflow conversion passes through, so code@@ -431,12 +432,26 @@ async def _process_workflow_yaml(# failure propagates: failing the save is safer than writing an implicit disable.enable_self_healing = _yaml_enable_self_healing(settings_fallback_yaml)+ mask_secrets = workflow_yaml_request.mask_secrets+ if mask_secrets is None:+ mask_secrets = _yaml_bool_setting(settings_fallback_yaml, "mask_secrets")+pin_saved_session_ip = _yaml_pin_saved_session_ip(workflow_yaml)if pin_saved_session_ip is None:pin_saved_session_ip = _yaml_pin_saved_session_ip(settings_fallback_yaml)- current_workflow: Workflow | None = None- if enable_self_healing is None or pin_saved_session_ip is None:+ if enable_self_healing is None:+ fallback_value = getattr(settings_fallback_workflow, "enable_self_healing", None)+ enable_self_healing = fallback_value if isinstance(fallback_value, bool) else None+ if mask_secrets is None:+ fallback_value = getattr(settings_fallback_workflow, "mask_secrets", None)+ mask_secrets = fallback_value if isinstance(fallback_value, bool) else None+ if pin_saved_session_ip is None:+ fallback_value = getattr(settings_fallback_workflow, "pin_saved_session_ip", None)+ pin_saved_session_ip = fallback_value if isinstance(fallback_value, bool) else None++ current_workflow = settings_fallback_workflow+ if enable_self_healing is None or mask_secrets is None or pin_saved_session_ip is None:try:current_workflow = await app.WORKFLOW_SERVICE.get_workflow_by_permanent_id(workflow_permanent_id=workflow_permanent_id,@@ -446,6 +461,8 @@ async def _process_workflow_yaml(current_workflow = Noneif enable_self_healing is None:enable_self_healing = bool(current_workflow and getattr(current_workflow, "enable_self_healing", False))+ if mask_secrets is None:+ mask_secrets = bool(current_workflow and getattr(current_workflow, "mask_secrets", False))if pin_saved_session_ip is None:pin_saved_session_ip = bool(current_workflow and getattr(current_workflow, "pin_saved_session_ip", False))@@ -464,6 +481,7 @@ async def _process_workflow_yaml(totp_verification_url=workflow_yaml_request.totp_verification_url,totp_identifier=workflow_yaml_request.totp_identifier,persist_browser_session=workflow_yaml_request.persist_browser_session or False,+ mask_secrets=mask_secrets,pin_saved_session_ip=pin_saved_session_ip,browser_profile_id=workflow_yaml_request.browser_profile_id,browser_profile_key=workflow_yaml_request.browser_profile_key,diff --git a/skyvern/forge/sdk/db/models.py b/skyvern/forge/sdk/db/models.pyindex 1b19fb81a..7331c78c3 100644--- a/skyvern/forge/sdk/db/models.py+++ b/skyvern/forge/sdk/db/models.py@@ -594,6 +594,7 @@ class WorkflowModel(SoftDeleteMixin, Base):totp_verification_url = Column(String)totp_identifier = Column(String)persist_browser_session = Column(Boolean, default=False, nullable=False)+ mask_secrets = Column(Boolean, default=False, nullable=False, server_default=sqlalchemy.false())pin_saved_session_ip = Column(Boolean, default=False, nullable=False, server_default=sqlalchemy.false())browser_profile_id = Column(String, nullable=True)browser_profile_key = Column(String, nullable=True)diff --git a/skyvern/forge/sdk/db/repositories/workflows.py b/skyvern/forge/sdk/db/repositories/workflows.pyindex 8e00565fa..40f52e9d9 100644--- a/skyvern/forge/sdk/db/repositories/workflows.py+++ b/skyvern/forge/sdk/db/repositories/workflows.py@@ -131,6 +131,7 @@ class WorkflowsRepository(BaseRepository):totp_verification_url: str | None = None,totp_identifier: str | None = None,persist_browser_session: bool = False,+ mask_secrets: bool = False,pin_saved_session_ip: bool = False,browser_profile_id: str | None = None,browser_profile_key: str | None = None,@@ -174,6 +175,7 @@ class WorkflowsRepository(BaseRepository):extra_http_headers=extra_http_headers,cdp_connect_headers=cdp_connect_headers,persist_browser_session=persist_browser_session,+ mask_secrets=mask_secrets,pin_saved_session_ip=pin_saved_session_ip,browser_profile_id=browser_profile_id,browser_profile_key=browser_profile_key,@@ -781,6 +783,7 @@ class WorkflowsRepository(BaseRepository):totp_verification_url: str | None | object = _UNSET,totp_identifier: str | None | object = _UNSET,persist_browser_session: bool | None = None,+ mask_secrets: bool | None = None,pin_saved_session_ip: bool | None = None,browser_profile_id: str | None | object = _UNSET,browser_profile_key: str | None | object = _UNSET,@@ -834,6 +837,8 @@ class WorkflowsRepository(BaseRepository):workflow.totp_identifier = cast(str | None, totp_identifier)if persist_browser_session is not None:workflow.persist_browser_session = persist_browser_session+ if mask_secrets is not None:+ workflow.mask_secrets = mask_secretsif pin_saved_session_ip is not None:workflow.pin_saved_session_ip = pin_saved_session_ipif browser_profile_id is not _UNSET:@@ -1102,6 +1107,7 @@ class WorkflowsRepository(BaseRepository):totp_verification_url: str | None | object = _UNSET,totp_identifier: str | None | object = _UNSET,persist_browser_session: bool | None = None,+ mask_secrets: bool | None = None,pin_saved_session_ip: bool | None = None,browser_profile_id: str | None | object = _UNSET,browser_profile_key: str | None | object = _UNSET,@@ -1194,6 +1200,8 @@ class WorkflowsRepository(BaseRepository):workflow.totp_identifier = cast(str | None, totp_identifier)if persist_browser_session is not None:workflow.persist_browser_session = persist_browser_session+ if mask_secrets is not None:+ workflow.mask_secrets = mask_secretsif pin_saved_session_ip is not None:workflow.pin_saved_session_ip = pin_saved_session_ipif browser_profile_id is not _UNSET:diff --git a/skyvern/forge/sdk/db/utils.py b/skyvern/forge/sdk/db/utils.pyindex 357a2d9f2..711258d84 100644--- a/skyvern/forge/sdk/db/utils.py+++ b/skyvern/forge/sdk/db/utils.py@@ -563,6 +563,7 @@ def convert_to_workflow(totp_verification_url=workflow_model.totp_verification_url,totp_identifier=workflow_model.totp_identifier,persist_browser_session=workflow_model.persist_browser_session,+ mask_secrets=workflow_model.mask_secrets,pin_saved_session_ip=workflow_model.pin_saved_session_ip,browser_profile_id=workflow_model.browser_profile_id,browser_profile_key=workflow_model.browser_profile_key,diff --git a/skyvern/forge/sdk/routes/sdk.py b/skyvern/forge/sdk/routes/sdk.pyindex 977259e8b..ddfdec1ff 100644--- a/skyvern/forge/sdk/routes/sdk.py+++ b/skyvern/forge/sdk/routes/sdk.py@@ -133,6 +133,7 @@ async def run_sdk_action([],None,workflow,+ mask_secrets=getattr(workflow, "mask_secrets", False),)context = skyvern_context.ensure_context()diff --git a/skyvern/forge/sdk/routes/workflow_copilot.py b/skyvern/forge/sdk/routes/workflow_copilot.pyindex 4b97c9add..ef9f641f0 100644--- a/skyvern/forge/sdk/routes/workflow_copilot.py+++ b/skyvern/forge/sdk/routes/workflow_copilot.py@@ -1224,6 +1224,7 @@ async def _commit_staged_workflow(totp_verification_url=staged_workflow.totp_verification_url,totp_identifier=staged_workflow.totp_identifier,persist_browser_session=staged_workflow.persist_browser_session,+ mask_secrets=staged_workflow.mask_secrets,pin_saved_session_ip=staged_workflow.pin_saved_session_ip,browser_profile_id=staged_workflow.browser_profile_id,browser_profile_key=staged_workflow.browser_profile_key,@@ -1263,6 +1264,7 @@ async def _restore_workflow_definition(original_workflow: Workflow | None, organtotp_verification_url=original_workflow.totp_verification_url,totp_identifier=original_workflow.totp_identifier,persist_browser_session=original_workflow.persist_browser_session,+ mask_secrets=original_workflow.mask_secrets,pin_saved_session_ip=original_workflow.pin_saved_session_ip,browser_profile_id=original_workflow.browser_profile_id,browser_profile_key=original_workflow.browser_profile_key,diff --git a/skyvern/forge/sdk/workflow/context_manager.py b/skyvern/forge/sdk/workflow/context_manager.pyindex 8344c3f5b..6799b0244 100644--- a/skyvern/forge/sdk/workflow/context_manager.py+++ b/skyvern/forge/sdk/workflow/context_manager.py@@ -140,6 +140,7 @@ class WorkflowRunContext:block_outputs: dict[str, Any] | None = None,workflow: "Workflow | None" = None,inherited_workflow_system_prompt: str | None = None,+ mask_secrets: bool = False,) -> Self:# key is label nameworkflow_run_context = cls(@@ -150,6 +151,7 @@ class WorkflowRunContext:aws_client=aws_client,workflow=workflow,inherited_workflow_system_prompt=inherited_workflow_system_prompt,+ mask_secrets=mask_secrets,)workflow_run_context.organization_id = organization.organization_id@@ -229,12 +231,14 @@ class WorkflowRunContext:aws_client: AsyncAWSClient,workflow: "Workflow | None" = None,inherited_workflow_system_prompt: str | None = None,+ mask_secrets: bool = False,) -> None:self.workflow_title = workflow_titleself.workflow_id = workflow_idself.workflow_permanent_id = workflow_permanent_idself.workflow_run_id = workflow_run_idself.workflow = workflow+ self.mask_secrets: bool = mask_secrets# Joined raw workflow_system_prompt(s) from ancestor workflows (outermost# first) collected by walking workflow_run.parent_workflow_run_id at# execute_workflow time. Jinja-rendered on demand and concatenated with@@ -1734,6 +1738,7 @@ class WorkflowContextManager:block_outputs: dict[str, Any] | None = None,workflow: "Workflow | None" = None,inherited_workflow_system_prompt: str | None = None,+ mask_secrets: bool = False,) -> WorkflowRunContext:workflow_run_context = await WorkflowRunContext.init(self.aws_client,@@ -1749,6 +1754,7 @@ class WorkflowContextManager:block_outputs,workflow,inherited_workflow_system_prompt=inherited_workflow_system_prompt,+ mask_secrets=mask_secrets,)self.workflow_run_contexts[workflow_run_id] = workflow_run_contextreturn workflow_run_context@@ -1760,6 +1766,12 @@ class WorkflowContextManager:def remove_workflow_run_context(self, workflow_run_id: str) -> None:self.workflow_run_contexts.pop(workflow_run_id, None)+ def mask_secrets_enabled_for_run(self, workflow_run_id: str | None) -> bool:+ if workflow_run_id is None:+ return False+ context = self.workflow_run_contexts.get(workflow_run_id)+ return context is not None and context.mask_secrets+def get_secret_values_for_run(self,workflow_run_id: str | None,diff --git a/skyvern/forge/sdk/workflow/models/workflow.py b/skyvern/forge/sdk/workflow/models/workflow.pyindex 7038549f6..f3097b8a6 100644--- a/skyvern/forge/sdk/workflow/models/workflow.py+++ b/skyvern/forge/sdk/workflow/models/workflow.py@@ -172,6 +172,7 @@ class Workflow(BaseModel):totp_verification_url: str | None = Nonetotp_identifier: str | None = Nonepersist_browser_session: bool = False+ mask_secrets: bool = Falsepin_saved_session_ip: bool = Falsebrowser_profile_id: str | None = Nonebrowser_profile_key: str | None = Nonediff --git a/skyvern/forge/sdk/workflow/service.py b/skyvern/forge/sdk/workflow/service.pyindex a1e2bf87f..423c11a9c 100644--- a/skyvern/forge/sdk/workflow/service.py+++ b/skyvern/forge/sdk/workflow/service.py@@ -3301,6 +3301,7 @@ class WorkflowService:block_outputs,workflow,inherited_workflow_system_prompt=inherited_workflow_system_prompt,+ mask_secrets=getattr(workflow, "mask_secrets", False),)except Exception as e:LOG.exception(@@ -6316,6 +6317,7 @@ class WorkflowService:totp_verification_url: str | None = None,totp_identifier: str | None = None,persist_browser_session: bool = False,+ mask_secrets: bool = False,pin_saved_session_ip: bool = False,browser_profile_id: str | None = None,browser_profile_key: str | None = None,@@ -6353,6 +6355,7 @@ class WorkflowService:totp_verification_url=totp_verification_url,totp_identifier=totp_identifier,persist_browser_session=persist_browser_session,+ mask_secrets=mask_secrets,pin_saved_session_ip=pin_saved_session_ip,browser_profile_id=browser_profile_id,browser_profile_key=browser_profile_key,@@ -6751,6 +6754,7 @@ class WorkflowService:totp_verification_url: str | None | object = _UNSET,totp_identifier: str | None | object = _UNSET,persist_browser_session: bool | None = None,+ mask_secrets: bool | None = None,pin_saved_session_ip: bool | None = None,browser_profile_id: str | None | object = _UNSET,browser_profile_key: str | None | object = _UNSET,@@ -6790,6 +6794,7 @@ class WorkflowService:totp_verification_url=totp_verification_url,totp_identifier=totp_identifier,persist_browser_session=persist_browser_session,+ mask_secrets=mask_secrets,pin_saved_session_ip=pin_saved_session_ip,browser_profile_id=browser_profile_id,browser_profile_key=browser_profile_key,@@ -6821,6 +6826,7 @@ class WorkflowService:totp_verification_url=totp_verification_url,totp_identifier=totp_identifier,persist_browser_session=persist_browser_session,+ mask_secrets=mask_secrets,pin_saved_session_ip=pin_saved_session_ip,browser_profile_id=browser_profile_id,browser_profile_key=browser_profile_key,@@ -9469,8 +9475,8 @@ class WorkflowService:workflow_run_id=workflow_run.workflow_run_id,browser_state=browser_state,)- secret_values = app.WORKFLOW_CONTEXT_MANAGER.get_secret_values_for_run(workflow_run.workflow_run_id)if settings.ENABLE_SECRET_ARTIFACT_REDACTION:+ secret_values = app.WORKFLOW_CONTEXT_MANAGER.get_secret_values_for_run(workflow_run.workflow_run_id)har_data = await asyncio.to_thread(redact_har_bytes, har_data, secret_values)if settings.SKYVERN_SUBMISSION_SIGNAL_SHADOW:submission_shadow.schedule_submission_signal_shadow(@@ -9499,8 +9505,8 @@ class WorkflowService:workflow_run_id=workflow_run.workflow_run_id,browser_state=browser_state,)- secret_values = app.WORKFLOW_CONTEXT_MANAGER.get_secret_values_for_run(workflow_run.workflow_run_id)if settings.ENABLE_SECRET_ARTIFACT_REDACTION:+ secret_values = app.WORKFLOW_CONTEXT_MANAGER.get_secret_values_for_run(workflow_run.workflow_run_id)browser_log = await asyncio.to_thread(redact_console_log_bytes, browser_log, secret_values)LOG.debug("Persisting browser log", browser_log_size=len(browser_log))if browser_log:@@ -9555,8 +9561,13 @@ class WorkflowService:workflow_run_id=workflow_run.workflow_run_id,browser_state=browser_state,)- secret_values = app.WORKFLOW_CONTEXT_MANAGER.get_secret_values_for_run(workflow_run.workflow_run_id)- if settings.ENABLE_SECRET_ARTIFACT_REDACTION:+ redaction_enabled = settings.ENABLE_SECRET_ARTIFACT_REDACTION+ secret_values = (+ app.WORKFLOW_CONTEXT_MANAGER.get_secret_values_for_run(workflow_run.workflow_run_id)+ if redaction_enabled+ else set()+ )+ if redaction_enabled:browser_log = await asyncio.to_thread(redact_console_log_bytes, browser_log, secret_values)LOG.debug("Persisting browser log (bundled)", browser_log_size=len(browser_log))if browser_log:@@ -9567,7 +9578,7 @@ class WorkflowService:workflow_run_id=workflow_run.workflow_run_id,browser_state=browser_state,)- if settings.ENABLE_SECRET_ARTIFACT_REDACTION:+ if redaction_enabled:har_data = await asyncio.to_thread(redact_har_bytes, har_data, secret_values)if settings.SKYVERN_SUBMISSION_SIGNAL_SHADOW:submission_shadow.schedule_submission_signal_shadow(@@ -9658,6 +9669,7 @@ class WorkflowService:totp_verification_url=runtime_workflow.totp_verification_url,totp_identifier=runtime_workflow.totp_identifier,persist_browser_session=runtime_workflow.persist_browser_session,+ mask_secrets=runtime_workflow.mask_secrets,pin_saved_session_ip=runtime_workflow.pin_saved_session_ip,browser_profile_id=runtime_workflow.browser_profile_id,browser_profile_key=runtime_workflow.browser_profile_key,@@ -9798,6 +9810,9 @@ class WorkflowService:totp_verification_url=request.totp_verification_url,totp_identifier=request.totp_identifier,persist_browser_session=request.persist_browser_session,+ mask_secrets=request.mask_secrets+ if request.mask_secrets is not None+ else getattr(existing_latest_workflow, "mask_secrets", False),pin_saved_session_ip=request.pin_saved_session_ipif "pin_saved_session_ip" in request.model_fields_setelse existing_latest_workflow.pin_saved_session_ip,@@ -9847,6 +9862,7 @@ class WorkflowService:totp_verification_url=request.totp_verification_url,totp_identifier=request.totp_identifier,persist_browser_session=request.persist_browser_session,+ mask_secrets=request.mask_secrets if request.mask_secrets is not None else False,pin_saved_session_ip=request.pin_saved_session_ip,browser_profile_id=request.browser_profile_id,browser_profile_key=request.browser_profile_key,diff --git a/skyvern/schemas/workflows.py b/skyvern/schemas/workflows.pyindex 693faf083..ae293cefc 100644--- a/skyvern/schemas/workflows.py+++ b/skyvern/schemas/workflows.py@@ -1449,6 +1449,11 @@ class WorkflowCreateYAMLRequest(BaseModel):totp_verification_url: str | None = Nonetotp_identifier: str | None = Nonepersist_browser_session: bool = False+ mask_secrets: bool | None = Field(+ default=None,+ title="Mask Secrets",+ description="Visually mask secrets as they are typed in the browser, hiding them from screenshots, recordings, and the live view.",+ )pin_saved_session_ip: bool = Falsebrowser_profile_id: str | None = Nonebrowser_profile_key: str | None = Nonediff --git a/skyvern/services/task_v2_service.py b/skyvern/services/task_v2_service.pyindex dbf08a0f5..be41746bc 100644--- a/skyvern/services/task_v2_service.py+++ b/skyvern/services/task_v2_service.py@@ -1548,6 +1548,7 @@ async def _set_up_workflow_context(workflow: Workflow, workflow_run_id: str, org[],None,workflow,+ mask_secrets=getattr(workflow, "mask_secrets", False),)diff --git a/skyvern/webeye/actions/handler.py b/skyvern/webeye/actions/handler.pyindex cedc12342..5d93e7c60 100644--- a/skyvern/webeye/actions/handler.py+++ b/skyvern/webeye/actions/handler.py@@ -276,18 +276,27 @@ def _is_totp_sentinel(value: Any) -> bool:async def _apply_secret_visual_mask_if_needed(skyvern_element: SkyvernElement,*,+ workflow_run_id: str | None,is_secret_value: bool,is_totp_value: bool,is_totp_sequence: bool = False,) -> None:- if settings.ENABLE_SECRET_VISUAL_MASKING and (is_secret_value or is_totp_value or is_totp_sequence):+ if not settings.ENABLE_SECRET_VISUAL_MASKING or not app.WORKFLOW_CONTEXT_MANAGER.mask_secrets_enabled_for_run(+ workflow_run_id+ ):+ return+ if is_secret_value or is_totp_value or is_totp_sequence:await skyvern_element.apply_secret_visual_mask()async def _apply_active_element_secret_visual_mask_if_needed(page: Page, text: str | None, workflow_run_id: str | None) -> None:- if not settings.ENABLE_SECRET_VISUAL_MASKING or not text or workflow_run_id is None:+ if (+ not settings.ENABLE_SECRET_VISUAL_MASKING+ or not text+ or not app.WORKFLOW_CONTEXT_MANAGER.mask_secrets_enabled_for_run(workflow_run_id)+ ):returntry:secret_values = app.WORKFLOW_CONTEXT_MANAGER.get_secret_values_for_run(@@ -4777,6 +4786,7 @@ async def handle_input_text_action(await _apply_secret_visual_mask_if_needed(skyvern_element,+ workflow_run_id=task.workflow_run_id,is_secret_value=is_secret_value,is_totp_value=is_totp_value,is_totp_sequence=is_multi_field_totp,@@ -4834,12 +4844,6 @@ async def handle_input_text_action(if await blocking_element.is_editable():skyvern_element = blocking_elementtag_name = blocking_element.get_tag_name()- await _apply_secret_visual_mask_if_needed(- skyvern_element,- is_secret_value=is_secret_value,- is_totp_value=is_totp_value,- is_totp_sequence=is_multi_field_totp,- )if used_bare_nanp:# The tel plan read constraints from the original element; re-derive them from# the element actually being filled.@@ -4848,6 +4852,13 @@ async def handle_input_text_action(tel_e164_fallback = _nanp_e164_fallback(tel_source_text or "", pattern=tel_pattern, maxlength=tel_maxlength)+ await _apply_secret_visual_mask_if_needed(+ skyvern_element,+ workflow_run_id=task.workflow_run_id,+ is_secret_value=is_secret_value,+ is_totp_value=is_totp_value,+ is_totp_sequence=is_multi_field_totp,+ )except Exception:LOG.info("Failed to find the blocking element, continue with the original element",@@ -9164,6 +9175,7 @@ async def select_from_emerging_elements(await input_element.scroll_into_view()await _apply_secret_visual_mask_if_needed(input_element,+ workflow_run_id=task.workflow_run_id,is_secret_value=is_dropdown_secret_value,is_totp_value=is_dropdown_totp_value,)@@ -9373,6 +9385,7 @@ async def select_from_dropdown(await input_element.scroll_into_view()await _apply_secret_visual_mask_if_needed(input_element,+ workflow_run_id=task.workflow_run_id,is_secret_value=is_dropdown_secret_value,is_totp_value=is_dropdown_totp_value,)diff --git a/tests/unit/conftest.py b/tests/unit/conftest.pyindex 81fa40e13..0caa49d7c 100644--- a/tests/unit/conftest.py+++ b/tests/unit/conftest.py@@ -25,6 +25,7 @@ from sqlalchemy.ext.asyncio import AsyncEngine, create_async_enginefrom skyvern.forge.prompts import prompt_enginefrom skyvern.forge.sdk.copilot.context import CopilotContextfrom skyvern.forge.sdk.db.models import Base+from skyvern.forge.sdk.workflow.context_manager import WorkflowContextManagerfrom tests.unit._fingerprint_expectations import FINGERPRINT_TEST_SECRET_KEYfrom tests.unit.force_stub_app import start_forge_stub_app@@ -41,6 +42,26 @@ def fingerprint_secret_key(monkeypatch: pytest.MonkeyPatch) -> str:return FINGERPRINT_TEST_SECRET_KEY+def workflow_context_manager_factory() -> Callable[..., WorkflowContextManager]:+ def _make(+ *,+ workflow_run_id: str = "wr_mask_secrets",+ mask_secrets: bool = True,+ secrets: dict[str, str] | None = None,+ runtime_otp_values: set[str] | None = None,+ ) -> WorkflowContextManager:+ manager = WorkflowContextManager()+ manager.workflow_run_contexts[workflow_run_id] = SimpleNamespace(+ mask_secrets=mask_secrets,+ secrets=dict(secrets or {}),+ runtime_otp_values=set(runtime_otp_values or set()),+ )+ return manager++ return _make++# Wire structlog through stdlib so caplog can capture log records in tests.structlog.configure(wrapper_class=structlog.make_filtering_bound_logger(logging.INFO),diff --git a/tests/unit/force_stub_app.py b/tests/unit/force_stub_app.pyindex a828fe5b3..cfabe7531 100644--- a/tests/unit/force_stub_app.py+++ b/tests/unit/force_stub_app.py@@ -15,6 +15,8 @@ def create_forge_stub_app() -> ForgeApp:fake_app_module = ForgeApp()fake_app_module.DATABASE = _LazyNamespace()fake_app_module.WORKFLOW_CONTEXT_MANAGER = _LazyNamespace()+ fake_app_module.WORKFLOW_CONTEXT_MANAGER.mask_secrets_enabled_for_run = MagicMock(return_value=False)+ fake_app_module.WORKFLOW_CONTEXT_MANAGER.get_secret_values_for_run = MagicMock(return_value=set())fake_app_module.WORKFLOW_SERVICE = _LazyNamespace()fake_app_module.BROWSER_MANAGER = _LazyNamespace()# get_for_task is a sync lookup returning None when no browser state is registered; _LazyNamespacediff --git a/tests/unit/forge/sdk/artifact/test_secret_artifact_redaction.py b/tests/unit/forge/sdk/artifact/test_secret_artifact_redaction.pyindex 2a9dc7b22..d6d4781a4 100644--- a/tests/unit/forge/sdk/artifact/test_secret_artifact_redaction.py+++ b/tests/unit/forge/sdk/artifact/test_secret_artifact_redaction.py@@ -1,3 +1,4 @@+from collections.abc import Callablefrom datetime import UTC, datetimefrom types import SimpleNamespace@@ -8,6 +9,7 @@ from skyvern.forge.sdk.artifact.manager import ArtifactManagerfrom skyvern.forge.sdk.artifact.models import Artifact, ArtifactTypefrom skyvern.forge.sdk.core import skyvern_contextfrom skyvern.forge.sdk.core.skyvern_context import SkyvernContext+from skyvern.forge.sdk.workflow.context_manager import WorkflowContextManagerfrom skyvern.utils.secret_redaction import REDACTED_SECRET_PLACEHOLDERfrom tests.unit.forge.sdk.artifact.storage.test_helpers import (TEST_ORGANIZATION_ID,@@ -18,16 +20,6 @@ from tests.unit.forge.sdk.artifact.storage.test_helpers import (TEST_STEP_ID = "step_secret_redaction"-class _FakeWorkflowContextManager:- def get_secret_values_for_run(self, workflow_run_id: str | None) -> set[str]:- return {"secret-value"} if workflow_run_id == "wr_redact" else set()---class _EmptyWorkflowContextManager:- def get_secret_values_for_run(self, workflow_run_id: str | None) -> set[str]:- return set()--class _FakeStorage:def __init__(self) -> None:self.stored: list[tuple[Artifact, bytes]] = []@@ -67,7 +59,10 @@ class _FakeArtifactDatabase:@pytest.fixture-def artifact_redaction_setup(monkeypatch: pytest.MonkeyPatch) -> _FakeStorage:+def artifact_redaction_setup(+ monkeypatch: pytest.MonkeyPatch,+ workflow_context_manager_factory: Callable[..., WorkflowContextManager],+) -> _FakeStorage:storage = _FakeStorage()monkeypatch.setattr(artifact_manager_module.settings, "ENABLE_SECRET_ARTIFACT_REDACTION", True)monkeypatch.setattr(artifact_manager_module.app, "STORAGE", storage)@@ -79,7 +74,11 @@ def artifact_redaction_setup(monkeypatch: pytest.MonkeyPatch) -> _FakeStorage:monkeypatch.setattr(artifact_manager_module.app,"WORKFLOW_CONTEXT_MANAGER",- _FakeWorkflowContextManager(),+ workflow_context_manager_factory(+ workflow_run_id="wr_redact",+ mask_secrets=False,+ secrets={"password": "secret-value"},+ ),)skyvern_context.reset()skyvern_context.set(SkyvernContext(organization_id=TEST_ORGANIZATION_ID, workflow_run_id="wr_redact"))@@ -102,9 +101,27 @@ async def test_create_artifact_redacts_textual_artifact_data(artifact_redaction_assert artifact_redaction_setup.stored[0][1] == f"<html>{REDACTED_SECRET_PLACEHOLDER}</html>".encode()+async def test_create_artifact_redacts_hashed_href_map(artifact_redaction_setup: _FakeStorage) -> None:+ manager = ArtifactManager()+ step = create_fake_step(TEST_STEP_ID)++ await manager.create_artifact(+ step=step,+ artifact_type=ArtifactType.HASHED_HREF_MAP,+ data=b'{"h1": "https://example.test/callback?token=secret-value"}',+ )+ await manager.wait_for_upload_aiotasks([step.task_id])++ stored = artifact_redaction_setup.stored[0][1]+ assert b"secret-value" not in stored+ assert REDACTED_SECRET_PLACEHOLDER.encode() in stored++@pytest.mark.asyncioasync def test_create_artifact_redacts_using_artifact_workflow_run_id_without_context(monkeypatch: pytest.MonkeyPatch,+ workflow_context_manager_factory: Callable[..., WorkflowContextManager],) -> None:storage = _FakeStorage()monkeypatch.setattr(artifact_manager_module.settings, "ENABLE_SECRET_ARTIFACT_REDACTION", True)@@ -117,7 +134,11 @@ async def test_create_artifact_redacts_using_artifact_workflow_run_id_without_comonkeypatch.setattr(artifact_manager_module.app,"WORKFLOW_CONTEXT_MANAGER",- _FakeWorkflowContextManager(),+ workflow_context_manager_factory(+ workflow_run_id="wr_redact",+ mask_secrets=False,+ secrets={"password": "secret-value"},+ ),)skyvern_context.reset()assert skyvern_context.current() is None@@ -176,11 +197,12 @@ async def test_create_artifact_leaves_textual_artifact_data_unchanged_when_flag_async def test_create_artifact_redacts_har_structured_fields_with_empty_secret_set(artifact_redaction_setup: _FakeStorage,monkeypatch: pytest.MonkeyPatch,+ workflow_context_manager_factory: Callable[..., WorkflowContextManager],) -> None:monkeypatch.setattr(artifact_manager_module.app,"WORKFLOW_CONTEXT_MANAGER",- _EmptyWorkflowContextManager(),+ workflow_context_manager_factory(workflow_run_id="wr_redact"),)manager = ArtifactManager()step = create_fake_step(TEST_STEP_ID)@@ -194,3 +216,26 @@ async def test_create_artifact_redacts_har_structured_fields_with_empty_secret_sassert REDACTED_SECRET_PLACEHOLDER.encode() in artifact_redaction_setup.stored[0][1]assert b"Bearer token" not in artifact_redaction_setup.stored[0][1]+++async def test_create_artifact_redacts_har_when_workflow_opted_out(+ artifact_redaction_setup: _FakeStorage,+ monkeypatch: pytest.MonkeyPatch,+ workflow_context_manager_factory: Callable[..., WorkflowContextManager],+) -> None:+ monkeypatch.setattr(+ artifact_manager_module.app,+ "WORKFLOW_CONTEXT_MANAGER",+ workflow_context_manager_factory(workflow_run_id="wr_redact", mask_secrets=False),+ )+ manager = ArtifactManager()+ step = create_fake_step(TEST_STEP_ID)+ har_data = b'{"log":{"entries":[{"request":{"headers":[{"name":"Authorization","value":"Bearer token"}]}}]}}'++ await manager.create_artifact(step=step, artifact_type=ArtifactType.HAR, data=har_data)+ await manager.wait_for_upload_aiotasks([step.task_id])++ stored = artifact_redaction_setup.stored[0][1]+ assert REDACTED_SECRET_PLACEHOLDER.encode() in stored+ assert b"Bearer token" not in storeddiff --git a/tests/unit/test_auto_completion_detection.py b/tests/unit/test_auto_completion_detection.pyindex 04b4eceb2..6ea09d067 100644--- a/tests/unit/test_auto_completion_detection.py+++ b/tests/unit/test_auto_completion_detection.py@@ -5,10 +5,12 @@ Covers direct attribute detection in is_auto_completion_input().from __future__ import annotations+from types import SimpleNamespacefrom unittest.mock import AsyncMock, MagicMock, patchimport pytest+from skyvern.webeye.actions import handler as handler_modulefrom skyvern.webeye.utils.dom import SkyvernElementfrom skyvern.webeye.utils.page import apply_secret_visual_mask_to_active_element@@ -111,3 +113,103 @@ async def test_active_element_secret_visual_mask_script_skips_password_inputs()assert 'toLowerCase() === "password"' in expressionassert "getRootNode" in expressionassert "data-skyvern-secret-mask" in expression++[email protected](("workflow_run_id", "enabled"), [(None, False), ("wr_disabled", False)])+async def test_secret_visual_mask_helper_skips_inactive_runs(+ monkeypatch: pytest.MonkeyPatch,+ workflow_run_id: str | None,+ enabled: bool,+) -> None:+ element = SimpleNamespace(apply_secret_visual_mask=AsyncMock())+ manager = SimpleNamespace(mask_secrets_enabled_for_run=MagicMock(return_value=enabled))+ monkeypatch.setattr(handler_module.app, "WORKFLOW_CONTEXT_MANAGER", manager)+ monkeypatch.setattr(handler_module.settings, "ENABLE_SECRET_VISUAL_MASKING", True)++ await handler_module._apply_secret_visual_mask_if_needed(+ element,+ workflow_run_id=workflow_run_id,+ is_secret_value=True,+ is_totp_value=False,+ )++ element.apply_secret_visual_mask.assert_not_awaited()+++async def test_secret_visual_mask_helper_applies_for_opted_in_run(monkeypatch: pytest.MonkeyPatch) -> None:+ element = SimpleNamespace(apply_secret_visual_mask=AsyncMock())+ manager = SimpleNamespace(mask_secrets_enabled_for_run=MagicMock(return_value=True))+ monkeypatch.setattr(handler_module.app, "WORKFLOW_CONTEXT_MANAGER", manager)+ monkeypatch.setattr(handler_module.settings, "ENABLE_SECRET_VISUAL_MASKING", True)++ await handler_module._apply_secret_visual_mask_if_needed(+ element,+ workflow_run_id="wr_enabled",+ is_secret_value=True,+ is_totp_value=False,+ )++ element.apply_secret_visual_mask.assert_awaited_once_with()+++async def test_secret_visual_mask_helper_skips_when_global_flag_disabled(+ monkeypatch: pytest.MonkeyPatch,+) -> None:+ element = SimpleNamespace(apply_secret_visual_mask=AsyncMock())+ manager = SimpleNamespace(mask_secrets_enabled_for_run=MagicMock(return_value=True))+ monkeypatch.setattr(handler_module.app, "WORKFLOW_CONTEXT_MANAGER", manager)+ monkeypatch.setattr(handler_module.settings, "ENABLE_SECRET_VISUAL_MASKING", False)++ await handler_module._apply_secret_visual_mask_if_needed(+ element,+ workflow_run_id="wr_enabled",+ is_secret_value=True,+ is_totp_value=False,+ )++ element.apply_secret_visual_mask.assert_not_awaited()+++async def test_active_element_secret_visual_mask_helper_skips_inactive_run(+ monkeypatch: pytest.MonkeyPatch,+) -> None:+ manager = SimpleNamespace(+ mask_secrets_enabled_for_run=MagicMock(return_value=False),+ get_secret_values_for_run=MagicMock(return_value={"secret-value"}),+ )+ apply_mask = AsyncMock()+ monkeypatch.setattr(handler_module.app, "WORKFLOW_CONTEXT_MANAGER", manager)+ monkeypatch.setattr(handler_module.settings, "ENABLE_SECRET_VISUAL_MASKING", True)+ monkeypatch.setattr(handler_module, "apply_secret_visual_mask_to_active_element", apply_mask)++ await handler_module._apply_active_element_secret_visual_mask_if_needed(MagicMock(), "secret-value", "wr_disabled")++ manager.get_secret_values_for_run.assert_not_called()+ apply_mask.assert_not_awaited()+++async def test_active_element_secret_visual_mask_helper_uses_raw_values_for_opted_in_run(+ monkeypatch: pytest.MonkeyPatch,+) -> None:+ manager = SimpleNamespace(+ mask_secrets_enabled_for_run=MagicMock(return_value=True),+ get_secret_values_for_run=MagicMock(return_value={"secret-value"}),+ )+ apply_mask = AsyncMock()+ monkeypatch.setattr(handler_module.app, "WORKFLOW_CONTEXT_MANAGER", manager)+ monkeypatch.setattr(handler_module.settings, "ENABLE_SECRET_VISUAL_MASKING", True)+ monkeypatch.setattr(handler_module, "apply_secret_visual_mask_to_active_element", apply_mask)++ page = MagicMock()+ await handler_module._apply_active_element_secret_visual_mask_if_needed(page, "secret-value", "wr_enabled")++ manager.get_secret_values_for_run.assert_called_once_with(+ "wr_enabled",+ respect_artifact_redaction_flag=False,+ )+ apply_mask.assert_awaited_once_with(page)diff --git a/tests/unit/test_cleanup_browser_video_path_fallback.py b/tests/unit/test_cleanup_browser_video_path_fallback.pyindex 5a210c66a..cb645cfd6 100644--- a/tests/unit/test_cleanup_browser_video_path_fallback.py+++ b/tests/unit/test_cleanup_browser_video_path_fallback.py@@ -10,22 +10,30 @@ OSS-synced: synthetic ids and example.* placeholders only.from __future__ import annotations+import jsonfrom pathlib import Pathfrom types import SimpleNamespacefrom unittest.mock import AsyncMock, MagicMock, patchimport pytest+from skyvern.forge import agent as agent_modulefrom skyvern.forge.agent import ForgeAgentfrom skyvern.forge.sdk.artifact.models import ArtifactTypefrom skyvern.forge.sdk.workflow.service import WorkflowService+from skyvern.utils.secret_redaction import REDACTED_SECRET_PLACEHOLDERfrom skyvern.webeye.browser_artifacts import BrowserArtifacts, VideoArtifact-def _make_task(task_id: str = "tsk_1", organization_id: str = "o_1") -> MagicMock:+def _make_task(+ task_id: str = "tsk_1",+ organization_id: str = "o_1",+ workflow_run_id: str | None = None,+) -> MagicMock:task = MagicMock()task.task_id = task_idtask.organization_id = organization_id+ task.workflow_run_id = workflow_run_idtask.webhook_callback_url = Nonereturn task@@ -295,3 +303,74 @@ async def test_cleanup_preserves_update_path_for_pre_registered_artifact(tmp_pat]assert recording_calls == []assert video_artifacts[0].video_artifact_id == "a_existing"++[email protected]("artifact_redaction_enabled", [False, True])+async def test_cleanup_gates_har_and_console_redaction_on_environment_flag(+ monkeypatch: pytest.MonkeyPatch,+ artifact_redaction_enabled: bool,+) -> None:+ har_data = json.dumps(+ {+ "log": {+ "entries": [+ {+ "request": {+ "headers": [{"name": "Authorization", "value": "Bearer token"}],+ }+ }+ ]+ }+ }+ ).encode()+ console_log = b"console secret: console-secret"+ task = _make_task(workflow_run_id="wr_1")+ browser_state = _browser_state()+ context_manager = SimpleNamespace(+ mask_secrets_enabled_for_run=MagicMock(return_value=False),+ get_secret_values_for_run=MagicMock(return_value={"console-secret"}),+ )++ monkeypatch.setattr(+ agent_module.settings,+ "ENABLE_SECRET_ARTIFACT_REDACTION",+ artifact_redaction_enabled,+ )+ with patch("skyvern.forge.agent.app") as mock_app:+ mock_app.WORKFLOW_CONTEXT_MANAGER = context_manager+ mock_app.BROWSER_MANAGER.cleanup_for_task = AsyncMock(return_value=browser_state)+ mock_app.BROWSER_MANAGER.get_video_artifacts = AsyncMock(return_value=[])+ mock_app.BROWSER_MANAGER.get_har_data = AsyncMock(return_value=har_data)+ mock_app.BROWSER_MANAGER.get_browser_console_log = AsyncMock(return_value=console_log)+ mock_app.ARTIFACT_MANAGER.create_artifact = AsyncMock(return_value="a_har")++ await ForgeAgent().cleanup_browser_and_create_artifacts(+ close_browser_on_completion=True,+ last_step=_make_step(),+ task=task,+ )++ har_calls = [+ call+ for call in mock_app.ARTIFACT_MANAGER.create_artifact.await_args_list+ if call.kwargs.get("artifact_type") == ArtifactType.HAR+ ]+ console_calls = [+ call+ for call in mock_app.ARTIFACT_MANAGER.create_artifact.await_args_list+ if call.kwargs.get("artifact_type") == ArtifactType.BROWSER_CONSOLE_LOG+ ]+ stored_har = har_calls[0].kwargs["data"]+ stored_console_log = console_calls[0].kwargs["data"]+ context_manager.mask_secrets_enabled_for_run.assert_not_called()+ if artifact_redaction_enabled:+ assert REDACTED_SECRET_PLACEHOLDER.encode() in stored_har+ assert b"Bearer token" not in stored_har+ assert REDACTED_SECRET_PLACEHOLDER.encode() in stored_console_log+ assert b"console-secret" not in stored_console_log+ context_manager.get_secret_values_for_run.assert_called_once_with("wr_1")+ else:+ assert stored_har == har_data+ assert stored_console_log == console_log+ context_manager.get_secret_values_for_run.assert_not_called()diff --git a/tests/unit/test_code_block_sandbox.py b/tests/unit/test_code_block_sandbox.pyindex bd1eb8418..34e7ec05d 100644--- a/tests/unit/test_code_block_sandbox.py+++ b/tests/unit/test_code_block_sandbox.py@@ -999,6 +999,7 @@ def _build_wrc_with_totp_seed(seed: str = _RFC_TOTP_SEED):workflow_permanent_id="wpid",workflow_run_id=_WORKFLOW_RUN_ID,aws_client=MagicMock(),+ mask_secrets=True,)totp_secret_id = wrc.generate_random_secret_id() + "_totp"wrc.secrets[totp_secret_id] = BitwardenConstants.TOTP@@ -1019,6 +1020,7 @@ def _build_wrc_with_identifier(identifier: str = "[email protected]"):workflow_permanent_id="wpid",workflow_run_id=_WORKFLOW_RUN_ID,aws_client=MagicMock(),+ mask_secrets=True,)wrc.values[_CREDENTIAL_KEY] = {"context": "placeholder note"}wrc.credential_totp_identifiers[_CREDENTIAL_KEY] = identifierdiff --git a/tests/unit/test_input_text_combobox_commit.py b/tests/unit/test_input_text_combobox_commit.pyindex 53da4b8cd..4d20cfdf9 100644--- a/tests/unit/test_input_text_combobox_commit.py+++ b/tests/unit/test_input_text_combobox_commit.py@@ -346,13 +346,18 @@ async def test_search_bar_does_not_use_combobox_branch() -> None:async def test_secret_valued_action_does_not_trigger_select() -> None:"""A secret-valued parameter must never enter the selection path: its value would otherwise belogged (target_value=...) and sent into the custom-select LLM prompt via target_value=text."""- results, el, select_mock = await _run_combobox_input(- attrs=_INVALID_BOTH,- options=_listbox_with_option(_TARGET),- select_success=True,- stop_flag=True,- is_secret=True,- )+ with patch.object(+ handler.app.WORKFLOW_CONTEXT_MANAGER,+ "mask_secrets_enabled_for_run",+ MagicMock(return_value=True),+ ):+ results, el, select_mock = await _run_combobox_input(+ attrs=_INVALID_BOTH,+ options=_listbox_with_option(_TARGET),+ select_success=True,+ stop_flag=True,+ is_secret=True,+ )select_mock.assert_not_awaited()el.apply_secret_visual_mask.assert_awaited_once_with()assert len(results) == 1 and isinstance(results[0], ActionSuccess)diff --git a/tests/unit/test_llm_prompt_secret_redaction.py b/tests/unit/test_llm_prompt_secret_redaction.pyindex ff53087df..b6f2d96d2 100644--- a/tests/unit/test_llm_prompt_secret_redaction.py+++ b/tests/unit/test_llm_prompt_secret_redaction.py@@ -1,20 +1,13 @@+from collections.abc import Callable+from skyvern.forge.sdk.api.llm import api_handler_factory+from skyvern.forge.sdk.core import skyvern_context+from skyvern.forge.sdk.core.skyvern_context import SkyvernContext+from skyvern.forge.sdk.workflow.context_manager import WorkflowContextManagerfrom skyvern.utils.secret_redaction import REDACTED_SECRET_PLACEHOLDER-class _FakeWorkflowContextManager:- def get_secret_values_for_run(self, workflow_run_id: str | None, exclude_runtime_otp: bool = False) -> set[str]:- return {"real-password"} if workflow_run_id == "wr_redact" else set()--def test_redact_prompt_text_removes_real_secret_and_keeps_placeholder(monkeypatch) -> None:- monkeypatch.setattr(api_handler_factory.settings, "ENABLE_SECRET_ARTIFACT_REDACTION", True)- monkeypatch.setattr(- api_handler_factory.app,- "WORKFLOW_CONTEXT_MANAGER",- _FakeWorkflowContextManager(),- )-redacted = api_handler_factory._redact_prompt_text("password real-password id placeholder_ab12_password",{"real-password"},@@ -23,6 +16,38 @@ def test_redact_prompt_text_removes_real_secret_and_keeps_placeholder(monkeypatcassert redacted == f"password {REDACTED_SECRET_PLACEHOLDER} id placeholder_ab12_password"+def test_current_secret_values_for_redaction_ignores_workflow_opt_out(+ monkeypatch,+ workflow_context_manager_factory: Callable[..., WorkflowContextManager],+) -> None:+ monkeypatch.setattr(api_handler_factory.settings, "ENABLE_SECRET_ARTIFACT_REDACTION", True)+ manager = workflow_context_manager_factory(+ workflow_run_id="wr_redact",+ mask_secrets=False,+ secrets={"password": "real-password"},+ )+ monkeypatch.setattr(api_handler_factory.app, "WORKFLOW_CONTEXT_MANAGER", manager)++ with skyvern_context.scoped(SkyvernContext(workflow_run_id="wr_redact")):+ assert api_handler_factory._current_secret_values_for_redaction() == {"real-password"}+++def test_current_secret_values_for_redaction_respects_global_flag(+ monkeypatch,+ workflow_context_manager_factory: Callable[..., WorkflowContextManager],+) -> None:+ monkeypatch.setattr(api_handler_factory.settings, "ENABLE_SECRET_ARTIFACT_REDACTION", False)+ manager = workflow_context_manager_factory(+ workflow_run_id="wr_redact",+ mask_secrets=False,+ secrets={"password": "real-password"},+ )+ monkeypatch.setattr(api_handler_factory.app, "WORKFLOW_CONTEXT_MANAGER", manager)++ with skyvern_context.scoped(SkyvernContext(workflow_run_id="wr_redact")):+ assert api_handler_factory._current_secret_values_for_redaction() == set()++def test_redact_message_text_content_redacts_tool_call_arguments() -> None:messages = [{diff --git a/tests/unit/test_multi_field_totp.py b/tests/unit/test_multi_field_totp.pyindex b700e152a..e983d3179 100644--- a/tests/unit/test_multi_field_totp.py+++ b/tests/unit/test_multi_field_totp.py@@ -68,6 +68,7 @@ def _patch_workflow_context(monkeypatch: pytest.MonkeyPatch, workflow_context: _SimpleNamespace(WORKFLOW_CONTEXT_MANAGER=SimpleNamespace(get_workflow_run_context=lambda _workflow_run_id: workflow_context,+ mask_secrets_enabled_for_run=lambda _workflow_run_id: False,),BROWSER_MANAGER=SimpleNamespace(get_for_task=lambda *_args, **_kwargs: None),),diff --git a/tests/unit/test_non_secret_credential_fields.py b/tests/unit/test_non_secret_credential_fields.pyindex c3490473c..bfc62e545 100644--- a/tests/unit/test_non_secret_credential_fields.py+++ b/tests/unit/test_non_secret_credential_fields.py@@ -23,13 +23,14 @@ _CARD = CreditCardCredential()-def _context() -> WorkflowRunContext:+def _context(*, mask_secrets: bool = True) -> WorkflowRunContext:return WorkflowRunContext(workflow_title="t",workflow_id="w_test",workflow_permanent_id="wpid_test",workflow_run_id="wr_test",aws_client=MagicMock(),+ mask_secrets=mask_secrets,)@@ -127,3 +128,20 @@ def test_long_secret_still_masks_as_substring() -> None:masked = context.mask_secrets_in_data({"log": "charged card 4111111111111111 ok"})assert masked == {"log": "charged card ***** ok"}+++def test_mask_secrets_in_data_masks_even_when_workflow_opted_out() -> None:+ context = _context(mask_secrets=False)+ context.secrets["password"] = "secret-value"++ assert context.mask_secrets_in_data({"password": "secret-value"}) == {"password": "*****"}+++def test_mask_secrets_in_data_masks_even_when_global_flag_disabled(+ monkeypatch: pytest.MonkeyPatch,+) -> None:+ monkeypatch.setattr(context_manager_module.settings, "ENABLE_SECRET_ARTIFACT_REDACTION", False)+ context = _context(mask_secrets=False)+ context.secrets["password"] = "secret-value"++ assert context.mask_secrets_in_data({"password": "secret-value"}) == {"password": "*****"}diff --git a/tests/unit/test_secret_artifact_redaction_wiring.py b/tests/unit/test_secret_artifact_redaction_wiring.pyindex 8f2e59005..cf2d0a978 100644--- a/tests/unit/test_secret_artifact_redaction_wiring.py+++ b/tests/unit/test_secret_artifact_redaction_wiring.py@@ -45,7 +45,9 @@ def _fake_app(har_data: bytes = b"", browser_log: bytes = b"") -> SimpleNamespaccreate_artifact=AsyncMock(return_value="artifact_1"),create_task_archive=AsyncMock(return_value="archive_1"),),- WORKFLOW_CONTEXT_MANAGER=SimpleNamespace(get_secret_values_for_run=Mock(return_value={SECRET})),+ WORKFLOW_CONTEXT_MANAGER=SimpleNamespace(+ get_secret_values_for_run=Mock(return_value={SECRET}),+ ),)@@ -81,6 +83,29 @@ async def test_persist_har_data_redacts_secret_and_sensitive_header(monkeypatch:assert SECRET.encode() not in stored_data+async def test_persist_har_data_skips_all_redaction_when_flag_disabled(+ monkeypatch: pytest.MonkeyPatch,+) -> None:+ original_har = _har_bytes()+ fake_app = _fake_app(har_data=original_har)+ monkeypatch.setattr(workflow_service_module, "app", fake_app)+ monkeypatch.setattr(workflow_service_module.settings, "ENABLE_SECRET_ARTIFACT_REDACTION", False)++ browser_state, last_step, workflow, workflow_run = _workflow_objects()+ service = WorkflowService()++ await service.persist_har_data(browser_state, last_step, workflow, workflow_run)++ fake_app.WORKFLOW_CONTEXT_MANAGER.get_secret_values_for_run.assert_not_called()+ artifact_kwargs = fake_app.ARTIFACT_MANAGER.create_artifact.await_args.kwargs+ stored_data = artifact_kwargs["data"]+ request = json.loads(stored_data)["log"]["entries"][0]["request"]++ assert stored_data == original_har+ assert request["headers"][0]["value"] == f"Bearer {SECRET}"++@pytest.mark.asyncioasync def test_persist_browser_console_log_redacts_secret(monkeypatch: pytest.MonkeyPatch) -> None:fake_app = _fake_app(browser_log=f"console leaked {SECRET}".encode())diff --git a/tests/unit/utils/test_secret_redaction.py b/tests/unit/utils/test_secret_redaction.pyindex 42e82b708..8fbaadf0e 100644--- a/tests/unit/utils/test_secret_redaction.py+++ b/tests/unit/utils/test_secret_redaction.py@@ -1,6 +1,6 @@import base64import json-from types import SimpleNamespace+from collections.abc import Callableimport pytest@@ -267,10 +267,44 @@ def test_get_secret_values_for_run_returns_empty_for_unknown_run(monkeypatch: pyassert manager.get_secret_values_for_run("missing") == set()-def test_get_secret_values_for_run_respects_artifact_redaction_flag(monkeypatch: pytest.MonkeyPatch) -> None:+def test_mask_secrets_enabled_for_run_truth_table(+ workflow_context_manager_factory: Callable[..., WorkflowContextManager],+) -> None:+ manager = workflow_context_manager_factory(workflow_run_id="wr_enabled", mask_secrets=True)+ manager.workflow_run_contexts["wr_disabled"] = workflow_context_manager_factory(+ workflow_run_id="wr_disabled", mask_secrets=False+ ).workflow_run_contexts["wr_disabled"]++ assert manager.mask_secrets_enabled_for_run("wr_enabled") is True+ assert manager.mask_secrets_enabled_for_run("wr_disabled") is False+ assert manager.mask_secrets_enabled_for_run("missing") is False+ assert manager.mask_secrets_enabled_for_run(None) is False+++def test_get_secret_values_for_run_ignores_workflow_opt_out_when_flag_enabled(+ monkeypatch: pytest.MonkeyPatch,+ workflow_context_manager_factory: Callable[..., WorkflowContextManager],+) -> None:+ monkeypatch.setattr(settings, "ENABLE_SECRET_ARTIFACT_REDACTION", True)+ manager = workflow_context_manager_factory(+ workflow_run_id="wr_1",+ mask_secrets=False,+ secrets={"password": "super-secret"},+ )++ assert manager.get_secret_values_for_run("wr_1") == {"super-secret"}+ assert manager.get_secret_values_for_run("wr_1", respect_artifact_redaction_flag=False) == {"super-secret"}+++def test_get_secret_values_for_run_returns_empty_when_global_flag_disabled(+ monkeypatch: pytest.MonkeyPatch,+ workflow_context_manager_factory: Callable[..., WorkflowContextManager],+) -> None:monkeypatch.setattr(settings, "ENABLE_SECRET_ARTIFACT_REDACTION", False)- manager = WorkflowContextManager()- manager.workflow_run_contexts["wr_1"] = SimpleNamespace(secrets={"password": "super-secret"})+ manager = workflow_context_manager_factory(+ workflow_run_id="wr_1",+ secrets={"password": "super-secret"},+ )assert manager.get_secret_values_for_run("wr_1") == set()assert manager.get_secret_values_for_run("wr_1", respect_artifact_redaction_flag=False) == {"super-secret"}@@ -278,16 +312,17 @@ def test_get_secret_values_for_run_respects_artifact_redaction_flag(monkeypatch:def test_get_secret_values_for_run_returns_filtered_context_and_current_totp_values(monkeypatch: pytest.MonkeyPatch,+ workflow_context_manager_factory: Callable[..., WorkflowContextManager],) -> None:monkeypatch.setattr(settings, "ENABLE_SECRET_ARTIFACT_REDACTION", True)- manager = WorkflowContextManager()- manager.workflow_run_contexts["wr_1"] = SimpleNamespace(+ manager = workflow_context_manager_factory(+ workflow_run_id="wr_1",secrets={"password": "super-secret","short_numeric": "587","placeholder_x1y2_password": "placeholder_x1y2_password","sentinel": "OP_TOTP",- }+ },)with skyvern_context.scoped(SkyvernContext(totp_codes={"task_1": "654321", "task_2": None})):@@ -296,10 +331,13 @@ def test_get_secret_values_for_run_returns_filtered_context_and_current_totp_valassert values == {"super-secret", "654321"}-def test_get_secret_values_for_run_can_exclude_runtime_otp_values(monkeypatch: pytest.MonkeyPatch) -> None:+def test_get_secret_values_for_run_can_exclude_runtime_otp_values(+ monkeypatch: pytest.MonkeyPatch,+ workflow_context_manager_factory: Callable[..., WorkflowContextManager],+) -> None:monkeypatch.setattr(settings, "ENABLE_SECRET_ARTIFACT_REDACTION", True)- manager = WorkflowContextManager()- manager.workflow_run_contexts["wr_1"] = SimpleNamespace(+ manager = workflow_context_manager_factory(+ workflow_run_id="wr_1",secrets={"placeholder_ab_pw": "hunter2secret","placeholder_cd_otp": "483920",@@ -311,10 +349,13 @@ def test_get_secret_values_for_run_can_exclude_runtime_otp_values(monkeypatch: passert manager.get_secret_values_for_run("wr_1", exclude_runtime_otp=True) == {"hunter2secret"}-def test_get_secret_values_for_run_collects_short_runtime_otp_values(monkeypatch: pytest.MonkeyPatch) -> None:+def test_get_secret_values_for_run_collects_short_runtime_otp_values(+ monkeypatch: pytest.MonkeyPatch,+ workflow_context_manager_factory: Callable[..., WorkflowContextManager],+) -> None:monkeypatch.setattr(settings, "ENABLE_SECRET_ARTIFACT_REDACTION", True)- manager = WorkflowContextManager()- manager.workflow_run_contexts["wr_1"] = SimpleNamespace(+ manager = workflow_context_manager_factory(+ workflow_run_id="wr_1",secrets={"placeholder_ab_pw": "hunter2secret","placeholder_cd_smtp_port": "587",@@ -326,10 +367,12 @@ def test_get_secret_values_for_run_collects_short_runtime_otp_values(monkeypatchassert manager.get_secret_values_for_run("wr_1", exclude_runtime_otp=True) == {"hunter2secret"}-def test_get_secret_values_for_run_skips_totp_cache_metadata(monkeypatch: pytest.MonkeyPatch) -> None:+def test_get_secret_values_for_run_skips_totp_cache_metadata(+ monkeypatch: pytest.MonkeyPatch,+ workflow_context_manager_factory: Callable[..., WorkflowContextManager],+) -> None:monkeypatch.setattr(settings, "ENABLE_SECRET_ARTIFACT_REDACTION", True)- manager = WorkflowContextManager()- manager.workflow_run_contexts["wr_1"] = SimpleNamespace(secrets={}, runtime_otp_values=set())+ manager = workflow_context_manager_factory(workflow_run_id="wr_1")with skyvern_context.scoped(SkyvernContext(diff --git a/tests/unit/workflow/test_code_block_escalation.py b/tests/unit/workflow/test_code_block_escalation.pyindex 56fc255cb..ed1486b7b 100644--- a/tests/unit/workflow/test_code_block_escalation.py+++ b/tests/unit/workflow/test_code_block_escalation.py@@ -72,6 +72,7 @@ def _make_context(workflow_permanent_id="wpid_test",workflow_run_id="wr_test",aws_client=MagicMock(),+ mask_secrets=with_secret,)if with_secret:context.secrets["k_secret"] = SECRET_VALUEdiff --git a/tests/unit/workflow/test_code_block_recorder.py b/tests/unit/workflow/test_code_block_recorder.pyindex 52dd7966d..ec50b90b7 100644--- a/tests/unit/workflow/test_code_block_recorder.py+++ b/tests/unit/workflow/test_code_block_recorder.py@@ -410,6 +410,7 @@ class FakeWorkflowRunContext:workflow_run_id = "wr_test"browser_session_id = Noneworkflow = None+ mask_secrets = Truedef __init__(self, secrets: dict[str, str] | None = None) -> None:self.secrets = secrets or {}diff --git a/tests/unit/workflow/test_http_request_block.py b/tests/unit/workflow/test_http_request_block.pyindex 637bcc916..34a3c61a1 100644--- a/tests/unit/workflow/test_http_request_block.py+++ b/tests/unit/workflow/test_http_request_block.py@@ -34,6 +34,7 @@ def _make_context(context.workflow_permanent_id = "wpid-1"context.workflow_run_id = "wr-1"context.browser_session_id = None+ context.mask_secrets = Falsereturn context