Skip to content

Automate browser based workflows with AI

fix(SKY-11228): focus newly added block in workflow editor (#6809)

Celal Zamanoğlu69d09b580ee3
diff --git a/skyvern-frontend/src/routes/workflows/editor/Workspace.tsx b/skyvern-frontend/src/routes/workflows/editor/Workspace.tsx
index f37228783..afaacfee5 100644
--- a/skyvern-frontend/src/routes/workflows/editor/Workspace.tsx
+++ b/skyvern-frontend/src/routes/workflows/editor/Workspace.tsx
@@ -1309,6 +1309,7 @@ function Workspace({
position: previousNodeIndex + 1,
});
doLayout(newNodesAfter, [...editedEdges, ...newEdges]);
+ useWorkflowPanelStore.getState().setSelectedBlockId(id);
}
const orderedBlockLabels = getOrderedBlockLabels(workflow);
diff --git a/skyvern-frontend/src/store/WorkflowPanelStore.test.ts b/skyvern-frontend/src/store/WorkflowPanelStore.test.ts
new file mode 100644
index 000000000..7e8e2fbee
--- /dev/null
+++ b/skyvern-frontend/src/store/WorkflowPanelStore.test.ts
@@ -0,0 +1,33 @@
+// @vitest-environment jsdom
+
+import { beforeEach, describe, expect, test } from "vitest";
+
+import { useWorkflowPanelStore } from "./WorkflowPanelStore";
+
+beforeEach(() => {
+ useWorkflowPanelStore.setState({
+ workflowPanelState: { active: false, content: "parameters" },
+ selectedBlockId: null,
+ });
+});
+
+describe("WorkflowPanelStore", () => {
+ test("setSelectedBlockId replaces any prior selection", () => {
+ const store = useWorkflowPanelStore.getState();
+ store.setSelectedBlockId("block-a");
+ store.setSelectedBlockId("block-b");
+ expect(useWorkflowPanelStore.getState().selectedBlockId).toBe("block-b");
+ });
+
+ test("closeWorkflowPanel deactivates the panel but preserves selectedBlockId", () => {
+ const store = useWorkflowPanelStore.getState();
+ store.setWorkflowPanelState({ active: true, content: "nodeLibrary" });
+ store.setSelectedBlockId("block-1");
+
+ useWorkflowPanelStore.getState().closeWorkflowPanel();
+
+ const next = useWorkflowPanelStore.getState();
+ expect(next.workflowPanelState.active).toBe(false);
+ expect(next.selectedBlockId).toBe("block-1");
+ });
+});
diff --git a/skyvern-frontend/src/store/WorkflowPanelStore.ts b/skyvern-frontend/src/store/WorkflowPanelStore.ts
index 13d6a6857..2681c50f0 100644
--- a/skyvern-frontend/src/store/WorkflowPanelStore.ts
+++ b/skyvern-frontend/src/store/WorkflowPanelStore.ts
@@ -53,6 +53,8 @@ const useWorkflowPanelStore = create<WorkflowPanelStore>((set, get) => {
set({ workflowPanelState });
},
closeWorkflowPanel: () => {
+ // Must not clear selectedBlockId: addNode selects the new block, then the
+ // node-library panel closes; the selection has to survive that close.
set({
workflowPanelState: {
...get().workflowPanelState,