Automate browser based workflows with AI
Python aiapiautomationbrowserbrowser-automationcomputergptllmplaywrightpowerautomatepuppeteerpythonrpaseleniumvisionworkflow
SKY-14030: isolate disabled-control retry cadence (#8195)
Aaron Perez6ec6a21f4618
diff --git a/skyvern/webeye/actions/handler.py b/skyvern/webeye/actions/handler.pyindex e409d3e2a..1d904120a 100644--- a/skyvern/webeye/actions/handler.py+++ b/skyvern/webeye/actions/handler.py@@ -208,6 +208,15 @@ from skyvern.webeye.utils.page import (LOG = structlog.get_logger()++async def _totp_window_sleep(delay: float) -> None:+ await asyncio.sleep(delay)+++async def _upload_settle_sleep(delay: float) -> None:+ await asyncio.sleep(delay)++UPLOAD_PENDING_FOLLOWUP_MESSAGE = "Upload is not complete yet. Continue the upload flow."DOWNLOAD_NOT_TRIGGERED_FOLLOWUP_MESSAGE = (@@ -5037,7 +5046,7 @@ async def _handle_multi_field_totp_sequence(totp=current_totp,)- await asyncio.sleep(wait_seconds)+ await _totp_window_sleep(wait_seconds)LOG.debug("6th digit: Finished waiting, TOTP is now valid",@@ -6124,7 +6133,7 @@ async def _wait_for_upload_processing(page: Page, engine_selection: BrowserEngintry:# Settle delay: let the page react to the file-input change and mount# upload UI (spinner, progress bar, XHR) before polling for readiness.- await asyncio.sleep(0.5)+ await _upload_settle_sleep(0.5)skyvern_frame = await SkyvernFrame.create_instance(page, engine_selection=engine_selection)await skyvern_frame.wait_for_page_ready(loading_indicator_timeout_ms=3000,diff --git a/tests/unit/test_multi_field_totp.py b/tests/unit/test_multi_field_totp.pyindex a1477317c..5964a5a37 100644--- a/tests/unit/test_multi_field_totp.py+++ b/tests/unit/test_multi_field_totp.py@@ -437,7 +437,7 @@ class TestHandleMultiFieldTotpSequence:patch("skyvern.webeye.actions.handler.skyvern_context.ensure_context", return_value=context),patch("skyvern.webeye.actions.handler.parse_totp_config", return_value=fake_totp),patch("skyvern.webeye.actions.handler.time.time", return_value=44),- patch("skyvern.webeye.actions.handler.asyncio.sleep", new_callable=AsyncMock) as sleep_mock,+ patch("skyvern.webeye.actions.handler._totp_window_sleep", new_callable=AsyncMock) as sleep_mock,):result = await _handle_multi_field_totp_sequence({"action_index": 5, "totp_secret": "otpauth://totp/example?secret=abc"},diff --git a/tests/unit/test_script_skyvern_page.py b/tests/unit/test_script_skyvern_page.pyindex f260915ee..9b77a4bb1 100644--- a/tests/unit/test_script_skyvern_page.py+++ b/tests/unit/test_script_skyvern_page.py@@ -12,7 +12,7 @@ import inspectimport reimport timefrom types import SimpleNamespace-from unittest.mock import AsyncMock, MagicMock, call, patch+from unittest.mock import AsyncMock, MagicMock, patchimport pytestfrom playwright.async_api import TimeoutError as PlaywrightTimeoutError@@ -2632,10 +2632,6 @@ async def test_guarded_direct_fill_never_releases_to_a_cross_origin_element_fram# =============================================================================# Tests for selector fallback prep opt-out — SKY-12096-#-# Patching skyvern_page.asyncio.sleep rebinds the GLOBAL asyncio.sleep, so the mock also-# records sleeps from coroutines running on other threads' event loops. Assert on locator-# behavior or on this path's own sleep values — never on bare await_args.# =============================================================================@@ -2645,19 +2641,17 @@ async def test_selector_fallback_default_runs_element_prep(mock_scraped_page, molocator = _RecordingLocator()skyvern_page = _skyvern_page_with_locator(mock_ai, locator)- with patch("skyvern.core.script_generations.skyvern_page.asyncio.sleep", new_callable=AsyncMock) as sleep:- if action == "click":- result = await skyvern_page.click("#target")- elif action == "fill":- result = await skyvern_page.fill("#target", "Noor")- else:- result = await skyvern_page.type("#target", "Noor")+ if action == "click":+ result = await skyvern_page.click("#target")+ elif action == "fill":+ result = await skyvern_page.fill("#target", "Noor")+ else:+ result = await skyvern_page.type("#target", "Noor")assert result in ("#target", "Noor")assert ("wait_for", "attached") in locator.callsassert ("wait_for", "visible") in locator.callsassert ("scroll_into_view_if_needed", None) in locator.calls- assert call(0.15) in sleep.await_args_list@pytest.mark.asyncio@@ -2670,18 +2664,16 @@ async def test_selector_fallback_prep_opt_out_uses_playwright_actionability(locator = _RecordingLocator()skyvern_page = _skyvern_page_with_locator(mock_ai, locator)- with patch("skyvern.core.script_generations.skyvern_page.asyncio.sleep", new_callable=AsyncMock) as sleep:- if action == "click":- result = await skyvern_page.click("#target", _skip_element_prep=True)- elif action == "fill":- result = await skyvern_page.fill("#target", "Noor", _skip_element_prep=True)- else:- result = await skyvern_page.type("#target", "Noor", _skip_element_prep=True)+ if action == "click":+ result = await skyvern_page.click("#target", _skip_element_prep=True)+ elif action == "fill":+ result = await skyvern_page.fill("#target", "Noor", _skip_element_prep=True)+ else:+ result = await skyvern_page.type("#target", "Noor", _skip_element_prep=True)assert result in ("#target", "Noor")assert not any(recorded[0] == "wait_for" for recorded in locator.calls)assert ("scroll_into_view_if_needed", None) not in locator.calls- assert call(0.15) not in sleep.await_args_list@pytest.mark.asynciodiff --git a/tests/unit/test_upload_file_wait.py b/tests/unit/test_upload_file_wait.pyindex 41f012440..518b38b38 100644--- a/tests/unit/test_upload_file_wait.py+++ b/tests/unit/test_upload_file_wait.py@@ -6,7 +6,7 @@ import astimport asyncioimport inspectimport textwrap-from unittest.mock import AsyncMock, MagicMock, Mock, patch+from unittest.mock import AsyncMock, MagicMock, Mock, call, patchimport pytestfrom playwright._impl._errors import Error as PlaywrightError@@ -62,9 +62,13 @@ async def test_calls_wait_for_page_ready_with_settle_delay() -> None:mock_frame = AsyncMock()with (patch("skyvern.webeye.actions.handler.SkyvernFrame.create_instance", new_callable=AsyncMock) as mock_create,- patch("skyvern.webeye.actions.handler.asyncio.sleep", new_callable=AsyncMock) as mock_sleep,+ patch("skyvern.webeye.actions.handler._upload_settle_sleep", new_callable=AsyncMock) as mock_sleep,):mock_create.return_value = mock_frame+ sequence = MagicMock()+ sequence.attach_mock(mock_sleep, "sleep")+ sequence.attach_mock(mock_create, "create_frame")+ sequence.attach_mock(mock_frame.wait_for_page_ready, "wait_for_page_ready")await _wait_for_upload_processing(page, engine_selection=engine_selection)# Settle delay before readiness polling@@ -76,6 +80,16 @@ async def test_calls_wait_for_page_ready_with_settle_delay() -> None:dom_stable_ms=300,dom_stability_timeout_ms=2000,)+ assert sequence.mock_calls == [+ call.sleep(0.5),+ call.create_frame(page, engine_selection=engine_selection),+ call.wait_for_page_ready(+ loading_indicator_timeout_ms=3000,+ network_idle_timeout_ms=3000,+ dom_stable_ms=300,+ dom_stability_timeout_ms=2000,+ ),+ ]@pytest.mark.asynciodiff --git a/tests/unit_tests/test_streaming_screencast.py b/tests/unit_tests/test_streaming_screencast.pyindex dc6082776..1916f53e8 100644--- a/tests/unit_tests/test_streaming_screencast.py+++ b/tests/unit_tests/test_streaming_screencast.py@@ -96,7 +96,7 @@ async def test_wait_for_browser_state_returns_when_working_page_is_available(resolve_mock = AsyncMock(return_value=browser_state)sleep_mock = AsyncMock()monkeypatch.setattr(screencast, "_resolve_browser_state", resolve_mock)- monkeypatch.setattr(screencast.asyncio, "sleep", sleep_mock)+ monkeypatch.setattr(screencast, "asyncio", SimpleNamespace(sleep=sleep_mock))result = await screencast.wait_for_browser_state("wr_123", "workflow_run", timeout=1, poll_interval=0.1)