Automate browser based workflows with AI
Python aiapiautomationbrowserbrowser-automationcomputergptllmplaywrightpowerautomatepuppeteerpythonrpaseleniumvisionworkflow
fix(SKY-9402): add needs_followup + followup_message for deferred upload action history (#6198)
LawyZheng71a40fb93bbe
diff --git a/skyvern/services/action_service.py b/skyvern/services/action_service.pyindex 65b3bbe87..aca5bdb05 100644--- a/skyvern/services/action_service.py+++ b/skyvern/services/action_service.py@@ -54,6 +54,8 @@ async def get_action_history("exception_message","download_triggered","upload_file_triggered",+ "needs_followup",+ "followup_message",},),}diff --git a/skyvern/webeye/actions/handler.py b/skyvern/webeye/actions/handler.pyindex f09de0f15..3f1614ebf 100644--- a/skyvern/webeye/actions/handler.py+++ b/skyvern/webeye/actions/handler.py@@ -138,6 +138,8 @@ from skyvern.webeye.utils.page import SkyvernFrameLOG = structlog.get_logger()+UPLOAD_PENDING_FOLLOWUP_MESSAGE = "Upload is not complete yet. Continue the upload flow."+DOWNLOAD_EVENT_ACTIVE_DIR_GRACE_SECONDS = 60DOWNLOAD_DUPLICATE_STEM_SUFFIX_RE = re.compile(r"(?:\s+\(\d{1,3}\)|_\d{1,3})$")@@ -3453,6 +3455,9 @@ async def chain_click(for r in action_results:if isinstance(r, ActionSuccess):r.upload_file_triggered = is_filechooser_trigger+ if not is_filechooser_trigger:+ r.needs_followup = True+ r.followup_message = UPLOAD_PENDING_FOLLOWUP_MESSAGE@traced(name="skyvern.agent.dropdown.auto_completion")diff --git a/skyvern/webeye/actions/responses.py b/skyvern/webeye/actions/responses.pyindex aeea6dbdc..f1ececb6d 100644--- a/skyvern/webeye/actions/responses.py+++ b/skyvern/webeye/actions/responses.py@@ -15,6 +15,8 @@ class ActionResult(BaseModel):step_order: int | None = Nonedownload_triggered: bool | None = Noneupload_file_triggered: bool | None = None+ needs_followup: bool | None = None+ followup_message: str | None = Nonedownloaded_files: list[str] | None = None # Actual file names that were downloaded# None is used for old data so that we can differentiate between old and new data which only has booleaninteracted_with_sibling: bool | None = None@@ -37,6 +39,10 @@ class ActionResult(BaseModel):results.append(f"download_triggered={self.download_triggered}")if self.upload_file_triggered is not None:results.append(f"upload_file_triggered={self.upload_file_triggered}")+ if self.needs_followup is not None:+ results.append(f"needs_followup={self.needs_followup}")+ if self.followup_message is not None:+ results.append(f"followup_message={self.followup_message}")if self.downloaded_files is not None:results.append(f"downloaded_files={self.downloaded_files}")if self.interacted_with_sibling is not None:diff --git a/tests/unit/test_upload_pending_action_history.py b/tests/unit/test_upload_pending_action_history.pynew file mode 100644index 000000000..29cb93790--- /dev/null+++ b/tests/unit/test_upload_pending_action_history.py@@ -0,0 +1,66 @@+from skyvern.webeye.actions.handler import UPLOAD_PENDING_FOLLOWUP_MESSAGE+from skyvern.webeye.actions.responses import ActionResult, ActionSuccess+++class TestUploadFollowupActionHistory:+ def test_followup_message_field_exists(self):+ r = ActionResult(success=True)+ assert r.followup_message is None++ def test_followup_message_set_on_deferred_upload(self):+ r = ActionSuccess()+ r.upload_file_triggered = False+ r.followup_message = UPLOAD_PENDING_FOLLOWUP_MESSAGE+ assert r.success is True+ assert r.upload_file_triggered is False+ assert r.followup_message == UPLOAD_PENDING_FOLLOWUP_MESSAGE++ def test_followup_message_absent_on_successful_upload(self):+ r = ActionSuccess()+ r.upload_file_triggered = True+ assert r.followup_message is None++ def test_followup_message_in_str_representation(self):+ r = ActionSuccess()+ r.upload_file_triggered = False+ r.followup_message = UPLOAD_PENDING_FOLLOWUP_MESSAGE+ s = str(r)+ assert "followup_message=" in s++ def test_followup_message_in_model_dump(self):+ r = ActionSuccess()+ r.upload_file_triggered = False+ r.followup_message = UPLOAD_PENDING_FOLLOWUP_MESSAGE+ d = r.model_dump(+ exclude_none=True,+ include={"success", "upload_file_triggered", "followup_message"},+ )+ assert d["success"] is True+ assert d["upload_file_triggered"] is False+ assert d["followup_message"] == UPLOAD_PENDING_FOLLOWUP_MESSAGE++ def test_no_followup_message_in_dump_when_none(self):+ r = ActionSuccess()+ r.upload_file_triggered = True+ d = r.model_dump(+ exclude_none=True,+ include={"success", "upload_file_triggered", "followup_message"},+ )+ assert "followup_message" not in d++ def test_needs_followup_set_on_deferred(self):+ r = ActionSuccess()+ r.needs_followup = True+ r.followup_message = UPLOAD_PENDING_FOLLOWUP_MESSAGE+ d = r.model_dump(+ exclude_none=True,+ include={"success", "needs_followup", "followup_message"},+ )+ assert d["needs_followup"] is True+ assert d["followup_message"] == UPLOAD_PENDING_FOLLOWUP_MESSAGE++ def test_needs_followup_absent_by_default(self):+ r = ActionSuccess()+ d = r.model_dump(exclude_none=True)+ assert "needs_followup" not in d+ assert "followup_message" not in d