Skip to content

Automate browser based workflows with AI

Fix recording refinement tool surface (#8546)

Cindy Li71fc88d2c367
diff --git a/skyvern/forge/sdk/copilot/browser_ablation.py b/skyvern/forge/sdk/copilot/browser_ablation.py
index d8ca182b9..a72a719af 100644
--- a/skyvern/forge/sdk/copilot/browser_ablation.py
+++ b/skyvern/forge/sdk/copilot/browser_ablation.py
@@ -253,12 +253,18 @@ def resolve_copilot_tool_surface(
# A turn without browser authority advertises no tool that would need one, rather than
# advertising them and refusing at dispatch.
selected = [tool for tool in native_tools if tool.name not in BROWSER_BOUND_TOOL_NAMES]
+ selected_aliases = {
+ name: transport_name
+ for name, transport_name in alias_map.items()
+ if not getattr(overlays[name], "requires_browser", False)
+ }
+ selected_overlays = {name: overlays[name] for name in selected_aliases}
return CopilotToolSurface(
native_tools=tuple(selected),
- alias_map={},
- overlays={},
+ alias_map=selected_aliases,
+ overlays=selected_overlays,
ordered_native_names=tuple(tool.name for tool in selected),
- ordered_mcp_names=(),
+ ordered_mcp_names=tuple(selected_aliases),
)
if mode is None or mode in REPAIR_PROBE_MODES:
diff --git a/skyvern/services/browser_recording/evidence.py b/skyvern/services/browser_recording/evidence.py
index 6c60b3dc9..0ba90bce0 100644
--- a/skyvern/services/browser_recording/evidence.py
+++ b/skyvern/services/browser_recording/evidence.py
@@ -100,14 +100,17 @@ def _redact_input_values(value: str | None, input_values: list[str]) -> str | No
if value is None:
return None
redacted = value
- variants = {
- variant
- for input_value in input_values
- if input_value
- for variant in (input_value, quote(input_value, safe=""), quote_plus(input_value, safe=""))
- }
- for variant in sorted(variants, key=len, reverse=True):
- redacted = redacted.replace(variant, _REDACTED_INPUT)
+ variants: dict[str, bool] = {}
+ for input_value in input_values:
+ if not input_value:
+ continue
+ for variant in (input_value, quote(input_value, safe=""), quote_plus(input_value, safe="")):
+ variants[variant] = variants.get(variant, False) or len(input_value) >= 3
+ for variant, replace_anywhere in sorted(variants.items(), key=lambda item: len(item[0]), reverse=True):
+ if replace_anywhere:
+ redacted = redacted.replace(variant, _REDACTED_INPUT)
+ else:
+ redacted = re.sub(rf"(?<![\w.-]){re.escape(variant)}(?![\w.-])", _REDACTED_INPUT, redacted)
return redacted
diff --git a/tests/unit/forge/sdk/copilot/test_browser_ablation_mode.py b/tests/unit/forge/sdk/copilot/test_browser_ablation_mode.py
index 96925e659..ab28dc9cc 100644
--- a/tests/unit/forge/sdk/copilot/test_browser_ablation_mode.py
+++ b/tests/unit/forge/sdk/copilot/test_browser_ablation_mode.py
@@ -151,9 +151,10 @@ def test_a_turn_without_browser_authority_advertises_no_browser_tool() -> None:
assert BROWSER_BOUND_TOOL_NAMES.isdisjoint(withheld.ordered_native_names)
assert withheld.ordered_native_names
- assert withheld.alias_map == {}
- assert withheld.overlays == {}
- assert withheld.ordered_mcp_names == ()
+ assert withheld.ordered_mcp_names == ("get_workflow_knowledge", "get_block_schema", "validate_block")
+ assert withheld.alias_map == {name: aliases[name] for name in withheld.ordered_mcp_names}
+ assert withheld.overlays == {name: overlays[name] for name in withheld.ordered_mcp_names}
+ assert all(not overlay.requires_browser for overlay in withheld.overlays.values())
assert BROWSER_BOUND_TOOL_NAMES <= set(granted.ordered_native_names)
assert granted.alias_map == aliases
assert granted.overlays == overlays
diff --git a/tests/unit/services/test_browser_recording_evidence.py b/tests/unit/services/test_browser_recording_evidence.py
index 4e6241fcd..ef7197137 100644
--- a/tests/unit/services/test_browser_recording_evidence.py
+++ b/tests/unit/services/test_browser_recording_evidence.py
@@ -86,6 +86,46 @@ def test_typed_values_are_redacted_from_later_target_metadata() -> None:
assert "[REDACTED_INPUT]" in serialized
+def test_short_typed_values_do_not_corrupt_unrelated_metadata() -> None:
+ input_action = make_input(1000, "a", selector="#query", input_type="text")
+ input_action.url = "https://example.com/search?q=a"
+ result = make_click(
+ 2000,
+ selector='[data-query="a"]',
+ accessible_name="Open a result",
+ texts=["Result a"],
+ )
+
+ packet = build_recording_evidence(
+ [input_action, result],
+ None,
+ browser_session_id=PBS_ID,
+ workflow_permanent_id=WP_ID,
+ recording_attempt_id="rra_test",
+ )
+
+ assert packet.actions[0].url == "https://example.com/search?q=[REDACTED_INPUT]"
+ assert packet.actions[1].target is not None
+ assert packet.actions[1].target.selector_candidates == ['[data-query="[REDACTED_INPUT]"]']
+ assert packet.actions[1].target.accessible_name == "Open [REDACTED_INPUT] result"
+ assert packet.actions[1].target.visible_texts == ["Result [REDACTED_INPUT]"]
+
+
+def test_encoded_short_typed_values_only_redact_standalone_matches() -> None:
+ input_action = make_input(1000, "?", selector="#query", input_type="text")
+ input_action.url = "https://example.com/path%3Fhelp?q=%3F"
+
+ packet = build_recording_evidence(
+ [input_action],
+ None,
+ browser_session_id=PBS_ID,
+ workflow_permanent_id=WP_ID,
+ recording_attempt_id="rra_test",
+ )
+
+ assert packet.actions[0].url == "https://example.com/path%3Fhelp?q=[REDACTED_INPUT]"
+
+
def test_draft_overlay_tracks_deleted_actions_and_labels() -> None:
kept = make_click(1000, selector="#keep")
deleted = make_click(2000, selector="#delete")