Automate browser based workflows with AI
Python aiapiautomationbrowserbrowser-automationcomputergptllmplaywrightpowerautomatepuppeteerpythonrpaseleniumvisionworkflow
fix: upload downloaded files to S3 in cached download path (#5105)
Shuchang Zheng7260dea99923
diff --git a/skyvern/services/script_service.py b/skyvern/services/script_service.pyindex e308a6a4f..5afdf84e6 100644--- a/skyvern/services/script_service.py+++ b/skyvern/services/script_service.py@@ -17,7 +17,7 @@ from fastapi import BackgroundTasks, HTTPExceptionfrom jinja2.sandbox import SandboxedEnvironmentfrom skyvern.config import settings-from skyvern.constants import GET_DOWNLOADED_FILES_TIMEOUT+from skyvern.constants import GET_DOWNLOADED_FILES_TIMEOUT, SAVE_DOWNLOADED_FILES_TIMEOUTfrom skyvern.core.script_generations.constants import SCRIPT_TASK_BLOCKSfrom skyvern.core.script_generations.generate_script import _build_block_fn, create_or_update_script_blockfrom skyvern.core.script_generations.script_skyvern_page import script_run_context_manager@@ -1839,6 +1839,17 @@ async def download(await _run_cached_function(cached_fn)+ # Upload downloaded files from local filesystem to S3 so that+ # get_downloaded_files() (which queries S3) can find them.+ try:+ async with asyncio.timeout(SAVE_DOWNLOADED_FILES_TIMEOUT):+ await app.STORAGE.save_downloaded_files(+ organization_id=org_id,+ run_id=run_id,+ )+ except asyncio.TimeoutError:+ LOG.warning("Timeout saving downloaded files after cached download")+# Verify a new file was actually downloaded.# Retry briefly — file may not be visible in storage immediately after the click.files_after: list = []