Skip to content

Automate browser based workflows with AI

dont let users add loop node in another loop node for now (#934)

Kerem Yilmaz750a3f8debdc
diff --git a/skyvern-frontend/src/routes/workflows/editor/edges/EdgeWithAddButton.tsx b/skyvern-frontend/src/routes/workflows/editor/edges/EdgeWithAddButton.tsx
index 545f10af1..12974437a 100644
--- a/skyvern-frontend/src/routes/workflows/editor/edges/EdgeWithAddButton.tsx
+++ b/skyvern-frontend/src/routes/workflows/editor/edges/EdgeWithAddButton.tsx
@@ -56,6 +56,7 @@ function EdgeWithAddButton({
size="icon"
className="h-4 w-4 rounded-full transition-all hover:scale-150"
onClick={() => {
+ const disableLoop = Boolean(sourceNode?.parentId);
setWorkflowPanelState({
active: true,
content: "nodeLibrary",
@@ -63,6 +64,7 @@ function EdgeWithAddButton({
previous: source,
next: target,
parent: sourceNode?.parentId,
+ disableLoop,
},
});
}}
diff --git a/skyvern-frontend/src/routes/workflows/editor/nodes/NodeAdderNode/NodeAdderNode.tsx b/skyvern-frontend/src/routes/workflows/editor/nodes/NodeAdderNode/NodeAdderNode.tsx
index 92407c991..461313767 100644
--- a/skyvern-frontend/src/routes/workflows/editor/nodes/NodeAdderNode/NodeAdderNode.tsx
+++ b/skyvern-frontend/src/routes/workflows/editor/nodes/NodeAdderNode/NodeAdderNode.tsx
@@ -27,6 +27,7 @@ function NodeAdderNode({ id, parentId }: NodeProps<NodeAdderNode>) {
className="rounded-full bg-slate-50 p-2"
onClick={() => {
const previous = edges.find((edge) => edge.target === id)?.source;
+ const disableLoop = Boolean(parentId);
setWorkflowPanelState({
active: true,
content: "nodeLibrary",
@@ -35,6 +36,7 @@ function NodeAdderNode({ id, parentId }: NodeProps<NodeAdderNode>) {
next: id,
parent: parentId,
connectingEdgeType: "default",
+ disableLoop,
},
});
}}
diff --git a/skyvern-frontend/src/routes/workflows/editor/panels/WorkflowNodeLibraryPanel.tsx b/skyvern-frontend/src/routes/workflows/editor/panels/WorkflowNodeLibraryPanel.tsx
index 70f4e737a..19ce984fc 100644
--- a/skyvern-frontend/src/routes/workflows/editor/panels/WorkflowNodeLibraryPanel.tsx
+++ b/skyvern-frontend/src/routes/workflows/editor/panels/WorkflowNodeLibraryPanel.tsx
@@ -106,6 +106,9 @@ function WorkflowNodeLibraryPanel({ onNodeClick, first }: Props) {
</header>
<div className="space-y-2">
{nodeLibraryItems.map((item) => {
+ if (workflowPanelData?.disableLoop && item.nodeType === "loop") {
+ return null;
+ }
return (
<div
key={item.nodeType}
diff --git a/skyvern-frontend/src/store/WorkflowPanelStore.ts b/skyvern-frontend/src/store/WorkflowPanelStore.ts
index 554e27c90..e4127e9bf 100644
--- a/skyvern-frontend/src/store/WorkflowPanelStore.ts
+++ b/skyvern-frontend/src/store/WorkflowPanelStore.ts
@@ -8,6 +8,7 @@ type WorkflowPanelState = {
next?: string | null;
parent?: string;
connectingEdgeType?: string;
+ disableLoop?: boolean;
};
};