Automate browser based workflows with AI
Python aiapiautomationbrowserbrowser-automationcomputergptllmplaywrightpowerautomatepuppeteerpythonrpaseleniumvisionworkflow
Revert "fix(SKY-9803): expose CLOSE_PAGE when multiple tabs are open" (#5997)
Trevor Cheung79eaa1cdb62e
diff --git a/skyvern-frontend/src/routes/workflows/WorkflowPage.test.tsx b/skyvern-frontend/src/routes/workflows/WorkflowPage.test.tsxnew file mode 100644index 000000000..8078cdfe8--- /dev/null+++ b/skyvern-frontend/src/routes/workflows/WorkflowPage.test.tsx@@ -0,0 +1,96 @@+// @vitest-environment jsdom+import { cleanup, render, screen } from "@testing-library/react";+import { afterEach, describe, expect, it, vi } from "vitest";+import { MemoryRouter, Route, Routes } from "react-router-dom";++import { WorkflowPage } from "./WorkflowPage";++vi.mock("use-debounce", () => ({+ useDebounce: <T,>(value: T): [T] => [value],+}));++vi.mock("@/api/AxiosClient", () => ({+ getClient: vi.fn(),+}));++vi.mock("@/hooks/useCredentialGetter", () => ({+ useCredentialGetter: () => vi.fn(),+}));++vi.mock("@/util/env", () => ({+ useNewRunsUrl: false,+}));++vi.mock("@/components/StatusFilterDropdown", () => ({+ StatusFilterDropdown: () => <div data-testid="status-filter" />,+}));++vi.mock("@/components/TableSearchInput", () => ({+ TableSearchInput: () => <input aria-label="Search runs by parameter" />,+}));++vi.mock("./WorkflowActions", () => ({+ WorkflowActions: () => <div data-testid="workflow-actions" />,+}));++vi.mock("./workflowRun/RunParametersDialog", () => ({+ RunParametersDialog: () => null,+}));++vi.mock("./hooks/useWorkflowQuery", () => ({+ useWorkflowQuery: () => ({+ data: {+ title: "Test Workflow",+ workflow_definition: { parameters: [] },+ },+ isLoading: false,+ }),+}));++vi.mock("./hooks/useWorkflowRunsQuery", () => ({+ useWorkflowRunsQuery: () => ({+ data: [],+ isLoading: false,+ }),+}));++vi.mock("./hooks/useKeywordSearch", () => ({+ useKeywordSearch: () => ({+ matchesParameter: () => false,+ isSearchActive: false,+ }),+}));++vi.mock("./hooks/useParameterExpansion", () => ({+ useParameterExpansion: () => ({+ expandedRows: new Set<string>(),+ toggleExpanded: vi.fn(),+ setAutoExpandedRows: vi.fn(),+ }),+}));++afterEach(() => {+ cleanup();+ vi.clearAllMocks();+});++function renderWorkflowPage() {+ return render(+ <MemoryRouter initialEntries={["/workflows/wpid_abc123"]}>+ <Routes>+ <Route+ path="/workflows/:workflowPermanentId"+ element={<WorkflowPage />}+ />+ </Routes>+ </MemoryRouter>,+ );+}++describe("WorkflowPage analytics button", () => {+ it("does not render the Analytics link", () => {+ renderWorkflowPage();++ expect(screen.queryByRole("link", { name: /analytics/i })).toBeNull();+ });+});diff --git a/skyvern-frontend/src/routes/workflows/WorkflowPage.tsx b/skyvern-frontend/src/routes/workflows/WorkflowPage.tsxindex 7f02e9600..e4ec1265a 100644--- a/skyvern-frontend/src/routes/workflows/WorkflowPage.tsx+++ b/skyvern-frontend/src/routes/workflows/WorkflowPage.tsx@@ -1,5 +1,4 @@import {- BarChartIcon,LightningBoltIcon,CodeIcon,MixerHorizontalIcon,@@ -42,8 +41,7 @@ import {formatExecutionTime,} from "@/util/timeFormat";import { cn } from "@/util/utils";-import CloudContext from "@/store/CloudContext";-import React, { useContext, useEffect, useState } from "react";+import React, { useEffect, useState } from "react";import {Link,useNavigate,@@ -71,11 +69,9 @@ import { useKeywordSearch } from "./hooks/useKeywordSearch";import { useParameterExpansion } from "./hooks/useParameterExpansion";import { ParameterDisplayInline } from "./components/ParameterDisplayInline";import { getOrderedRunParameters } from "./utils";-import { buildWorkflowAnalyticsPath } from "./workflowAnalyticsPath";function WorkflowPage() {const { workflowPermanentId } = useParams();- const isCloud = useContext(CloudContext);const [searchParams, setSearchParams] = useSearchParams();const page = searchParams.get("page") ? Number(searchParams.get("page")) : 1;const [statusFilters, setStatusFilters] = useState<Array<Status>>([]);@@ -156,14 +152,6 @@ function WorkflowPage() {onSuccessfullyDeleted={() => navigate("/workflows")}/>)}- {isCloud ? (- <Button asChild variant="secondary">- <Link to={buildWorkflowAnalyticsPath(workflowPermanentId)}>- <BarChartIcon className="mr-2 size-4" />- Analytics- </Link>- </Button>- ) : null}<Button asChild variant="secondary"><Link to={`/workflows/${workflowPermanentId}/scripts`}><CodeIcon className="mr-2 size-4" />diff --git a/skyvern-frontend/src/routes/workflows/workflowAnalyticsPath.test.ts b/skyvern-frontend/src/routes/workflows/workflowAnalyticsPath.test.tsdeleted file mode 100644index f1a44f858..000000000--- a/skyvern-frontend/src/routes/workflows/workflowAnalyticsPath.test.ts+++ /dev/null@@ -1,17 +0,0 @@-import { describe, expect, it } from "vitest";--import { buildWorkflowAnalyticsPath } from "./workflowAnalyticsPath";--describe("buildWorkflowAnalyticsPath", () => {- it("links analytics to the workflow comparison selection", () => {- expect(buildWorkflowAnalyticsPath("wpid_abc123")).toBe(- "/analytics?compare=wpid_abc123",- );- });-- it("URL-encodes workflow ids before adding them to the query string", () => {- expect(buildWorkflowAnalyticsPath("wpid space")).toBe(- "/analytics?compare=wpid+space",- );- });-});diff --git a/skyvern-frontend/src/routes/workflows/workflowAnalyticsPath.ts b/skyvern-frontend/src/routes/workflows/workflowAnalyticsPath.tsdeleted file mode 100644index 382a75935..000000000--- a/skyvern-frontend/src/routes/workflows/workflowAnalyticsPath.ts+++ /dev/null@@ -1,7 +0,0 @@-function buildWorkflowAnalyticsPath(workflowPermanentId: string): string {- const params = new URLSearchParams();- params.set("compare", workflowPermanentId);- return `/analytics?${params.toString()}`;-}--export { buildWorkflowAnalyticsPath };