Skip to content

Automate browser based workflows with AI

Add FORCE_NEW_BROWSER_CONTEXT_CDP_FETCH feature flag with async cleanup (#4930)

LawyZheng7aec0da11e08
diff --git a/skyvern/webeye/browser_factory.py b/skyvern/webeye/browser_factory.py
index c51e165f5..981645bc3 100644
--- a/skyvern/webeye/browser_factory.py
+++ b/skyvern/webeye/browser_factory.py
@@ -36,6 +36,8 @@ from skyvern.webeye.cdp_download_interceptor import CDPDownloadInterceptor
LOG = structlog.get_logger()
+
+BrowserCleanupFunc = Callable[[], Awaitable[None]] | None
# Header to signal fresh browser context creation (stripped before sending to websites)
# When set to "true", creates a new incognito-like context instead of reusing existing ones
FRESH_CONTEXT_HEADER = "X-Skyvern-Fresh-Context"
@@ -83,9 +85,6 @@ def parse_extra_headers(extra_http_headers: dict[str, str] | None) -> ParsedBrow
)
-BrowserCleanupFunc = Callable[[], None] | None
-
-
def set_browser_console_log(browser_context: BrowserContext, browser_artifacts: BrowserArtifacts) -> None:
if browser_artifacts.browser_console_log_path is None:
log_path = f"{settings.LOG_PATH}/{datetime.utcnow().strftime('%Y-%m-%d')}/{uuid.uuid4()}.log"
diff --git a/skyvern/webeye/real_browser_state.py b/skyvern/webeye/real_browser_state.py
index 3ce0d8e20..27f8ec755 100644
--- a/skyvern/webeye/real_browser_state.py
+++ b/skyvern/webeye/real_browser_state.py
@@ -425,7 +425,7 @@ class RealBrowserState(BrowserState):
LOG.info("Main browser context and all its pages are closed")
if self.browser_cleanup is not None:
try:
- self.browser_cleanup()
+ await self.browser_cleanup()
LOG.info("Main browser cleanup is executed")
except Exception:
LOG.warning("Failed to execute browser cleanup", exc_info=True)