Automate browser based workflows with AI
Python aiapiautomationbrowserbrowser-automationcomputergptllmplaywrightpowerautomatepuppeteerpythonrpaseleniumvisionworkflow
feat(SKY-11891): restore learned run-class studio pane layout (#7118)
Celal Zamanoğlu7eecd12f828c
diff --git a/skyvern-frontend/src/routes/workflows/RunWorkflowForm.tsx b/skyvern-frontend/src/routes/workflows/RunWorkflowForm.tsxindex e73a33d2a..4e29dd4fb 100644--- a/skyvern-frontend/src/routes/workflows/RunWorkflowForm.tsx+++ b/skyvern-frontend/src/routes/workflows/RunWorkflowForm.tsx@@ -403,10 +403,8 @@ function RunWorkflowForm({queryKey: ["runs"],});if (studioEnabled) {- // A full-run start RESETS the layout: land on the bare ?wr= deep link- // so the run mapping (copilot, browser, overview) applies exactly as- // it does when cold-entering a run — the editor doesn't ride along- // into run-watching. Block runs keep their own append path.+ // A full-run start lands on the bare ?wr= deep link; the learned run+ // layout (or factory copilot,browser,overview) restores via the fallback.navigate(`/agents/${workflowPermanentId}/studio?wr=${response.data.workflow_run_id}`,);diff --git a/skyvern-frontend/src/routes/workflows/studio/StudioPaneDefaults.tsx b/skyvern-frontend/src/routes/workflows/studio/StudioPaneDefaults.tsxindex 9a8dbf817..1a6e5ac17 100644--- a/skyvern-frontend/src/routes/workflows/studio/StudioPaneDefaults.tsx+++ b/skyvern-frontend/src/routes/workflows/studio/StudioPaneDefaults.tsx@@ -67,8 +67,16 @@ export function StudioPaneDefaultsProvider({return learnedEdit ?? defaultPanesForWorkflowState({ hasBlocks });});+ const [learnedRunPanes] = useState<readonly StudioPaneId[] | null>(() =>+ sanitizeLearnedPanes(useStudioShellStore.getState().paneLayouts.run),+ );+const [initialPanes] = useState<readonly StudioPaneId[]>(() =>- resolveOpenPanes(liveSearch(location.search), defaultPanes),+ resolveOpenPanes(+ liveSearch(location.search),+ defaultPanes,+ learnedRunPanes,+ ),);const [clamp, setClamp] = useState<PaneClamp | null>(null);@@ -122,8 +130,14 @@ export function StudioPaneDefaultsProvider({}, []);const value = useMemo(- () => ({ defaultPanes, clamp, notePaneWrite, registerStageElement }),- [defaultPanes, clamp, notePaneWrite, registerStageElement],+ () => ({+ defaultPanes,+ clamp,+ notePaneWrite,+ registerStageElement,+ learnedRunPanes,+ }),+ [defaultPanes, clamp, notePaneWrite, registerStageElement, learnedRunPanes],);return (diff --git a/skyvern-frontend/src/routes/workflows/studio/StudioPaneDefaultsContext.ts b/skyvern-frontend/src/routes/workflows/studio/StudioPaneDefaultsContext.tsindex 9f18937a5..4fd07ab7b 100644--- a/skyvern-frontend/src/routes/workflows/studio/StudioPaneDefaultsContext.ts+++ b/skyvern-frontend/src/routes/workflows/studio/StudioPaneDefaultsContext.ts@@ -17,6 +17,7 @@ export type StudioPaneDefaultsValue = {clamp: PaneClamp | null;notePaneWrite: (change: PaneWrite) => void;registerStageElement: (el: HTMLElement | null) => void;+ learnedRunPanes: readonly StudioPaneId[] | null;};const noop = () => undefined;@@ -29,6 +30,7 @@ export const StudioPaneDefaultsContext = createContext<StudioPaneDefaultsValue>(clamp: null,notePaneWrite: noop,registerStageElement: noop,+ learnedRunPanes: null,},);diff --git a/skyvern-frontend/src/routes/workflows/studio/panes.test.ts b/skyvern-frontend/src/routes/workflows/studio/panes.test.tsindex 9e30c4e63..f38469515 100644--- a/skyvern-frontend/src/routes/workflows/studio/panes.test.ts+++ b/skyvern-frontend/src/routes/workflows/studio/panes.test.ts@@ -110,6 +110,57 @@ describe("panesFromDeepLink", () => {panesFromDeepLink({ runId: null, active: null, blockLabel: null }),).toEqual(["copilot", "browser"]);});++ test("a learned run layout restores on a bare ?wr= entry", () => {+ const learned = ["copilot", "browser", "editor", "overview"] as const;+ expect(+ panesFromDeepLink(+ { runId: "wr_123", active: null, blockLabel: null },+ DEFAULT_STUDIO_PANES,+ learned,+ ),+ ).toEqual(["copilot", "browser", "editor", "overview"]);+ });++ test("learned run layout including editor is restored as-is", () => {+ expect(+ panesFromDeepLink(+ { runId: "wr_123", active: null, blockLabel: null },+ DEFAULT_STUDIO_PANES,+ ["editor", "overview"],+ ),+ ).toEqual(["editor", "overview"]);+ });++ test("block-iterate (?wr= + ?bl=) ignores the learned run layout", () => {+ expect(+ panesFromDeepLink(+ { runId: "wr_123", active: null, blockLabel: "block_1" },+ DEFAULT_STUDIO_PANES,+ ["copilot", "editor"],+ ),+ ).toEqual(["editor", "browser", "overview"]);+ });++ test("?active= alone ignores the learned run layout", () => {+ expect(+ panesFromDeepLink(+ { runId: null, active: "act_1", blockLabel: null },+ DEFAULT_STUDIO_PANES,+ ["editor", "overview"],+ ),+ ).toEqual(["copilot", "browser", "overview"]);+ });++ test("null learned layout falls back to factory run panes", () => {+ expect(+ panesFromDeepLink(+ { runId: "wr_123", active: null, blockLabel: null },+ DEFAULT_STUDIO_PANES,+ null,+ ),+ ).toEqual(["copilot", "browser", "overview"]);+ });});describe("resolveOpenPanes", () => {@@ -165,6 +216,34 @@ describe("resolveOpenPanes", () => {"browser",]);});++ test("?wr= with a learned run layout restores it", () => {+ expect(+ resolveOpenPanes("?wr=wr_123", DEFAULT_STUDIO_PANES, [+ "browser",+ "overview",+ "editor",+ ]),+ ).toEqual(["browser", "overview", "editor"]);+ });++ test("explicit ?panes= wins over the learned run layout", () => {+ expect(+ resolveOpenPanes("?wr=wr_123&panes=copilot", DEFAULT_STUDIO_PANES, [+ "browser",+ "overview",+ ]),+ ).toEqual(["copilot"]);+ });++ test("?wr= + ?bl= ignores the learned run layout", () => {+ expect(+ resolveOpenPanes("?wr=wr_123&bl=block_1", DEFAULT_STUDIO_PANES, [+ "copilot",+ "editor",+ ]),+ ).toEqual(["editor", "browser", "overview"]);+ });});describe("defaultPanesForWorkflowState", () => {diff --git a/skyvern-frontend/src/routes/workflows/studio/panes.ts b/skyvern-frontend/src/routes/workflows/studio/panes.tsindex 8e73fda73..c4574afa6 100644--- a/skyvern-frontend/src/routes/workflows/studio/panes.ts+++ b/skyvern-frontend/src/routes/workflows/studio/panes.ts@@ -144,7 +144,8 @@ export function parsePanesParam(raw: string | null): StudioPaneId[] | null {}// Deep-link → panes mapping when ?panes= is absent: a block-run link lands on-// iterate (Editor leads); any other run reference lands on watch-and-review.+// iterate (Editor leads); a bare run reference restores the learned run layout+// (or falls back to watch-and-review); ?active= alone always opens watch-and-review.export function panesFromDeepLink(params: {runId: string | null;@@ -152,11 +153,17 @@ export function panesFromDeepLink(blockLabel: string | null;},defaultPanes: readonly StudioPaneId[] = DEFAULT_STUDIO_PANES,+ learnedRunPanes?: readonly StudioPaneId[] | null,): StudioPaneId[] {if (params.runId && params.blockLabel) {return ["editor", "browser", "overview"];}- if (params.runId || params.active) {+ if (params.runId) {+ return learnedRunPanes+ ? [...learnedRunPanes]+ : ["copilot", "browser", "overview"];+ }+ if (params.active) {return ["copilot", "browser", "overview"];}return [...defaultPanes];@@ -167,6 +174,7 @@ export function panesFromDeepLink(export function resolveOpenPanes(search: string,defaultPanes: readonly StudioPaneId[] = DEFAULT_STUDIO_PANES,+ learnedRunPanes?: readonly StudioPaneId[] | null,): StudioPaneId[] {const params = new URLSearchParams(search);const explicit = parsePanesParam(params.get(STUDIO_PANES_PARAM));@@ -180,6 +188,7 @@ export function resolveOpenPanes(blockLabel: params.get("bl"),},defaultPanes,+ learnedRunPanes,);}diff --git a/skyvern-frontend/src/routes/workflows/studio/useStudioPanes.ts b/skyvern-frontend/src/routes/workflows/studio/useStudioPanes.tsindex 71cd7fb1c..b96cc0e64 100644--- a/skyvern-frontend/src/routes/workflows/studio/useStudioPanes.ts+++ b/skyvern-frontend/src/routes/workflows/studio/useStudioPanes.ts@@ -38,7 +38,8 @@ type ApplyPanesOptions = Pick<NavigateOptions, "state"> & {export function useStudioPanes() {const location = useLocation();const navigate = useNavigate();- const { defaultPanes, clamp, notePaneWrite } = useStudioPaneDefaults();+ const { defaultPanes, clamp, notePaneWrite, learnedRunPanes } =+ useStudioPaneDefaults();const workflowDeleted = useStudioWorkflowDeletedAt() !== null;const setPaneLayout = useStudioShellStore((s) => s.setPaneLayout);@@ -61,8 +62,9 @@ export function useStudioPanes() {);const panes = useMemo(- () => present(resolveOpenPanes(location.search, defaultPanes)),- [location.search, defaultPanes, present],+ () =>+ present(resolveOpenPanes(location.search, defaultPanes, learnedRunPanes)),+ [location.search, defaultPanes, present, learnedRunPanes],);// The open list as the live URL resolves it right now — what cross-route@@ -70,8 +72,14 @@ export function useStudioPanes() {// continuity rule: in-app actions append, never rearrange or close.const resolveLivePanes = useCallback((): StudioPaneId[] =>- present(resolveOpenPanes(liveSearch(location.search), defaultPanes)),- [location.search, defaultPanes, present],+ present(+ resolveOpenPanes(+ liveSearch(location.search),+ defaultPanes,+ learnedRunPanes,+ ),+ ),+ [location.search, defaultPanes, present, learnedRunPanes],);const applyPanes = useCallback(