Skip to content

Automate browser based workflows with AI

Reject run creation for workflows with no blocks with a 400 (SKY-17343) (#8728)

Cindy Li7f0866f2dcf2
diff --git a/skyvern/exceptions.py b/skyvern/exceptions.py
index 4e5f2da42..7e2ad2eb5 100644
--- a/skyvern/exceptions.py
+++ b/skyvern/exceptions.py
@@ -598,6 +598,14 @@ class WorkflowNotFound(SkyvernHTTPException):
)
+class WorkflowHasNoBlocks(SkyvernHTTPException):
+ def __init__(self, workflow_permanent_id: str) -> None:
+ super().__init__(
+ f"Workflow {workflow_permanent_id} has no blocks to run. Add at least one block before running it.",
+ status_code=HTTPStatus.BAD_REQUEST,
+ )
+
+
class WorkflowNotFoundForWorkflowRun(SkyvernHTTPException):
def __init__(
self,
diff --git a/skyvern/forge/sdk/workflow/models/block.py b/skyvern/forge/sdk/workflow/models/block.py
index 763baea56..3e2f0c391 100644
--- a/skyvern/forge/sdk/workflow/models/block.py
+++ b/skyvern/forge/sdk/workflow/models/block.py
@@ -18692,6 +18692,7 @@ class WorkflowTriggerBlock(Block):
# workflow's engine, so persist that engine on the child run for fidelity even
# though it carries a browser_session_id. None for caller-supplied/parent-shared.
server_owned_browser_type=child_effective_browser_type if created_fresh_session else None,
+ reject_empty_workflow=True,
)
except Exception as e:
error_msg = get_user_facing_exception_message(e)
diff --git a/skyvern/forge/sdk/workflow/service.py b/skyvern/forge/sdk/workflow/service.py
index 9aa989964..e098fafcb 100644
--- a/skyvern/forge/sdk/workflow/service.py
+++ b/skyvern/forge/sdk/workflow/service.py
@@ -71,6 +71,7 @@ from skyvern.exceptions import (
SkyvernHTTPException,
UnrecognizedWorkflowParameters,
WorkflowAttemptDispatchSuperseded,
+ WorkflowHasNoBlocks,
WorkflowNotFound,
WorkflowNotFoundForWorkflowRun,
WorkflowRetryAttemptLookupError,
@@ -3315,6 +3316,7 @@ class WorkflowService:
shares_parent_browser: bool = False,
server_owned_browser_type: str | None = None,
created_by: str | None = None,
+ reject_empty_workflow: bool = False,
) -> WorkflowRun:
"""
Create a workflow run and its parameters. Validate the workflow and the organization. If there are missing
@@ -3345,6 +3347,8 @@ class WorkflowService:
if workflow is None:
LOG.warning(f"Workflow {workflow_permanent_id} not found", workflow_version=version)
raise WorkflowNotFound(workflow_permanent_id=workflow_permanent_id, version=version)
+ if reject_empty_workflow and not workflow.workflow_definition.blocks:
+ raise WorkflowHasNoBlocks(workflow_permanent_id=workflow_permanent_id)
workflow_id = workflow.workflow_id
if workflow_request.proxy_location is None and workflow.proxy_location is not None:
workflow_request.proxy_location = workflow.proxy_location
diff --git a/skyvern/services/workflow_service.py b/skyvern/services/workflow_service.py
index 6d41bb1fb..093673b79 100644
--- a/skyvern/services/workflow_service.py
+++ b/skyvern/services/workflow_service.py
@@ -124,6 +124,7 @@ async def prepare_workflow(
organization=organization,
version=version,
max_steps_override=max_steps,
+ reject_empty_workflow=True,
is_template_workflow=template,
debug_session_id=debug_session_id,
code_gen=code_gen,
diff --git a/tests/unit/test_runs_v2_route.py b/tests/unit/test_runs_v2_route.py
index c40a353ff..b09bd09ad 100644
--- a/tests/unit/test_runs_v2_route.py
+++ b/tests/unit/test_runs_v2_route.py
@@ -1030,7 +1030,24 @@ async def creator_harness(
workflow_permanent_id="wpid_creator",
organization_id=organization.organization_id,
title="Creator Workflow",
- workflow_definition={"blocks": [], "parameters": []},
+ workflow_definition={
+ "blocks": [
+ {
+ "block_type": "goto_url",
+ "label": "navigate",
+ "url": "https://example.com",
+ "output_parameter": {
+ "parameter_type": "output",
+ "key": "navigate_output",
+ "output_parameter_id": "op_creator",
+ "workflow_id": "w_creator",
+ "created_at": "2026-01-01T00:00:00",
+ "modified_at": "2026-01-01T00:00:00",
+ },
+ }
+ ],
+ "parameters": [],
+ },
status="published",
version=1,
)
diff --git a/tests/unit/test_workflow_browser_profile_id.py b/tests/unit/test_workflow_browser_profile_id.py
index baf0f99c7..2512f68c5 100644
--- a/tests/unit/test_workflow_browser_profile_id.py
+++ b/tests/unit/test_workflow_browser_profile_id.py
@@ -8,8 +8,10 @@ from unittest.mock import AsyncMock, Mock, call, patch
import pytest
-from skyvern.exceptions import SkyvernHTTPException
+from skyvern.exceptions import SkyvernHTTPException, WorkflowHasNoBlocks
from skyvern.forge.sdk.core import skyvern_context
+from skyvern.forge.sdk.workflow.models.block import ForLoopBlock
+from skyvern.forge.sdk.workflow.models.parameter import OutputParameter
from skyvern.forge.sdk.workflow.models.workflow import Workflow, WorkflowDefinition, WorkflowRequestBody
from skyvern.forge.sdk.workflow.service import WorkflowService, _workflow_save_fingerprint
from skyvern.schemas.workflows import WorkflowCreateYAMLRequest, WorkflowDefinitionYAML
@@ -930,3 +932,49 @@ async def test_setup_workflow_run_without_credentials_writes_no_sequential_crede
update_mock = mock_app.DATABASE.workflow_runs.update_workflow_run
assert all("sequential_credential_id" not in call.kwargs for call in update_mock.await_args_list)
+
+
+async def test_setup_workflow_run_rejects_empty_workflow_before_creating_run() -> None:
+ service, organization, _ = _make_setup_service(_make_workflow_stub(browser_profile_id=None))
+
+ with patch("skyvern.forge.sdk.workflow.service.app") as mock_app:
+ _configure_setup_app_mocks(mock_app)
+ with pytest.raises(WorkflowHasNoBlocks) as exc_info:
+ await service.setup_workflow_run(
+ request_id="req_test",
+ workflow_request=WorkflowRequestBody(data={}),
+ workflow_permanent_id="wpid_test",
+ organization=organization,
+ reject_empty_workflow=True,
+ )
+
+ assert exc_info.value.status_code == 400
+ cast(AsyncMock, service.create_workflow_run).assert_not_awaited()
+
+
+async def test_setup_workflow_run_allows_empty_loop_block_when_rejecting_empty_workflows() -> None:
+ workflow_stub = _make_workflow_stub(browser_profile_id=None)
+ output_parameter = OutputParameter(
+ key="loop_output",
+ output_parameter_id="op_test",
+ workflow_id="wf_test",
+ created_at=datetime.now(timezone.utc),
+ modified_at=datetime.now(timezone.utc),
+ )
+ empty_loop = ForLoopBlock(label="loop", output_parameter=output_parameter, loop_blocks=[])
+ workflow_stub.workflow_definition = SimpleNamespace(parameters=[], blocks=[empty_loop])
+ service, organization, _ = _make_setup_service(workflow_stub)
+
+ with patch("skyvern.forge.sdk.workflow.service.app") as mock_app:
+ _configure_setup_app_mocks(mock_app)
+ await service.setup_workflow_run(
+ request_id="req_test",
+ workflow_request=WorkflowRequestBody(data={}),
+ workflow_permanent_id="wpid_test",
+ organization=organization,
+ reject_empty_workflow=True,
+ )
+
+ cast(AsyncMock, service.create_workflow_run).assert_awaited_once()