Automate browser based workflows with AI
Python aiapiautomationbrowserbrowser-automationcomputergptllmplaywrightpowerautomatepuppeteerpythonrpaseleniumvisionworkflow
fix(SKY-12246): respect canvas lock for studio block expand/collapse (#7599)
Celal Zamanoğlu7f897afb8cb3
diff --git a/skyvern-frontend/src/routes/workflows/editor/collapse/collapseModeGate.test.ts b/skyvern-frontend/src/routes/workflows/editor/collapse/collapseModeGate.test.tsnew file mode 100644index 000000000..3f22b88c3--- /dev/null+++ b/skyvern-frontend/src/routes/workflows/editor/collapse/collapseModeGate.test.ts@@ -0,0 +1,45 @@+import { describe, expect, test } from "vitest";++import { isCollapseGated } from "./collapseModeGate";++describe("isCollapseGated (SKY-12246)", () => {+ test("returns false when nothing gates collapse", () => {+ expect(+ isCollapseGated({+ isRecording: false,+ isReadOnlyScope: false,+ isCanvasLocked: false,+ }),+ ).toBe(false);+ });++ test("returns true when recording is on", () => {+ expect(+ isCollapseGated({+ isRecording: true,+ isReadOnlyScope: false,+ isCanvasLocked: false,+ }),+ ).toBe(true);+ });++ test("returns true when scope is read-only", () => {+ expect(+ isCollapseGated({+ isRecording: false,+ isReadOnlyScope: true,+ isCanvasLocked: false,+ }),+ ).toBe(true);+ });++ test("returns true when canvas is locked", () => {+ expect(+ isCollapseGated({+ isRecording: false,+ isReadOnlyScope: false,+ isCanvasLocked: true,+ }),+ ).toBe(true);+ });+});diff --git a/skyvern-frontend/src/routes/workflows/editor/collapse/collapseModeGate.ts b/skyvern-frontend/src/routes/workflows/editor/collapse/collapseModeGate.tsnew file mode 100644index 000000000..e046df599--- /dev/null+++ b/skyvern-frontend/src/routes/workflows/editor/collapse/collapseModeGate.ts@@ -0,0 +1,15 @@+// The collapse chevron reshuffles canvas layout, so it follows the same+// freezes as the other canvas mutations (recording, read-only, canvas lock).+export type CollapseModeGateInputs = {+ isRecording: boolean;+ isReadOnlyScope: boolean;+ isCanvasLocked: boolean;+};++export function isCollapseGated({+ isRecording,+ isReadOnlyScope,+ isCanvasLocked,+}: CollapseModeGateInputs): boolean {+ return isRecording || isReadOnlyScope || isCanvasLocked;+}diff --git a/skyvern-frontend/src/routes/workflows/editor/nodes/components/NodeHeader.tsx b/skyvern-frontend/src/routes/workflows/editor/nodes/components/NodeHeader.tsxindex 73da8202a..7af0f5f2f 100644--- a/skyvern-frontend/src/routes/workflows/editor/nodes/components/NodeHeader.tsx+++ b/skyvern-frontend/src/routes/workflows/editor/nodes/components/NodeHeader.tsx@@ -103,6 +103,7 @@ import {import { useIsCanvasLocked } from "../../controls/useIsCanvasLocked";import { isBlockFinallyGated } from "../../sortable/finallyBlockGate";import { collapsibleWorkflowBlockTypes } from "../../collapse/collapsibleBlockTypes";+import { isCollapseGated } from "../../collapse/collapseModeGate";import {useIsBlockCollapsed,useNodeCollapseStore,@@ -889,13 +890,11 @@ function NodeHeader({);}- // Recording mid-collapse would change captured DOM, so freeze only on- // isRecording. Read-only renders (comparison canvases) must not mutate- // the workflow's persisted collapse state — `isReadOnlyScope` (read- // above) is true when FlowRenderer is mounted with `readOnly`, in- // which case the toggle is disabled so a compare-canvas click cannot- // persist collapse state into the editor view the user returns to.- const collapseToggleGated = isRecording || isReadOnlyScope;+ const collapseToggleGated = isCollapseGated({+ isRecording,+ isReadOnlyScope,+ isCanvasLocked,+ });const collapseLabel = isCollapsed ? "Expand block" : "Collapse block";const collapseToggleButton =isCollapsible &&