Skip to content

Automate browser based workflows with AI

feat(SKY-12100): lead session MCP results with app_url + recording_url (#7251)

Marc Kelechava806977ece831
diff --git a/skyvern/cli/core/result.py b/skyvern/cli/core/result.py
index 0d1094e0f..071ce7470 100644
--- a/skyvern/cli/core/result.py
+++ b/skyvern/cli/core/result.py
@@ -29,6 +29,17 @@ _DATA_KEEP_NONE_KEYS = frozenset(
}
)
+# (action, key) pairs whose None value is meaningful only for that specific
+# action, not globally — e.g. a session has no recordings yet. Scoped rather
+# than added to _DATA_KEEP_NONE_KEYS so it doesn't change unrelated tools
+# (skyvern_run_task/skyvern_login also have a recording_url field).
+_ACTION_DATA_KEEP_NONE_KEYS = frozenset(
+ {
+ ("skyvern_browser_session_get", "recording_url"),
+ ("skyvern_browser_session_close", "recording_url"),
+ }
+)
+
def set_concise_responses(enabled: bool) -> None:
global _concise_responses # noqa: PLW0603
@@ -103,7 +114,8 @@ def make_result(
concise_data = {
k: v
for k, v in data.items()
- if k not in _DATA_STRIP_KEYS and (v is not None or k in _DATA_KEEP_NONE_KEYS)
+ if k not in _DATA_STRIP_KEYS
+ and (v is not None or k in _DATA_KEEP_NONE_KEYS or (action, k) in _ACTION_DATA_KEEP_NONE_KEYS)
}
if concise_data:
result["data"] = concise_data
diff --git a/skyvern/cli/mcp_tools/session.py b/skyvern/cli/mcp_tools/session.py
index aab2ac6c0..b8d2e1096 100644
--- a/skyvern/cli/mcp_tools/session.py
+++ b/skyvern/cli/mcp_tools/session.py
@@ -47,12 +47,16 @@ def _should_default_to_cdp() -> tuple[bool, str | None]:
def _session_create_data(
- session_id: str | None, timeout_minutes: int | None, generate_browser_profile: bool
+ session_id: str | None,
+ timeout_minutes: int | None,
+ generate_browser_profile: bool,
+ app_url: str | None = None,
) -> dict[str, Any]:
- data = {
- "session_id": session_id,
- "timeout_minutes": timeout_minutes,
- }
+ data: dict[str, Any] = {}
+ if app_url is not None:
+ data["app_url"] = app_url
+ data["session_id"] = session_id
+ data["timeout_minutes"] = timeout_minutes
if generate_browser_profile:
data["generate_browser_profile"] = True
return data
@@ -96,7 +100,7 @@ async def skyvern_browser_session_create(
local: Annotated[bool, Field(description="Launch local browser instead of cloud")] = False,
headless: Annotated[bool, Field(description="Run local browser in headless mode")] = False,
) -> dict[str, Any]:
- """Create a new browser session to start interacting with websites. Creates a cloud-hosted browser by default with geographic proxy support. This must be called before using any browser tools (navigate, click, extract, etc.).
+ """Create a new browser session to start interacting with websites. Cloud session results include app_url to watch the run live. Creates a cloud-hosted browser by default with geographic proxy support. This must be called before using any browser tools (navigate, click, extract, etc.).
Use local=true for a local Chromium instance.
The session persists across tool calls until explicitly closed.
@@ -183,7 +187,12 @@ async def skyvern_browser_session_create(
return make_result(
"skyvern_browser_session_create",
browser_context=ctx,
- data=_session_create_data(session.browser_session_id, timeout or 60, generate_browser_profile),
+ data=_session_create_data(
+ session.browser_session_id,
+ timeout or 60,
+ generate_browser_profile,
+ app_url=session.app_url,
+ ),
timing_ms=timer.timing_ms,
)
@@ -209,6 +218,15 @@ async def skyvern_browser_session_create(
)
set_current_session(SessionState(browser=browser, context=ctx, api_key_hash=_session_api_key_hash()))
+ app_url: str | None = None
+ if not result.local and result.session_id:
+ try:
+ fetched = await skyvern.get_browser_session(result.session_id)
+ app_url = fetched.app_url
+ except Exception:
+ pass
+ timer.mark("app_url")
+
except ValueError as e:
return make_result(
"skyvern_browser_session_create",
@@ -239,7 +257,12 @@ async def skyvern_browser_session_create(
return make_result(
"skyvern_browser_session_create",
browser_context=ctx,
- data=_session_create_data(result.session_id, result.timeout_minutes, generate_browser_profile),
+ data=_session_create_data(
+ result.session_id,
+ result.timeout_minutes,
+ generate_browser_profile,
+ app_url=app_url,
+ ),
timing_ms=timer.timing_ms,
)
@@ -261,12 +284,27 @@ async def _fetch_session_recording_data(skyvern: Any, sid: str | None) -> dict[s
return {}
+def _session_close_data(session_id: str | None, closed: bool, recording_data: dict[str, Any]) -> dict[str, Any]:
+ data: dict[str, Any] = {}
+ if "app_url" in recording_data:
+ data["app_url"] = recording_data["app_url"]
+ data["session_id"] = session_id
+ data["closed"] = closed
+ if "recordings" in recording_data:
+ recordings = recording_data["recordings"]
+ data["recordings"] = recordings
+ data["recording_url"] = recordings[0]["url"] if recordings else None
+ if "downloaded_files" in recording_data:
+ data["downloaded_files"] = recording_data["downloaded_files"]
+ return data
+
+
async def skyvern_browser_session_close(
session_id: Annotated[str | None, Field(description="Session ID to close (uses current if not specified)")] = None,
) -> dict[str, Any]:
"""Close a browser session when you're done. Frees cloud resources.
- Returns session_id, closed status, plus app_url and recording URLs for the session.
+ Returns session_id and closed status, plus app_url for the live view and recording_url alongside the recordings list.
Closes the specified session or the current active session.
"""
current = get_current_session()
@@ -313,7 +351,7 @@ async def skyvern_browser_session_close(
recording_data = await _fetch_session_recording_data(skyvern, session_id)
return make_result(
"skyvern_browser_session_close",
- data={"session_id": result.session_id, "closed": result.closed, **recording_data},
+ data=_session_close_data(result.session_id, result.closed, recording_data),
timing_ms=timer.timing_ms,
)
@@ -344,7 +382,7 @@ async def skyvern_browser_session_close(
recording_data = await _fetch_session_recording_data(skyvern, closed_id)
return make_result(
"skyvern_browser_session_close",
- data={"session_id": closed_id, "closed": True, **recording_data},
+ data=_session_close_data(closed_id, True, recording_data),
timing_ms=timer.timing_ms,
)
@@ -405,7 +443,10 @@ async def skyvern_browser_session_list() -> dict[str, Any]:
async def skyvern_browser_session_get(
session_id: Annotated[str, "Browser session ID to get details for"],
) -> dict[str, Any]:
- """Get details about a specific browser session -- status, timeout, availability."""
+ """Get details about a specific browser session -- status, timeout, availability.
+
+ The result includes app_url for the live view and recording_url for the first recording.
+ """
with Timer() as timer:
try:
skyvern = get_skyvern()
@@ -425,10 +466,12 @@ async def skyvern_browser_session_get(
recordings = [{"url": r.url, "filename": r.filename} for r in (session.recordings or [])]
downloaded_files = [{"url": f.url, "filename": f.filename} for f in (session.downloaded_files or [])]
+ recording_url = recordings[0]["url"] if recordings else None
return make_result(
"skyvern_browser_session_get",
browser_context=BrowserContext(mode="cloud_session", session_id=session_id) if is_current else None,
data={
+ "app_url": session.app_url,
"session_id": session.browser_session_id,
"status": session.status,
"started_at": session.started_at.isoformat() if session.started_at else None,
@@ -436,8 +479,8 @@ async def skyvern_browser_session_get(
"timeout": session.timeout,
"runnable_id": session.runnable_id,
"is_current": is_current,
- "app_url": session.app_url,
"recordings": recordings,
+ "recording_url": recording_url,
"downloaded_files": downloaded_files,
},
timing_ms=timer.timing_ms,
diff --git a/tests/unit/test_mcp_browser_tools.py b/tests/unit/test_mcp_browser_tools.py
index 472ca65ae..c84a50545 100644
--- a/tests/unit/test_mcp_browser_tools.py
+++ b/tests/unit/test_mcp_browser_tools.py
@@ -8,7 +8,7 @@ from unittest.mock import AsyncMock, MagicMock
import pytest
-from skyvern.cli.core.result import BrowserContext
+from skyvern.cli.core.result import BrowserContext, set_concise_responses
from skyvern.cli.mcp_tools import browser as mcp_browser
from skyvern.cli.mcp_tools import mcp
from skyvern.client.errors import InternalServerError, UnprocessableEntityError
@@ -139,6 +139,38 @@ async def test_skyvern_login_success_returns_run_data(monkeypatch: pytest.Monkey
assert result["data"]["status"] == "completed"
+async def test_skyvern_login_null_recording_url_stays_stripped_in_concise_mode(
+ monkeypatch: pytest.MonkeyPatch,
+) -> None:
+ """skyvern_browser_session_get/close preserve a null recording_url in concise mode via an
+ action-scoped allowlist — unrelated tools like skyvern_login must keep stripping it."""
+ response = SimpleNamespace(
+ run_id="wr_124",
+ status="completed",
+ output={"ok": True},
+ failure_reason=None,
+ recording_url=None,
+ app_url="https://app.example.com/wr_124",
+ )
+ page = _login_page_mock(None)
+ page.agent.login = AsyncMock(return_value=response)
+ context = BrowserContext(mode="cloud_session", session_id="pbs_test")
+ monkeypatch.setattr(mcp_browser, "get_page", AsyncMock(return_value=(page, context)))
+
+ set_concise_responses(True)
+ try:
+ result = await mcp_browser.skyvern_login(
+ credential_type="skyvern",
+ credential_id="cred_123",
+ )
+ finally:
+ set_concise_responses(False)
+
+ assert result["ok"] is True
+ assert "recording_url" not in result["data"]
+
+
@pytest.mark.asyncio
async def test_skyvern_run_task_timeout_returns_timeout_code(monkeypatch: pytest.MonkeyPatch) -> None:
page = SimpleNamespace(agent=SimpleNamespace(run_task=AsyncMock(side_effect=asyncio.TimeoutError())))
diff --git a/tests/unit/test_mcp_session_lifecycle.py b/tests/unit/test_mcp_session_lifecycle.py
index d4d69e18b..d45232dbd 100644
--- a/tests/unit/test_mcp_session_lifecycle.py
+++ b/tests/unit/test_mcp_session_lifecycle.py
@@ -1,5 +1,6 @@
from __future__ import annotations
+import asyncio
from types import SimpleNamespace
from typing import cast
from unittest.mock import AsyncMock, MagicMock
@@ -7,6 +8,7 @@ from unittest.mock import AsyncMock, MagicMock
import pytest
from skyvern.cli.core import client as client_mod
+from skyvern.cli.core import result as result_mod
from skyvern.cli.core import session_manager, session_ops
from skyvern.cli.core.result import BrowserContext
from skyvern.cli.core.session_ops import SessionCloseResult, coerce_proxy_location
@@ -469,6 +471,7 @@ async def test_session_close_with_matching_session_id_closes_browser_handle(monk
)
fake_skyvern = MagicMock()
+ fake_skyvern.get_browser_session = AsyncMock(side_effect=RuntimeError("recording lookup failed"))
monkeypatch.setattr(mcp_session, "get_skyvern", lambda: fake_skyvern)
do_session_close = AsyncMock(return_value=SessionCloseResult(session_id="pbs_456", closed=True))
@@ -478,11 +481,130 @@ async def test_session_close_with_matching_session_id_closes_browser_handle(monk
assert result["ok"] is True
assert result["data"] == {"session_id": "pbs_456", "closed": True}
+ assert "app_url" not in result["data"]
+ assert "recording_url" not in result["data"]
current_browser.close.assert_awaited_once()
do_session_close.assert_awaited_once_with(fake_skyvern, "pbs_456")
assert mcp_session.get_current_session().browser is None
+async def test_session_close_returns_app_url_first_and_first_recording_url(
+ monkeypatch: pytest.MonkeyPatch,
+) -> None:
+ fake_skyvern = MagicMock()
+ fake_skyvern.get_browser_session = AsyncMock(
+ return_value=SimpleNamespace(
+ app_url="https://app.example.test/sessions/pbs_recorded",
+ recordings=[SimpleNamespace(url="https://media.example.test/recording.webm", filename="recording.webm")],
+ downloaded_files=[],
+ )
+ )
+ monkeypatch.setattr(mcp_session, "get_skyvern", lambda: fake_skyvern)
+
+ do_session_close = AsyncMock(return_value=SessionCloseResult(session_id="pbs_recorded", closed=True))
+ monkeypatch.setattr(mcp_session, "do_session_close", do_session_close)
+
+ result = await mcp_session.skyvern_browser_session_close(session_id="pbs_recorded")
+
+ assert result["ok"] is True
+ assert list(result["data"])[0] == "app_url"
+ assert result["data"]["app_url"] == "https://app.example.test/sessions/pbs_recorded"
+ assert result["data"]["recording_url"] == "https://media.example.test/recording.webm"
+ assert result["data"]["recordings"] == [
+ {"url": "https://media.example.test/recording.webm", "filename": "recording.webm"}
+ ]
+
+
+async def test_session_close_preserves_null_recording_url_in_concise_response(
+ monkeypatch: pytest.MonkeyPatch,
+) -> None:
+ fake_skyvern = MagicMock()
+ fake_skyvern.get_browser_session = AsyncMock(
+ return_value=SimpleNamespace(
+ app_url="https://app.example.test/sessions/pbs_empty",
+ recordings=[],
+ downloaded_files=[],
+ )
+ )
+ monkeypatch.setattr(mcp_session, "get_skyvern", lambda: fake_skyvern)
+ monkeypatch.setattr(
+ mcp_session,
+ "do_session_close",
+ AsyncMock(return_value=SessionCloseResult(session_id="pbs_empty", closed=True)),
+ )
+
+ result_mod.set_concise_responses(True)
+ try:
+ result = await mcp_session.skyvern_browser_session_close(session_id="pbs_empty")
+ finally:
+ result_mod.set_concise_responses(False)
+
+ assert list(result["data"])[0] == "app_url"
+ assert result["data"]["recording_url"] is None
+ assert list(result["data"]).index("recording_url") == list(result["data"]).index("recordings") + 1
+
+
+async def test_session_get_returns_app_url_first_and_first_recording_url(
+ monkeypatch: pytest.MonkeyPatch,
+) -> None:
+ fake_skyvern = MagicMock()
+ fake_skyvern.get_browser_session = AsyncMock(
+ return_value=SimpleNamespace(
+ app_url="https://app.example.test/sessions/pbs_details",
+ browser_session_id="pbs_details",
+ status="completed",
+ started_at=None,
+ completed_at=None,
+ timeout=60,
+ runnable_id=None,
+ recordings=[SimpleNamespace(url="https://media.example.test/details.webm", filename="details.webm")],
+ downloaded_files=[],
+ )
+ )
+ monkeypatch.setattr(mcp_session, "get_skyvern", lambda: fake_skyvern)
+
+ result = await mcp_session.skyvern_browser_session_get("pbs_details")
+
+ assert result["ok"] is True
+ assert list(result["data"])[0] == "app_url"
+ assert result["data"]["app_url"] == "https://app.example.test/sessions/pbs_details"
+ assert result["data"]["recording_url"] == "https://media.example.test/details.webm"
+
+
+async def test_session_get_preserves_null_recording_url_in_concise_response(
+ monkeypatch: pytest.MonkeyPatch,
+) -> None:
+ fake_skyvern = MagicMock()
+ fake_skyvern.get_browser_session = AsyncMock(
+ return_value=SimpleNamespace(
+ app_url="https://app.example.test/sessions/pbs_empty",
+ browser_session_id="pbs_empty",
+ status="created",
+ started_at=None,
+ completed_at=None,
+ timeout=60,
+ runnable_id=None,
+ recordings=[],
+ downloaded_files=[],
+ )
+ )
+ monkeypatch.setattr(mcp_session, "get_skyvern", lambda: fake_skyvern)
+
+ result_mod.set_concise_responses(True)
+ try:
+ result = await mcp_session.skyvern_browser_session_get("pbs_empty")
+ finally:
+ result_mod.set_concise_responses(False)
+
+ assert list(result["data"])[0] == "app_url"
+ assert result["data"]["recording_url"] is None
+ assert list(result["data"]).index("recording_url") == list(result["data"]).index("recordings") + 1
+
+
@pytest.mark.asyncio
async def test_session_close_chains_exceptions_when_both_api_and_browser_fail(
monkeypatch: pytest.MonkeyPatch,
@@ -731,13 +853,34 @@ def test_coerce_proxy_location_rejects_non_object_json() -> None:
coerce_proxy_location('["RESIDENTIAL"]')
+def test_session_create_data_leads_with_app_url_and_omits_none() -> None:
+ with_app_url = mcp_session._session_create_data(
+ "pbs_data",
+ 60,
+ False,
+ app_url="https://app.example.test/sessions/pbs_data",
+ )
+ without_app_url = mcp_session._session_create_data("pbs_data", 60, False, app_url=None)
+ empty_app_url = mcp_session._session_create_data("pbs_data", 60, False, app_url="")
+
+ assert list(with_app_url)[0] == "app_url"
+ assert with_app_url["app_url"] == "https://app.example.test/sessions/pbs_data"
+ assert "app_url" not in without_app_url
+ assert empty_app_url["app_url"] == ""
+
+
@pytest.mark.asyncio
async def test_session_create_stateless_mode_returns_session_without_persisting_browser(
monkeypatch: pytest.MonkeyPatch,
) -> None:
session_manager.set_stateless_http_mode(True)
fake_skyvern = MagicMock()
- fake_skyvern.create_browser_session = AsyncMock(return_value=SimpleNamespace(browser_session_id="pbs_abc"))
+ fake_skyvern.create_browser_session = AsyncMock(
+ return_value=SimpleNamespace(
+ browser_session_id="pbs_abc",
+ app_url="https://app.example.test/sessions/pbs_abc",
+ )
+ )
monkeypatch.setattr(mcp_session, "get_skyvern", lambda: fake_skyvern)
do_session_create = AsyncMock()
monkeypatch.setattr(mcp_session, "do_session_create", do_session_create)
@@ -748,7 +891,12 @@ async def test_session_create_stateless_mode_returns_session_without_persisting_
session_manager.set_stateless_http_mode(False)
assert result["ok"] is True
- assert result["data"] == {"session_id": "pbs_abc", "timeout_minutes": 45}
+ assert list(result["data"])[0] == "app_url"
+ assert result["data"] == {
+ "app_url": "https://app.example.test/sessions/pbs_abc",
+ "session_id": "pbs_abc",
+ "timeout_minutes": 45,
+ }
do_session_create.assert_not_awaited()
assert mcp_session.get_current_session().browser is None
assert mcp_session.get_current_session().context is None
@@ -760,7 +908,9 @@ async def test_session_create_stateless_mode_accepts_geotarget_proxy_location(
) -> None:
session_manager.set_stateless_http_mode(True)
fake_skyvern = MagicMock()
- fake_skyvern.create_browser_session = AsyncMock(return_value=SimpleNamespace(browser_session_id="pbs_geo"))
+ fake_skyvern.create_browser_session = AsyncMock(
+ return_value=SimpleNamespace(browser_session_id="pbs_geo", app_url=None)
+ )
monkeypatch.setattr(mcp_session, "get_skyvern", lambda: fake_skyvern)
try:
@@ -785,7 +935,9 @@ async def test_session_create_stateless_mode_forwards_extensions(
) -> None:
session_manager.set_stateless_http_mode(True)
fake_skyvern = MagicMock()
- fake_skyvern.create_browser_session = AsyncMock(return_value=SimpleNamespace(browser_session_id="pbs_ext"))
+ fake_skyvern.create_browser_session = AsyncMock(
+ return_value=SimpleNamespace(browser_session_id="pbs_ext", app_url=None)
+ )
monkeypatch.setattr(mcp_session, "get_skyvern", lambda: fake_skyvern)
try:
@@ -810,7 +962,9 @@ async def test_session_create_stateless_mode_forwards_browser_profile_id(
) -> None:
session_manager.set_stateless_http_mode(True)
fake_skyvern = MagicMock()
- fake_skyvern.create_browser_session = AsyncMock(return_value=SimpleNamespace(browser_session_id="pbs_profile"))
+ fake_skyvern.create_browser_session = AsyncMock(
+ return_value=SimpleNamespace(browser_session_id="pbs_profile", app_url=None)
+ )
monkeypatch.setattr(mcp_session, "get_skyvern", lambda: fake_skyvern)
try:
@@ -835,7 +989,9 @@ async def test_session_create_stateless_mode_enables_browser_profile_export(
) -> None:
session_manager.set_stateless_http_mode(True)
fake_skyvern = MagicMock()
- fake_skyvern.create_browser_session = AsyncMock(return_value=SimpleNamespace(browser_session_id="pbs_profile"))
+ fake_skyvern.create_browser_session = AsyncMock(
+ return_value=SimpleNamespace(browser_session_id="pbs_profile", app_url=None)
+ )
arm_generate_browser_profile = AsyncMock()
monkeypatch.setattr(mcp_session, "get_skyvern", lambda: fake_skyvern)
monkeypatch.setattr(
@@ -867,7 +1023,9 @@ async def test_session_create_stateless_mode_rolls_back_on_browser_profile_expor
) -> None:
session_manager.set_stateless_http_mode(True)
fake_skyvern = MagicMock()
- fake_skyvern.create_browser_session = AsyncMock(return_value=SimpleNamespace(browser_session_id="pbs_profile"))
+ fake_skyvern.create_browser_session = AsyncMock(
+ return_value=SimpleNamespace(browser_session_id="pbs_profile", app_url=None)
+ )
fake_skyvern.close_browser_session = AsyncMock()
update_generate_browser_profile = AsyncMock(side_effect=RuntimeError("PATCH failed"))
monkeypatch.setattr(mcp_session, "get_skyvern", lambda: fake_skyvern)
@@ -906,6 +1064,86 @@ async def test_session_create_stateless_mode_rejects_local() -> None:
assert result["error"]["code"] == mcp_session.ErrorCode.INVALID_INPUT
+async def test_session_create_stateful_mode_fetches_app_url(
+ monkeypatch: pytest.MonkeyPatch,
+) -> None:
+ fake_browser = MagicMock()
+ fake_browser.browser_session_id = "pbs_stateful"
+ fake_skyvern = MagicMock()
+ fake_skyvern.launch_cloud_browser = AsyncMock(return_value=fake_browser)
+ fake_skyvern.get_browser_session = AsyncMock(
+ return_value=SimpleNamespace(app_url="https://app.example.test/sessions/pbs_stateful")
+ )
+ monkeypatch.setattr(mcp_session, "get_skyvern", lambda: fake_skyvern)
+
+ result = await mcp_session.skyvern_browser_session_create(timeout=50)
+
+ assert result["ok"] is True
+ assert list(result["data"])[0] == "app_url"
+ assert result["data"]["app_url"] == "https://app.example.test/sessions/pbs_stateful"
+ fake_skyvern.get_browser_session.assert_awaited_once_with("pbs_stateful")
+
+
+async def test_session_create_stateful_mode_app_url_fetch_counts_toward_timing(
+ monkeypatch: pytest.MonkeyPatch,
+) -> None:
+ """The app_url follow-up must run inside the Timer context, not after it exits."""
+ fake_browser = MagicMock()
+ fake_browser.browser_session_id = "pbs_timed"
+ fake_skyvern = MagicMock()
+ fake_skyvern.launch_cloud_browser = AsyncMock(return_value=fake_browser)
+
+ async def _slow_get_browser_session(_session_id: str) -> SimpleNamespace:
+ await asyncio.sleep(0.03)
+ return SimpleNamespace(app_url="https://app.example.test/sessions/pbs_timed")
+
+ fake_skyvern.get_browser_session = _slow_get_browser_session
+ monkeypatch.setattr(mcp_session, "get_skyvern", lambda: fake_skyvern)
+
+ result = await mcp_session.skyvern_browser_session_create(timeout=50)
+
+ timing_ms = result["timing_ms"]
+ assert "app_url" in timing_ms
+ assert timing_ms["app_url"] >= 25
+ assert timing_ms["total"] >= timing_ms["app_url"]
+
+
+async def test_session_create_stateful_mode_succeeds_when_app_url_fetch_fails(
+ monkeypatch: pytest.MonkeyPatch,
+) -> None:
+ fake_browser = MagicMock()
+ fake_browser.browser_session_id = "pbs_stateful"
+ fake_skyvern = MagicMock()
+ fake_skyvern.launch_cloud_browser = AsyncMock(return_value=fake_browser)
+ fake_skyvern.get_browser_session = AsyncMock(side_effect=ConnectionError("session lookup failed"))
+ monkeypatch.setattr(mcp_session, "get_skyvern", lambda: fake_skyvern)
+
+ result = await mcp_session.skyvern_browser_session_create(timeout=50)
+
+ assert result["ok"] is True
+ assert result["data"] == {"session_id": "pbs_stateful", "timeout_minutes": 50}
+ assert "app_url" not in result["data"]
+ fake_skyvern.get_browser_session.assert_awaited_once_with("pbs_stateful")
+
+
+async def test_session_create_local_mode_omits_app_url(monkeypatch: pytest.MonkeyPatch) -> None:
+ fake_browser = MagicMock()
+ fake_skyvern = MagicMock()
+ fake_skyvern.launch_local_browser = AsyncMock(return_value=fake_browser)
+ monkeypatch.setattr(mcp_session, "get_skyvern", lambda: fake_skyvern)
+
+ result = await mcp_session.skyvern_browser_session_create(local=True, headless=True)
+
+ assert result["ok"] is True
+ assert result["data"] == {"local": True, "headless": True}
+ assert "app_url" not in result["data"]
+ fake_skyvern.launch_local_browser.assert_awaited_once_with(headless=True)
+
+
@pytest.mark.asyncio
async def test_session_create_cdp_connect_rejects_profile_options(monkeypatch: pytest.MonkeyPatch) -> None:
monkeypatch.setenv("BROWSER_TYPE", "cdp-connect")
@@ -933,7 +1171,7 @@ async def test_session_create_forwards_extensions_to_stateful_session_create(
do_session_create = AsyncMock(
return_value=(
fake_browser,
- SimpleNamespace(local=False, session_id="pbs_ext", timeout_minutes=60, headless=False),
+ SimpleNamespace(local=False, session_id="pbs_ext", timeout_minutes=60, headless=False, app_url=None),
)
)
monkeypatch.setattr(mcp_session, "do_session_create", do_session_create)
@@ -967,7 +1205,7 @@ async def test_session_create_forwards_browser_profile_id_to_stateful_session_cr
do_session_create = AsyncMock(
return_value=(
fake_browser,
- SimpleNamespace(local=False, session_id="pbs_profile", timeout_minutes=60, headless=False),
+ SimpleNamespace(local=False, session_id="pbs_profile", timeout_minutes=60, headless=False, app_url=None),
)
)
monkeypatch.setattr(mcp_session, "do_session_create", do_session_create)
@@ -1001,7 +1239,7 @@ async def test_session_create_forwards_generate_browser_profile_to_stateful_sess
do_session_create = AsyncMock(
return_value=(
fake_browser,
- SimpleNamespace(local=False, session_id="pbs_profile", timeout_minutes=60, headless=False),
+ SimpleNamespace(local=False, session_id="pbs_profile", timeout_minutes=60, headless=False, app_url=None),
)
)
monkeypatch.setattr(mcp_session, "do_session_create", do_session_create)
@@ -1036,7 +1274,7 @@ async def test_session_create_persists_active_api_key_hash_in_session_state(
do_session_create = AsyncMock(
return_value=(
fake_browser,
- SimpleNamespace(local=False, session_id="pbs_123", timeout_minutes=60, headless=False),
+ SimpleNamespace(local=False, session_id="pbs_123", timeout_minutes=60, headless=False, app_url=None),
)
)
monkeypatch.setattr(mcp_session, "do_session_create", do_session_create)