Skip to content

Automate browser based workflows with AI

Fix tooltip weird behavior in editable titles (#1268)

Shuchang Zheng80f2d5ae96c6
diff --git a/skyvern-frontend/src/routes/workflows/editor/nodes/components/EditableNodeTitle.tsx b/skyvern-frontend/src/routes/workflows/editor/nodes/components/EditableNodeTitle.tsx
index e228ed1bb..4072ece00 100644
--- a/skyvern-frontend/src/routes/workflows/editor/nodes/components/EditableNodeTitle.tsx
+++ b/skyvern-frontend/src/routes/workflows/editor/nodes/components/EditableNodeTitle.tsx
@@ -25,11 +25,11 @@ function EditableNodeTitle({
}: Props) {
const [editing, setEditing] = useState(false);
- return (
- <TooltipProvider>
- <Tooltip>
- <TooltipTrigger asChild>
- {!editing ? (
+ if (!editing) {
+ return (
+ <TooltipProvider>
+ <Tooltip>
+ <TooltipTrigger asChild>
<h1
className={cn("cursor-text", titleClassName)}
onClick={() => {
@@ -38,41 +38,43 @@ function EditableNodeTitle({
>
{value}
</h1>
- ) : (
- <HorizontallyResizingInput
- disabled={!editable}
- size={1}
- autoFocus
- className={cn("nopan w-min border-0 p-0", inputClassName)}
- onBlur={(event) => {
- if (!editable) {
- event.currentTarget.value = value;
- return;
- }
- if (event.currentTarget.value !== value) {
- onChange(event.target.value);
- }
- setEditing(false);
- }}
- onKeyDown={(event) => {
- if (!editable) {
- return;
- }
- if (event.key === "Enter") {
- event.currentTarget.blur();
- }
- if (event.key === "Escape") {
- event.currentTarget.value = value;
- event.currentTarget.blur();
- }
- }}
- defaultValue={value}
- />
- )}
- </TooltipTrigger>
- <TooltipContent>Click to edit</TooltipContent>
- </Tooltip>
- </TooltipProvider>
+ </TooltipTrigger>
+ <TooltipContent>Click to edit</TooltipContent>
+ </Tooltip>
+ </TooltipProvider>
+ );
+ }
+
+ return (
+ <HorizontallyResizingInput
+ disabled={!editable}
+ size={1}
+ autoFocus
+ className={cn("nopan w-min border-0 p-0", inputClassName)}
+ onBlur={(event) => {
+ if (!editable) {
+ event.currentTarget.value = value;
+ return;
+ }
+ if (event.currentTarget.value !== value) {
+ onChange(event.target.value);
+ }
+ setEditing(false);
+ }}
+ onKeyDown={(event) => {
+ if (!editable) {
+ return;
+ }
+ if (event.key === "Enter") {
+ event.currentTarget.blur();
+ }
+ if (event.key === "Escape") {
+ event.currentTarget.value = value;
+ event.currentTarget.blur();
+ }
+ }}
+ defaultValue={value}
+ />
);
}