Automate browser based workflows with AI
Python aiapiautomationbrowserbrowser-automationcomputergptllmplaywrightpowerautomatepuppeteerpythonrpaseleniumvisionworkflow
Avoid inherited blank page workflow URLs (#7001)
Suchintan830674adc946
diff --git a/skyvern/forge/agent.py b/skyvern/forge/agent.pyindex 9a8c4ba62..332510803 100644--- a/skyvern/forge/agent.py+++ b/skyvern/forge/agent.py@@ -170,11 +170,44 @@ from skyvern.webeye.scraper.scraped_page import ElementTreeFormat, ScrapedPagefrom skyvern.webeye.utils.page import SkyvernFrame, build_open_tabs_contextLOG = structlog.get_logger()+BLANK_WORKFLOW_TASK_URLS = {"about:blank", ":"}+RECOVERABLE_BLANK_WORKFLOW_TASK_URLS = {":"}EXTRACT_ACTION_TEMPLATE = "extract-action"DECISIVE_CRITERION_VALIDATE_TEMPLATE = "decisive-criterion-validate"+async def resolve_inherited_workflow_task_page(browser_state: BrowserState, workflow_run_id: str) -> Page:+ working_page = await browser_state.get_working_page()+ if not working_page:+ LOG.error(+ "BrowserState has no page",+ workflow_run_id=workflow_run_id,+ )+ raise MissingBrowserStatePage(workflow_run_id=workflow_run_id)++ if working_page.url not in BLANK_WORKFLOW_TASK_URLS:+ return working_page++ if working_page.url not in RECOVERABLE_BLANK_WORKFLOW_TASK_URLS:+ raise InvalidWorkflowTaskURLState(workflow_run_id)++ pages = await browser_state.list_valid_pages()+ for page_index, page in reversed(list(enumerate(pages))):+ if page.url not in BLANK_WORKFLOW_TASK_URLS:+ LOG.warning(+ "Inherited workflow task URL resolved from latest non-blank page",+ workflow_run_id=workflow_run_id,+ blank_url=working_page.url,+ fallback_url=page.url,+ page_index=page_index,+ )+ await browser_state.set_active_page(page)+ return page++ raise InvalidWorkflowTaskURLState(workflow_run_id)++def should_auto_download_pdf(pdf_src: str) -> bool:context = skyvern_context.current()if not context:@@ -526,17 +559,10 @@ class ForgeAgent:workflow_run_id=workflow_run.workflow_run_id, parent_workflow_run_id=workflow_run.parent_workflow_run_id)if browser_state is not None:- working_page = await browser_state.get_working_page()- if not working_page:- LOG.error(- "BrowserState has no page",- workflow_run_id=workflow_run.workflow_run_id,- )- raise MissingBrowserStatePage(workflow_run_id=workflow_run.workflow_run_id)-- if working_page.url == "about:blank":- raise InvalidWorkflowTaskURLState(workflow_run.workflow_run_id)-+ working_page = await resolve_inherited_workflow_task_page(+ browser_state=browser_state,+ workflow_run_id=workflow_run.workflow_run_id,+ )task_url = working_page.urlelse:LOG.info("No browser state found for workflow run, setting task url to empty string")diff --git a/skyvern/webeye/real_browser_state.py b/skyvern/webeye/real_browser_state.pyindex 174c8a686..9908943ad 100644--- a/skyvern/webeye/real_browser_state.py+++ b/skyvern/webeye/real_browser_state.py@@ -35,6 +35,7 @@ LOG = structlog.get_logger()SETTLE_TIME_MS = 750SETTLE_JITTER_MS = 500+RECOVERABLE_BLANK_PAGE_URLS = {":"}def _same_page_ignoring_fragment(left: str | None, right: str | None) -> bool:@@ -209,21 +210,22 @@ class RealBrowserState(BrowserState):LOG.info("No http, https or blank page found in the browser context, return None")return None- # Honor a tab explicitly selected via NEW_TAB/SWITCH_TAB while it is still open and no- # new tab has appeared since selection. A newly-opened tab (any page not in the snapshot)- # auto-takes focus, preserving the legacy last-page behavior; closing an unrelated tab- # does not drop the pin.+ # Honor a tab explicitly selected via NEW_TAB/SWITCH_TAB while it is still open.+ # A genuinely new tab auto-takes focus, preserving legacy last-page behavior; a+ # recoverable blank marker from a download flow does not break the selected-tab pin.active_page = self.__active_page- if (- active_page is not None- and not active_page.is_closed()- and active_page in pages- and all(page in self.__active_page_known_pages for page in pages)- ):- self.__page = active_page- return active_page-- # No (or stale) pin: fall back to the last http/https page as the working page.+ if active_page is not None and not active_page.is_closed() and active_page in pages:+ if all(page in self.__active_page_known_pages for page in pages):+ self.__page = active_page+ return active_page++ new_pages = [page for page in pages if page not in self.__active_page_known_pages]+ if new_pages and all(page.url in RECOVERABLE_BLANK_PAGE_URLS for page in new_pages):+ # Do not add marker pages to known_pages; they should remain ignored until closed.+ self.__page = active_page+ return active_page++ # No (or stale) pin: fall back to the newest valid page.self.__active_page = Noneself.__active_page_known_pages = set()last_page = pages[-1]diff --git a/tests/unit/test_missing_starter_url.py b/tests/unit/test_missing_starter_url.pyindex a835558df..c6616848e 100644--- a/tests/unit/test_missing_starter_url.py+++ b/tests/unit/test_missing_starter_url.py@@ -17,11 +17,13 @@ from unittest.mock import AsyncMock, MagicMock, patchimport pytest-from skyvern.exceptions import MissingStarterUrl+from skyvern.exceptions import InvalidWorkflowTaskURLState, MissingStarterUrl+from skyvern.forge.agent import ForgeAgent, resolve_inherited_workflow_task_pagefrom skyvern.forge.sdk.schemas.tasks import TaskStatusfrom skyvern.forge.sdk.workflow.context_manager import WorkflowRunContextfrom skyvern.forge.sdk.workflow.models.block import TaskBlockfrom skyvern.forge.sdk.workflow.models.parameter import OutputParameter, ParameterType+from skyvern.webeye.real_browser_state import RealBrowserStatedef _output_parameter(key: str = "task_output") -> OutputParameter:@@ -167,6 +169,176 @@ async def test_execute_fails_early_when_first_block_has_no_url(blank_url: str) -)+def _workflow_run_for_create_task() -> SimpleNamespace:+ return SimpleNamespace(+ workflow_run_id="wr_missing_starter_url_test",+ parent_workflow_run_id=None,+ organization_id="o_test",+ proxy_location=None,+ max_screenshot_scrolls=None,+ extra_http_headers=None,+ cdp_connect_headers=None,+ browser_address=None,+ browser_session_id=None,+ )+++def _task_block_without_url() -> TaskBlock:+ return TaskBlock(+ label="validate_download",+ output_parameter=_output_parameter(),+ title="Validate downloaded file",+ url=None,+ )+++async def test_create_task_rejects_about_blank_url_inherited_from_later_block() -> None:+ """Keep the historical behavior for about:blank inherited task URLs."""++ browser_state = MagicMock()+ browser_state.get_working_page = AsyncMock(return_value=SimpleNamespace(url="about:blank"))+ browser_state.list_valid_pages = AsyncMock()++ browser_manager = MagicMock()+ browser_manager.get_for_workflow_run.return_value = browser_state++ workflow = SimpleNamespace(workflow_id="w_missing_starter_url_test")+ workflow_run = _workflow_run_for_create_task()+ workflow_run_context = SimpleNamespace(get_value=MagicMock())++ with patch("skyvern.forge.agent.app") as mock_app:+ mock_app.BROWSER_MANAGER = browser_manager++ with pytest.raises(InvalidWorkflowTaskURLState):+ await ForgeAgent().create_task_and_step_from_block(+ task_block=_task_block_without_url(),+ workflow=workflow,+ workflow_run=workflow_run,+ workflow_run_context=workflow_run_context,+ task_order=5,+ task_retry=0,+ )++ browser_state.get_working_page.assert_awaited_once()+ browser_state.list_valid_pages.assert_not_awaited()+++async def test_create_task_uses_latest_non_blank_page_for_inherited_marker_url() -> None:+ """Later blocks with url=None inherit the current browser page URL. The+ ':' marker URL can be left behind after downloads; use the latest non-blank+ page so scrape/reload runs against the real page."""++ real_page = SimpleNamespace(url="https://example.test/invoices")+ blank_page = SimpleNamespace(url=":")++ browser_state = MagicMock()+ browser_state.get_working_page = AsyncMock(return_value=blank_page)+ browser_state.list_valid_pages = AsyncMock(return_value=[real_page, blank_page])+ browser_state.set_active_page = AsyncMock()++ browser_manager = MagicMock()+ browser_manager.get_for_workflow_run.return_value = browser_state++ created_task = SimpleNamespace(+ task_id="tsk_missing_starter_url_test",+ organization_id="o_test",+ url=real_page.url,+ title="Validate downloaded file",+ proxy_location=None,+ )+ step = SimpleNamespace(order=0, retry_index=0)+ tasks_db = MagicMock()+ tasks_db.create_task = AsyncMock(return_value=created_task)+ tasks_db.update_task = AsyncMock(return_value=created_task)+ tasks_db.create_step = AsyncMock(return_value=step)++ database = MagicMock()+ database.tasks = tasks_db++ workflow = SimpleNamespace(workflow_id="w_missing_starter_url_test")+ workflow_run = _workflow_run_for_create_task()+ workflow_run_context = SimpleNamespace(get_value=MagicMock())++ with patch("skyvern.forge.agent.app") as mock_app:+ mock_app.BROWSER_MANAGER = browser_manager+ mock_app.DATABASE = database++ task, _ = await ForgeAgent().create_task_and_step_from_block(+ task_block=_task_block_without_url(),+ workflow=workflow,+ workflow_run=workflow_run,+ workflow_run_context=workflow_run_context,+ task_order=5,+ task_retry=0,+ )++ assert task is created_task+ assert tasks_db.create_task.await_args.kwargs["url"] == real_page.url+ browser_state.get_working_page.assert_awaited_once()+ browser_state.list_valid_pages.assert_awaited_once()+ browser_state.set_active_page.assert_awaited_once_with(real_page)+++async def test_resolved_inherited_marker_page_stays_active() -> None:+ real_page = MagicMock()+ real_page.url = "https://example.test/invoices"+ real_page.is_closed = MagicMock(return_value=False)+ blank_page = MagicMock()+ blank_page.url = ":"+ blank_page.is_closed = MagicMock(return_value=False)++ browser_state = RealBrowserState(pw=MagicMock(), browser_context=MagicMock())+ browser_state.list_valid_pages = AsyncMock(return_value=[real_page, blank_page])+ await browser_state.set_working_page(blank_page)++ assert await resolve_inherited_workflow_task_page(browser_state, "wr_missing_starter_url_test") is real_page+ assert await browser_state.get_working_page() is real_page+++async def test_resolved_inherited_marker_page_raises_when_no_non_blank_page_exists() -> None:+ about_blank_page = MagicMock()+ about_blank_page.url = "about:blank"+ about_blank_page.is_closed = MagicMock(return_value=False)+ blank_marker_page = MagicMock()+ blank_marker_page.url = ":"+ blank_marker_page.is_closed = MagicMock(return_value=False)++ browser_state = MagicMock()+ browser_state.get_working_page = AsyncMock(return_value=blank_marker_page)+ browser_state.list_valid_pages = AsyncMock(return_value=[about_blank_page, blank_marker_page])+ browser_state.set_active_page = AsyncMock()++ with pytest.raises(InvalidWorkflowTaskURLState):+ await resolve_inherited_workflow_task_page(browser_state, "wr_missing_starter_url_test")++ browser_state.set_active_page.assert_not_awaited()+++async def test_resolved_inherited_marker_page_preserves_selected_tab() -> None:+ selected_page = MagicMock()+ selected_page.url = "https://example.test/selected"+ selected_page.is_closed = MagicMock(return_value=False)+ other_page = MagicMock()+ other_page.url = "https://example.test/other"+ other_page.is_closed = MagicMock(return_value=False)+ blank_page = MagicMock()+ blank_page.url = ":"+ blank_page.is_closed = MagicMock(return_value=False)++ browser_state = RealBrowserState(pw=MagicMock(), browser_context=MagicMock())+ browser_state.list_valid_pages = AsyncMock(return_value=[selected_page, other_page])+ await browser_state.set_active_page(selected_page)+ browser_state.list_valid_pages = AsyncMock(return_value=[selected_page, other_page, blank_page])++ assert await resolve_inherited_workflow_task_page(browser_state, "wr_missing_starter_url_test") is selected_page+ assert await browser_state.get_working_page() is selected_page++@pytest.mark.asyncioasync def test_execute_does_not_raise_when_profile_loaded_a_page() -> None:"""If the browser session/profile navigated the page away from about:blank beforediff --git a/tests/unit/test_real_browser_state_active_page.py b/tests/unit/test_real_browser_state_active_page.pyindex e6e323d94..fca922650 100644--- a/tests/unit/test_real_browser_state_active_page.py+++ b/tests/unit/test_real_browser_state_active_page.py@@ -28,6 +28,18 @@ async def test_no_pin_returns_last_page() -> None:assert await state.get_working_page() is page1[email protected]("blank_url", ["about:blank", ":"])+async def test_no_pin_returns_last_blank_page(blank_url: str) -> None:+ page0 = _mock_page("https://example.test/bills")+ blank_page = _mock_page(blank_url)+ state = _make_state()+ state.list_valid_pages = AsyncMock(return_value=[page0, blank_page])+ await state.set_working_page(page0)++ assert await state.get_working_page() is blank_page++@pytest.mark.asyncioasync def test_pin_overrides_last_page() -> None:page0, page1 = _mock_page(), _mock_page()@@ -63,6 +75,30 @@ async def test_pin_dropped_when_new_tab_opens() -> None:assert await state.get_working_page() is page2+async def test_pin_dropped_when_about_blank_tab_opens() -> None:+ page0, page1 = _mock_page(), _mock_page()+ state = _make_state()+ state.list_valid_pages = AsyncMock(return_value=[page0, page1])+ await state.set_active_page(page0)++ blank_page = _mock_page("about:blank")+ state.list_valid_pages = AsyncMock(return_value=[page0, page1, blank_page])+ assert await state.get_working_page() is blank_page+++async def test_pin_survives_when_recoverable_blank_marker_opens() -> None:+ page0, page1 = _mock_page(), _mock_page()+ state = _make_state()+ state.list_valid_pages = AsyncMock(return_value=[page0, page1])+ await state.set_active_page(page0)++ blank_page = _mock_page(":")+ state.list_valid_pages = AsyncMock(return_value=[page0, page1, blank_page])+ assert await state.get_working_page() is page0++@pytest.mark.asyncioasync def test_pin_survives_when_other_tab_closes() -> None:page0, page1, page2 = _mock_page(), _mock_page(), _mock_page()