Automate browser based workflows with AI
Python aiapiautomationbrowserbrowser-automationcomputergptllmplaywrightpowerautomatepuppeteerpythonrpaseleniumvisionworkflow
Record the 2026-08-30 PBS session-startup incident and its triage shortcut (#8332)
Aaron Perez89859e6b1f43
diff --git a/docs/api-reference/openapi.json b/docs/api-reference/openapi.jsonindex a6e0fa801..a41eda243 100644--- a/docs/api-reference/openapi.json+++ b/docs/api-reference/openapi.json@@ -18832,6 +18832,18 @@"title": "Onepassword Item Id","description": "1Password item ID"},+ "onepassword_totp_field_name": {+ "anyOf": [+ {+ "type": "string"+ },+ {+ "type": "null"+ }+ ],+ "title": "Onepassword Totp Field Name",+ "description": "1Password item field id or label to treat as the TOTP secret, overriding 1Password's own field-type detection"+ },"azure_vault_name": {"anyOf": [{@@ -19650,6 +19662,17 @@"type": "string","title": "Item Id"},+ "totp_field_name": {+ "anyOf": [+ {+ "type": "string"+ },+ {+ "type": "null"+ }+ ],+ "title": "Totp Field Name"+ },"created_at": {"type": "string","format": "date-time",@@ -19715,6 +19738,17 @@"item_id": {"type": "string","title": "Item Id"+ },+ "totp_field_name": {+ "anyOf": [+ {+ "type": "string"+ },+ {+ "type": "null"+ }+ ],+ "title": "Totp Field Name"}},"type": "object",diff --git a/skyvern-frontend/src/routes/browserProfiles/hooks/useBackgroundBrowserProfileCreate.test.tsx b/skyvern-frontend/src/routes/browserProfiles/hooks/useBackgroundBrowserProfileCreate.test.tsxnew file mode 100644index 000000000..57121f0b9--- /dev/null+++ b/skyvern-frontend/src/routes/browserProfiles/hooks/useBackgroundBrowserProfileCreate.test.tsx@@ -0,0 +1,107 @@+// @vitest-environment jsdom++import type { ReactNode } from "react";+import { act, renderHook } from "@testing-library/react";+import { QueryClient, QueryClientProvider } from "@tanstack/react-query";+import { afterEach, describe, expect, it, vi } from "vitest";++const { mockPost, mockToast } = vi.hoisted(() => ({+ mockPost: vi.fn(),+ mockToast: vi.fn(),+}));++vi.mock("@/api/AxiosClient", () => ({+ getClient: () => Promise.resolve({ post: mockPost, patch: vi.fn() }),+}));++vi.mock("@/hooks/useCredentialGetter", () => ({+ useCredentialGetter: () => () => Promise.resolve("test-token"),+}));++vi.mock("@/components/ui/use-toast", () => ({ toast: mockToast }));++import { useBackgroundBrowserProfileCreate } from "./useBackgroundBrowserProfileCreate";+import { useBrowserProfileCreateStore } from "@/store/useBrowserProfileCreateStore";++function wrapper({ children }: { children: ReactNode }) {+ const queryClient = new QueryClient({+ defaultOptions: {+ queries: { retry: false },+ mutations: { retry: false },+ },+ });++ return (+ <QueryClientProvider client={queryClient}>{children}</QueryClientProvider>+ );+}++afterEach(() => {+ vi.clearAllMocks();+ useBrowserProfileCreateStore.setState({ active: null });+});++describe("useBackgroundBrowserProfileCreate concurrency guard", () => {+ it("does not clobber an in-flight create for another session", async () => {+ const { result } = renderHook(() => useBackgroundBrowserProfileCreate(), {+ wrapper,+ });++ await act(async () => {+ await result.current.startBackgroundCreate({+ browserSessionId: "pbs_first",+ name: "first",+ isSessionRunning: false,+ });+ });++ expect(+ useBrowserProfileCreateStore.getState().active?.browserSessionId,+ ).toBe("pbs_first");+ mockToast.mockClear();++ await act(async () => {+ await result.current.startBackgroundCreate({+ browserSessionId: "pbs_second",+ name: "second",+ isSessionRunning: false,+ });+ });++ // The first session's in-flight create must survive — starting a second+ // session's create must fail loudly (toast) instead of silently dropping it.+ expect(+ useBrowserProfileCreateStore.getState().active?.browserSessionId,+ ).toBe("pbs_first");+ expect(mockToast).toHaveBeenCalledWith(+ expect.objectContaining({ variant: "destructive" }),+ );+ });++ it("allows a new create once the previous one has gone stale", async () => {+ useBrowserProfileCreateStore.setState({+ active: {+ browserSessionId: "pbs_stale",+ name: "stale",+ startTime: Date.now() - 10 * 60 * 1000,+ phase: "creating",+ },+ });++ const { result } = renderHook(() => useBackgroundBrowserProfileCreate(), {+ wrapper,+ });++ await act(async () => {+ await result.current.startBackgroundCreate({+ browserSessionId: "pbs_fresh",+ name: "fresh",+ isSessionRunning: false,+ });+ });++ expect(+ useBrowserProfileCreateStore.getState().active?.browserSessionId,+ ).toBe("pbs_fresh");+ });+});diff --git a/skyvern-frontend/src/routes/browserProfiles/hooks/useBackgroundBrowserProfileCreate.tsx b/skyvern-frontend/src/routes/browserProfiles/hooks/useBackgroundBrowserProfileCreate.tsxindex ee4b07fd4..a60134cb3 100644--- a/skyvern-frontend/src/routes/browserProfiles/hooks/useBackgroundBrowserProfileCreate.tsx+++ b/skyvern-frontend/src/routes/browserProfiles/hooks/useBackgroundBrowserProfileCreate.tsx@@ -293,6 +293,21 @@ function useBackgroundBrowserProfileCreate() {description,isSessionRunning,}: StartBackgroundCreateInput) => {+ const existingActive = useBrowserProfileCreateStore.getState().active;+ if (+ existingActive &&+ existingActive.browserSessionId !== browserSessionId &&+ Date.now() - existingActive.startTime <= MAX_TOTAL_DURATION_MS+ ) {+ toast({+ title: "Another browser profile save is already in progress",+ description:+ "Wait for that save to finish (or time out) before starting a new one, so it isn't discarded.",+ variant: "destructive",+ });+ return;+ }+cleanup();const startTime = Date.now();diff --git a/skyvern-frontend/src/routes/workflows/editor/FlowRenderer.tsx b/skyvern-frontend/src/routes/workflows/editor/FlowRenderer.tsxindex 94f23dabe..90f7c911e 100644--- a/skyvern-frontend/src/routes/workflows/editor/FlowRenderer.tsx+++ b/skyvern-frontend/src/routes/workflows/editor/FlowRenderer.tsx@@ -342,6 +342,7 @@ function convertToParametersYAML(description: parameter.description || null,vault_id: parameter.vaultId,item_id: parameter.itemId,+ totp_field_name: parameter.totpFieldName || null,};} else if (parameterIsAzureVaultCredential(parameter)) {return {diff --git a/skyvern-frontend/src/routes/workflows/editor/panels/WorkflowParameterEditPanel.tsx b/skyvern-frontend/src/routes/workflows/editor/panels/WorkflowParameterEditPanel.tsxindex 83c927556..e8c9079e0 100644--- a/skyvern-frontend/src/routes/workflows/editor/panels/WorkflowParameterEditPanel.tsx+++ b/skyvern-frontend/src/routes/workflows/editor/panels/WorkflowParameterEditPanel.tsx@@ -364,6 +364,9 @@ function WorkflowParameterEditPanel({(initialValues.vaultId.includes("{{") ||initialValues.itemId.includes("{{")),);+ const [opTotpFieldName, setOpTotpFieldName] = useState(+ isOnePasswordCredential ? (initialValues.totpFieldName ?? "") : "",+ );const opEditModeInitializedRef = useRef(false);const opUserTouchedRef = useRef(false);const savedOpVaultId = isOnePasswordCredential ? initialValues.vaultId : "";@@ -951,6 +954,24 @@ function WorkflowParameterEditPanel({/>)}</div>+ {credentialDataType === "password" && (+ <div className="space-y-1">+ <div className="flex gap-2">+ <Label className="text-xs text-tertiary-foreground">+ 1Password TOTP Field (optional)+ </Label>+ <HelpTooltip content="Item field id or label holding the TOTP secret. Set this if the OTP is stored in a plain field (e.g. a custom field named 'digits') rather than 1Password's own one-time-password field type. Leave empty to auto-detect." />+ </div>+ <Input+ value={opTotpFieldName}+ onChange={(e) => {+ opUserTouchedRef.current = true;+ setOpTotpFieldName(e.target.value);+ }}+ placeholder="Leave empty to auto-detect"+ />+ </div>+ )}{credentialDataType === "creditCard" && (<div className="rounded-md bg-muted p-2"><div className="space-y-1 text-xs text-muted-foreground">@@ -1353,6 +1374,8 @@ function WorkflowParameterEditPanel({parameterType: "onepassword",vaultId: opVaultId,itemId: opItemId,+ totpFieldName:+ opTotpFieldName.trim() === "" ? null : opTotpFieldName,description,});return;diff --git a/skyvern-frontend/src/routes/workflows/editor/types.ts b/skyvern-frontend/src/routes/workflows/editor/types.tsindex 7053beea2..d4c03783c 100644--- a/skyvern-frontend/src/routes/workflows/editor/types.ts+++ b/skyvern-frontend/src/routes/workflows/editor/types.ts@@ -37,6 +37,10 @@ export type OnePasswordCredential = {parameterType: "onepassword";vaultId: string;itemId: string;+ // Item field id or label to treat as the TOTP secret, overriding 1Password's own+ // field-type detection. Needed for items whose OTP lives in a plain field (e.g.+ // named "digits") rather than a native 1Password one-time-password field.+ totpFieldName?: string | null;};export type AzureVaultCredential = {diff --git a/skyvern-frontend/src/routes/workflows/editor/utils.ts b/skyvern-frontend/src/routes/workflows/editor/utils.tsindex bd7d989b4..d824175b7 100644--- a/skyvern-frontend/src/routes/workflows/editor/utils.ts+++ b/skyvern-frontend/src/routes/workflows/editor/utils.ts@@ -193,6 +193,7 @@ const getInitialParameters = (workflow: WorkflowApiResponse) => {parameterType: WorkflowEditorParameterTypes.OnePassword,vaultId: parameter.vault_id,itemId: parameter.item_id,+ totpFieldName: parameter.totp_field_name,description: parameter.description,};} else if (diff --git a/skyvern-frontend/src/routes/workflows/types/workflowTypes.ts b/skyvern-frontend/src/routes/workflows/types/workflowTypes.tsindex ac0708ee8..884e12d95 100644--- a/skyvern-frontend/src/routes/workflows/types/workflowTypes.ts+++ b/skyvern-frontend/src/routes/workflows/types/workflowTypes.ts@@ -67,6 +67,7 @@ export type OnePasswordCredentialParameter = WorkflowParameterBase & {onepassword_credential_parameter_id: string;vault_id: string;item_id: string;+ totp_field_name: string | null;created_at: string;modified_at: string;deleted_at: string | null;diff --git a/skyvern-frontend/src/routes/workflows/types/workflowYamlTypes.ts b/skyvern-frontend/src/routes/workflows/types/workflowYamlTypes.tsindex b196ed5a1..bd054482b 100644--- a/skyvern-frontend/src/routes/workflows/types/workflowYamlTypes.ts+++ b/skyvern-frontend/src/routes/workflows/types/workflowYamlTypes.ts@@ -112,6 +112,7 @@ export type OnePasswordCredentialParameterYAML = ParameterYAMLBase & {parameter_type: "onepassword";vault_id: string;item_id: string;+ totp_field_name?: string | null;};export type AzureVaultCredentialParameterYAML = ParameterYAMLBase & {diff --git a/skyvern/forge/sdk/routes/run_blocks.py b/skyvern/forge/sdk/routes/run_blocks.pyindex d76e526e9..03fce06a3 100644--- a/skyvern/forge/sdk/routes/run_blocks.py+++ b/skyvern/forge/sdk/routes/run_blocks.py@@ -238,6 +238,7 @@ async def login(key=parameter_key,vault_id=login_request.onepassword_vault_id,item_id=login_request.onepassword_item_id,+ totp_field_name=login_request.onepassword_totp_field_name,)]elif login_request.credential_type == CredentialType.azure_vault:diff --git a/skyvern/forge/sdk/workflow/context_manager.py b/skyvern/forge/sdk/workflow/context_manager.pyindex bdd666571..cf7229992 100644--- a/skyvern/forge/sdk/workflow/context_manager.py+++ b/skyvern/forge/sdk/workflow/context_manager.py@@ -1026,6 +1026,8 @@ class WorkflowRunContext:"context": "These values are placeholders. When you type this in, the real value gets inserted (For security reasons)",}+ totp_field_name = self._resolve_parameter_value(parameter.totp_field_name)+# Process all fields generically so it covers passwords and credit cardsfor field in item.fields:if not field.value or field.field_type == ItemFieldType.UNSUPPORTED:@@ -1036,7 +1038,14 @@ class WorkflowRunContext:continuefield_type = field.field_type.value.lower()- if field_type == "totp":+ # A configured totp_field_name overrides 1Password's own field-type detection, for+ # items whose OTP lives in a plain field (e.g. named "digits") rather than a native+ # 1Password one-time-password field.+ is_totp_field = field_type == "totp" or (+ totp_field_name is not None+ and totp_field_name.lower() in {field.id.lower(), (field.title or "").lower()}+ )+ if is_totp_field:random_secret_id = self.generate_random_secret_id()totp_secret_id = f"{random_secret_id}_totp"self.secrets[totp_secret_id] = OnePasswordConstants.TOTPdiff --git a/skyvern/forge/sdk/workflow/models/parameter.py b/skyvern/forge/sdk/workflow/models/parameter.pyindex 025fe25b2..c4d4a93e9 100644--- a/skyvern/forge/sdk/workflow/models/parameter.py+++ b/skyvern/forge/sdk/workflow/models/parameter.py@@ -200,6 +200,10 @@ class OnePasswordCredentialParameter(Parameter):workflow_id: strvault_id: stritem_id: str+ # Item field id or label to treat as the TOTP secret, overriding 1Password's own field-type+ # detection. Needed for items whose OTP is stored in a plain field (e.g. named "digits") rather+ # than a native 1Password one-time-password field.+ totp_field_name: str | None = Nonecreated_at: datetimemodified_at: datetimediff --git a/skyvern/forge/sdk/workflow/workflow_definition_converter.py b/skyvern/forge/sdk/workflow/workflow_definition_converter.pyindex 4c8a153e5..e071cd93b 100644--- a/skyvern/forge/sdk/workflow/workflow_definition_converter.py+++ b/skyvern/forge/sdk/workflow/workflow_definition_converter.py@@ -187,6 +187,7 @@ def convert_workflow_definition(description=parameter.description,vault_id=parameter.vault_id,item_id=parameter.item_id,+ totp_field_name=parameter.totp_field_name,created_at=now,modified_at=now,)diff --git a/skyvern/schemas/run_blocks.py b/skyvern/schemas/run_blocks.pyindex ea0ca4a31..5db82ffdb 100644--- a/skyvern/schemas/run_blocks.py+++ b/skyvern/schemas/run_blocks.py@@ -103,6 +103,11 @@ class LoginRequest(BaseRunBlockRequest):# 1Password credentialonepassword_vault_id: str | None = Field(default=None, description="1Password vault ID")onepassword_item_id: str | None = Field(default=None, description="1Password item ID")+ onepassword_totp_field_name: str | None = Field(+ default=None,+ description="1Password item field id or label to treat as the TOTP secret, overriding "+ "1Password's own field-type detection",+ )# Azure Vault credentialazure_vault_name: str | None = Field(default=None, description="Azure Vault Name")diff --git a/skyvern/schemas/workflows.py b/skyvern/schemas/workflows.pyindex b38adfa70..b06bda750 100644--- a/skyvern/schemas/workflows.py+++ b/skyvern/schemas/workflows.py@@ -733,6 +733,7 @@ class OnePasswordCredentialParameterYAML(ParameterYAML):parameter_type: Literal[ParameterType.ONEPASSWORD] = ParameterType.ONEPASSWORD # type: ignorevault_id: stritem_id: str+ totp_field_name: str | None = Noneclass AzureVaultCredentialParameterYAML(ParameterYAML):diff --git a/tests/unit/test_workflow_onepassword_errors.py b/tests/unit/test_workflow_onepassword_errors.pyindex 58f63eaf2..533b00090 100644--- a/tests/unit/test_workflow_onepassword_errors.py+++ b/tests/unit/test_workflow_onepassword_errors.py@@ -11,6 +11,7 @@ from unittest.mock import AsyncMock, MagicMock, patchimport pytestfrom fastapi import HTTPException+from onepassword import ItemFieldTypefrom onepassword.errors import DesktopSessionExpiredException, RateLimitExceededExceptionfrom skyvern.exceptions import (@@ -28,6 +29,8 @@ from skyvern.forge.sdk.services.credentials import (from skyvern.forge.sdk.workflow.context_manager import WorkflowRunContextfrom skyvern.forge.sdk.workflow.models.parameter import OnePasswordCredentialParameter+_TEST_TOTP_SECRET = "JBSWY3DPEHPK3PXP"+def _make_context() -> WorkflowRunContext:return WorkflowRunContext(@@ -39,7 +42,11 @@ def _make_context() -> WorkflowRunContext:)-def _make_parameter(vault_id: str = "vault123", item_id: str = "item123") -> OnePasswordCredentialParameter:+def _make_parameter(+ vault_id: str = "vault123",+ item_id: str = "item123",+ totp_field_name: str | None = None,+) -> OnePasswordCredentialParameter:now = datetime.now(timezone.utc)return OnePasswordCredentialParameter(key="op_cred",@@ -47,11 +54,16 @@ def _make_parameter(vault_id: str = "vault123", item_id: str = "item123") -> Oneworkflow_id="wf-id",vault_id=vault_id,item_id=item_id,+ totp_field_name=totp_field_name,created_at=now,modified_at=now,)+def _make_field(field_id: str, title: str | None, value: str, field_type: ItemFieldType) -> SimpleNamespace:+ return SimpleNamespace(id=field_id, title=title, value=value, field_type=field_type)++def _make_organization() -> MagicMock:org = MagicMock()org.organization_id = "o_test"@@ -184,6 +196,94 @@ async def test_onepassword_error_includes_resolved_vault_and_item_ids(assert "fake-token" not in message+ "field_type, totp_field_name",+ [+ # Regression: 1Password's own TOTP field type is still auto-detected with no override set.+ (ItemFieldType.TOTP, None),+ # SKY-14541: a plain field (e.g. a custom field named "digits") isn't tagged as 1Password's+ # native TOTP type, so an external automation that writes the OTP seed there needs+ # totp_field_name to tell Skyvern which field carries it. Matching is case-insensitive.+ (ItemFieldType.CONCEALED, "DIGITS"),+ ],+)+async def test_onepassword_totp_field_is_detected(+ mocked_app_database, patched_settings_token, field_type, totp_field_name+):+ ctx = _make_context()+ forge_app.AGENT_FUNCTION.parse_enterprise_totp_secret = AsyncMock(return_value=None)+ fake_item = SimpleNamespace(+ fields=[_make_field("digits", "Digits", _TEST_TOTP_SECRET, field_type)],+ notes=None,+ )+ fake_client = MagicMock()+ fake_client.items.get = AsyncMock(return_value=fake_item)+ with patch(+ "skyvern.forge.sdk.workflow.context_manager.OnePasswordClient.authenticate",+ new_callable=AsyncMock,+ return_value=fake_client,+ ):+ await ctx.register_onepassword_credential_parameter_value(+ _make_parameter(totp_field_name=totp_field_name), _make_organization()+ )++ totp_secret_id = ctx.values["op_cred"]["totp"]+ assert ctx.secrets[ctx.totp_secret_value_key(totp_secret_id)] == _TEST_TOTP_SECRET+++async def test_onepassword_totp_field_name_matches_by_id_when_title_is_missing(+ mocked_app_database, patched_settings_token+):+ """A field with no title (title=None is valid per the 1Password SDK) must still match by id+ instead of raising AttributeError out of the credential registration."""+ ctx = _make_context()+ forge_app.AGENT_FUNCTION.parse_enterprise_totp_secret = AsyncMock(return_value=None)+ fake_item = SimpleNamespace(+ fields=[_make_field("digits", None, _TEST_TOTP_SECRET, ItemFieldType.CONCEALED)],+ notes=None,+ )+ fake_client = MagicMock()+ fake_client.items.get = AsyncMock(return_value=fake_item)+ with patch(+ "skyvern.forge.sdk.workflow.context_manager.OnePasswordClient.authenticate",+ new_callable=AsyncMock,+ return_value=fake_client,+ ):+ await ctx.register_onepassword_credential_parameter_value(+ _make_parameter(totp_field_name="digits"), _make_organization()+ )++ totp_secret_id = ctx.values["op_cred"]["totp"]+ assert ctx.secrets[ctx.totp_secret_value_key(totp_secret_id)] == _TEST_TOTP_SECRET+++async def test_onepassword_unmatched_totp_field_name_falls_back_to_plain_field(+ mocked_app_database, patched_settings_token+):+ """A totp_field_name that matches nothing must not crash the run — the field is registered+ as a plain secret and no TOTP value is set."""+ ctx = _make_context()+ fake_item = SimpleNamespace(+ fields=[_make_field("digits", "Digits", _TEST_TOTP_SECRET, ItemFieldType.CONCEALED)],+ notes=None,+ )+ fake_client = MagicMock()+ fake_client.items.get = AsyncMock(return_value=fake_item)+ with patch(+ "skyvern.forge.sdk.workflow.context_manager.OnePasswordClient.authenticate",+ new_callable=AsyncMock,+ return_value=fake_client,+ ):+ await ctx.register_onepassword_credential_parameter_value(+ _make_parameter(totp_field_name="otp_code"), _make_organization()+ )++ assert "totp" not in ctx.values["op_cred"]++@pytest.mark.asyncioasync def test_onepassword_incidental_5xx_digits_do_not_trigger_service_unavailable(mocked_app_database, patched_settings_token