Skip to content

Automate browser based workflows with AI

fix(SKY-11433): make pre-screenshot load-state wait non-fatal (#6799)

Aaron Perez8a19b3eb6c07
diff --git a/skyvern/config.py b/skyvern/config.py
index f3ec554b7..c4958dea4 100644
--- a/skyvern/config.py
+++ b/skyvern/config.py
@@ -111,6 +111,9 @@ class Settings(BaseSettings):
PAGE_READY_DOM_STABILITY_TIMEOUT_MS: float = 3000 # Max time to wait for DOM stability
BROWSER_SCREENSHOT_TIMEOUT_MS: int = 20000
BROWSER_LOADING_TIMEOUT_MS: int = 60000
+ # Pre-screenshot readiness guard; kept short so a page that never settles
+ # degrades fast instead of burning the full loading-timeout budget.
+ BROWSER_SCREENSHOT_LOAD_STATE_TIMEOUT_MS: int = 5000
BROWSER_SCRAPING_BUILDING_ELEMENT_TREE_TIMEOUT_MS: int = 60 * 1000 # 1 minute
CODE_BLOCK_EXECUTION_TIMEOUT_SECONDS: int = 300
# In-block OTP email/SMS poll budget; bounded under CODE_BLOCK_EXECUTION_TIMEOUT_SECONDS
diff --git a/skyvern/webeye/utils/page.py b/skyvern/webeye/utils/page.py
index 5fbc837d2..3476c5ff8 100644
--- a/skyvern/webeye/utils/page.py
+++ b/skyvern/webeye/utils/page.py
@@ -81,6 +81,19 @@ async def _wait_for_navigation_settle(frame: Page | Frame, timeout_ms: float) ->
return
+async def _wait_for_screenshot_load_state(page: Page, timeout_ms: float) -> None:
+ # Best-effort readiness guard before capturing. 'domcontentloaded' fires far
+ # earlier than 'load'; pages with streaming/long-polling/SSE/websockets or a
+ # persistent spinner may never fire 'load', so a timeout here must be
+ # non-fatal — the capture has its own (separate) timeout budget.
+ if timeout_ms <= 0:
+ return
+ try:
+ await page.wait_for_load_state("domcontentloaded", timeout=timeout_ms)
+ except (PlaywrightError, TimeoutError):
+ LOG.warning("Page did not reach domcontentloaded before screenshot; capturing current state anyway")
+
+
def _load_cursor_overlay_js() -> str:
path = f"{SKYVERN_DIR}/webeye/scraper/cursorOverlay.js"
with open(path, encoding="utf-8") as f:
@@ -151,8 +164,9 @@ async def _current_viewpoint_screenshot_helper(
try:
if mode == ScreenshotMode.DETAILED:
- await page.wait_for_load_state(timeout=SettingsManager.get_settings().BROWSER_LOADING_TIMEOUT_MS)
- LOG.debug("Page is fully loaded, agent is about to take screenshots")
+ await _wait_for_screenshot_load_state(
+ page, timeout_ms=SettingsManager.get_settings().BROWSER_SCREENSHOT_LOAD_STATE_TIMEOUT_MS
+ )
start_time = time.time()
screenshot: bytes = b""
if file_path:
diff --git a/tests/unit/webeye/test_screenshot_load_state_nonfatal.py b/tests/unit/webeye/test_screenshot_load_state_nonfatal.py
new file mode 100644
index 000000000..ed6e80f5e
--- /dev/null
+++ b/tests/unit/webeye/test_screenshot_load_state_nonfatal.py
@@ -0,0 +1,62 @@
+"""A stuck page load-state must not fail an otherwise-capturable screenshot."""
+
+from __future__ import annotations
+
+from unittest.mock import AsyncMock, MagicMock
+
+import pytest
+from playwright._impl._errors import Error as PlaywrightError
+from playwright._impl._errors import TimeoutError as PlaywrightTimeoutError
+from playwright.async_api import Page
+
+from skyvern.webeye.utils.page import ScreenshotMode, _current_viewpoint_screenshot_helper
+
+
+def _make_page(screenshot_bytes: bytes) -> MagicMock:
+ page = MagicMock(spec=Page)
+ page.is_closed.return_value = False
+ page.url = "https://example.test/stream"
+ page.viewport_size = {"width": 1280, "height": 720}
+ page.wait_for_load_state = AsyncMock()
+ page.screenshot = AsyncMock(return_value=screenshot_bytes)
+ return page
+
+
+class TestScreenshotLoadStateNonFatal:
+ @pytest.mark.asyncio
+ async def test_load_state_timeout_does_not_block_screenshot(self) -> None:
+ page = _make_page(b"image-bytes")
+ page.wait_for_load_state = AsyncMock(side_effect=PlaywrightTimeoutError("Timeout 60000ms exceeded"))
+
+ result = await _current_viewpoint_screenshot_helper(page, mode=ScreenshotMode.DETAILED)
+
+ assert result == b"image-bytes"
+ page.screenshot.assert_awaited_once()
+
+ @pytest.mark.asyncio
+ async def test_load_state_playwright_error_does_not_block_screenshot(self) -> None:
+ page = _make_page(b"image-bytes")
+ page.wait_for_load_state = AsyncMock(side_effect=PlaywrightError("Target closed"))
+
+ result = await _current_viewpoint_screenshot_helper(page, mode=ScreenshotMode.DETAILED)
+
+ assert result == b"image-bytes"
+ page.screenshot.assert_awaited_once()
+
+ @pytest.mark.asyncio
+ async def test_detailed_mode_waits_for_domcontentloaded(self) -> None:
+ page = _make_page(b"image-bytes")
+
+ await _current_viewpoint_screenshot_helper(page, mode=ScreenshotMode.DETAILED)
+
+ page.wait_for_load_state.assert_awaited_once()
+ assert page.wait_for_load_state.await_args.args[0] == "domcontentloaded"
+
+ @pytest.mark.asyncio
+ async def test_lite_mode_skips_load_state_wait(self) -> None:
+ page = _make_page(b"image-bytes")
+
+ result = await _current_viewpoint_screenshot_helper(page, mode=ScreenshotMode.LITE)
+
+ assert result == b"image-bytes"
+ page.wait_for_load_state.assert_not_awaited()