Automate browser based workflows with AI
Python aiapiautomationbrowserbrowser-automationcomputergptllmplaywrightpowerautomatepuppeteerpythonrpaseleniumvisionworkflow
Give correct error feedback for json fields in task node (#911)
Kerem Yilmaz8b79dfa2361d
diff --git a/skyvern-frontend/src/routes/workflows/editor/FlowRenderer.tsx b/skyvern-frontend/src/routes/workflows/editor/FlowRenderer.tsxindex bdde8f1c9..63430970e 100644--- a/skyvern-frontend/src/routes/workflows/editor/FlowRenderer.tsx+++ b/skyvern-frontend/src/routes/workflows/editor/FlowRenderer.tsx@@ -63,6 +63,7 @@ import {import { Button } from "@/components/ui/button";import { ReloadIcon } from "@radix-ui/react-icons";import { isLoopNode, LoopNode } from "./nodes/LoopNode/types";+import { isTaskNode } from "./nodes/TaskNode/types";function convertToParametersYAML(parameters: ParametersState,@@ -433,6 +434,40 @@ function FlowRenderer({doLayout(newNodesWithUpdatedParameters, newEdges);}+ function getWorkflowErrors(): Array<string> {+ const errors: Array<string> = [];++ // check loop node parameters+ const loopNodes: Array<LoopNode> = nodes.filter(isLoopNode);+ const emptyLoopNodes = loopNodes.filter(+ (node: LoopNode) => node.data.loopValue === "",+ );+ if (emptyLoopNodes.length > 0) {+ emptyLoopNodes.forEach((node) => {+ errors.push(+ `${node.data.label}: Loop value parameter must be selected`,+ );+ });+ }++ // check task node json fields+ const taskNodes = nodes.filter(isTaskNode);+ taskNodes.forEach((node) => {+ try {+ JSON.parse(node.data.dataSchema);+ } catch {+ errors.push(`${node.data.label}: Data schema is not valid JSON`);+ }+ try {+ JSON.parse(node.data.errorCodeMapping);+ } catch {+ errors.push(`${node.data.label}: Error messages is not valid JSON`);+ }+ });++ return errors;+ }+return (<><Dialog@@ -551,6 +586,21 @@ function FlowRenderer({}}}onSave={async () => {+ const errors = getWorkflowErrors();+ if (errors.length > 0) {+ toast({+ title: "Can not save workflow because of errors:",+ description: (+ <div className="space-y-2">+ {errors.map((error) => (+ <p key={error}>{error}</p>+ ))}+ </div>+ ),+ variant: "destructive",+ });+ return;+ }// TODO might need to abstract this out or find different way to handle errorsconst loopNodes: Array<LoopNode> = nodes.filter(isLoopNode);const emptyLoopNodes = loopNodes.filter(diff --git a/skyvern-frontend/src/routes/workflows/editor/nodes/TaskNode/types.ts b/skyvern-frontend/src/routes/workflows/editor/nodes/TaskNode/types.tsindex 9b31ec2ec..f3560f062 100644--- a/skyvern-frontend/src/routes/workflows/editor/nodes/TaskNode/types.ts+++ b/skyvern-frontend/src/routes/workflows/editor/nodes/TaskNode/types.ts@@ -37,3 +37,7 @@ export const taskNodeDefaultData: TaskNodeData = {totpVerificationUrl: null,totpIdentifier: null,} as const;++export function isTaskNode(node: Node): node is TaskNode {+ return node.type === "task";+}