Automate browser based workflows with AI
Python aiapiautomationbrowserbrowser-automationcomputergptllmplaywrightpowerautomatepuppeteerpythonrpaseleniumvisionworkflow
fix(recording): revert to Playwright default recording size, add config override (#6524)
Shuchang Zheng8e6794daa734
diff --git a/skyvern/config.py b/skyvern/config.pyindex 4038b3a73..651da2104 100644--- a/skyvern/config.py+++ b/skyvern/config.py@@ -231,6 +231,11 @@ class Settings(BaseSettings):DEFAULT_BROWSER_PROFILE_DIR: str = ""BROWSER_WIDTH: int = 1920BROWSER_HEIGHT: int = 1080+ # Playwright's ffmpeg encoder runs continuously while the browser is open and its CPU cost+ # scales with pixel count. Unset means Playwright's default (viewport scaled to fit 800x800);+ # set both to record at an explicit resolution.+ BROWSER_RECORDING_WIDTH: int | None = None+ BROWSER_RECORDING_HEIGHT: int | None = NoneBROWSER_POLICY_FILE: str = "/etc/chromium/policies/managed/policies.json"BROWSER_LOGS_ENABLED: bool = TrueBROWSER_CURSOR_VISUALIZATION: bool = Falsediff --git a/skyvern/webeye/browser_factory.py b/skyvern/webeye/browser_factory.pyindex 42cde0ce6..7885f6c98 100644--- a/skyvern/webeye/browser_factory.py+++ b/skyvern/webeye/browser_factory.py@@ -360,16 +360,17 @@ class BrowserContextFactory:],"record_har_path": har_dir,"record_video_dir": video_dir,- "record_video_size": {- "width": settings.BROWSER_WIDTH,- "height": settings.BROWSER_HEIGHT,- },"viewport": {"width": settings.BROWSER_WIDTH,"height": settings.BROWSER_HEIGHT,},"extra_http_headers": extra_http_headers,}+ if settings.BROWSER_RECORDING_WIDTH and settings.BROWSER_RECORDING_HEIGHT:+ args["record_video_size"] = {+ "width": settings.BROWSER_RECORDING_WIDTH,+ "height": settings.BROWSER_RECORDING_HEIGHT,+ }if settings.BROWSER_LOCALE:args["locale"] = settings.BROWSER_LOCALE@@ -929,7 +930,7 @@ async def _connect_to_cdp_browser()browser_context = await browser.new_context(record_video_dir=browser_args["record_video_dir"],- record_video_size=browser_args["record_video_size"],+ record_video_size=browser_args.get("record_video_size"),viewport=browser_args["viewport"],extra_http_headers=browser_args["extra_http_headers"],)diff --git a/tests/unit/test_proxy_url_custom.py b/tests/unit/test_proxy_url_custom.pyindex 9cf18b950..fd32b0ae8 100644--- a/tests/unit/test_proxy_url_custom.py+++ b/tests/unit/test_proxy_url_custom.py@@ -1,3 +1,6 @@+import pytest++from skyvern.config import settingsfrom skyvern.forge.sdk.db.utils import deserialize_proxy_location, serialize_proxy_locationfrom skyvern.schemas.runs import GeoTarget, ProxyLocationfrom skyvern.webeye.browser_factory import BrowserContextFactory, _redact_proxy_url@@ -33,10 +36,19 @@ def test_build_browser_args_invalid_custom_proxy_url_ignored() -> None:assert "proxy" not in args-def test_build_browser_args_sets_record_video_size_to_viewport() -> None:+def test_build_browser_args_defaults_to_playwright_recording_size() -> None:+ args = BrowserContextFactory.build_browser_args()++ assert "record_video_size" not in args+++def test_build_browser_args_uses_configured_recording_size(monkeypatch: pytest.MonkeyPatch) -> None:+ monkeypatch.setattr(settings, "BROWSER_RECORDING_WIDTH", 1280)+ monkeypatch.setattr(settings, "BROWSER_RECORDING_HEIGHT", 720)+args = BrowserContextFactory.build_browser_args()- assert args["record_video_size"] == args["viewport"]+ assert args["record_video_size"] == {"width": 1280, "height": 720}def test_deserialize_proxy_location_custom_url_returns_dict() -> None: