Skip to content

Automate browser based workflows with AI

fix(SKY-8929): gate worker startup on X display readiness; sanitize browser headers (#6645)

pedrohsdb911b609927a0
diff --git a/skyvern/webeye/browser_factory.py b/skyvern/webeye/browser_factory.py
index 57874de6f..7706741ab 100644
--- a/skyvern/webeye/browser_factory.py
+++ b/skyvern/webeye/browser_factory.py
@@ -108,6 +108,29 @@ def parse_extra_headers(extra_http_headers: dict[str, str] | None) -> ParsedBrow
)
+# RFC 7230 field-name token: the only characters Chromium accepts in a header name.
+_VALID_HEADER_NAME_RE = re.compile(r"[A-Za-z0-9!#$%&'*+.^_`|~-]+")
+# Chromium rejects the whole batch if any value carries these header-injection chars.
+_INVALID_HEADER_VALUE_RE = re.compile(r"[\r\n\x00]")
+
+
+def sanitize_browser_headers(headers: dict[str, str] | None) -> dict[str, str] | None:
+ """Drop entries whose name or value is malformed, so one bad header can't make Chromium
+ reject the whole Network.setExtraHTTPHeaders batch and fail the launch."""
+ if not headers:
+ return None
+ sanitized: dict[str, str] = {}
+ for name, value in headers.items():
+ if not isinstance(name, str) or not _VALID_HEADER_NAME_RE.fullmatch(name):
+ LOG.warning("Dropping invalid extra HTTP header name before browser launch", header_name=name)
+ continue
+ if not isinstance(value, str) or _INVALID_HEADER_VALUE_RE.search(value):
+ LOG.warning("Dropping extra HTTP header with invalid value before browser launch", header_name=name)
+ continue
+ sanitized[name] = value
+ return sanitized or None
+
+
def set_browser_console_log(browser_context: BrowserContext, browser_artifacts: BrowserArtifacts) -> None:
if browser_artifacts.browser_console_log_path is None:
log_path = f"{settings.LOG_PATH}/{datetime.utcnow().strftime('%Y-%m-%d')}/{uuid.uuid4()}.log"
@@ -384,7 +407,7 @@ class BrowserContextFactory:
"width": settings.BROWSER_WIDTH,
"height": settings.BROWSER_HEIGHT,
},
- "extra_http_headers": extra_http_headers,
+ "extra_http_headers": sanitize_browser_headers(extra_http_headers),
}
if settings.BROWSER_RECORDING_WIDTH and settings.BROWSER_RECORDING_HEIGHT:
args["record_video_size"] = {
diff --git a/tests/unit/test_browser_header_sanitization.py b/tests/unit/test_browser_header_sanitization.py
new file mode 100644
index 000000000..f9cbead78
--- /dev/null
+++ b/tests/unit/test_browser_header_sanitization.py
@@ -0,0 +1,53 @@
+"""Tests for extra HTTP header sanitization in browser_factory.py.
+
+A malformed header name passed through extra_http_headers makes Chromium reject the
+whole batch via Network.setExtraHTTPHeaders ("Invalid header name"), which fails browser
+context creation outright (SKY-8929). sanitize_browser_headers drops the bad names so the
+launch survives with the valid headers intact.
+"""
+
+from skyvern.webeye.browser_factory import sanitize_browser_headers
+
+
+class TestSanitizeBrowserHeaders:
+ def test_none_passes_through(self) -> None:
+ assert sanitize_browser_headers(None) is None
+
+ def test_empty_returns_none(self) -> None:
+ assert sanitize_browser_headers({}) is None
+
+ def test_valid_headers_unchanged(self) -> None:
+ headers = {"X-Custom-Header": "value", "Authorization": "Bearer abc", "Accept": "application/json"}
+ assert sanitize_browser_headers(headers) == headers
+
+ def test_token_special_characters_allowed(self) -> None:
+ headers = {"X-Foo_Bar.Baz!#$%&'*+^`|~-": "ok"}
+ assert sanitize_browser_headers(headers) == headers
+
+ def test_drops_header_name_with_space(self) -> None:
+ result = sanitize_browser_headers({"Invalid Header": "v", "Valid-Header": "keep"})
+ assert result == {"Valid-Header": "keep"}
+
+ def test_drops_header_name_with_colon_or_newline(self) -> None:
+ result = sanitize_browser_headers({"Bad:Name": "v", "Bad\nName": "v", "Good-Name": "keep"})
+ assert result == {"Good-Name": "keep"}
+
+ def test_drops_empty_header_name(self) -> None:
+ result = sanitize_browser_headers({"": "v", "Good": "keep"})
+ assert result == {"Good": "keep"}
+
+ def test_all_invalid_collapses_to_none(self) -> None:
+ assert sanitize_browser_headers({"bad name": "v", "": "w"}) is None
+
+ def test_drops_name_with_trailing_newline(self) -> None:
+ # `$` matches before a trailing newline, so this must use fullmatch to be dropped.
+ result = sanitize_browser_headers({"X-Custom\n": "v", "X-Ok": "keep"})
+ assert result == {"X-Ok": "keep"}
+
+ def test_drops_value_with_crlf(self) -> None:
+ result = sanitize_browser_headers({"X-Bad": "ok\r\nInjected: evil", "X-Ok": "keep"})
+ assert result == {"X-Ok": "keep"}
+
+ def test_drops_value_with_newline_or_null(self) -> None:
+ result = sanitize_browser_headers({"X-NL": "a\nb", "X-Null": "a\x00b", "X-Ok": "keep"})
+ assert result == {"X-Ok": "keep"}