Skip to content

Automate browser based workflows with AI

feat: surface dormant trigger-block payload entries in editor (SKY-9259) (#5720)

Aaron Perez94908970cc9b
diff --git a/skyvern-frontend/src/routes/workflows/editor/nodes/WorkflowTriggerNode/PayloadParameterFields.test.tsx b/skyvern-frontend/src/routes/workflows/editor/nodes/WorkflowTriggerNode/PayloadParameterFields.test.tsx
new file mode 100644
index 000000000..77bc95c12
--- /dev/null
+++ b/skyvern-frontend/src/routes/workflows/editor/nodes/WorkflowTriggerNode/PayloadParameterFields.test.tsx
@@ -0,0 +1,80 @@
+// @vitest-environment jsdom
+import { afterEach, describe, expect, it, vi } from "vitest";
+import { cleanup, fireEvent, render, screen } from "@testing-library/react";
+
+afterEach(() => cleanup());
+
+vi.mock("../../../hooks/useCredentialsQuery", () => ({
+ useCredentialsQuery: () => ({ data: [] }),
+}));
+
+vi.mock("@/components/WorkflowBlockInputTextarea", () => ({
+ WorkflowBlockInputTextarea: (props: {
+ value: string;
+ onChange: (v: string) => void;
+ placeholder?: string;
+ }) => (
+ <input
+ data-testid="wb-input"
+ value={props.value}
+ placeholder={props.placeholder}
+ onChange={(e) => props.onChange(e.target.value)}
+ />
+ ),
+}));
+
+vi.mock("../../../components/CredentialSelector", () => ({
+ CredentialSelector: () => <div data-testid="cred-selector" />,
+}));
+
+import { PayloadParameterFields } from "./PayloadParameterFields";
+
+describe("PayloadParameterFields", () => {
+ it("renders only the placeholder when target has 0 params and payload is empty", () => {
+ render(
+ <PayloadParameterFields
+ parameters={[]}
+ payload="{}"
+ onChange={vi.fn()}
+ nodeId="n1"
+ isLoading={false}
+ />,
+ );
+ expect(screen.getByText(/no input parameters/i)).toBeTruthy();
+ expect(screen.queryByText(/dormant payload entries/i)).not.toBeTruthy();
+ });
+
+ it("surfaces dormant entries when target has 0 params but payload has saved keys", () => {
+ render(
+ <PayloadParameterFields
+ parameters={[]}
+ payload={JSON.stringify({ file_url: "{{ x..y }}", text: "hi" })}
+ onChange={vi.fn()}
+ nodeId="n1"
+ isLoading={false}
+ />,
+ );
+ expect(screen.getByText(/dormant payload entries/i)).toBeTruthy();
+ expect(screen.getByText("file_url")).toBeTruthy();
+ expect(screen.getByText("{{ x..y }}")).toBeTruthy();
+ expect(screen.getByText("text")).toBeTruthy();
+ expect(screen.getByText("hi")).toBeTruthy();
+ });
+
+ it("delete-dormant-key button calls onChange without that key", () => {
+ const onChange = vi.fn();
+ render(
+ <PayloadParameterFields
+ parameters={[]}
+ payload={JSON.stringify({ file_url: "x", text: "y" })}
+ onChange={onChange}
+ nodeId="n1"
+ isLoading={false}
+ />,
+ );
+ fireEvent.click(screen.getByRole("button", { name: /delete file_url/i }));
+ expect(onChange).toHaveBeenCalledWith(
+ JSON.stringify({ text: "y" }, null, 2),
+ );
+ });
+});
diff --git a/skyvern-frontend/src/routes/workflows/editor/nodes/WorkflowTriggerNode/PayloadParameterFields.tsx b/skyvern-frontend/src/routes/workflows/editor/nodes/WorkflowTriggerNode/PayloadParameterFields.tsx
index 6b3f33550..7d713b98a 100644
--- a/skyvern-frontend/src/routes/workflows/editor/nodes/WorkflowTriggerNode/PayloadParameterFields.tsx
+++ b/skyvern-frontend/src/routes/workflows/editor/nodes/WorkflowTriggerNode/PayloadParameterFields.tsx
@@ -124,7 +124,13 @@ function PayloadParameterFields({
);
}
- if (parameters.length === 0) {
+ const payloadValues = parsePayload(payload);
+ const declaredKeys = new Set(parameters.map((p) => p.key));
+ const staleKeys = Object.keys(payloadValues).filter(
+ (k) => !declaredKeys.has(k),
+ );
+
+ if (parameters.length === 0 && staleKeys.length === 0) {
return (
<p className="text-xs text-slate-500">
This workflow has no input parameters.
@@ -132,10 +138,13 @@ function PayloadParameterFields({
);
}
- const payloadValues = parsePayload(payload);
-
return (
<div className="space-y-3">
+ {parameters.length === 0 && (
+ <p className="text-xs text-slate-500">
+ This workflow has no input parameters.
+ </p>
+ )}
{parameters.map((param) => {
const isCredential = isCredentialParam(param);
const isDynamic = dynamicCredentialKeys.has(param.key);
@@ -196,6 +205,39 @@ function PayloadParameterFields({
</div>
);
})}
+
+ {staleKeys.length > 0 && (
+ <div className="space-y-1.5 rounded border border-amber-700/40 bg-amber-950/20 p-2">
+ <p className="text-[10px] font-medium uppercase text-amber-400">
+ Dormant payload entries
+ </p>
+ <p className="text-[10px] text-slate-400">
+ The target workflow no longer declares these parameters. They are
+ saved but never consumed at runtime, and any malformed Jinja2 here
+ will still fail the trigger at execute time. Delete or align the
+ target.
+ </p>
+ {staleKeys.map((key) => (
+ <div key={key} className="flex items-center gap-2">
+ <Label className="text-xs text-slate-300">{key}</Label>
+ <code
+ className="min-w-0 grow truncate text-[10px] text-slate-400"
+ title={payloadValues[key]}
+ >
+ {payloadValues[key]}
+ </code>
+ <button
+ type="button"
+ aria-label={`delete ${key}`}
+ className="text-xs text-red-400 hover:underline"
+ onClick={() => handleFieldChange(key, "")}
+ >
+ delete
+ </button>
+ </div>
+ ))}
+ </div>
+ )}
</div>
);
}