Skip to content

Automate browser based workflows with AI

fix: improve TextPromptBlock error handling and LLM error diagnostics (SKY-8584) (#5333)

pedrohsdb9cfa3989d92a
diff --git a/skyvern/forge/sdk/api/llm/api_handler_factory.py b/skyvern/forge/sdk/api/llm/api_handler_factory.py
index 91b14adcb..e028a9533 100644
--- a/skyvern/forge/sdk/api/llm/api_handler_factory.py
+++ b/skyvern/forge/sdk/api/llm/api_handler_factory.py
@@ -756,7 +756,7 @@ class LLMAPIHandlerFactory:
fallback_model=response_model,
)
except litellm.exceptions.APIError as e:
- raise LLMProviderErrorRetryableTask(llm_key) from e
+ raise LLMProviderErrorRetryableTask(llm_key, cause=e) from e
except litellm.exceptions.ContextWindowExceededError as e:
duration_seconds = time.time() - start_time
LOG.exception(
@@ -776,7 +776,7 @@ class LLMAPIHandlerFactory:
prompt_name=prompt_name,
duration_seconds=duration_seconds,
)
- raise LLMProviderErrorRetryableTask(llm_key) from e
+ raise LLMProviderErrorRetryableTask(llm_key, cause=e) from e
except Exception as e:
duration_seconds = time.time() - start_time
LOG.exception(
@@ -786,7 +786,7 @@ class LLMAPIHandlerFactory:
prompt_name=prompt_name,
duration_seconds=duration_seconds,
)
- raise LLMProviderError(llm_key) from e
+ raise LLMProviderError(llm_key, cause=e) from e
llm_response_json = _safe_model_dump_json(response)
if should_persist_llm_artifacts:
@@ -1207,7 +1207,7 @@ class LLMAPIHandlerFactory:
**active_parameters,
)
except litellm.exceptions.APIError as e:
- raise LLMProviderErrorRetryableTask(llm_key) from e
+ raise LLMProviderErrorRetryableTask(llm_key, cause=e) from e
except litellm.exceptions.ContextWindowExceededError as e:
duration_seconds = time.time() - start_time
LOG.exception(
@@ -1249,7 +1249,7 @@ class LLMAPIHandlerFactory:
prompt_name=prompt_name,
duration_seconds=duration_seconds,
)
- raise LLMProviderError(llm_key) from e
+ raise LLMProviderError(llm_key, cause=e) from e
llm_response_json = _safe_model_dump_json(response)
if should_persist_llm_artifacts:
@@ -1657,7 +1657,7 @@ class LLMCaller:
# only update message_history when the request is successful
self.message_history = messages
except litellm.exceptions.APIError as e:
- raise LLMProviderErrorRetryableTask(self.llm_key) from e
+ raise LLMProviderErrorRetryableTask(self.llm_key, cause=e) from e
except litellm.exceptions.ContextWindowExceededError as e:
LOG.exception(
"Context window exceeded",
@@ -1687,7 +1687,7 @@ class LLMCaller:
raise LLMProviderError(self.llm_key) from None
except Exception as e:
LOG.exception("LLM request failed unexpectedly", llm_key=self.llm_key)
- raise LLMProviderError(self.llm_key) from e
+ raise LLMProviderError(self.llm_key, cause=e) from e
llm_response_json = _safe_model_dump_json(response)
if should_persist_llm_artifacts:
diff --git a/skyvern/forge/sdk/api/llm/exceptions.py b/skyvern/forge/sdk/api/llm/exceptions.py
index 896189170..107f9eb81 100644
--- a/skyvern/forge/sdk/api/llm/exceptions.py
+++ b/skyvern/forge/sdk/api/llm/exceptions.py
@@ -45,14 +45,16 @@ class InvalidLLMConfigError(BaseLLMError):
class LLMProviderError(BaseLLMError):
- def __init__(self, llm_key: str) -> None:
- super().__init__(f"Error while using LLMProvider {llm_key}")
+ def __init__(self, llm_key: str, cause: Exception | None = None) -> None:
+ detail = f" — {type(cause).__name__}: {cause}" if cause else ""
+ super().__init__(f"Error while using LLMProvider {llm_key}{detail}")
class LLMProviderErrorRetryableTask(LLMProviderError):
- def __init__(self, llm_key: str) -> None:
- # Call BaseLLMError directly to avoid double-formatting the message through LLMProviderError.__init__
- BaseLLMError.__init__(self, f"Retryable error while using LLMProvider {llm_key}")
+ def __init__(self, llm_key: str, cause: Exception | None = None) -> None:
+ detail = f" — {type(cause).__name__}: {cause}" if cause else ""
+ # Skip LLMProviderError.__init__ to set our own message prefix
+ SkyvernException.__init__(self, f"Retryable error while using LLMProvider {llm_key}{detail}")
class NoProviderEnabledError(BaseLLMError):
diff --git a/skyvern/forge/sdk/workflow/models/block.py b/skyvern/forge/sdk/workflow/models/block.py
index c6b52fc44..558183176 100644
--- a/skyvern/forge/sdk/workflow/models/block.py
+++ b/skyvern/forge/sdk/workflow/models/block.py
@@ -2662,6 +2662,24 @@ class TextPromptBlock(Block):
# get all parameters into a dictionary
parameter_values = {}
for parameter in self.parameters:
+ if not workflow_run_context.has_value(parameter.key):
+ LOG.warning(
+ "TextPromptBlock missing required parameter",
+ block_label=self.label,
+ parameter_key=parameter.key,
+ workflow_run_id=workflow_run_id,
+ )
+ return await self.build_block_result(
+ success=False,
+ failure_reason=(
+ f"Parameter '{parameter.key}' is not available in the workflow context. "
+ f"An upstream block that produces this value may have failed or been skipped."
+ ),
+ output_parameter_value=None,
+ status=BlockStatus.failed,
+ workflow_run_block_id=workflow_run_block_id,
+ organization_id=organization_id,
+ )
value = workflow_run_context.get_value(parameter.key)
secret_value = workflow_run_context.get_original_secret_value_or_none(value)
if secret_value:
@@ -2669,13 +2687,29 @@ class TextPromptBlock(Block):
else:
parameter_values[parameter.key] = value
- response = await self.send_prompt(
- self.prompt,
- parameter_values,
- workflow_run_id,
- organization_id,
- workflow_run_block_id=workflow_run_block_id,
- )
+ try:
+ response = await self.send_prompt(
+ self.prompt,
+ parameter_values,
+ workflow_run_id,
+ organization_id,
+ workflow_run_block_id=workflow_run_block_id,
+ )
+ except Exception as e:
+ LOG.exception(
+ "TextPromptBlock LLM call failed",
+ block_label=self.label,
+ workflow_run_id=workflow_run_id,
+ llm_key=self.override_llm_key or self.llm_key,
+ )
+ return await self.build_block_result(
+ success=False,
+ failure_reason=f"LLM call failed: {e}",
+ output_parameter_value=None,
+ status=BlockStatus.failed,
+ workflow_run_block_id=workflow_run_block_id,
+ organization_id=organization_id,
+ )
await self.record_output_parameter_value(workflow_run_context, workflow_run_id, response)
return await self.build_block_result(
success=True,