Skip to content

Automate browser based workflows with AI

Protect API-key creation and provision role fixture key (#8981)

Aaron Perez9e0691c831b0
diff --git a/skyvern-frontend/src/routes/browserProfiles/hooks/useBrowserProfileQueries.test.tsx b/skyvern-frontend/src/routes/browserProfiles/hooks/useBrowserProfileQueries.test.tsx
new file mode 100644
index 000000000..8eeb753d1
--- /dev/null
+++ b/skyvern-frontend/src/routes/browserProfiles/hooks/useBrowserProfileQueries.test.tsx
@@ -0,0 +1,58 @@
+// @vitest-environment jsdom
+
+import type { ReactNode } from "react";
+import { QueryClient, QueryClientProvider } from "@tanstack/react-query";
+import { act, renderHook } from "@testing-library/react";
+import { afterEach, describe, expect, it, vi } from "vitest";
+
+const { mockGet } = vi.hoisted(() => ({ mockGet: vi.fn() }));
+
+vi.mock("@/api/AxiosClient", () => ({
+ getClient: () => Promise.resolve({ get: mockGet }),
+}));
+vi.mock("@/hooks/useCredentialGetter", () => ({
+ useCredentialGetter: () => () => Promise.resolve("test-token"),
+}));
+
+import { useBrowserProfileQuery } from "./useBrowserProfileQuery";
+import { useBrowserProfileUsageQuery } from "./useBrowserProfileUsageQuery";
+
+function wrapper({ children }: { children: ReactNode }) {
+ return (
+ <QueryClientProvider
+ client={
+ new QueryClient({ defaultOptions: { queries: { retry: false } } })
+ }
+ >
+ {children}
+ </QueryClientProvider>
+ );
+}
+
+afterEach(() => vi.clearAllMocks());
+
+describe("browser profile queries", () => {
+ it("does not fetch a missing profile even when callers enable the query", async () => {
+ const { result } = renderHook(
+ () => useBrowserProfileQuery(undefined, { enabled: true }),
+ { wrapper },
+ );
+
+ await act(() => new Promise((resolve) => setTimeout(resolve, 0)));
+
+ expect(result.current.fetchStatus).toBe("idle");
+ expect(mockGet).not.toHaveBeenCalled();
+ });
+
+ it("does not fetch usage for a missing profile even when callers enable the query", async () => {
+ const { result } = renderHook(
+ () => useBrowserProfileUsageQuery(undefined, { enabled: true }),
+ { wrapper },
+ );
+
+ await act(() => new Promise((resolve) => setTimeout(resolve, 0)));
+
+ expect(result.current.fetchStatus).toBe("idle");
+ expect(mockGet).not.toHaveBeenCalled();
+ });
+});
diff --git a/skyvern-frontend/src/routes/browserProfiles/hooks/useBrowserProfileQuery.ts b/skyvern-frontend/src/routes/browserProfiles/hooks/useBrowserProfileQuery.ts
index db5cab4e9..9bb77409e 100644
--- a/skyvern-frontend/src/routes/browserProfiles/hooks/useBrowserProfileQuery.ts
+++ b/skyvern-frontend/src/routes/browserProfiles/hooks/useBrowserProfileQuery.ts
@@ -23,9 +23,9 @@ function useBrowserProfileQuery(
.get<BrowserProfileApiResponse>(`/browser_profiles/${profileId}`)
.then((response) => response.data);
},
- enabled: Boolean(profileId),
staleTime: 5 * 60 * 1000,
...options,
+ enabled: Boolean(profileId) && (options.enabled ?? true),
});
}
diff --git a/skyvern-frontend/src/routes/browserProfiles/hooks/useBrowserProfileUsageQuery.ts b/skyvern-frontend/src/routes/browserProfiles/hooks/useBrowserProfileUsageQuery.ts
index 051cf416b..f6e7eab09 100644
--- a/skyvern-frontend/src/routes/browserProfiles/hooks/useBrowserProfileUsageQuery.ts
+++ b/skyvern-frontend/src/routes/browserProfiles/hooks/useBrowserProfileUsageQuery.ts
@@ -23,9 +23,9 @@ function useBrowserProfileUsageQuery(
.get<BrowserProfileUsage>(`/browser_profiles/${profileId}/usage`)
.then((response) => response.data);
},
- enabled: Boolean(profileId),
staleTime: 60 * 1000,
...options,
+ enabled: Boolean(profileId) && (options.enabled ?? true),
});
}