Automate browser based workflows with AI
Python aiapiautomationbrowserbrowser-automationcomputergptllmplaywrightpowerautomatepuppeteerpythonrpaseleniumvisionworkflow
Revert validated proxy session pool (#6206)
Shuchang Zhenga125d33ea665
diff --git a/skyvern/forge/agent.py b/skyvern/forge/agent.pyindex 96c54c91c..dfcd69580 100644--- a/skyvern/forge/agent.py+++ b/skyvern/forge/agent.py@@ -4377,14 +4377,6 @@ class ForgeAgent:await self.cleanup_browser_and_create_artifacts(close_browser_on_completion, last_step, task, browser_session_id=browser_session_id)- try:- await app.AGENT_FUNCTION.release_proxy_session_for_owner(task.task_id)- except Exception:- LOG.warning(- "Failed to release proxy session for task",- exc_info=True,- task_id=task.task_id,- )# Wait for all tasks to complete before generating the links for the artifactswith _tracer.start_as_current_span("skyvern.agent.cleanup.wait_for_upload") as _cl_wait_span:diff --git a/skyvern/forge/agent_functions.py b/skyvern/forge/agent_functions.pyindex 5ebe09371..26e510254 100644--- a/skyvern/forge/agent_functions.py+++ b/skyvern/forge/agent_functions.py@@ -706,15 +706,6 @@ class AgentFunction:async def post_cache_step_execution(self, task: Task, step: Step) -> None:return- async def release_proxy_session_for_owner(self, owner_id: str) -> None:- """Release any proxy lease held by ``owner_id``.-- OSS no-op. Cloud overrides this to release the lease back to the- proxy-session pool so workflow/task cleanup doesn't have to- import cloud-only modules from the OSS-synced ``skyvern/`` tree.- """- return None-async def wait_for_challenge_solver(self, page: Page) -> None:"""Wait for a cloud-managed challenge solver if one is attached to the page.diff --git a/skyvern/forge/sdk/workflow/service.py b/skyvern/forge/sdk/workflow/service.pyindex f4c959def..ff475b20c 100644--- a/skyvern/forge/sdk/workflow/service.py+++ b/skyvern/forge/sdk/workflow/service.py@@ -5476,14 +5476,6 @@ class WorkflowService:organization_id=workflow_run.organization_id,child_workflow_run_ids=child_workflow_run_ids,)- try:- await app.AGENT_FUNCTION.release_proxy_session_for_owner(workflow_run.workflow_run_id)- except Exception:- LOG.warning(- "Failed to release proxy session for workflow run",- exc_info=True,- workflow_run_id=workflow_run.workflow_run_id,- )if browser_state:await self.persist_video_data(browser_state, workflow, workflow_run, close_browser_on_completion=close_browser_on_completiondiff --git a/tests/unit/test_workflow_service_profile_writeback.py b/tests/unit/test_workflow_service_profile_writeback.pyindex a1bedaf72..a26fc1444 100644--- a/tests/unit/test_workflow_service_profile_writeback.py+++ b/tests/unit/test_workflow_service_profile_writeback.py@@ -48,7 +48,6 @@ def _patch_clean_up_deps(monkeypatch: pytest.MonkeyPatch, browser_state: MagicMomonkeypatch.setattr(app.STORAGE, "save_downloaded_files", AsyncMock())monkeypatch.setattr(app.BROWSER_MANAGER, "cleanup_for_workflow_run", AsyncMock(return_value=browser_state))monkeypatch.setattr(app.ARTIFACT_MANAGER, "wait_for_upload_aiotasks", AsyncMock())- monkeypatch.setattr(app.AGENT_FUNCTION, "release_proxy_session_for_owner", AsyncMock())monkeypatch.setattr(app.DATABASE.workflow_runs,"get_workflow_runs_by_parent_workflow_run_id",