Automate browser based workflows with AI
Python aiapiautomationbrowserbrowser-automationcomputergptllmplaywrightpowerautomatepuppeteerpythonrpaseleniumvisionworkflow
fix: clarify applied Copilot changes label (#6988)
Aaron Pereza3724498b56c
diff --git a/skyvern-frontend/src/routes/workflows/copilot/WorkflowCopilotChat.queue.test.tsx b/skyvern-frontend/src/routes/workflows/copilot/WorkflowCopilotChat.queue.test.tsxindex 205c31ab5..ff6df0c3c 100644--- a/skyvern-frontend/src/routes/workflows/copilot/WorkflowCopilotChat.queue.test.tsx+++ b/skyvern-frontend/src/routes/workflows/copilot/WorkflowCopilotChat.queue.test.tsx@@ -6,6 +6,7 @@ import {screen,waitFor,} from "@testing-library/react";+import type { ComponentProps } from "react";import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";import { useCopilotActionStore } from "@/store/useCopilotActionStore";@@ -162,8 +163,10 @@ const workflowDraft = () => ({workflow: { workflow_id: "wf_draft" },});-async function renderChat() {- const view = render(<WorkflowCopilotChat />);+async function renderChat(+ props: ComponentProps<typeof WorkflowCopilotChat> = {},+) {+ const view = render(<WorkflowCopilotChat {...props} />);// Let the mount-time chat-history fetch settle.await waitFor(() =>expect(screen.getByPlaceholderText(/Message Skyvern Copilot/)).toBeTruthy(),@@ -697,6 +700,150 @@ describe("WorkflowCopilotChat — keep the chat live during a turn", () => {expect(screen.getByRole("button", { name: "Reject" })).toBeTruthy();});+ it("keeps a rejected history-loaded auto-applicable draft labeled as proposed changes", async () => {+ historyResponse.data = {+ workflow_copilot_chat_id: "chat-1",+ chat_history: [+ {+ sender: "user",+ content: "build me a workflow",+ created_at: "2026-05-25T00:00:00Z",+ },+ {+ sender: "ai",+ content: "I drafted workflow changes for review.",+ created_at: "2026-05-25T00:00:05Z",+ narrative_payload: {+ turnId: "turn-1",+ turnIndex: 0,+ mode: "build",+ responseType: "REPLY",+ cancelled: false,+ proposalDisposition: "auto_applicable",+ designStarted: true,+ designEnded: true,+ draft: {+ blockCount: 1,+ blockLabels: ["open_page"],+ summary: null,+ },+ blocks: [+ {+ workflowRunBlockId: "",+ label: "open_page",+ blockType: "goto_url",+ state: "drafted",+ lastSeenIteration: 0,+ activity: [],+ startedAt: null,+ endedAt: null,+ },+ ],+ terminal: "response",+ terminalMessage: "I drafted workflow changes for review.",+ narrativeSummary: "I drafted workflow changes for review.",+ priorBlockCount: null,+ designActivity: [],+ startedAt: "2026-05-25T00:00:00Z",+ endedAt: "2026-05-25T00:00:05Z",+ },+ },+ ],+ proposed_workflow: { workflow_id: "wf_draft" },+ auto_accept: false,+ };++ const portalTarget = document.createElement("div");+ document.body.appendChild(portalTarget);+ await renderChat({ docked: true, portalTarget });++ expect(screen.getByText("Proposed changes")).toBeTruthy();+ await act(async () => {+ fireEvent.click(screen.getByRole("button", { name: "Reject" }));+ });++ expect(screen.queryByRole("button", { name: "Reject" })).toBeNull();+ expect(screen.getByText("Proposed changes")).toBeTruthy();+ expect(screen.queryByText("Applied changes")).toBeNull();+ portalTarget.remove();+ });++ it("relabels an auto-applicable draft as applied changes once accepted", async () => {+ historyResponse.data = {+ workflow_copilot_chat_id: "chat-1",+ chat_history: [+ {+ sender: "user",+ content: "build me a workflow",+ created_at: "2026-05-25T00:00:00Z",+ },+ {+ sender: "ai",+ content: "I drafted workflow changes for review.",+ created_at: "2026-05-25T00:00:05Z",+ narrative_payload: {+ turnId: "turn-1",+ turnIndex: 0,+ mode: "build",+ responseType: "REPLY",+ cancelled: false,+ proposalDisposition: "auto_applicable",+ designStarted: true,+ designEnded: true,+ draft: {+ blockCount: 1,+ blockLabels: ["open_page"],+ summary: null,+ },+ blocks: [+ {+ workflowRunBlockId: "",+ label: "open_page",+ blockType: "goto_url",+ state: "drafted",+ lastSeenIteration: 0,+ activity: [],+ startedAt: null,+ endedAt: null,+ },+ ],+ terminal: "response",+ terminalMessage: "I drafted workflow changes for review.",+ narrativeSummary: "I drafted workflow changes for review.",+ priorBlockCount: null,+ designActivity: [],+ startedAt: "2026-05-25T00:00:00Z",+ endedAt: "2026-05-25T00:00:05Z",+ },+ },+ ],+ proposed_workflow: { workflow_id: "wf_draft" },+ auto_accept: false,+ };++ const portalTarget = document.createElement("div");+ document.body.appendChild(portalTarget);+ await renderChat({ docked: true, portalTarget });++ expect(screen.getByText("Proposed changes")).toBeTruthy();+ expect(screen.queryByText("Applied changes")).toBeNull();++ await act(async () => {+ fireEvent.click(screen.getByRole("button", { name: "Accept" }));+ });++ await waitFor(() =>+ expect(screen.queryByRole("button", { name: "Accept" })).toBeNull(),+ );+ expect(cancelPost).toHaveBeenCalledWith(+ "/workflow/copilot/apply-proposed-workflow",+ expect.objectContaining({ workflow_copilot_chat_id: "chat-1" }),+ );+ expect(screen.getByText("Applied changes")).toBeTruthy();+ expect(screen.queryByText("Proposed changes")).toBeNull();+ portalTarget.remove();+ });+it("renders an ASK_QUESTION response payload as a question", async () => {await renderChat();await submit("build a lookup workflow");diff --git a/skyvern-frontend/src/routes/workflows/copilot/WorkflowCopilotChat.tsx b/skyvern-frontend/src/routes/workflows/copilot/WorkflowCopilotChat.tsxindex 362bc3c56..dab1e8360 100644--- a/skyvern-frontend/src/routes/workflows/copilot/WorkflowCopilotChat.tsx+++ b/skyvern-frontend/src/routes/workflows/copilot/WorkflowCopilotChat.tsx@@ -246,6 +246,16 @@ interface ChatMessage {narrative?: TurnNarrativeState;}+const getLatestDiffCardTurnId = (messages: ChatMessage[]): string | null => {+ for (let index = messages.length - 1; index >= 0; index -= 1) {+ const narrative = messages[index]?.narrative;+ if (narrative?.turnId && shouldShowDiffCard(narrative)) {+ return narrative.turnId;+ }+ }+ return null;+};+type QueuedPrompt = {id: string;content: string;@@ -485,6 +495,11 @@ export function WorkflowCopilotChat({const [messages, setMessages] = useState<ChatMessage[]>([]);const [proposedWorkflow, setProposedWorkflow] =useState<WorkflowApiResponse | null>(null);+ // Turn IDs the user explicitly rejected. This is client-local because reject+ // only reverts the local canvas; the backend proposalDisposition stays fixed.+ const [rejectedTurnIds, setRejectedTurnIds] = useState<Set<string>>(+ new Set(),+ );const [autoAccept, setAutoAccept] = useState<boolean>(false);const [inputValue, setInputValue] = useState("");const [isLoading, setIsLoading] = useState(false);@@ -687,6 +702,7 @@ export function WorkflowCopilotChat({setWorkflowCopilotChatId(null);setProposedWorkflow(null);setAutoAccept(false);+ setRejectedTurnIds(new Set());setNarrative(EMPTY_NARRATIVE);turnSnapshots.current.clear();pendingSubmitSnapshot.current = null;@@ -719,6 +735,10 @@ export function WorkflowCopilotChat({return hydrated;})(),}));+ const pendingProposalTurnId = data.proposed_workflow+ ? getLatestDiffCardTurnId(historyMessages)+ : null;+ latestTurnId.current = pendingProposalTurnId;setMessages(historyMessages);setWorkflowCopilotChatId(data.workflow_copilot_chat_id);setProposedWorkflow(data.proposed_workflow ?? null);@@ -733,6 +753,7 @@ export function WorkflowCopilotChat({if (!workflowPermanentId) return;setIsLoadingHistory(true);updateQueuedPrompt(null);+ setRejectedTurnIds(new Set());setNarrative(EMPTY_NARRATIVE);turnSnapshots.current.clear();pendingSubmitSnapshot.current = null;@@ -878,11 +899,14 @@ export function WorkflowCopilotChat({// The staged proposal was rendered onto the canvas mid-turn (via// WORKFLOW_DRAFT). Reject must revert the canvas to the pre-submit// canvas state captured client-side at submit time.- const turnId = latestTurnId.current;+ const turnId = latestTurnId.current ?? getLatestDiffCardTurnId(messages);const entry = turnId ? turnSnapshots.current.get(turnId) : null;if (entry?.snapshot) {applyWorkflowUpdate(entry.snapshot);}+ if (turnId) {+ setRejectedTurnIds((prev) => new Set(prev).add(turnId));+ }setProposedWorkflow(null);void clearProposedWorkflow(false);};@@ -2194,7 +2218,14 @@ export function WorkflowCopilotChat({</div>) : null}{docked && shouldShowDiffCard(message.narrative) ? (- <DiffCard turn={message.narrative} />+ <DiffCard+ pendingProposal={showProposalActions}+ rejected={+ message.narrative.turnId !== null &&+ rejectedTurnIds.has(message.narrative.turnId)+ }+ turn={message.narrative}+ />) : null}{docked &&isLastMessage &&diff --git a/skyvern-frontend/src/routes/workflows/copilot/cards/DiffCard.test.ts b/skyvern-frontend/src/routes/workflows/copilot/cards/DiffCard.test.tsnew file mode 100644index 000000000..4d3934775--- /dev/null+++ b/skyvern-frontend/src/routes/workflows/copilot/cards/DiffCard.test.ts@@ -0,0 +1,82 @@+import { describe, expect, it } from "vitest";++import { EMPTY_NARRATIVE, type TurnNarrativeState } from "../narrativeState";+import { getDiffCardTitle } from "./diffCardTitle";++const turn = (+ overrides: Partial<TurnNarrativeState> = {},+): TurnNarrativeState => ({+ ...EMPTY_NARRATIVE,+ turnId: "turn-1",+ turnIndex: 0,+ mode: "build",+ designStarted: true,+ designEnded: true,+ draft: {+ blockCount: 1,+ blockLabels: ["block_1"],+ summary: null,+ },+ proposalDisposition: "auto_applicable",+ terminal: "response",+ ...overrides,+});++describe("getDiffCardTitle", () => {+ it("labels auto-applied workflow updates as applied changes", () => {+ expect(getDiffCardTitle(turn())).toBe("Applied changes");+ });++ it("labels pending proposals as proposed changes", () => {+ expect(getDiffCardTitle(turn(), { pendingProposal: true })).toBe(+ "Proposed changes",+ );+ });++ it.each(["review_untested", "review_tested"] as const)(+ "keeps %s drafts labeled as proposed changes",+ (proposalDisposition) => {+ expect(getDiffCardTitle(turn({ proposalDisposition }))).toBe(+ "Proposed changes",+ );+ },+ );++ it("never labels a rejected auto-applicable draft as applied changes", () => {+ expect(getDiffCardTitle(turn(), { rejected: true })).toBe(+ "Proposed changes",+ );+ });++ it("labels cancelled auto-applicable drafts as proposed changes", () => {+ expect(getDiffCardTitle(turn({ cancelled: true }))).toBe(+ "Proposed changes",+ );+ });++ it("labels errored auto-applicable drafts as proposed changes", () => {+ expect(getDiffCardTitle(turn({ terminal: "error" }))).toBe(+ "Proposed changes",+ );+ });++ it("defaults an unknown or missing disposition to proposed changes", () => {+ expect(getDiffCardTitle(turn({ proposalDisposition: null }))).toBe(+ "Proposed changes",+ );+ });++ it("preserves a backend-supplied draft summary", () => {+ expect(+ getDiffCardTitle(+ turn({+ draft: {+ blockCount: 1,+ blockLabels: ["block_1"],+ summary: "Added browser step",+ },+ }),+ ),+ ).toBe("Added browser step");+ });+});diff --git a/skyvern-frontend/src/routes/workflows/copilot/cards/DiffCard.tsx b/skyvern-frontend/src/routes/workflows/copilot/cards/DiffCard.tsxindex c314c40a2..444860e20 100644--- a/skyvern-frontend/src/routes/workflows/copilot/cards/DiffCard.tsx+++ b/skyvern-frontend/src/routes/workflows/copilot/cards/DiffCard.tsx@@ -1,6 +1,7 @@import { MagicWandIcon } from "@radix-ui/react-icons";import { TurnNarrativeState } from "../narrativeState";+import { getDiffCardTitle } from "./diffCardTitle";// eslint-disable-next-line react-refresh/only-export-componentsexport function shouldShowDiffCard(turn: TurnNarrativeState): boolean {@@ -13,7 +14,15 @@ export function shouldShowDiffCard(turn: TurnNarrativeState): boolean {return turn.draft.blockLabels.length > 0;}-export function DiffCard({ turn }: { turn: TurnNarrativeState }) {+export function DiffCard({+ pendingProposal = false,+ rejected = false,+ turn,+}: {+ pendingProposal?: boolean;+ rejected?: boolean;+ turn: TurnNarrativeState;+}) {const draft = turn.draft;if (!draft) {return null;@@ -29,7 +38,7 @@ export function DiffCard({ turn }: { turn: TurnNarrativeState }) {<div className="rounded-lg border border-border bg-slate-elevation2 p-3"><div className="flex items-center gap-2 text-xs font-semibold text-studio-accent-2"><MagicWandIcon className="h-3.5 w-3.5" />- {draft.summary ?? "Proposed changes"}+ {getDiffCardTitle(turn, { pendingProposal, rejected })}</div>{draft.blockLabels.length > 0 ? (<div className="mt-2">diff --git a/skyvern-frontend/src/routes/workflows/copilot/cards/diffCardTitle.ts b/skyvern-frontend/src/routes/workflows/copilot/cards/diffCardTitle.tsnew file mode 100644index 000000000..80c98e91b--- /dev/null+++ b/skyvern-frontend/src/routes/workflows/copilot/cards/diffCardTitle.ts@@ -0,0 +1,32 @@+import { TurnNarrativeState } from "../narrativeState";++type DiffCardTitleOptions = {+ pendingProposal?: boolean;+ rejected?: boolean;+};++export function getDiffCardTitle(+ turn: TurnNarrativeState,+ { pendingProposal = false, rejected = false }: DiffCardTitleOptions = {},+): string {+ const summary = turn.draft?.summary?.trim();+ if (summary) {+ return summary;+ }++ // "Applied changes" requires the backend's explicit auto-applied signal.+ // Everything else - pending review, a rejected auto-applicable draft, or a+ // null/unknown disposition from a forward-compatible backend - defaults to+ // "Proposed changes" rather than assuming the change landed.+ if (+ rejected ||+ pendingProposal ||+ turn.cancelled ||+ turn.terminal === "error" ||+ turn.proposalDisposition !== "auto_applicable"+ ) {+ return "Proposed changes";+ }++ return "Applied changes";+}