Automate browser based workflows with AI
Python aiapiautomationbrowserbrowser-automationcomputergptllmplaywrightpowerautomatepuppeteerpythonrpaseleniumvisionworkflow
do not close the tab when download is not triggered (#2234)
Shuchang Zhenga3d991738672
diff --git a/skyvern/webeye/actions/handler.py b/skyvern/webeye/actions/handler.pyindex 449ad3560..561b2eb86 100644--- a/skyvern/webeye/actions/handler.py+++ b/skyvern/webeye/actions/handler.py@@ -534,6 +534,7 @@ async def handle_click_action(step_id=step.step_id,workflow_run_id=task.workflow_run_id,)+ results: list[ActionResult] = []try:results = await handle_click_to_download_file_action(action, page, scraped_page, task, step)except Exception:@@ -555,21 +556,30 @@ async def handle_click_action(workflow_run_id=task.workflow_run_id,)if page_count_after_download > initial_page_count and browser_state and browser_state.browser_context:- LOG.info(- "Extra page opened after download, closing it",- task_id=task.task_id,- step_id=step.step_id,- workflow_run_id=task.workflow_run_id,- )- if page == browser_state.browser_context.pages[-1]:- LOG.warning(- "The extra page is the current page, closing it",+ if results and results[-1].download_triggered:+ LOG.info(+ "Download triggered, closing the extra page",+ task_id=task.task_id,+ step_id=step.step_id,+ workflow_run_id=task.workflow_run_id,+ )++ if page == browser_state.browser_context.pages[-1]:+ LOG.warning(+ "The extra page is the current page, closing it",+ task_id=task.task_id,+ step_id=step.step_id,+ workflow_run_id=task.workflow_run_id,+ )+ # close the extra page+ await browser_state.browser_context.pages[-1].close()+ else:+ LOG.info(+ "No download triggered, not closing the extra page",task_id=task.task_id,step_id=step.step_id,workflow_run_id=task.workflow_run_id,)- # close the extra page- await browser_state.browser_context.pages[-1].close()else:results = await chain_click(task,