Automate browser based workflows with AI
Python aiapiautomationbrowserbrowser-automationcomputergptllmplaywrightpowerautomatepuppeteerpythonrpaseleniumvisionworkflow
State the file count in download-block framing before the model decides (SKY-18769) (#9070)
Andrew Neilsonac83fc161c35
diff --git a/skyvern/forge/taskv3/goal_composition.py b/skyvern/forge/taskv3/goal_composition.pyindex 50407e423..9cc358608 100644--- a/skyvern/forge/taskv3/goal_composition.py+++ b/skyvern/forge/taskv3/goal_composition.py@@ -24,6 +24,8 @@ if TYPE_CHECKING:from skyvern.forge.sdk.schemas.tasks import Taskfrom skyvern.forge.sdk.workflow.models.block import BaseTaskBlock+DOWNLOAD_BLOCK_FACT = "No file has landed in this block yet."+PAGE_FIELD_NOUNS = {"navigation_goal": "goal","data_extraction_goal": "extraction goal",@@ -228,6 +230,8 @@ def render_block_context(if task.task_type != TaskType.validationelse "")+ # The download settle's predicate: on these blocks finish records the files that landed.+ + (f" {DOWNLOAD_BLOCK_FACT}" if task_block.complete_on_download and task.workflow_run_id else "")+ " If the criterion is genuinely satisfied, finish with status=completed ""immediately without acting. Stay ""within this block's goal: never sign out, navigate away from the current flow, or undo "diff --git a/tests/unit/test_agent_task_v3.py b/tests/unit/test_agent_task_v3.pyindex d57524a28..0a2627b30 100644--- a/tests/unit/test_agent_task_v3.py+++ b/tests/unit/test_agent_task_v3.py@@ -83,7 +83,7 @@ from skyvern.forge.taskv3.engine import DEFAULT_MAX_SETTLE_DEFERRALS, MIN_ACTIONfrom skyvern.forge.taskv3.goal_check import (BLOCK_COMPLETION_CHECK_PROMPT_NAME,)-from skyvern.forge.taskv3.goal_composition import CodeProgressRecord, CodeTypedValue+from skyvern.forge.taskv3.goal_composition import DOWNLOAD_BLOCK_FACT, CodeProgressRecord, CodeTypedValuefrom skyvern.forge.taskv3.handoff_redaction import pin_caller_authored_block_urlsfrom skyvern.forge.taskv3.loop import (ACTION_BLOCK_TARGET_ACTION_RESERVE,@@ -2775,6 +2775,7 @@ async def test_execute_task_v3_download_block_completes_with_zero_files_when_nonmonkeypatch: pytest.MonkeyPatch, tmp_path: Path, block_cls: type[BaseTaskBlock], extraction: bool) -> None:async def _finish_without_a_file(kwargs: dict[str, Any], captured: dict[str, Any]) -> LoopOutcome:+ captured["goal"] = kwargs["goal"]return await _finish_through_the_real_tool(kwargs, captured, {"records": 0} if extraction else None)captured = await _run_execute_task_v3_download(@@ -2786,6 +2787,7 @@ async def test_execute_task_v3_download_block_completes_with_zero_files_when_nondata_extraction_goal="Extract the record count" if extraction else None,)+ assert DOWNLOAD_BLOCK_FACT in captured["goal"]assert DOWNLOAD_NO_FILE_FACT in captured["finish_content"]assert captured["task"].status == TaskStatus.completedassert list(tmp_path.iterdir()) == []@@ -2875,6 +2877,7 @@ async def test_execute_task_v3_download_timeout_only_gets_a_download_wait_and_nowait = loop_mock.await_args.kwargs["download_wait"]assert wait is not Noneassert loop_mock.await_args.kwargs["download_settle"] is None+ assert DOWNLOAD_BLOCK_FACT not in loop_mock.await_args.kwargs["goal"]await wait()wait_mock.assert_awaited_once()diff --git a/tests/unit/test_taskv3_goal_composition.py b/tests/unit/test_taskv3_goal_composition.pyindex 869cd4de8..a99b02abc 100644--- a/tests/unit/test_taskv3_goal_composition.py+++ b/tests/unit/test_taskv3_goal_composition.py@@ -14,9 +14,10 @@ import pytestimport skyvern.forge.taskv3from skyvern.forge.sdk.schemas.tasks import TaskType-from skyvern.forge.sdk.workflow.models.block import ExtractionBlock+from skyvern.forge.sdk.workflow.models.block import ExtractionBlock, FileDownloadBlockfrom skyvern.forge.sdk.workflow.page_derived_templates import OPEN, PageDerivedRenderfrom skyvern.forge.taskv3.goal_composition import (+ DOWNLOAD_BLOCK_FACT,CodeProgressRecord,CodeTypedValue,GoalDirectives,@@ -381,3 +382,17 @@ def test_judging_blocks_extend_a_criterions_accepted_number_forms_to_the_same_kifor task in not_judging:assert marker not in render_block_context(task, _make_block("blk"))assert render_block_context(judging[0], None) == ""+++def test_only_download_block_framing_states_no_file_has_landed() -> None:+ # finish states the file count only in its terminal result, so the model needs it before deciding.+ now = datetime.now(UTC)+ org = make_organization(now)+ task = make_task(now, org, workflow_run_id="wr_1")+ block = FileDownloadBlock(label="dl", output_parameter=output_param("dl"), complete_on_download=True)++ framing = render_block_context(task, block)++ assert DOWNLOAD_BLOCK_FACT in framing+ assert DOWNLOAD_BLOCK_FACT not in render_block_context(make_task(now, org, workflow_run_id=None), block)+ assert DOWNLOAD_BLOCK_FACT not in render_block_context(task, _make_block("blk"))