Automate browser based workflows with AI
Python aiapiautomationbrowserbrowser-automationcomputergptllmplaywrightpowerautomatepuppeteerpythonrpaseleniumvisionworkflow
Offer the Task V3 no-action hold to navigation blocks, the population it was measured on (#8634)
pedrohsdbacd3f55fb414
diff --git a/skyvern/forge/taskv3/engine.py b/skyvern/forge/taskv3/engine.pyindex 0e281b842..6203f2da8 100644--- a/skyvern/forge/taskv3/engine.py+++ b/skyvern/forge/taskv3/engine.py@@ -99,12 +99,10 @@ MAX_TOKENS_PER_ACTION_STEP = DEFAULT_MAX_TOKENS // MIN_ACTION_STEPS# turns/tool-calls scale unbounded (they cost loop iterations), tokens are the direct-spend guard.MAX_TOKENS_CEILING = 4 * DEFAULT_MAX_TOKENS-# SKY-16651: task blocks are what SKY-16651 measured, so pinning the arm to them keeps the-# pre-registered read comparable to itself. An ALLOWLIST, not an exclusion list, because the-# dangerous case is the one nobody enumerated -- a bare task carries block_type=None, and an-# exclusion let it through. Unknown and absent block types fail closed.-# It is NOT an authorization test: block type alone cannot establish interaction intent.-NO_ACTION_HOLD_BLOCK_TYPES = frozenset({BlockType.TASK})+# SKY-16651 measured NAVIGATION blocks ("task block" in its analysis meant any task-running block, not+# BlockType.TASK), and a TaskBlock with a navigation_goal is the same construct, so both are in. An+# allowlist scoping the population, not authorizing it: bare tasks (block_type=None) fail closed.+NO_ACTION_HOLD_BLOCK_TYPES = frozenset({BlockType.TASK, BlockType.NAVIGATION})# SKY-16651: what the prompt tells the model to do about ONE required SENSITIVE field the payload# cannot fill -- the clause's antecedent is "one of those", i.e. the do-not-invent categories, NOT@@ -564,7 +562,7 @@ async def run_task_v3_agent_loop(# All None when no failed/terminated finish ever reached that gate -- a guard verdict or a# clean completion, both outside the population. `block_type` is the fifth input, above.# Eligible == perceptions > 0 and attempts == 0 and status in (failed, terminated)- # and block_type == task and has_navigation_goal.+ # and block_type in NO_ACTION_HOLD_BLOCK_TYPES and has_navigation_goal.# Filtering on a SUBSET of these does not narrow the cohort, it pollutes it: a task block# with no navigation goal can never be held, so admitting one adds to BOTH arms a run whose# outcome the treatment could not have changed.diff --git a/tests/unit/test_taskv3_engine.py b/tests/unit/test_taskv3_engine.pyindex 2a664140a..0203a82a2 100644--- a/tests/unit/test_taskv3_engine.py+++ b/tests/unit/test_taskv3_engine.py@@ -2117,7 +2117,9 @@ async def test_unanswerable_field_remedy_treatment_adds_no_submit_pressure() ->@pytest.mark.parametrize(("block_type", "has_navigation_goal", "expected_hold"),[- # The only block type the hold is offered to: the population SKY-16651 measured.+ # SKY-16651's measured specimen is navigation blocks; "task block" in its analysis meant any+ # block that runs a task, not BlockType.TASK alone.+ ("navigation", True, True),("task", True, True),# A TASK BLOCK WITH NO navigation_goal is read-only by construction -- TaskBlockYAML allows# a data_extraction_goal alone, and agent.py keys its own `is_extraction_task` on exactly