Skip to content

Automate browser based workflows with AI

fix(scraper): use networkidle settle for Auth0 form_post redirect recovery (SKY-9470) (#6035)

LawyZhengb6291a7777f5
diff --git a/skyvern/webeye/utils/page.py b/skyvern/webeye/utils/page.py
index cb21c719a..c43aae885 100644
--- a/skyvern/webeye/utils/page.py
+++ b/skyvern/webeye/utils/page.py
@@ -50,7 +50,7 @@ async def _wait_for_navigation_settle(frame: Page | Frame, timeout_ms: float) ->
if timeout_ms <= 0:
return
try:
- await frame.wait_for_load_state("load", timeout=timeout_ms)
+ await frame.wait_for_load_state("networkidle", timeout=timeout_ms)
except PlaywrightError:
return
diff --git a/tests/unit/test_navigation_recovery.py b/tests/unit/test_navigation_recovery.py
new file mode 100644
index 000000000..3dafc9c50
--- /dev/null
+++ b/tests/unit/test_navigation_recovery.py
@@ -0,0 +1,149 @@
+from __future__ import annotations
+
+from unittest.mock import ANY, AsyncMock
+
+import pytest
+from playwright._impl._errors import Error as PlaywrightError
+
+from skyvern.webeye.utils.page import (
+ SkyvernFrame,
+ _is_navigation_context_lost,
+ _wait_for_navigation_settle,
+)
+
+
+class TestIsNavigationContextLost:
+ def test_execution_context_destroyed(self) -> None:
+ assert (
+ _is_navigation_context_lost(
+ "Page.evaluate: Execution context was destroyed, most likely because of a navigation."
+ )
+ is True
+ )
+
+ def test_reference_error_not_defined(self) -> None:
+ assert _is_navigation_context_lost("Page.evaluate: ReferenceError: scrollToXY is not defined") is True
+
+ def test_unrelated_error(self) -> None:
+ assert _is_navigation_context_lost("Page.evaluate: TypeError: Cannot read properties of null") is False
+
+ def test_empty_string(self) -> None:
+ assert _is_navigation_context_lost("") is False
+
+
+class TestWaitForNavigationSettle:
+ @pytest.mark.asyncio
+ async def test_uses_networkidle(self) -> None:
+ frame = AsyncMock()
+ frame.wait_for_load_state = AsyncMock()
+ await _wait_for_navigation_settle(frame, timeout_ms=3000)
+ frame.wait_for_load_state.assert_awaited_once_with("networkidle", timeout=3000)
+
+ @pytest.mark.asyncio
+ async def test_swallows_playwright_error(self) -> None:
+ frame = AsyncMock()
+ frame.wait_for_load_state = AsyncMock(side_effect=PlaywrightError("Timeout"))
+ await _wait_for_navigation_settle(frame, timeout_ms=3000)
+
+ @pytest.mark.asyncio
+ async def test_zero_timeout_returns_immediately(self) -> None:
+ frame = AsyncMock()
+ await _wait_for_navigation_settle(frame, timeout_ms=0)
+ frame.wait_for_load_state.assert_not_awaited()
+
+ @pytest.mark.asyncio
+ async def test_negative_timeout_returns_immediately(self) -> None:
+ frame = AsyncMock()
+ await _wait_for_navigation_settle(frame, timeout_ms=-100)
+ frame.wait_for_load_state.assert_not_awaited()
+
+
+def _context_destroyed_error() -> PlaywrightError:
+ return PlaywrightError("Page.evaluate: Execution context was destroyed, most likely because of a navigation.")
+
+
+def _reference_error() -> PlaywrightError:
+ return PlaywrightError("Page.evaluate: ReferenceError: scrollToXY is not defined")
+
+
+class TestEvaluateWithNavigationRecovery:
+ @pytest.mark.asyncio
+ async def test_recovers_after_one_context_destroyed(self) -> None:
+ """First eval fails, re-inject + retry succeeds."""
+ frame = AsyncMock()
+ frame.evaluate = AsyncMock(
+ side_effect=[
+ _context_destroyed_error(),
+ None,
+ 42,
+ ]
+ )
+ frame.wait_for_load_state = AsyncMock()
+
+ result = await SkyvernFrame.evaluate(frame=frame, expression="() => 42", timeout_ms=30000)
+ assert result == 42
+
+ @pytest.mark.asyncio
+ async def test_recovers_after_reference_error(self) -> None:
+ frame = AsyncMock()
+ frame.evaluate = AsyncMock(
+ side_effect=[
+ _reference_error(),
+ None,
+ "ok",
+ ]
+ )
+ frame.wait_for_load_state = AsyncMock()
+
+ result = await SkyvernFrame.evaluate(frame=frame, expression="() => getScrollXY()", timeout_ms=30000)
+ assert result == "ok"
+
+ @pytest.mark.asyncio
+ async def test_fails_after_max_attempts_exhausted(self) -> None:
+ frame = AsyncMock()
+ frame.evaluate = AsyncMock(side_effect=_context_destroyed_error())
+ frame.wait_for_load_state = AsyncMock()
+
+ with pytest.raises(PlaywrightError, match="Execution context was destroyed"):
+ await SkyvernFrame.evaluate(frame=frame, expression="() => 1", timeout_ms=30000)
+
+ @pytest.mark.asyncio
+ async def test_injection_succeeds_but_retry_context_destroyed_continues(self) -> None:
+ """SSO form_post pattern: inject succeeds but expression eval hits another navigation."""
+ frame = AsyncMock()
+ frame.evaluate = AsyncMock(
+ side_effect=[
+ _context_destroyed_error(),
+ None,
+ _context_destroyed_error(),
+ None,
+ 99,
+ ]
+ )
+ frame.wait_for_load_state = AsyncMock()
+
+ result = await SkyvernFrame.evaluate(frame=frame, expression="() => 99", timeout_ms=30000)
+ assert result == 99
+
+ @pytest.mark.asyncio
+ async def test_non_navigation_error_propagates(self) -> None:
+ frame = AsyncMock()
+ frame.evaluate = AsyncMock(side_effect=PlaywrightError("Page.evaluate: TypeError: null is not an object"))
+
+ with pytest.raises(PlaywrightError, match="TypeError"):
+ await SkyvernFrame.evaluate(frame=frame, expression="() => null.foo", timeout_ms=30000)
+
+ @pytest.mark.asyncio
+ async def test_settle_wait_called_with_networkidle(self) -> None:
+ frame = AsyncMock()
+ frame.evaluate = AsyncMock(
+ side_effect=[
+ _context_destroyed_error(),
+ None,
+ "done",
+ ]
+ )
+ frame.wait_for_load_state = AsyncMock()
+
+ await SkyvernFrame.evaluate(frame=frame, expression="() => 1", timeout_ms=30000)
+ frame.wait_for_load_state.assert_awaited_once_with("networkidle", timeout=ANY)