Skip to content

Automate browser based workflows with AI

chore(security): avoid yaml.load pattern in safe_load_no_dates (#5602)

Shuchang Zhengb97a4f54c02c
diff --git a/skyvern/utils/yaml_loader.py b/skyvern/utils/yaml_loader.py
index f284138aa..f2a63e22f 100644
--- a/skyvern/utils/yaml_loader.py
+++ b/skyvern/utils/yaml_loader.py
@@ -28,5 +28,16 @@ NoDatesSafeLoader.yaml_implicit_resolvers = {
def safe_load_no_dates(stream: Any) -> Any:
- """``yaml.safe_load`` variant that keeps ISO 8601 strings as strings."""
- return yaml.load(stream, Loader=NoDatesSafeLoader)
+ """``yaml.safe_load`` variant that keeps ISO 8601 strings as strings.
+
+ Implemented by constructing ``NoDatesSafeLoader`` directly (the same
+ pattern ``yaml.safe_load`` uses internally) instead of calling
+ ``yaml.load(...)``. ``NoDatesSafeLoader`` is a ``SafeLoader`` subclass,
+ so this is just as safe — but avoiding ``yaml.load`` keeps SAST
+ scanners from flagging a false-positive unsafe-deserialization.
+ """
+ loader = NoDatesSafeLoader(stream)
+ try:
+ return loader.get_single_data()
+ finally:
+ loader.dispose() # type: ignore[no-untyped-call]