Automate browser based workflows with AI
Python aiapiautomationbrowserbrowser-automationcomputergptllmplaywrightpowerautomatepuppeteerpythonrpaseleniumvisionworkflow
fix(SKY-10979): dedupe generated workflow parameter keys to prevent duplicate-key hard-fail (#6543)
Trevor Cheungbe24e191d2f1
diff --git a/skyvern/services/task_v2_service.py b/skyvern/services/task_v2_service.pyindex cd4ac5906..a17abc680 100644--- a/skyvern/services/task_v2_service.py+++ b/skyvern/services/task_v2_service.py@@ -1439,7 +1439,9 @@ async def _generate_loop_task(else:LOG.info("Loop values are not links", loop_values=loop_values)url = None- context_parameter_key = "target"+ # Suffix with the per-loop random string so multiple non-link loop tasks in one run+ # don't all emit a parameter keyed "target", which fails duplicate-key validation.+ context_parameter_key = f"target_{loop_random_string}"# create ContextParameter for the valueurl_value_context_parameter = ContextParameter(diff --git a/tests/unit/test_task_v2_loop_parameter_keys.py b/tests/unit/test_task_v2_loop_parameter_keys.pynew file mode 100644index 000000000..68a7b6cc8--- /dev/null+++ b/tests/unit/test_task_v2_loop_parameter_keys.py@@ -0,0 +1,114 @@+"""Regression tests for duplicate loop-value parameter keys generated by task_v2.++task_v2 runs its planner repeatedly within a single run. Each "loop" task it emits used+to create a context parameter with the hardcoded key "target" when the loop values were+not links. Two such loop tasks in one run therefore produced two parameters sharing the+key "target", which fails WorkflowDefinition validation and hard-aborts the run.++The fix suffixes the generated key with the per-loop random string so the keys are unique.+These tests assert that behavior at the converter boundary (the layer that raised the+error) and at the generation site.+"""++import inspect++import pytest++from skyvern.forge.sdk.workflow.exceptions import WorkflowDefinitionHasDuplicateParameterKeys+from skyvern.forge.sdk.workflow.workflow_definition_converter import convert_workflow_definition+from skyvern.schemas.workflows import (+ ContextParameterYAML,+ ExtractionBlockYAML,+ ForLoopBlockYAML,+ TaskBlockYAML,+ WorkflowDefinitionYAML,+)+++def _loop_task_definition(suffixes: list[str], value_parameter_key: str) -> WorkflowDefinitionYAML:+ """Assemble a workflow definition shaped like the output of N non-link loop tasks.++ ``value_parameter_key`` is templated with each suffix to model both the buggy+ (constant "target") and fixed (per-loop unique) key derivations.+ """+ parameters: list = []+ blocks: list = []+ for suffix in suffixes:+ loop_values_key = f"loop_values_{suffix}"+ extraction_label = f"extraction_task_for_loop_{suffix}"+ task_label = f"task_in_loop_{suffix}"+ loop_label = f"loop_{suffix}"++ parameters.append(+ ContextParameterYAML(+ key=loop_values_key,+ source_parameter_key=f"{extraction_label}_output",+ )+ )+ parameters.append(+ ContextParameterYAML(+ key=value_parameter_key.format(suffix=suffix),+ source_parameter_key=loop_values_key,+ )+ )+ blocks.append(+ ExtractionBlockYAML(+ label=extraction_label,+ data_extraction_goal="extract the loop values",+ )+ )+ blocks.append(+ ForLoopBlockYAML(+ label=loop_label,+ loop_over_parameter_key=loop_values_key,+ loop_blocks=[+ TaskBlockYAML(+ label=task_label,+ navigation_goal="do the task for the current value",+ parameter_keys=[value_parameter_key.format(suffix=suffix)],+ )+ ],+ )+ )++ return WorkflowDefinitionYAML(parameters=parameters, blocks=blocks)+++def test_two_non_link_loop_tasks_with_constant_key_collide() -> None:+ """Two loop tasks both keyed 'target' must trip duplicate-key validation."""+ definition = _loop_task_definition(["aaaaa", "bbbbb"], value_parameter_key="target")++ with pytest.raises(WorkflowDefinitionHasDuplicateParameterKeys) as exc_info:+ convert_workflow_definition(workflow_definition_yaml=definition, workflow_id="w_test")++ assert "target" in str(exc_info.value)+++def test_two_non_link_loop_tasks_with_unique_keys_validate() -> None:+ """With per-loop-unique value keys the same workflow converts cleanly."""+ definition = _loop_task_definition(["aaaaa", "bbbbb"], value_parameter_key="target_{suffix}")++ workflow_definition = convert_workflow_definition(workflow_definition_yaml=definition, workflow_id="w_test")++ parameter_keys = {parameter.key for parameter in workflow_definition.parameters}+ value_keys = {key for key in parameter_keys if key.startswith("target_")}+ assert value_keys == {"target_aaaaa", "target_bbbbb"}+++def test_single_loop_task_with_constant_key_still_validates() -> None:+ """A single loop task is unaffected; the collision only arises across multiple tasks."""+ definition = _loop_task_definition(["aaaaa"], value_parameter_key="target")++ workflow_definition = convert_workflow_definition(workflow_definition_yaml=definition, workflow_id="w_test")++ parameter_keys = {parameter.key for parameter in workflow_definition.parameters}+ assert "target" in parameter_keys+++def test_generated_loop_value_key_is_not_a_bare_constant() -> None:+ """The generation site must derive the key from the per-loop random string."""+ from skyvern.services import task_v2_service++ source = inspect.getsource(task_v2_service._generate_loop_task)+ assert 'context_parameter_key = "target"' not in source+ assert "loop_random_string" in source