Skip to content

Automate browser based workflows with AI

Only notify with actual changes (#1173)

Shuchang Zhengc1c2b5ca240d
diff --git a/skyvern-frontend/src/hooks/useShouldNotifyWhenClosingTab.ts b/skyvern-frontend/src/hooks/useShouldNotifyWhenClosingTab.ts
index b73cab15d..a55622a7c 100644
--- a/skyvern-frontend/src/hooks/useShouldNotifyWhenClosingTab.ts
+++ b/skyvern-frontend/src/hooks/useShouldNotifyWhenClosingTab.ts
@@ -1,13 +1,14 @@
import { useEffect } from "react";
-function useShouldNotifyWhenClosingTab() {
+function useShouldNotifyWhenClosingTab(shouldNotify: boolean) {
useEffect(() => {
function f(event: BeforeUnloadEvent) {
// this function is here to have a stable reference only
-
+ if (!shouldNotify) {
+ return undefined;
+ }
// Recommended
event.preventDefault();
-
// Included for legacy support, e.g. Chrome/Edge < 119
// refer to https://developer.mozilla.org/en-US/docs/Web/API/Window/beforeunload_event
event.returnValue = true;
@@ -18,7 +19,7 @@ function useShouldNotifyWhenClosingTab() {
return () => {
window.removeEventListener("beforeunload", f);
};
- }, []);
+ }, [shouldNotify]);
}
export { useShouldNotifyWhenClosingTab };
diff --git a/skyvern-frontend/src/routes/workflows/editor/FlowRenderer.tsx b/skyvern-frontend/src/routes/workflows/editor/FlowRenderer.tsx
index 6426d3583..39097d62c 100644
--- a/skyvern-frontend/src/routes/workflows/editor/FlowRenderer.tsx
+++ b/skyvern-frontend/src/routes/workflows/editor/FlowRenderer.tsx
@@ -191,7 +191,7 @@ function FlowRenderer({
const [title, setTitle] = useState(initialTitle);
const nodesInitialized = useNodesInitialized();
const { hasChanges, setHasChanges } = useWorkflowHasChangesStore();
- useShouldNotifyWhenClosingTab();
+ useShouldNotifyWhenClosingTab(hasChanges);
const blocker = useBlocker(({ currentLocation, nextLocation }) => {
return hasChanges && nextLocation.pathname !== currentLocation.pathname;
});