Skip to content

Automate browser based workflows with AI

fix(SKY-10478): render block prompts in workflow version comparison (#6331)

Aaron Perezca160b118815
diff --git a/skyvern-frontend/src/components/DataSchemaInputGroup/WorkflowDataSchemaInputGroup.test.tsx b/skyvern-frontend/src/components/DataSchemaInputGroup/WorkflowDataSchemaInputGroup.test.tsx
new file mode 100644
index 000000000..52c41fd7c
--- /dev/null
+++ b/skyvern-frontend/src/components/DataSchemaInputGroup/WorkflowDataSchemaInputGroup.test.tsx
@@ -0,0 +1,66 @@
+// @vitest-environment jsdom
+
+import { QueryClient, QueryClientProvider } from "@tanstack/react-query";
+import { cleanup, render, screen } from "@testing-library/react";
+import { afterEach, describe, expect, test, vi } from "vitest";
+
+import { WorkflowScopeContext } from "@/routes/workflows/editor/WorkflowScopeContext";
+
+import { WorkflowDataSchemaInputGroup } from "./WorkflowDataSchemaInputGroup";
+
+vi.mock("@/hooks/useCredentialGetter", () => ({
+ useCredentialGetter: () => undefined,
+}));
+
+vi.mock("@/routes/workflows/components/CodeEditor", () => ({
+ CodeEditor: ({ value, readOnly }: { value: string; readOnly?: boolean }) => (
+ <div
+ data-testid="schema-editor"
+ data-readonly={readOnly ? "true" : "false"}
+ >
+ {value}
+ </div>
+ ),
+}));
+
+afterEach(cleanup);
+
+function renderGroup(readOnly: boolean) {
+ const client = new QueryClient({
+ defaultOptions: { queries: { retry: false }, mutations: { retry: false } },
+ });
+ return render(
+ <QueryClientProvider client={client}>
+ <WorkflowScopeContext.Provider value={{ workflowId: "w", readOnly }}>
+ <WorkflowDataSchemaInputGroup
+ value={'{"type":"object"}'}
+ onChange={() => {}}
+ suggestionContext={{}}
+ exampleValue={{}}
+ />
+ </WorkflowScopeContext.Provider>
+ </QueryClientProvider>,
+ );
+}
+
+describe("WorkflowDataSchemaInputGroup in a read-only scope", () => {
+ test("exposes the schema controls in the live editor scope", () => {
+ renderGroup(false);
+ expect(screen.queryByText("Generate with AI")).not.toBeNull();
+ expect(screen.getByRole("checkbox").hasAttribute("disabled")).toBe(false);
+ expect(
+ screen.getByTestId("schema-editor").getAttribute("data-readonly"),
+ ).toBe("false");
+ });
+
+ // A comparison canvas must stay inert: the schema is visible but cannot be
+ // edited, toggled, or sent to /suggest/data_schema.
+ test("locks the schema and hides Generate with AI in a read-only comparison scope", () => {
+ renderGroup(true);
+ expect(screen.queryByText("Generate with AI")).toBeNull();
+ expect(screen.getByRole("checkbox").hasAttribute("disabled")).toBe(true);
+ expect(
+ screen.getByTestId("schema-editor").getAttribute("data-readonly"),
+ ).toBe("true");
+ });
+});
diff --git a/skyvern-frontend/src/components/DataSchemaInputGroup/WorkflowDataSchemaInputGroup.tsx b/skyvern-frontend/src/components/DataSchemaInputGroup/WorkflowDataSchemaInputGroup.tsx
index 9a5612be4..a993f4777 100644
--- a/skyvern-frontend/src/components/DataSchemaInputGroup/WorkflowDataSchemaInputGroup.tsx
+++ b/skyvern-frontend/src/components/DataSchemaInputGroup/WorkflowDataSchemaInputGroup.tsx
@@ -21,6 +21,7 @@ import { useCredentialGetter } from "@/hooks/useCredentialGetter";
import { getClient } from "@/api/AxiosClient";
import { CodeEditor } from "@/routes/workflows/components/CodeEditor";
import { helpTooltips } from "@/routes/workflows/editor/helpContent";
+import { useWorkflowScopeReadOnly } from "@/routes/workflows/editor/WorkflowScopeContext";
import { useCallback, useMemo, useState } from "react";
import { AutoResizingTextarea } from "../AutoResizingTextarea/AutoResizingTextarea";
import { Button } from "../ui/button";
@@ -45,6 +46,7 @@ function WorkflowDataSchemaInputGroup({
helpTooltip,
}: Props) {
const credentialGetter = useCredentialGetter();
+ const scopeReadOnly = useWorkflowScopeReadOnly();
const [generateWithAIActive, setGenerateWithAIActive] = useState(false);
const [generateWithAIPrompt, setGenerateWithAIPrompt] = useState("");
const [pendingSchema, setPendingSchema] = useState<string | null>(null);
@@ -99,6 +101,7 @@ function WorkflowDataSchemaInputGroup({
</div>
<Checkbox
checked={value !== "null"}
+ disabled={scopeReadOnly}
onCheckedChange={(checked) => {
if (!checked) {
resetAIState();
@@ -109,7 +112,7 @@ function WorkflowDataSchemaInputGroup({
}}
/>
</div>
- {value !== "null" && !generateWithAIActive && (
+ {value !== "null" && !generateWithAIActive && !scopeReadOnly && (
<Button
variant="tertiary"
className="h-7 text-xs"
@@ -177,6 +180,7 @@ function WorkflowDataSchemaInputGroup({
language="json"
value={value}
onChange={onChange}
+ readOnly={scopeReadOnly}
className="nopan"
fontSize={8}
/>
diff --git a/skyvern-frontend/src/components/ModelSelector.test.tsx b/skyvern-frontend/src/components/ModelSelector.test.tsx
new file mode 100644
index 000000000..6c06e9716
--- /dev/null
+++ b/skyvern-frontend/src/components/ModelSelector.test.tsx
@@ -0,0 +1,56 @@
+// @vitest-environment jsdom
+
+import { QueryClient, QueryClientProvider } from "@tanstack/react-query";
+import { cleanup, render, screen } from "@testing-library/react";
+import { afterEach, describe, expect, test, vi } from "vitest";
+
+import { WorkflowScopeContext } from "@/routes/workflows/editor/WorkflowScopeContext";
+
+import { ModelSelector } from "./ModelSelector";
+
+const getMock = vi
+ .fn()
+ .mockResolvedValue({ data: { models: { "gpt-4o": "GPT-4o" } } });
+
+vi.mock("@/api/AxiosClient", () => ({
+ getClient: () => Promise.resolve({ get: getMock }),
+}));
+vi.mock("@/hooks/useCredentialGetter", () => ({
+ useCredentialGetter: () => null,
+}));
+
+afterEach(() => {
+ cleanup();
+ vi.clearAllMocks();
+});
+
+function renderSelector(readOnly: boolean) {
+ const client = new QueryClient({
+ defaultOptions: { queries: { retry: false } },
+ });
+ return render(
+ <QueryClientProvider client={client}>
+ <WorkflowScopeContext.Provider value={{ workflowId: "w", readOnly }}>
+ <ModelSelector
+ value={{ model_name: "removed-model-x" }}
+ onChange={() => {}}
+ />
+ </WorkflowScopeContext.Provider>
+ </QueryClientProvider>,
+ );
+}
+
+describe("ModelSelector in a read-only comparison scope", () => {
+ test("shows the stored model verbatim and does not fetch /models", () => {
+ renderSelector(true);
+ expect(screen.getByTestId("model-selector-readonly").textContent).toBe(
+ "removed-model-x",
+ );
+ expect(getMock).not.toHaveBeenCalled();
+ });
+
+ test("renders the interactive selector in the live editor scope", () => {
+ renderSelector(false);
+ expect(screen.queryByTestId("model-selector-readonly")).toBeNull();
+ });
+});
diff --git a/skyvern-frontend/src/components/ModelSelector.tsx b/skyvern-frontend/src/components/ModelSelector.tsx
index 8ee48f73a..7eb88885a 100644
--- a/skyvern-frontend/src/components/ModelSelector.tsx
+++ b/skyvern-frontend/src/components/ModelSelector.tsx
@@ -12,6 +12,7 @@ import { useQuery } from "@tanstack/react-query";
import { useCredentialGetter } from "@/hooks/useCredentialGetter";
import { ModelsResponse } from "@/api/types";
import { WorkflowModel } from "@/routes/workflows/types/workflowTypes";
+import { useWorkflowScopeReadOnly } from "@/routes/workflows/editor/WorkflowScopeContext";
type Props = {
className?: string;
@@ -40,6 +41,7 @@ function ModelSelector({
className,
}: Props) {
const credentialGetter = useCredentialGetter();
+ const scopeReadOnly = useWorkflowScopeReadOnly();
const { data: availableModels } = useQuery<ModelsResponse>({
queryKey: ["models"],
@@ -47,6 +49,7 @@ function ModelSelector({
const client = await getClient(credentialGetter);
return client.get("/models").then((res) => res.data);
},
+ enabled: !scopeReadOnly,
});
const rawModels = availableModels?.models ?? {};
@@ -76,6 +79,27 @@ function ModelSelector({
: constants.SkyvernOptimized;
const choices = [constants.SkyvernOptimized, ...labels];
+ // Read-only diff shows the stored model verbatim, not remapped through the gated-off /models list.
+ if (scopeReadOnly) {
+ return (
+ <div className="flex items-center justify-between">
+ <div className="flex gap-2">
+ <Label className="text-xs font-normal text-slate-300">Model</Label>
+ <HelpTooltip content="The LLM model to use for this block" />
+ </div>
+ <div
+ data-testid="model-selector-readonly"
+ className={
+ "flex h-9 items-center rounded-md border border-input px-3 text-sm text-slate-300 " +
+ (className || "")
+ }
+ >
+ {value?.model_name ?? constants.SkyvernOptimized}
+ </div>
+ </div>
+ );
+ }
+
return (
<div className="flex items-center justify-between">
<div className="flex gap-2">
diff --git a/skyvern-frontend/src/components/WorkflowBlockInput.test.tsx b/skyvern-frontend/src/components/WorkflowBlockInput.test.tsx
new file mode 100644
index 000000000..0ee24fe84
--- /dev/null
+++ b/skyvern-frontend/src/components/WorkflowBlockInput.test.tsx
@@ -0,0 +1,48 @@
+// @vitest-environment jsdom
+
+import { QueryClient, QueryClientProvider } from "@tanstack/react-query";
+import { cleanup, render, screen } from "@testing-library/react";
+import { ReactFlowProvider } from "@xyflow/react";
+import { afterEach, describe, expect, test } from "vitest";
+
+import { WorkflowScopeContext } from "@/routes/workflows/editor/WorkflowScopeContext";
+
+import { WorkflowBlockInput } from "./WorkflowBlockInput";
+
+afterEach(cleanup);
+
+function renderInput(readOnly: boolean) {
+ const client = new QueryClient({
+ defaultOptions: { queries: { retry: false }, mutations: { retry: false } },
+ });
+ return render(
+ <QueryClientProvider client={client}>
+ <ReactFlowProvider>
+ <WorkflowScopeContext.Provider value={{ workflowId: "w", readOnly }}>
+ <WorkflowBlockInput
+ nodeId="n1"
+ value="suffix.csv"
+ onChange={() => {}}
+ />
+ </WorkflowScopeContext.Provider>
+ </ReactFlowProvider>
+ </QueryClientProvider>,
+ );
+}
+
+describe("WorkflowBlockInput in a read-only scope", () => {
+ test("stays editable with the parameter action in the live editor scope", () => {
+ renderInput(false);
+ const input = screen.getByRole("textbox") as HTMLInputElement;
+ expect(input.readOnly).toBe(false);
+ expect(screen.queryByTestId("block-input-actions")).not.toBeNull();
+ });
+
+ // Comparison canvases need the value readable (still in the a11y tree) but not editable.
+ test("is readOnly and hides actions in a read-only comparison scope", () => {
+ renderInput(true);
+ const input = screen.getByRole("textbox") as HTMLInputElement;
+ expect(input.readOnly).toBe(true);
+ expect(screen.queryByTestId("block-input-actions")).toBeNull();
+ });
+});
diff --git a/skyvern-frontend/src/components/WorkflowBlockInput.tsx b/skyvern-frontend/src/components/WorkflowBlockInput.tsx
index be90c6090..785bb57f6 100644
--- a/skyvern-frontend/src/components/WorkflowBlockInput.tsx
+++ b/skyvern-frontend/src/components/WorkflowBlockInput.tsx
@@ -5,6 +5,7 @@ import { Input } from "./ui/input";
import { Popover, PopoverContent, PopoverTrigger } from "./ui/popover";
import { WorkflowBlockParameterSelect } from "@/routes/workflows/editor/nodes/WorkflowBlockParameterSelect";
import { useParameterAutocomplete } from "@/hooks/useParameterAutocomplete";
+import { useWorkflowScopeReadOnly } from "@/routes/workflows/editor/WorkflowScopeContext";
import { ParameterAutocompleteDropdown } from "./ParameterAutocompleteDropdown";
import { ParameterGhostText } from "./ParameterGhostText";
@@ -36,6 +37,8 @@ function WorkflowBlockInput(props: Props) {
const isPasswordField = type === "password";
const actualType = isPasswordField && showPassword ? "text" : type;
+ // Read-only comparison canvases: value readable but not editable, no actions.
+ const scopeReadOnly = useWorkflowScopeReadOnly();
const autocomplete = useParameterAutocomplete({
nodeId,
@@ -63,6 +66,7 @@ function WorkflowBlockInput(props: Props) {
<Input
{...inputProps}
ref={inputRef}
+ readOnly={scopeReadOnly || inputProps.readOnly}
value={localValue}
type={actualType}
className={cn(
@@ -100,8 +104,11 @@ function WorkflowBlockInput(props: Props) {
onSelect={handleAutocompleteSelect}
onDismiss={autocomplete.dismiss}
/>
- {(isPasswordField || !hideParameterSelect) && (
- <div className="absolute right-0 top-0 flex cursor-pointer items-center justify-center">
+ {(isPasswordField || !hideParameterSelect) && !scopeReadOnly && (
+ <div
+ data-testid="block-input-actions"
+ className="absolute right-0 top-0 flex cursor-pointer items-center justify-center"
+ >
{isPasswordField && (
<div className="flex size-9 items-center justify-center">
<div
diff --git a/skyvern-frontend/src/components/WorkflowBlockInputSet.test.tsx b/skyvern-frontend/src/components/WorkflowBlockInputSet.test.tsx
new file mode 100644
index 000000000..3ac06d5c9
--- /dev/null
+++ b/skyvern-frontend/src/components/WorkflowBlockInputSet.test.tsx
@@ -0,0 +1,47 @@
+// @vitest-environment jsdom
+
+import { cleanup, render, screen } from "@testing-library/react";
+import { afterEach, describe, expect, test, vi } from "vitest";
+
+import { WorkflowScopeContext } from "@/routes/workflows/editor/WorkflowScopeContext";
+
+import { WorkflowBlockInputSet } from "./WorkflowBlockInputSet";
+
+vi.mock("@/store/WorkflowParametersStore", () => ({
+ useWorkflowParametersStore: () => ({ parameters: [{ key: "suffix" }] }),
+}));
+
+vi.mock("@/routes/workflows/editor/nodes/WorkflowBlockParameterSelect", () => ({
+ WorkflowBlockParameterSelect: () => null,
+}));
+
+afterEach(cleanup);
+
+function renderSet(readOnly: boolean) {
+ return render(
+ <WorkflowScopeContext.Provider value={{ workflowId: "w", readOnly }}>
+ <WorkflowBlockInputSet
+ nodeId="n1"
+ values={new Set(["suffix"])}
+ onChange={() => {}}
+ />
+ </WorkflowScopeContext.Provider>,
+ );
+}
+
+describe("WorkflowBlockInputSet in a read-only scope", () => {
+ test("shows add and remove controls in the live editor scope", () => {
+ renderSet(false);
+ expect(screen.getByText("suffix")).toBeTruthy();
+ expect(screen.queryByTestId("input-set-add")).not.toBeNull();
+ expect(screen.queryByTestId("input-set-remove-suffix")).not.toBeNull();
+ });
+
+ // The displayed inputs stay readable but cannot be added/removed in a comparison.
+ test("hides add and remove controls in a read-only comparison scope", () => {
+ renderSet(true);
+ expect(screen.getByText("suffix")).toBeTruthy();
+ expect(screen.queryByTestId("input-set-add")).toBeNull();
+ expect(screen.queryByTestId("input-set-remove-suffix")).toBeNull();
+ });
+});
diff --git a/skyvern-frontend/src/components/WorkflowBlockInputSet.tsx b/skyvern-frontend/src/components/WorkflowBlockInputSet.tsx
index 5396cce17..6bf1f33d7 100644
--- a/skyvern-frontend/src/components/WorkflowBlockInputSet.tsx
+++ b/skyvern-frontend/src/components/WorkflowBlockInputSet.tsx
@@ -1,6 +1,7 @@
import { PlusIcon, Cross2Icon } from "@radix-ui/react-icons";
import { Popover, PopoverContent, PopoverTrigger } from "./ui/popover";
import { WorkflowBlockParameterSelect } from "@/routes/workflows/editor/nodes/WorkflowBlockParameterSelect";
+import { useWorkflowScopeReadOnly } from "@/routes/workflows/editor/WorkflowScopeContext";
import { useWorkflowParametersStore } from "@/store/WorkflowParametersStore";
import { useState, useEffect } from "react";
import "./workflow-block-input-set.css";
@@ -20,6 +21,8 @@ function areSetsEqual<T>(a: Set<T>, b: Set<T>): boolean {
function WorkflowBlockInputSet(props: Props) {
const { nodeId, onChange, values } = props;
+ // Read-only comparison canvases: inputs readable but not add/removable.
+ const scopeReadOnly = useWorkflowScopeReadOnly();
const [parameterKeys, setParameterKeys] = useState<Set<string>>(values);
const hasKeys = parameterKeys.size > 0;
const { parameters: workflowParameters } = useWorkflowParametersStore();
@@ -52,16 +55,19 @@ function WorkflowBlockInputSet(props: Props) {
className={`parameter-key flex items-center gap-2 ${missing ? "missing" : ""}`}
>
<span>{parameterKey}</span>
- <Cross2Icon
- className="size-4 cursor-pointer"
- onClick={() => {
- setParameterKeys((prev) => {
- const newSet = new Set(prev);
- newSet.delete(parameterKey);
- return newSet;
- });
- }}
- />
+ {!scopeReadOnly && (
+ <Cross2Icon
+ data-testid={`input-set-remove-${parameterKey}`}
+ className="size-4 cursor-pointer"
+ onClick={() => {
+ setParameterKeys((prev) => {
+ const newSet = new Set(prev);
+ newSet.delete(parameterKey);
+ return newSet;
+ });
+ }}
+ />
+ )}
</div>
);
})
@@ -69,27 +75,32 @@ function WorkflowBlockInputSet(props: Props) {
<span className="flex items-center gap-2 text-slate-400">&nbsp;</span>
)}
</div>
- <div className="absolute right-0 top-0 flex size-9 cursor-pointer items-center justify-center">
- <Popover>
- <PopoverTrigger asChild>
- <div className="rounded p-1 hover:bg-muted">
- <PlusIcon className="size-4" />
- </div>
- </PopoverTrigger>
- <PopoverContent className="w-fit max-w-sm">
- <WorkflowBlockParameterSelect
- nodeId={nodeId}
- onAdd={(parameterKey) => {
- setParameterKeys((prev) => {
- const newSet = new Set(prev);
- newSet.add(parameterKey);
- return newSet;
- });
- }}
- />
- </PopoverContent>
- </Popover>
- </div>
+ {!scopeReadOnly && (
+ <div
+ data-testid="input-set-add"
+ className="absolute right-0 top-0 flex size-9 cursor-pointer items-center justify-center"
+ >
+ <Popover>
+ <PopoverTrigger asChild>
+ <div className="rounded p-1 hover:bg-muted">
+ <PlusIcon className="size-4" />
+ </div>
+ </PopoverTrigger>
+ <PopoverContent className="w-fit max-w-sm">
+ <WorkflowBlockParameterSelect
+ nodeId={nodeId}
+ onAdd={(parameterKey) => {
+ setParameterKeys((prev) => {
+ const newSet = new Set(prev);
+ newSet.add(parameterKey);
+ return newSet;
+ });
+ }}
+ />
+ </PopoverContent>
+ </Popover>
+ </div>
+ )}
</div>
);
}
diff --git a/skyvern-frontend/src/components/WorkflowBlockInputTextarea.test.tsx b/skyvern-frontend/src/components/WorkflowBlockInputTextarea.test.tsx
new file mode 100644
index 000000000..3668fa4a5
--- /dev/null
+++ b/skyvern-frontend/src/components/WorkflowBlockInputTextarea.test.tsx
@@ -0,0 +1,49 @@
+// @vitest-environment jsdom
+
+import { QueryClient, QueryClientProvider } from "@tanstack/react-query";
+import { cleanup, render, screen } from "@testing-library/react";
+import { ReactFlowProvider } from "@xyflow/react";
+import { afterEach, describe, expect, test } from "vitest";
+
+import { WorkflowScopeContext } from "@/routes/workflows/editor/WorkflowScopeContext";
+
+import { WorkflowBlockInputTextarea } from "./WorkflowBlockInputTextarea";
+
+afterEach(cleanup);
+
+function renderTextarea(readOnly: boolean) {
+ const client = new QueryClient({
+ defaultOptions: { queries: { retry: false }, mutations: { retry: false } },
+ });
+ return render(
+ <QueryClientProvider client={client}>
+ <ReactFlowProvider>
+ <WorkflowScopeContext.Provider value={{ workflowId: "w", readOnly }}>
+ <WorkflowBlockInputTextarea
+ nodeId="n1"
+ value="goal text"
+ aiImprove={{ useCase: "navigation" }}
+ onChange={() => {}}
+ />
+ </WorkflowScopeContext.Provider>
+ </ReactFlowProvider>
+ </QueryClientProvider>,
+ );
+}
+
+describe("WorkflowBlockInputTextarea in a read-only scope", () => {
+ test("stays editable with actions in the live editor scope", () => {
+ renderTextarea(false);
+ const textarea = screen.getByRole("textbox") as HTMLTextAreaElement;
+ expect(textarea.readOnly).toBe(false);
+ expect(screen.queryByTestId("block-textarea-actions")).not.toBeNull();
+ });
+
+ // Comparison canvases need the prompt readable (still in the a11y tree) but not editable, and no prompt-improve action.
+ test("is readOnly and hides actions in a read-only comparison scope", () => {
+ renderTextarea(true);
+ const textarea = screen.getByRole("textbox") as HTMLTextAreaElement;
+ expect(textarea.readOnly).toBe(true);
+ expect(screen.queryByTestId("block-textarea-actions")).toBeNull();
+ });
+});
diff --git a/skyvern-frontend/src/components/WorkflowBlockInputTextarea.tsx b/skyvern-frontend/src/components/WorkflowBlockInputTextarea.tsx
index ff30d728c..154439874 100644
--- a/skyvern-frontend/src/components/WorkflowBlockInputTextarea.tsx
+++ b/skyvern-frontend/src/components/WorkflowBlockInputTextarea.tsx
@@ -6,6 +6,7 @@ import { WorkflowBlockParameterSelect } from "@/routes/workflows/editor/nodes/Wo
import { useEffect, useRef, useState } from "react";
import { useDebouncedCallback } from "use-debounce";
import { useParameterAutocomplete } from "@/hooks/useParameterAutocomplete";
+import { useWorkflowScopeReadOnly } from "@/routes/workflows/editor/WorkflowScopeContext";
import { ParameterAutocompleteDropdown } from "./ParameterAutocompleteDropdown";
import { ParameterGhostText } from "./ParameterGhostText";
@@ -37,7 +38,9 @@ function WorkflowBlockInputTextarea(props: Props) {
disabled,
...textAreaProps
} = props;
- const showActions = !disabled && !hideActions;
+ // Read-only comparison canvases: prompt readable but not editable, no actions.
+ const scopeReadOnly = useWorkflowScopeReadOnly();
+ const showActions = !disabled && !hideActions && !scopeReadOnly;
const [internalValue, setInternalValue] = useState(props.value ?? "");
const textareaRef = useRef<HTMLTextAreaElement>(null);
const [cursorPosition, setCursorPosition] = useState<{
@@ -124,6 +127,7 @@ function WorkflowBlockInputTextarea(props: Props) {
<AutoResizingTextarea
{...textAreaProps}
disabled={disabled}
+ readOnly={scopeReadOnly || textAreaProps.readOnly}
value={internalValue}
ref={textareaRef}
onBlur={() => {
@@ -164,7 +168,10 @@ function WorkflowBlockInputTextarea(props: Props) {
/>
{showActions && (
- <div className="absolute right-1 top-0 flex size-9 items-center justify-end">
+ <div
+ data-testid="block-textarea-actions"
+ className="absolute right-1 top-0 flex size-9 items-center justify-end"
+ >
<div className="flex items-center justify-center gap-1">
{aiImprove && (
<ImprovePrompt
diff --git a/skyvern-frontend/src/routes/workflows/copilot/NarrativeView.collapse.test.tsx b/skyvern-frontend/src/routes/workflows/copilot/NarrativeView.collapse.test.tsx
index d627407f3..a34196a94 100644
--- a/skyvern-frontend/src/routes/workflows/copilot/NarrativeView.collapse.test.tsx
+++ b/skyvern-frontend/src/routes/workflows/copilot/NarrativeView.collapse.test.tsx
@@ -71,7 +71,7 @@ describe("NarrativeView collapse default", () => {
).toBeTruthy();
});
- it("expands on click and re-collapses via the same header control", () => {
+ it("expands via the summary card and re-collapses via the labeled control", () => {
render(<NarrativeView turn={terminalBuildTurn()} />);
const head = () =>
screen.getByRole("button", { name: new RegExp(HEADLINE) });
@@ -79,9 +79,10 @@ describe("NarrativeView collapse default", () => {
expect(head().getAttribute("aria-expanded")).toBe("false");
fireEvent.click(head());
- expect(head().getAttribute("aria-expanded")).toBe("true");
+ const collapse = screen.getByRole("button", { name: "Collapse turn" });
+ expect(screen.queryByText(HEADLINE)).toBeNull();
- fireEvent.click(head());
+ fireEvent.click(collapse);
expect(head().getAttribute("aria-expanded")).toBe("false");
});
@@ -96,13 +97,13 @@ describe("NarrativeView collapse default", () => {
it("preserves a user's expand override across re-renders", () => {
const turn = terminalBuildTurn();
const { rerender } = render(<NarrativeView turn={turn} />);
- const head = () =>
- screen.getByRole("button", { name: new RegExp(HEADLINE) });
- fireEvent.click(head());
- expect(head().getAttribute("aria-expanded")).toBe("true");
+ fireEvent.click(screen.getByRole("button", { name: new RegExp(HEADLINE) }));
+ expect(screen.getByRole("button", { name: "Collapse turn" })).toBeTruthy();
+ expect(screen.queryByText(HEADLINE)).toBeNull();
rerender(<NarrativeView turn={turn} />);
- expect(head().getAttribute("aria-expanded")).toBe("true");
+ expect(screen.getByRole("button", { name: "Collapse turn" })).toBeTruthy();
+ expect(screen.queryByText(HEADLINE)).toBeNull();
});
});
diff --git a/skyvern-frontend/src/routes/workflows/copilot/NarrativeView.tsx b/skyvern-frontend/src/routes/workflows/copilot/NarrativeView.tsx
index fac959ec3..6b1b93225 100644
--- a/skyvern-frontend/src/routes/workflows/copilot/NarrativeView.tsx
+++ b/skyvern-frontend/src/routes/workflows/copilot/NarrativeView.tsx
@@ -642,17 +642,11 @@ function RollupCard({ turn, summary, onExpand }: RollupCardProps) {
interface DetailViewProps {
turn: TurnNarrativeState;
- summary: TurnSummary;
onCollapse: (() => void) | null;
onBlockSelect?: (label: string) => void;
}
-function DetailView({
- turn,
- summary,
- onCollapse,
- onBlockSelect,
-}: DetailViewProps) {
+function DetailView({ turn, onCollapse, onBlockSelect }: DetailViewProps) {
const hasBlocks = turn.blocks.length > 0;
const designStarted = turn.designStarted;
const designOpen = designStarted && !turn.designEnded;
@@ -669,7 +663,17 @@ function DetailView({
return (
<div className="flex flex-col gap-2.5">
{onCollapse ? (
- <TurnHead summary={summary} expanded onClick={onCollapse} />
+ <button
+ type="button"
+ onClick={onCollapse}
+ aria-label="Collapse turn"
+ className="flex w-full items-center justify-end gap-1.5 px-3.5 py-1.5 text-[11px] font-medium uppercase tracking-wide text-slate-500 hover:text-slate-300"
+ >
+ <span>Collapse</span>
+ <span aria-hidden="true" className="rotate-90 text-[13px]">
+ ›
+ </span>
+ </button>
) : null}
{showDesign ? (
@@ -739,7 +743,6 @@ export function NarrativeView({ turn, onBlockSelect }: NarrativeViewProps) {
return (
<DetailView
turn={turn}
- summary={summary}
onCollapse={isComplete ? () => setUserRolled(true) : null}
onBlockSelect={onBlockSelect}
/>
diff --git a/skyvern-frontend/src/routes/workflows/editor/Workspace.tsx b/skyvern-frontend/src/routes/workflows/editor/Workspace.tsx
index f5afe69eb..2ba8a675d 100644
--- a/skyvern-frontend/src/routes/workflows/editor/Workspace.tsx
+++ b/skyvern-frontend/src/routes/workflows/editor/Workspace.tsx
@@ -1516,12 +1516,12 @@ function Workspace({
<div className="relative flex h-full w-full overflow-hidden overflow-x-hidden">
{/* comparison view */}
<div
- className="absolute left-6 top-[6rem]"
+ className="absolute left-6 top-[8.5rem]"
style={{
width: workflowPanelState.active
? "calc(100% - 32rem)"
: "calc(100% - 3rem)",
- height: "calc(100vh - 11rem)",
+ height: "calc(100vh - 13.5rem)",
}}
>
<WorkflowComparisonPanel
diff --git a/skyvern-frontend/src/routes/workflows/editor/nodes/BuildModeOnly.test.tsx b/skyvern-frontend/src/routes/workflows/editor/nodes/BuildModeOnly.test.tsx
new file mode 100644
index 000000000..522ffdc36
--- /dev/null
+++ b/skyvern-frontend/src/routes/workflows/editor/nodes/BuildModeOnly.test.tsx
@@ -0,0 +1,54 @@
+// @vitest-environment jsdom
+
+import { cleanup, render, screen } from "@testing-library/react";
+import { MemoryRouter } from "react-router-dom";
+import { afterEach, describe, expect, test } from "vitest";
+
+import { WorkflowScopeContext } from "../WorkflowScopeContext";
+import { BuildModeOnly } from "./BuildModeOnly";
+
+afterEach(cleanup);
+
+function renderAt(
+ path: string,
+ scope: { workflowId: string | null; readOnly: boolean },
+ props: { renderInReadOnlyComparison?: boolean } = {},
+) {
+ return render(
+ <MemoryRouter initialEntries={[path]}>
+ <WorkflowScopeContext.Provider value={scope}>
+ <BuildModeOnly {...props}>
+ <div data-testid="child">child</div>
+ </BuildModeOnly>
+ </WorkflowScopeContext.Provider>
+ </MemoryRouter>,
+ );
+}
+
+describe("BuildModeOnly", () => {
+ test("renders children in build mode", () => {
+ renderAt("/workflows/wpid_abc/build", { workflowId: "w", readOnly: false });
+ expect(screen.queryByTestId("child")).not.toBeNull();
+ });
+
+ test("renders nothing in edit mode on the live editor", () => {
+ renderAt("/workflows/wpid_abc/edit", { workflowId: "w", readOnly: false });
+ expect(screen.queryByTestId("child")).toBeNull();
+ });
+
+ // Comparison canvases mount under /edit without a sidebar; the inline form is the only prompt surface.
+ test("renders children in edit mode inside a read-only comparison scope", () => {
+ renderAt("/workflows/wpid_abc/edit", { workflowId: "w", readOnly: true });
+ expect(screen.queryByTestId("child")).not.toBeNull();
+ });
+
+ // Non-prompt forms (e.g. workflow settings) opt out so their interactive controls stay out of comparison.
+ test("opts out of the read-only comparison scope when asked", () => {
+ renderAt(
+ "/workflows/wpid_abc/edit",
+ { workflowId: "w", readOnly: true },
+ { renderInReadOnlyComparison: false },
+ );
+ expect(screen.queryByTestId("child")).toBeNull();
+ });
+});
diff --git a/skyvern-frontend/src/routes/workflows/editor/nodes/BuildModeOnly.tsx b/skyvern-frontend/src/routes/workflows/editor/nodes/BuildModeOnly.tsx
index 8a31062ac..08beb66b4 100644
--- a/skyvern-frontend/src/routes/workflows/editor/nodes/BuildModeOnly.tsx
+++ b/skyvern-frontend/src/routes/workflows/editor/nodes/BuildModeOnly.tsx
@@ -1,10 +1,20 @@
import { type ReactNode } from "react";
+import { useWorkflowScopeReadOnly } from "../WorkflowScopeContext";
import { useWorkflowEditorMode } from "../hooks/useWorkflowEditorMode";
-function BuildModeOnly({ children }: { children: ReactNode }) {
+function BuildModeOnly({
+ children,
+ renderInReadOnlyComparison = true,
+}: {
+ children: ReactNode;
+ renderInReadOnlyComparison?: boolean;
+}) {
const mode = useWorkflowEditorMode();
- if (mode !== "build") {
+ // Read-only comparison canvases (under /edit, no sidebar) surface a block's prompts inline; opt non-prompt forms out.
+ const inReadOnlyComparison =
+ useWorkflowScopeReadOnly() && renderInReadOnlyComparison;
+ if (mode !== "build" && !inReadOnlyComparison) {
return null;
}
return <>{children}</>;
diff --git a/skyvern-frontend/src/routes/workflows/editor/nodes/CodeBlockNode/CodeBlockEditor.test.tsx b/skyvern-frontend/src/routes/workflows/editor/nodes/CodeBlockNode/CodeBlockEditor.test.tsx
new file mode 100644
index 000000000..744aa78bf
--- /dev/null
+++ b/skyvern-frontend/src/routes/workflows/editor/nodes/CodeBlockNode/CodeBlockEditor.test.tsx
@@ -0,0 +1,61 @@
+// @vitest-environment jsdom
+
+import { cleanup, render, screen } from "@testing-library/react";
+import { afterEach, describe, expect, test, vi } from "vitest";
+
+import { WorkflowScopeContext } from "@/routes/workflows/editor/WorkflowScopeContext";
+
+import { CodeBlockEditor } from "./CodeBlockEditor";
+
+const node = {
+ id: "cb1",
+ type: "codeBlock",
+ data: { editable: true, code: "print(1)", parameterKeys: [] },
+};
+
+vi.mock("@xyflow/react", () => ({
+ useReactFlow: () => ({ getNode: () => node, updateNodeData: vi.fn() }),
+}));
+
+vi.mock("..", () => ({
+ isWorkflowBlockNode: () => true,
+}));
+
+vi.mock("@/components/WorkflowBlockInputSet", () => ({
+ WorkflowBlockInputSet: () => null,
+}));
+
+vi.mock("@/routes/workflows/components/CodeEditor", () => ({
+ CodeEditor: ({ readOnly }: { readOnly?: boolean }) => (
+ <div data-testid="code-editor" data-readonly={String(Boolean(readOnly))} />
+ ),
+}));
+
+afterEach(cleanup);
+
+function renderEditor(readOnly: boolean) {
+ return render(
+ <WorkflowScopeContext.Provider value={{ workflowId: "w", readOnly }}>
+ <CodeBlockEditor blockId="cb1" />
+ </WorkflowScopeContext.Provider>,
+ );
+}
+
+describe("CodeBlockEditor in a read-only scope", () => {
+ test("keeps the code editor editable in the live editor scope", () => {
+ renderEditor(false);
+
+ expect(
+ screen.getByTestId("code-editor").getAttribute("data-readonly"),
+ ).toBe("false");
+ });
+
+ // CodeMirror buffers edits locally, so the displayed historical code must be read-only here.
+ test("renders the code editor read-only in a read-only comparison scope", () => {
+ renderEditor(true);
+
+ expect(
+ screen.getByTestId("code-editor").getAttribute("data-readonly"),
+ ).toBe("true");
+ });
+});
diff --git a/skyvern-frontend/src/routes/workflows/editor/nodes/CodeBlockNode/CodeBlockEditor.tsx b/skyvern-frontend/src/routes/workflows/editor/nodes/CodeBlockNode/CodeBlockEditor.tsx
index 19ecdeb23..8806a25cf 100644
--- a/skyvern-frontend/src/routes/workflows/editor/nodes/CodeBlockNode/CodeBlockEditor.tsx
+++ b/skyvern-frontend/src/routes/workflows/editor/nodes/CodeBlockNode/CodeBlockEditor.tsx
@@ -3,6 +3,7 @@ import { useReactFlow } from "@xyflow/react";
import { Label } from "@/components/ui/label";
import { WorkflowBlockInputSet } from "@/components/WorkflowBlockInputSet";
import { CodeEditor } from "@/routes/workflows/components/CodeEditor";
+import { useWorkflowScopeReadOnly } from "@/routes/workflows/editor/WorkflowScopeContext";
import { deepEqualStringArrays } from "@/util/equality";
import { type AppNode, isWorkflowBlockNode } from "..";
@@ -28,6 +29,7 @@ function CodeBlockEditorBody({
const data = node.data;
const { editable } = data;
const update = useUpdate<CodeBlockNodeData>({ id: blockId, editable });
+ const scopeReadOnly = useWorkflowScopeReadOnly();
return (
<div data-testid="code-block-block-form" className="space-y-4">
@@ -49,6 +51,7 @@ function CodeBlockEditorBody({
<CodeEditor
language="python"
value={data.code}
+ readOnly={scopeReadOnly}
onChange={(value) => {
update({ code: value });
}}
diff --git a/skyvern-frontend/src/routes/workflows/editor/nodes/GoogleSheetsReadNode/GoogleSheetsReadNode.tsx b/skyvern-frontend/src/routes/workflows/editor/nodes/GoogleSheetsReadNode/GoogleSheetsReadNode.tsx
index 6a32e3f42..1d0cf5f5e 100644
--- a/skyvern-frontend/src/routes/workflows/editor/nodes/GoogleSheetsReadNode/GoogleSheetsReadNode.tsx
+++ b/skyvern-frontend/src/routes/workflows/editor/nodes/GoogleSheetsReadNode/GoogleSheetsReadNode.tsx
@@ -67,7 +67,8 @@ function GoogleSheetsReadNode({
type="google_sheets_read"
/>
<NodeBody>
- <BuildModeOnly>
+ {/* Editor mounts live Google credential/Sheets queries; keep it out of read-only version diffs. */}
+ <BuildModeOnly renderInReadOnlyComparison={false}>
<GoogleSheetsReadEditor blockId={id} />
</BuildModeOnly>
</NodeBody>
diff --git a/skyvern-frontend/src/routes/workflows/editor/nodes/GoogleSheetsWriteNode/GoogleSheetsWriteNode.tsx b/skyvern-frontend/src/routes/workflows/editor/nodes/GoogleSheetsWriteNode/GoogleSheetsWriteNode.tsx
index 80fc7e8ee..73b1e494a 100644
--- a/skyvern-frontend/src/routes/workflows/editor/nodes/GoogleSheetsWriteNode/GoogleSheetsWriteNode.tsx
+++ b/skyvern-frontend/src/routes/workflows/editor/nodes/GoogleSheetsWriteNode/GoogleSheetsWriteNode.tsx
@@ -67,7 +67,8 @@ function GoogleSheetsWriteNode({
type="google_sheets_write"
/>
<NodeBody>
- <BuildModeOnly>
+ {/* Editor mounts live Google credential/Sheets queries; keep it out of read-only version diffs. */}
+ <BuildModeOnly renderInReadOnlyComparison={false}>
<GoogleSheetsWriteEditor blockId={id} />
</BuildModeOnly>
</NodeBody>
diff --git a/skyvern-frontend/src/routes/workflows/editor/nodes/StartNode/StartNode.tsx b/skyvern-frontend/src/routes/workflows/editor/nodes/StartNode/StartNode.tsx
index bb9df5133..8b7515bb0 100644
--- a/skyvern-frontend/src/routes/workflows/editor/nodes/StartNode/StartNode.tsx
+++ b/skyvern-frontend/src/routes/workflows/editor/nodes/StartNode/StartNode.tsx
@@ -147,7 +147,7 @@ function StartNode({ id, data, parentId }: NodeProps<StartNode>) {
<div className="relative">
<header className="mb-6 mt-2">Start</header>
<Separator />
- <BuildModeOnly>
+ <BuildModeOnly renderInReadOnlyComparison={false}>
<Accordion
type="single"
collapsible
diff --git a/skyvern-frontend/src/routes/workflows/editor/nodes/WorkflowTriggerNode/WorkflowTriggerNode.tsx b/skyvern-frontend/src/routes/workflows/editor/nodes/WorkflowTriggerNode/WorkflowTriggerNode.tsx
index f85e0cb74..6b7a81b22 100644
--- a/skyvern-frontend/src/routes/workflows/editor/nodes/WorkflowTriggerNode/WorkflowTriggerNode.tsx
+++ b/skyvern-frontend/src/routes/workflows/editor/nodes/WorkflowTriggerNode/WorkflowTriggerNode.tsx
@@ -65,7 +65,8 @@ function WorkflowTriggerNode({ id, data }: NodeProps<WorkflowTriggerNodeType>) {
type={WorkflowBlockTypes.WorkflowTrigger}
/>
<NodeBody>
- <BuildModeOnly>
+ {/* Editor mounts live workflow-lookup queries; keep it out of read-only version diffs. */}
+ <BuildModeOnly renderInReadOnlyComparison={false}>
<WorkflowTriggerEditor blockId={id} />
</BuildModeOnly>
</NodeBody>
diff --git a/skyvern-frontend/src/routes/workflows/editor/useUpdate.test.tsx b/skyvern-frontend/src/routes/workflows/editor/useUpdate.test.tsx
new file mode 100644
index 000000000..e29e3634f
--- /dev/null
+++ b/skyvern-frontend/src/routes/workflows/editor/useUpdate.test.tsx
@@ -0,0 +1,64 @@
+// @vitest-environment jsdom
+
+import { renderHook } from "@testing-library/react";
+import type { ReactNode } from "react";
+import { afterEach, describe, expect, test, vi } from "vitest";
+
+import { WorkflowScopeContext } from "./WorkflowScopeContext";
+import { useUpdate } from "./useUpdate";
+
+const updateNodeData = vi.fn();
+
+vi.mock("@xyflow/react", () => ({
+ useReactFlow: () => ({ updateNodeData }),
+}));
+
+afterEach(() => {
+ vi.clearAllMocks();
+});
+
+function scopeWrapper(readOnly: boolean) {
+ return function Wrapper({ children }: { children: ReactNode }) {
+ return (
+ <WorkflowScopeContext.Provider value={{ workflowId: "w", readOnly }}>
+ {children}
+ </WorkflowScopeContext.Provider>
+ );
+ };
+}
+
+describe("useUpdate", () => {
+ test("persists node data in the live editor scope", () => {
+ const { result } = renderHook(
+ () => useUpdate<{ x: string }>({ id: "n1", editable: true }),
+ { wrapper: scopeWrapper(false) },
+ );
+
+ result.current({ x: "1" });
+
+ expect(updateNodeData).toHaveBeenCalledWith("n1", { x: "1" });
+ });
+
+ // Reviewing a workflow version must never mutate the displayed snapshot.
+ test("does not persist in a read-only comparison scope", () => {
+ const { result } = renderHook(
+ () => useUpdate<{ x: string }>({ id: "n1", editable: true }),
+ { wrapper: scopeWrapper(true) },
+ );
+
+ result.current({ x: "1" });
+
+ expect(updateNodeData).not.toHaveBeenCalled();
+ });
+
+ test("does not persist when the node is not editable", () => {
+ const { result } = renderHook(
+ () => useUpdate<{ x: string }>({ id: "n1", editable: false }),
+ { wrapper: scopeWrapper(false) },
+ );
+
+ result.current({ x: "1" });
+
+ expect(updateNodeData).not.toHaveBeenCalled();
+ });
+});
diff --git a/skyvern-frontend/src/routes/workflows/editor/useUpdate.ts b/skyvern-frontend/src/routes/workflows/editor/useUpdate.ts
index e4b831676..56661d06e 100644
--- a/skyvern-frontend/src/routes/workflows/editor/useUpdate.ts
+++ b/skyvern-frontend/src/routes/workflows/editor/useUpdate.ts
@@ -1,6 +1,8 @@
import { useReactFlow } from "@xyflow/react";
import { useCallback } from "react";
+import { useWorkflowScopeReadOnly } from "./WorkflowScopeContext";
+
type UseUpdateOptions = {
id: string;
editable: boolean;
@@ -24,14 +26,16 @@ export function useUpdate<T extends Record<string, unknown>>({
editable,
}: UseUpdateOptions) {
const { updateNodeData } = useReactFlow();
+ // Comparison/diff canvases mount read-only; no control may persist to the reviewed snapshot.
+ const readOnlyScope = useWorkflowScopeReadOnly();
const update = useCallback(
(updates: Partial<T>) => {
- if (!editable) return;
+ if (!editable || readOnlyScope) return;
updateNodeData(id, updates);
},
- [id, editable, updateNodeData],
+ [id, editable, readOnlyScope, updateNodeData],
);
return update;
diff --git a/skyvern-frontend/src/routes/workflows/hooks/useCredentialsQuery.test.tsx b/skyvern-frontend/src/routes/workflows/hooks/useCredentialsQuery.test.tsx
index 8794f7707..47ab18e45 100644
--- a/skyvern-frontend/src/routes/workflows/hooks/useCredentialsQuery.test.tsx
+++ b/skyvern-frontend/src/routes/workflows/hooks/useCredentialsQuery.test.tsx
@@ -6,6 +6,7 @@ import { ReactNode } from "react";
import { afterEach, describe, expect, it, vi } from "vitest";
import { getClient } from "@/api/AxiosClient";
+import { WorkflowScopeContext } from "@/routes/workflows/editor/WorkflowScopeContext";
import { useCredentialsQuery } from "./useCredentialsQuery";
vi.mock("@/api/AxiosClient", () => ({
@@ -79,3 +80,34 @@ describe("useCredentialsQuery — search + type query params (SKY-5679)", () =>
expect(params.get("page_size")).toBe("25");
});
});
+
+describe("useCredentialsQuery in a read-only comparison scope", () => {
+ function makeComparisonWrapper() {
+ const queryClient = new QueryClient({
+ defaultOptions: { queries: { retry: false } },
+ });
+ return function Wrapper({ children }: { children: ReactNode }) {
+ return (
+ <QueryClientProvider client={queryClient}>
+ <WorkflowScopeContext.Provider
+ value={{ workflowId: "w", readOnly: true }}
+ >
+ {children}
+ </WorkflowScopeContext.Provider>
+ </QueryClientProvider>
+ );
+ };
+ }
+
+ it("does not fetch credentials when the scope is read-only", () => {
+ const getMock = stubClient();
+
+ const { result } = renderHook(
+ () => useCredentialsQuery({ enabled: true, page_size: 100 }),
+ { wrapper: makeComparisonWrapper() },
+ );
+
+ expect(result.current.fetchStatus).toBe("idle");
+ expect(getMock).not.toHaveBeenCalled();
+ });
+});
diff --git a/skyvern-frontend/src/routes/workflows/hooks/useCredentialsQuery.ts b/skyvern-frontend/src/routes/workflows/hooks/useCredentialsQuery.ts
index 30d63154f..f06225d5e 100644
--- a/skyvern-frontend/src/routes/workflows/hooks/useCredentialsQuery.ts
+++ b/skyvern-frontend/src/routes/workflows/hooks/useCredentialsQuery.ts
@@ -1,6 +1,7 @@
import { getClient } from "@/api/AxiosClient";
import { CredentialApiResponse } from "@/api/types";
import { useCredentialGetter } from "@/hooks/useCredentialGetter";
+import { useWorkflowScopeReadOnly } from "@/routes/workflows/editor/WorkflowScopeContext";
import { useQuery } from "@tanstack/react-query";
type QueryReturnType = Array<CredentialApiResponse>;
@@ -27,6 +28,8 @@ function useCredentialsQuery(props: Props = {}) {
...queryOptions
} = props;
const credentialGetter = useCredentialGetter();
+ // Read-only version-comparison canvases never need live credential data; suppress the fetch there for every caller at once.
+ const scopeReadOnly = useWorkflowScopeReadOnly();
return useQuery<Array<CredentialApiResponse>>({
queryKey: [
@@ -55,6 +58,7 @@ function useCredentialsQuery(props: Props = {}) {
},
refetchOnMount: "always",
...queryOptions,
+ enabled: queryOptions.enabled !== false && !scopeReadOnly,
});
}