Skip to content

Automate browser based workflows with AI

feat: implement error code mapping in TaskBlock and add unit tests fo… (#5265)

LawyZhengdc29abbf299a
diff --git a/skyvern/forge/sdk/workflow/models/block.py b/skyvern/forge/sdk/workflow/models/block.py
index a50f47b40..7a6af26fb 100644
--- a/skyvern/forge/sdk/workflow/models/block.py
+++ b/skyvern/forge/sdk/workflow/models/block.py
@@ -692,6 +692,16 @@ class BaseTaskBlock(Block):
self.terminate_criterion, workflow_run_context
)
+ if self.error_code_mapping:
+ self.error_code_mapping = {
+ self.format_block_parameter_template_from_workflow_run_context(error_code, workflow_run_context): (
+ self.format_block_parameter_template_from_workflow_run_context(
+ error_description, workflow_run_context
+ )
+ )
+ for error_code, error_description in self.error_code_mapping.items()
+ }
+
@staticmethod
async def get_task_order(workflow_run_id: str, current_retry: int) -> tuple[int, int]:
"""
diff --git a/tests/unit/workflow/test_task_block_template_rendering.py b/tests/unit/workflow/test_task_block_template_rendering.py
new file mode 100644
index 000000000..6620de231
--- /dev/null
+++ b/tests/unit/workflow/test_task_block_template_rendering.py
@@ -0,0 +1,65 @@
+from datetime import datetime, timezone
+from unittest.mock import MagicMock
+
+from skyvern.forge.sdk.workflow.context_manager import WorkflowRunContext
+from skyvern.forge.sdk.workflow.models.block import TaskBlock
+from skyvern.forge.sdk.workflow.models.parameter import OutputParameter, ParameterType
+
+
+def _make_output_parameter(key: str = "task_output") -> OutputParameter:
+ return OutputParameter(
+ parameter_type=ParameterType.OUTPUT,
+ key=key,
+ description="test output",
+ output_parameter_id="op_task_template_test",
+ workflow_id="w_task_template_test",
+ created_at=datetime.now(timezone.utc),
+ modified_at=datetime.now(timezone.utc),
+ )
+
+
+def _make_workflow_run_context(values: dict | None = None) -> WorkflowRunContext:
+ ctx = WorkflowRunContext(
+ workflow_title="test",
+ workflow_id="w_task_template_test",
+ workflow_permanent_id="wpid_task_template_test",
+ workflow_run_id="wr_task_template_test",
+ aws_client=MagicMock(),
+ )
+ if values:
+ ctx.values.update(values)
+ return ctx
+
+
+def test_format_potential_template_parameters_renders_error_code_mapping() -> None:
+ block = TaskBlock(
+ label="task_with_error_codes",
+ output_parameter=_make_output_parameter(),
+ title="task title",
+ error_code_mapping={
+ "ERR_{{ region }}": "{{ reason }} for {{ region }}",
+ "STATIC_CODE": "static description",
+ },
+ )
+ ctx = _make_workflow_run_context({"region": "US", "reason": "login failed"})
+
+ block.format_potential_template_parameters(ctx)
+
+ assert block.error_code_mapping == {
+ "ERR_US": "login failed for US",
+ "STATIC_CODE": "static description",
+ }
+
+
+def test_format_potential_template_parameters_with_no_error_code_mapping() -> None:
+ block = TaskBlock(
+ label="task_without_error_codes",
+ output_parameter=_make_output_parameter(),
+ title="task title",
+ error_code_mapping=None,
+ )
+ ctx = _make_workflow_run_context({"region": "US"})
+
+ block.format_potential_template_parameters(ctx)
+
+ assert block.error_code_mapping is None